Message ID | 20230109033838.2779902-3-senozhatsky@chromium.org (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D53DC54EBD for <linux-mm@archiver.kernel.org>; Mon, 9 Jan 2023 03:39:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E74F18E0005; Sun, 8 Jan 2023 22:39:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E250B8E0001; Sun, 8 Jan 2023 22:39:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CECF98E0005; Sun, 8 Jan 2023 22:39:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C07888E0001 for <linux-mm@kvack.org>; Sun, 8 Jan 2023 22:39:16 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 968C2C019F for <linux-mm@kvack.org>; Mon, 9 Jan 2023 03:39:16 +0000 (UTC) X-FDA: 80333855112.22.2E275E4 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf25.hostedemail.com (Postfix) with ESMTP id F1829A000C for <linux-mm@kvack.org>; Mon, 9 Jan 2023 03:39:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WQwcvUaQ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673235555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AEbqzpe3o1M34E1TK5SG9WYfEV64gTPdXoQ0O7E/LWQ=; b=yKrCTS+8O2EKWsk3zhyfE6l7gznoAV5Cpv241xL42/XkJ7Zynp1SkgNHX4g2X5zOefsDJ+ HxPevg/VCEDhSLLes1s+6z6NLRqZhuRVvvTXtZ5xQpoIZQv1g8PX3FLvKrWS+Eb7opwtM/ RfdeBf4wfmgb/eYj70GzZ8JLkbpF7uA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WQwcvUaQ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673235555; a=rsa-sha256; cv=none; b=hS+d8zac5Vc1DMSkZ+ZozbQfRnje2beBK26qfi9isJDk99GI/OcueKu/4TYB46Hf9I+O0Z SfRn6vHPafMKa5J7j6gdvoLPrg/h8B994I8htI79r+z/z9PX2Ik9ztZhUiTpOR5kO0v7IW jGgqZ50jcokt+MWfHVOZjP2m4tK3aZ4= Received: by mail-pl1-f170.google.com with SMTP id 17so8212572pll.0 for <linux-mm@kvack.org>; Sun, 08 Jan 2023 19:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AEbqzpe3o1M34E1TK5SG9WYfEV64gTPdXoQ0O7E/LWQ=; b=WQwcvUaQg4HJvYV5wdvB976BQcDb2ieJxDOiGtrty58I7ls1CoGJAe+vD3cCTZp0mS MPzdxEZgAGUlrS6cKJYGVF2aAESwfwE6LZMlPD5NWQcc0HUDKXcHX6v7+prbsOpr1QtL IYdJ1jZd59PF3ZX5SIaIzmqcHL1J296Zz2HzM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AEbqzpe3o1M34E1TK5SG9WYfEV64gTPdXoQ0O7E/LWQ=; b=m5y3+3q7++xYX+AgJkoJ13q1Eohu0Do70iqkqJRi8di+ayKuEF0b+NJgOwm/NMeWe/ ea3lcAA4yJ3FwpML1l8mVGsR+TJLE5OMYu3XYv0ErSw+jOZDtBYQOdcbU1y3zTgZczyG MCWCMioUvxcFCH01tXISQpNO7zfS3oS0AxLc4ck6/3cUC0k849wrnUGJRTJtSqN/mDP5 SFXQzs3h/GDwrwS0RBep2a/nETeXgOdAE+FoaSElWnlfsPx+c0YQ6SpE8K1Qz8alwg+M ZDzstAZiTja3lnYI21UWzLURKWMsWGDsMT2BJBTFLEhVDtB3YU2hP97L9Nn8CxKfA5Un KA/w== X-Gm-Message-State: AFqh2krxMkS9R+C/tQkqmeXHt6cf44h5MG1T854jl90DcTFmPSAHM3Hm qESYPPCfryITu902gxviLgyyaw== X-Google-Smtp-Source: AMrXdXuHYjjQwDymUilhCJ/UhceAK/SDhGEV9/RSE9nacPsscyxB7o9e8XDsnKmXaH8nblH8oShCVQ== X-Received: by 2002:a17:903:ca:b0:192:9fda:7665 with SMTP id x10-20020a17090300ca00b001929fda7665mr33824571plc.53.1673235553783; Sun, 08 Jan 2023 19:39:13 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:5ec1:f8d2:ce47:7ddc]) by smtp.gmail.com with ESMTPSA id u5-20020a170902e80500b00189529ed580sm4896685plg.60.2023.01.08.19.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 19:39:13 -0800 (PST) From: Sergey Senozhatsky <senozhatsky@chromium.org> To: Minchan Kim <minchan@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky <senozhatsky@chromium.org> Subject: [PATCHv2 2/4] zsmalloc: skip chain size calculation for pow_of_2 classes Date: Mon, 9 Jan 2023 12:38:36 +0900 Message-Id: <20230109033838.2779902-3-senozhatsky@chromium.org> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog In-Reply-To: <20230109033838.2779902-1-senozhatsky@chromium.org> References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F1829A000C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: f6h4i65axxuitnd7faornnfaojn9spyr X-HE-Tag: 1673235554-980250 X-HE-Meta: U2FsdGVkX1/XBrjA2D/Y10tTfHCE96vS9coZq4VB+WSTLeh7h5+fGagjaEWWNijbPqeoVuHLOr6ZlLRv9RLltoGlxyZlHpYunamBo7jW8IcPNG6cb7YgR70j7j9ynNLzjQ4MFe2hqr59cSRptGZmS4oAG+e6dZ04+aiFoD3c1DJ+v/ceHbV0KZN/l6URaKwjNphxJF/Q3tAK6n7o+td6REdn4aFVDkQp7t3YAzd4zxdUdRzQdPovIVTmJgrrjHY3xgLcBbqwLxycCjBFKOBwUKyTW/cOyyBTGVJftROMCazg2nYW73f9FuBFfiVyplul6Wx8dZSwHZ399ezRPMbHAoGZadwg6+P42aIN72AA2ayHLygLMKQ2O8Hl9nCueBdR3tOGNLi5EMaDPeKdaVIoHacBlwoJaTO/bLo+a7JLRRclJPa6Pikk3qauRV+m1o6IgtSyl9omvlsyfyE4p/VKR5QbbarE98J1bsmLBqqg3oivMPzTFDlnVm9Q2FarVB4rLsNNPVRVJB5Ib6CGzss4GAp++wVjHXiMgeXP+HAavXz2p7Y8IXUc9hrD+7rm7jBOtdgDUc7hdHxDP06QPIJcKV5rbiAWmLbOwqdyeMY0HMio0ZqZSI/r3XKzBHlgUodTO+Euer3BZ4UAZka1FIGSnNbtaxeVV/4853BtRbn/to++bjjcmiMy7WALH+5axLVcbmZ73tmdCLILZkTyG0Wpzx/i3R/v45tT7a5uKQU2ZyDcQhjWzKpaLyGwP6p0C3XtSPN9pYFDiSaHNDW8MGqNF8WB709FlNz2ljAas2IJVmfzVwGVdwaDx78AlrrEsbs1rWOsERSZWvq5C/ixlbhXUB6TqFZn/ahFxPsZrIo0SprePQ2WhbysegRQRypJBCsPAxAh1g1YFhnHwF7cCysGw16MtewPAOH2OZ9Kia2CmWbUrIqgsCQ5Dwsj9ozWkG9c92fdgYHn/3QDwFMtcwI TSA/qHO7 lMzREygZYbQBuVxkBKvzwj0eYfMoLsafopAjVzov5Ohl7D9r4Vsz2JPXNLsS+OFf5XC8zsW0CsH8C0tlLhNeUs/z39BYFwUDMsOlFZsaeQgjvTvma4HXKh0P7GUKUCAo80dsWcMGAdXPiLrmzG0OzAFTjnyBLNZnqErxiHgMw9ty4M8PLzogVmftqTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
zsmalloc: make zspage chain size configurable
|
expand
|
On Mon, Jan 09, 2023 at 12:38:36PM +0900, Sergey Senozhatsky wrote: > If a class size is power of 2 then it wastes no memory > and the best configuration is 1 physical page per-zspage. > > Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> Acked-by: Minchan Kim <minchan@kernel.org>
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index effe10fe76e9..ee8431784998 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -2287,6 +2287,9 @@ static int calculate_zspage_chain_size(int class_size) int i, min_waste = INT_MAX; int chain_size = 1; + if (is_power_of_2(class_size)) + return chain_size; + for (i = 1; i <= ZS_MAX_PAGES_PER_ZSPAGE; i++) { int waste;
If a class size is power of 2 then it wastes no memory and the best configuration is 1 physical page per-zspage. Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> --- mm/zsmalloc.c | 3 +++ 1 file changed, 3 insertions(+)