From patchwork Thu Jan 12 19:43:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13099351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F2FC54EBE for ; Thu, 12 Jan 2023 20:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 944028E000A; Thu, 12 Jan 2023 15:15:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CD2C8E0001; Thu, 12 Jan 2023 15:15:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AC2D8E000A; Thu, 12 Jan 2023 15:15:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 57A828E0001 for ; Thu, 12 Jan 2023 15:15:16 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14C81AB4DB for ; Thu, 12 Jan 2023 20:15:16 +0000 (UTC) X-FDA: 80347251432.06.217CD24 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 3CE9040004 for ; Thu, 12 Jan 2023 20:15:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T8OnHc73; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673554514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=N/LoJ6QokuvkgqrdUyeUyAC9uk5r3NGpRlHTjN0UEk8=; b=0M9RcjQUSKcblEr/xp/QMOvwD2AjdmdzsuJf/7i+xvQeoCftVoWaAn5+6+yO2D8UWVl1s3 PsO8AnJVkJY8KtLtKOoNQHSWJxga4UaeiaAtoXn5Yexh4o+8TfcKoHt83mMKA6iq8bWKDL aXNGl3vyFpyWPjmsUavzwc14Hel2f4U= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T8OnHc73; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673554514; a=rsa-sha256; cv=none; b=23PUVOQQyG+vGGJrpfB/bjKRvhnWQ+OYXCDcQ6LhZKRWRGAJXEoay6DzyWy/cIhm5JbEdP 76pM69C/IOTnpyvvxFrSXpJnBs9rYt6zj+Nh+dNrWZx69vShViPwRzEEaGLCKvgm7MdmR3 CwOJvQoN+qXu3GNhr9QrONcWNf2/1tI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=N/LoJ6QokuvkgqrdUyeUyAC9uk5r3NGpRlHTjN0UEk8=; b=T8OnHc73dEliAoWK/xch6i2J7U UMPcH7C3wey9SZCz29M3TnVGeV/W9jC6hfvxLiKRMqnquFKPM6nid5EbmG5dczPvuD2DZ3rsJb8bh 1B5YEftBb1n98ERVSHO05+IatfdS4u87KvvQGiPoj8rifuEdsA4srZC4wIENwPRAVZsXaUzY4luW4 Zenh892eKzf2pgbhojQV6wJdtmIWgpRiTZY36OvBCfqI5tc8YiwERNFtaxcfar59LGMt3V5FwEWxd 1IYeXc/xNHpxnwh58Sqsesvu7xJ/zUZBM+XUWlSRPervhZPQ3w6Fk9QTn2mJpsRI+pQDUPSrD9z7J 4u6HFEyw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3hZ-005Oda-BM; Thu, 12 Jan 2023 19:57:29 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3E0CF303417; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id D46292CCF1F75; Thu, 12 Jan 2023 20:57:07 +0100 (CET) Message-ID: <20230112195540.251666856@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:29 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 15/51] acpi_idle: Remove tracing References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Stat-Signature: o114h68rh1dp4sixjof1c5mgcgzym1xh X-Rspam-User: X-Rspamd-Queue-Id: 3CE9040004 X-Rspamd-Server: rspam06 X-HE-Tag: 1673554514-441826 X-HE-Meta: U2FsdGVkX1/WWWHXzvKLBWqtqj+RAKDZHO1qYXCqjpsvuWxUpBf/rG+zeX0UXnE8AiGjrdvuOWeenabmtFlkhCewqSK00rdooxAW4uEpi/H/jcElIruBncEZtHVIVv2XO7Vl4ZwbDadDpe0N4di6GysJynH9Hhd5HqalvbKQE0By60WRbUPHrXK0xOAzOfz17RpSy3e6Klrt1ZKxEk4KmV9tA8TNbAriF6kHOsQnoVryeD25BTHiRVV7l3OLwnJtbgmpHUhpM8j6RNFL18nJ8QIVsVyk31j+IJug9Uk68GPfQIJJKRGFhhc3hRUvjCcU4WFfL9BpkHIWOUKakuiKaNTn4tpQKoDwF8llmCyjz6bd6YcUUSMEw4mnZo5KPeDjv9VxjLfWminpL9pEi0uincxS1Qvdj6bYhY5Rh4pZExivwFKfxcR+JzhchD60ZuSqlKB/Pmeg94YRc6g0zERRolHPpv9Olf9VSJ9dP9vA/44mzszGMXmM9/lfmKIGJe31ydCwX/pmAuotelRHcA61IesCj0m5Za0b4E0cavfRB0yV9c8UZGSjynxeX6/t37dvQEhyxgTh+uW4TSukS+/r0ZyJicDgTMxon0460/jRAaAl/cO4V8kyAb9F1dA7MngVmCjQNm51ogDTV8BbyrDigfLjFqJg7m52MNYw0dlU9nZT4mCOJtcZgPoxt8lUBp50c4UOk/CRwZLfeT6Sv74jovfp9ovHlUx+WKgMKLIYlaa+Af46a3YRFwnYsFrgqT7+axKSXQhbSPl81Wa6jZwlO06GoOxKHdYJL57ANSlHxqpYpnJY9Ka6+nVSluNFuSwFIlkUlvDJCOEnjzVhvkVPuYs0Ez10HLtQmyrnVL4XJ9iL87etQro9dco6NKcjUm+VrPpV5EI78FOY6w97Xumb3J4Q+0T2uQVXQbiitO9Ja74ZweWLqrNAwd0vMSw6FMo6VjTSmfXpZb+XTS3LoCx dHjx3kbq hP3nBeBlggS1zqJWekWJ/kVvFKfS0bKagMfA80lXnla32tORmcw91iYFASwnZtUFTfT1yN47E6DxMrIrQQH0rwQbMP4QTqF0hVRmncfUpRnymIiGIBmuea5HGIH58MzrcMmIDZAKmbSrx04qpjJwq8W0EgesJTb0HTGjlkw0eZykIwvb4aFGpZINGrHl61+51PPhhlPLjA89GFihUyQWDA2zFAAKkoM8lsjLrJ48HhJ8SbIwy3VQma0TKGtnvuxFiHzjLivqAnS2vAXw/z61e2oss7pchRK6Qk4xIjVQ+s11Ecl0EPc8ZktaqpvkFlxiPpqSnhPn8VqeNTEHPvSm8ZHL0+m37vi8tydY1Mw6SsHIiGlsRlVAjDFuzl3KjMV7MdpUpXXjGGYNa0mqPHo7KfhDTruvU9v4uOMsRENBctQDZXyKO/BBv6FOZsBRg24/gLmSluBwe+sZj8CD/1UEcpCyZPQ4ZzQXyfnYT87+g3XA/Xj3aaEx4YD4N24CNqGJmNyAmGK6hu7zEEX6whISs8dyBRXPXUeoAODlKLHB3uZZWxknTfYIl3RE7MZNkqqxSL+nIpVhdjwdWr1Hlb/T4HcQsO/awH+dYZjFT4vsWanZiLwNfFAkxwHrOgIXzUVsqxYpJu5ZuW32jR9jirkIcSw35qXWvA9sZk8FhYPQkTBZUCy5f1f4bqoEvMklVdELjblLdj2lgjfbrT4fukhkMPYNJ0+UcE9Psh1xOEHwpAZhLchhv0XyW1w5lfanVWDzkOcxXsEyXjw9UQDczWbS1sVrsPJpPPOAJsGeaKIIhpN9laa3GiS2kde5svbFpBmY3/WFrYtqUBdV9fzCNkeoUn5IWgmMMd+q87Mih7knuRCRq2Adz1D03zB1EbJL/fiADidhBB14AqE4/BDlz6BdXjx2BPoGIzxGiBv+vp26KrFJL9UIS/WpJ6CF+5vUzcwe8PB1hIRp8fQiKHC0WfUsKHD6p+i5i zpXPRZ+v k3+7AJygD8er/7ftiOirkRhQg4ue44ufh/QRGdEbY0/+LzVx7oXlH3WqxP7cnsLjNpiG8bHvnm/T6rVAK6gcKYx39+zY8YBR9k8hRf/9cckUENgcTX4xJlKZxO5hK6YsvZdMGpKiSju2XHS1U/dje5vb35BQhhBMiLR8f+CIntr1VuH7voKoU9lObKLoQ/cp4fDD0p7Z0C5EISRnvb0lv6tvy34tAXBJehvUIe987HVq/lNnSvshZjfg7RbunQql2Vxak4bI7MIMBbQBKATS/0XMOvRtvJEXtJChfjEhEj+JyL5N5L11wF+iIBQxTjktk3gBiM3Bl0Fj7lX5By++BudtzeoNOmk8MWUDYl5xNt1CyKttsmHfcibtPMzm+0TDUZ0tybY02Z2Y3Tt2phdUi0DS949/0Hu45pDQmklDfPfGyevfdzCOLJZqg2v3I/MdECmFLaJwaVeVJrRDpnYfEq3SAqHduQeUvKoH/3WpBJ4zJg+amr72Zpi7ecoIg3xZoh9WJINjOGP78PStWItDQo5VUs46lISGvUIZbFL+9fgh5iaphu09cVoAJI9Ryx8EWxC3AB2Fte2fuAwqqvfE7hwso3SGR1IMLpynu9KmL/8yiMSqgltFRNOWvJTveFWfQxexAtSHnmI+TcgclKLmeCABw6Tn0WfrlGWrxQRIf0wLS0ndwfObhCz2QN1J/5fxntla02SCx5FgHyhBb3du2uYT7v3qah5y7WUl4kJV3ecZs45/HTWMrPM/fZ7vpTO1o6TuTxw9aT0EgYDas5oG8iWVHm1SJY5h8kJotfR5eWFl5FFhjNuo+IU3fPX/uYA1ktx1st5iYvJQSfXfjTbBkLBM2KF22b9B0geNKeBAxw0QXC9kzExLiyEzqxoMZjB0rnKY52ZRKTsQKeucV1J0iDfOLFeZZqLQzpzfYcaznaPx3u20LvCVXivRR/gHEvi+H47PPByd3DQs42J9zUzJUZfXTKbY8 cWMzwX2u bcJsd9lwyOGkS7elvAYD0qEq/sXhkvl1b4PYZwexnUxW+b2frX/pDGIXpR1c3udBp3/tkc3amRkp/dvjvstkdTWYqi2E/xwJDT195633QnYedrs1pykJzJbrUhz36iMcvPc2zp4/sfMZvdDe3P9LPIq5lyV56fVfi7y/HVzrRM98WlzgbRK3l3e93ICjq+ZN/mgPOgj9Jj4py6MIZqENMRMqZxMqwaB9BUtzY+JnXuLghJheCntKKGNn/f07FeOgY1L30+TE5uD+tAXlBF7Y+OYOrItQBSMYD+JNzbnlpqwuzcP0H8BNlgSntYE7S5dRSAUa7JJoRAXTTIJbMnD37+ZOaYQV+JtvfKttc7o+L84LRbfssGpLyu0C0GqOA49+8EHfSQgAk0/gbUepXOu5672dWL2DKz+O1XI5eYGU7A6MrEeM2wX6iSY93G8MUCXuFwoXBsl9vpb17nOqXin/tMDyKhsthukAFtgcTfRmzO4OP0za9udE3rCsqtEoeYtK7LyQJWLuMeMg6en08y6Wehe6AfZJNXyvTPEfAXksl2vKrry0E6fBKk5/lL+0esLd3YqiVuC+qfMoKtElL8RzFJ7L7B1O03dymZsqGec8dDSa+80GXwfZk7Y7dCY5JzOBLnAZJvgrsudzB2psnOvk3TfCG5JfLlQm7Dpd1WsgnxY88jtrSF/MEsfil8OeLMeLs12CF6zuA8dnU0tOEJSEX/6ASVRhexWGaJ5yZlR8DmEYhlas6JL0B2CUSik6H/MKfpg3g09wMhaN6zCwViume3gnRd8qGsMY2xXJk8ZCzkBEZNe+N03/5JzU1HN9o7RqpcZgxl5RoeB8/qPRS1A7kSrlwdVhVq6J8OpZLBGb5Cx1wV68deHM8X0VqhpHBROFmquqvL7KscKpWeOZmAkE0KA6clTyukuSXB8iCKYff+4G3+zgbrJoKXofEbA3r5l7w4vxlAhI5WSCvNLNLT3kVZ9Whb2Fl Vde82O90 yZbeDWnTJjCXVLO6mArgDVNRfYG3zzpbGGA3UADtGiXCUPQk84PFzOkPsdyc4hUeD0CMknd5gtyU41VcovllaUarlcKw6iNq9grMFQzl77rTt7zW6QncyCcydmFkXEov5NIU35F0O9BIcBWJ8bKeTV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All the idle routines are called with RCU disabled, as such there must not be any tracing inside. While there; clean-up the io-port idle thing. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- drivers/acpi/processor_idle.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -109,8 +109,8 @@ static const struct dmi_system_id proces static void __cpuidle acpi_safe_halt(void) { if (!tif_need_resched()) { - safe_halt(); - local_irq_disable(); + raw_safe_halt(); + raw_local_irq_disable(); } } @@ -525,8 +525,11 @@ static int acpi_idle_bm_check(void) return bm_status; } -static void wait_for_freeze(void) +static __cpuidle void io_idle(unsigned long addr) { + /* IO port based C-state */ + inb(addr); + #ifdef CONFIG_X86 /* No delay is needed if we are in guest */ if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) @@ -571,9 +574,7 @@ static void __cpuidle acpi_idle_do_entry } else if (cx->entry_method == ACPI_CSTATE_HALT) { acpi_safe_halt(); } else { - /* IO port based C-state */ - inb(cx->address); - wait_for_freeze(); + io_idle(cx->address); } perf_lopwr_cb(false); @@ -595,8 +596,7 @@ static int acpi_idle_play_dead(struct cp if (cx->entry_method == ACPI_CSTATE_HALT) safe_halt(); else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) { - inb(cx->address); - wait_for_freeze(); + io_idle(cx->address); } else return -ENODEV;