From patchwork Thu Jan 12 19:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13098772 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3AF1C677F1 for ; Thu, 12 Jan 2023 19:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A4E880012; Thu, 12 Jan 2023 14:57:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF4D80011; Thu, 12 Jan 2023 14:57:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4252780012; Thu, 12 Jan 2023 14:57:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 186E68000D for ; Thu, 12 Jan 2023 14:57:35 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E35D2AAF90 for ; Thu, 12 Jan 2023 19:57:34 +0000 (UTC) X-FDA: 80347206828.11.CA01BB9 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf13.hostedemail.com (Postfix) with ESMTP id 5C7652000E for ; Thu, 12 Jan 2023 19:57:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=g8GqpZrZ; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=jJDEZOhAk9N+ZSaOA6QuB1P1t6S4a5Fqf3eoW7G5up4=; b=rc5r0A2qpRzY2RBW6hDV5FPmc0Xej5IHz90pTAkOKG6Kwlg0p5wtBwtv9JXeuXpqVnWkri Ba8ap/moRe7jns/W2yM6HtUUcbrQJ8TFxOMUPOaZZI7sa66rim7U0Gm4vMixhvWymB4FN4 kfBU0S9sWhSe57WDnsZpbWatpUIWBmU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=g8GqpZrZ; spf=none (imf13.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553453; a=rsa-sha256; cv=none; b=QP76tAn3MVqEcnE4ctO41pYxhjjjkv/HQGX6DjJRszJJQQ8twrgXyTQ8LwVLDG37tFgPCW cX6y7mRKCLuVJkC0bOqZaBxMZZfuFhY18x7EUripKGjQa9kUIDRE5Iqw9rNLxHDoVGSMvZ bEB1vWOzS0zr0aV0qLUlMgzNXK48eQE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=jJDEZOhAk9N+ZSaOA6QuB1P1t6S4a5Fqf3eoW7G5up4=; b=g8GqpZrZBs/6V7ZcEBgPwjcdfx RzN5EIQzgwhnINnCaYfY2n9e8ruxberdgD9oVXDNG7YtbZJuFTb45S/H+fPvltC8GZOopId40GcrW AjA8r3rpj2n0SPUYiyps5TjYIQhFAuCcVOx3q73tbMUmUmsFJOFjnQHKvLFlGE+QPNhh8ljdxL4dF uEhNEMsDP/u8xa4UcCmCa7nRPM/4jBKkN20B1meW0t5Yl0NahpjdmysonPb3YGsPg97sJdxjUBn+s lGjWVSdxy2Ny8UJn3s4WanbpIOQXXuMwg2JoVT798bOv9N9iHlojnH9paqJ/CUzQBNz9ShA6pr1w+ Y7bXuV8w==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pG3hF-0045oZ-0H; Thu, 12 Jan 2023 19:57:09 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5187F30341E; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id E64E52CCF1F79; Thu, 12 Jan 2023 20:57:07 +0100 (CET) Message-ID: <20230112195540.434302128@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:32 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 18/51] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again* References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5C7652000E X-Stat-Signature: 4rp5zojngqi6qkwjwwjk4wqxtj1faeft X-HE-Tag: 1673553453-987654 X-HE-Meta: U2FsdGVkX19G3BOnTi0QgvPWuMwVgxQrU4RTmWxeVq3N7uYEE9ti6JNLw4WJPNwqdkNYxTfYUj8U3n680oVzLD6c0jCX9MKfIlHQOWImVihC1kLO7l/jx5KrieE5UXq1XgfkToemG27Rsff37RlQ2J285vOtFcA7MdQA3DalS9US84YVTtBUcdbgF0E3bAy8zwgFG+nZSXYEaWNhF3/fu/tnB5PTI1buo72TT6/u+O4pS+2ZrRM9SKRuOIwx1IEBEr9jyFm/327LaK3S8tgom+k3kFR6im3y9Ffde/uEwGjKXCJsv0xvOr6Aeidf9YE071DiO51kbyb6v+ceYSTg6HF8JJ2SV/52XuTKQOgphwS8twfIol5zRxVgOajNYMu2r3OgK22p1bjJt/e39Xw1pKaqrR81Y/tWN0SI+4ym6GizYvJI2/QhZLn32rKQZHRjsJik19wVutk8EcUICkNB/6EW/uKvYHXcn4W/J/DQCkcCfLlJdzCrGoASaFlFL+wn5wNOYFMGCCpzu8x9WbbF6tGUK7Cb1XRwzk8JGEjkxndpMaKtPdjaOu5u/DhzwZZu1ndcYJGT2ZaqpuWEByG6xhAAER8837NfQ6duLS9HnhQYtCuEn2FFODQS0DwIpKmiODfVati57l78JNDMbRy7YO+Taj2/lqCB++EZLbqOoSRMLQXip4XCq0fgpdqp262gK4GG7XEmVBzD0Yj0CftwZnw627lCJMgrhhh58/NvraJ1QfJldzZCQvxbZelNGDKLUecSkZQBeqt1kJuYipUO7HnKG3mcbA7Zpt27rOuao6OPv5gBfSBwR1iPY8mnpMhwJ9p/jAikG4bpDs5Kj2loaQx24fkfwIQuL8/lv5DNFlS9tGIuwpUDZ5WeyPH92avMauWJdEP9m1Zx8snvAsY4QpTBXKXhmg8hq5f4aLtcB8ICnaFNDBvdS22Mlhz9wQRkDbjpBM6bF0ZI9G2vyGE pNzdJYHs FPbRITBn/aRqcQ80O3aM1I/8CTQbRwN7cZuK+qM0dNViUKBArmzWZPlqQXaAl2UaNwE9eZozVcbTOcRX37kMPqB0Rpx9EQpOT9em9+NqV2RnmpJEA5U1cs7/jLW2/N92euWRnTE6jVMmLDJTFhCiAcmS8/y0GHPk1dYUeuZABxCLqoNAXR/WBdQLPj72LF6I6CqurWMQ+/CnuQFHtVQ4xqKWe3BIB9drjxoGs5ywdqvlvjxgRnMOSrBdFQ2HOgQjVhZq2x969t7n6ohw6k6WmDrwmny1ZzRhSQYG3wNRQ8TjjaSOBSexNDv9CWnQuS2A4j9infaNMVw6I+7/GDzXE+TK/UXwXaGpfRNQGm+4Km2muMutaxDbValkblXut3DHop36WVZIh4XHBgHOX9A88LNj2427kkku3vNWgh4XAS1g2ql/SD8vHHqu0TVryzZNBO0KboV8SNVTOBTpBie42SLeb8JLgFz9cxRD/VVNJnaYGFrpN/ASe75A3PHnUI+wWn7SjpOvJfetlkf1C2gBzoc/qfhL1yI7bk7NDr4WzA412h9TRxwUa0NiG2ZIomRkIn4Ml82kSxDf9HhVez25VsEozZEiGliB5k0c97XQ0Ton79XJnKtTsZFSCheOYE3YXvkyNowwmejJeDBPLN5VjSVNA6im6SxAiMeLhpjajSfFIkEGtThjU+FcjqBMrM7hY+eZ9Yfn8WQw27xg1AHOIrYZq0TAcqwqYuUTpuDfDSgHis9COa5G8CfvvygC9VIY6zTuHxIbm6v9/0xLlXEzRIsEo+8yINMXo7mine9piGU+IB+o9o7ox0Som/6Lha8xa7iL4djgIbwRJWdRd9ej7SUp/Jfe+YifO5drGroL4ty2ydk2yM6Ilc5BZrDv43rCzM6QMFPf34UXrur+lWHmGYJ+VABVmhk+LgvyGlXfBaB+cl7G9u4E+QsYmjxZ9mnXhSCsrMA3f5qc23jXaoRGCBxhvWYpa cXPRoOnK Giiw/FN8iCwg7/sSCODDY/h6pdNM3E89F/atmMylOzEpE3ddz4uRAteWR/QrroV3m4gQqiT7/swk3TIlfOWQowBjJcQNc3glDFaJIZh3XuFKd7XJz6Y3A9qP8y4WorJD2kg2A4JnH8g0fu0anrg3tr/KIgkdOAep6eNn4VxdwaDPdSuTWtKA7pJhg6VD1SJD/6rcV+qn1QOSZt10CflZ/fzEcBJGBO163hAWdHLaMa2FEGKU5eDWhDbhNFpCOrH05xFLcC0NSDPT16yXcqHT63QNwfEs6xX1tGMpEwVf5CqQmnJ+iyR2Y6qrbWD1IzJ5CRN32XZ4jq+4qZo6ex6NMlGMcwXKxyhTIkr88fN2cT+Y5atFle34z8ozDVRt6SNlFYD8/sr4cYa1RIULt/IYVbYrDrU+q24lY4Cx8b/QQJ0QdLRD6oKpFJY4AmS4Hl5Ag51oOUiLUDu+aX/pi2+WW6LLRxQlZ/zTb5OfiAYDOJEF2yicBDwIuIcq3nwX+D5ZKhLX0i71MCzF4c2P2Y9kzTujaN7Xr//sWpB5wxYQtvsq4IkmNgPMLNobU7F4qrFMujJRspZMEoo8y+ujov7NO5QYLdzeC+IRJfeNGZ0GExoX1d5uWGsRPhzVpLGf4qon6G/CxlfXtVjlNUxI2pScslkbgKtUxCyIiL9vP8cwxEyZnSu5Lo9aOnTsvfX+URvlrXFXVMOVgNEQaNd/JB1+YsYbhr5JdY7UWCztoNktQWVDeVNVB2pj2coXJfhnU/7SR1F5G2HTSpPwBdJW5oZ6OS76Gg+oVdDAsj1UCpRAO+JdMqzQLolRI1UKMVgrzSOBqB3PNVXWMhWVfmE55YaQTouumxVI2pMg2bQGiAaiX0yZYmzXNYipj0OXwd81Q1KdoS2h1UOnf0l1X8ODJUXv2MYG5VqDg6mVRoCnGWMaCksISP72Ov+2+ZYfMkI26Zn0Wc8zFBGwQOKKIiMWvkFDCjSsQbb7o 4e3mCBZ3 LIeg7AH9b1ufyBbtCv8G8exjJq5wTUZyLZR8g4FXFKuURGgMYn5ZgtNPaHYXBtk1pDN3SI4dVGNUpxbz3UfHJ+/ovg14utrqqXyobJYuvUN8me0lywFA1j0GP+JFkCjbFk5LyWR12WymTCU9mglNfJtX/xt6qIQRm+/8l0HlUk5liqO1Rtneg14PmPsdlVBSIVwPTclvy2ciNklhocl8flJVXNLuXOYFrUaApsgYuYkbGiBFvmMRfnEdNPV/y/KDhb0m2Q9HIpl0AWkKTyg8f219XWZ1b4wf85WqvVKkP/E6SyhfQiRFqrhmrNMVLdy8oCA3KdOzauARiy5ogfr941iMoz/gGQl7Sg9xaNC7CXNgLYUDXZzVT1KG9dSiLbTDgiJuzGDMdNtWlX5Q9jpcEbtg38sNrJRWwCWLAg7S825BQBjjPVdNCZuvXiVmZWLVCuiFugaUWFM5spC1e7ylXam0MqGIdHiX/Baw+a0F8MR9gBBtxGRRfNXB5L5PV9oGtlzwdewrQU1EAHQb8P4ZfiyML5f7AJ94kF3bxsUjzVX9qSCofGNGrMT6oGYrj/ARxiF3MQfwIBMkMmOmxw7FVRG0Yh8/i8uKyYxsPu8txKqKWUy2sk2JitdGeYdmhmpAbEN6qI7hp4h4NdpD4WDX1nG14Anza30D/2rOd79hhfvhUzxP3jd9GWfp9Xx0I4PbaoLvJviGc1SpgdO9GfJnwF0IG8us3wOOwqZqnZBvLTV5M+CKoyWNVKCtH6PIDSr1rBr0Y9lJ+83mRPc6mjrMnNVPffddDZZE+tDxbjT/262ORlHH7e7WH09sMEDCwR5B3tULleGT4FJKyO7cJO6IZxIbwsLTHy/QhYn2OQPeLVF7CHk8XTq82LRq0C55jP0mjXHlUegTUHx9DIkBp2CmlAm+a5Sjtcf5rIrBv3emLdgRd1ue5bm5RYE0jy+nUlvFnhQ112flwr5lAoW8cjqFX4wKyQw9f yuFAWi8y VGMj5mc45SxUxZv8cp8LWIUSc4Hb/Fb2QDZv4F5OLbMPwctrVpjulEx0PftwugA/YX81hEepDph6IQSVNDPMo2yP66/6eCBLCwpqxe/iplHARaEPqq/FCpUFg3BoRhGpa5iKIE0p8/6wq16xb8cJrF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: vmlinux.o: warning: objtool: intel_idle_irq+0x10c: call to trace_hardirqs_off() leaves .noinstr.text section As per commit 32d4fd5751ea ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE"): "must not have tracing in idle functions" Clearly people can't read and tinker along until splat dissapears. This straight up reverts commit d295ad34f236 ("intel_idle: Fix false positive RCU splats due to incorrect hardirqs state"). It doesn't re-introduce the problem because preceding patches fixed it properly. Fixes: d295ad34f236 ("intel_idle: Fix false positive RCU splats due to incorrect hardirqs state") Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- drivers/idle/intel_idle.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -168,13 +168,7 @@ static __cpuidle int intel_idle_irq(stru raw_local_irq_enable(); ret = __intel_idle(dev, drv, index); - - /* - * The lockdep hardirqs state may be changed to 'on' with timer - * tick interrupt followed by __do_softirq(). Use local_irq_disable() - * to keep the hardirqs state correct. - */ - local_irq_disable(); + raw_local_irq_disable(); return ret; }