From patchwork Thu Jan 12 19:43:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13099445 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7910AC63797 for ; Thu, 12 Jan 2023 21:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015398E0009; Thu, 12 Jan 2023 16:19:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD598E0001; Thu, 12 Jan 2023 16:19:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CC48E0009; Thu, 12 Jan 2023 16:19:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B7AE88E0001 for ; Thu, 12 Jan 2023 16:19:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 78B08160E0B for ; Thu, 12 Jan 2023 21:19:55 +0000 (UTC) X-FDA: 80347414350.19.2344E71 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf29.hostedemail.com (Postfix) with ESMTP id C71D1120010 for ; Thu, 12 Jan 2023 21:19:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=CDjE30SH; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673558394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=nPi2VaSnukDemWiv4/ra3+urtWJi7QCVP16nY4QbOXo=; b=T4zQJhlluEbNgFXizujWoCDICnhYFg0ylxJwUHA0pmMebs0RFVxo2K5gAnZVab2NexKP7o pEkGgx0DZ+NjJuu76pXakS6XDuGpA4rdQNx7bhQW+ssmivYlGM3abdXKU3ti21QcSw8zNs SI7KWcwUJGNRE5vV1vFU/1XbTjEd07U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=CDjE30SH; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673558394; a=rsa-sha256; cv=none; b=qN2Fz0aFoOhPrUrsFYcxZpQJZ2Jgcr5NIc9dZ7IMv3gYUH04wsAlJAD3yQyQjkhHJRPRvE genfUaSRAy2yX26BG3AmoVx8XkO7aRy5UGqQnDtWEaWVlVSw2csAHky0B7k477SZg3IPgZ Ajw+umGHWQ4jyejHD0ANA1hiu8tYoAo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=nPi2VaSnukDemWiv4/ra3+urtWJi7QCVP16nY4QbOXo=; b=CDjE30SHxh/MHeshq7LcxCyRnB pAloIyE5xsjlMTbeKB6u/sxCgYnoL1p+OYgspBL5pFU5mK2BmQ486B/NcumbPG/RDRvRocqku+/+w 9uMl5zfVPVAo7sN1COzJFktYLeZ5aZ36fFLW3kVxdMQ9rGWvI/TrmA4iM2REwC6E89NJG4BtwXdYh Cf3lKWPZyztC126H0PkFylComcCFMahDJ0ywksznJkEyMohG+lfLKIpWv0CU/+S3YKvbiUVd/D8wg UbT7ahOD8OTpISXQDxoK1saIUM6+KxGwdAqH9AqOxzOt3IA8iSNroHtgP/sEIC13R1sHdOMtNIcT9 tVhxTauA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pG3hG-0045oz-1Q; Thu, 12 Jan 2023 19:57:12 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8DF5D303438; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 156E92CCF62AD; Thu, 12 Jan 2023 20:57:08 +0100 (CET) Message-ID: <20230112195540.927904612@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:40 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 26/51] time/tick-broadcast: Remove RCU_NONIDLE usage References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mx5nm1ff5ntgwta49jmtqdsb4mm1braz X-Rspamd-Queue-Id: C71D1120010 X-HE-Tag: 1673558393-21073 X-HE-Meta: U2FsdGVkX18uoJL5qgRhEpujAKfc65w72S96ARqa/9XodSqw/FIJXQmz5njqWdpuYQP+mpRMNGA9wM3tarF9nDtYDMiCwX/BwM9RtGS/hSi5lIC/L7rI6Dh849RS/XqDXXiJd9kN+wAOnYzOAKdSLMbAvB4HqNKX3dbl96WZAdSx1cVLkwb7eBYag5MzDQbH2FcC5Y2HdwEB+JUw1SelpGoLIAsvvSKIT2rFlwItUXI5LzlsQ/s3uqT20CXREB9kMr2DoPd1HAMhI/tEFivTQQa61e03ebFD1wS4oA7Y2GYXWWKm3MSm2KH5J6YUu/EcxXIM6m8BtkqfZVqTp3SjA6rEWyXIRP9TTf3WlUkrPCLE4TeLMSvtOKgxMk2QA+ystT3bEkLiQusRGkGxKmlubt8aqXZgLulGIlT6c1V4/W2BVO/LR5HbFVVyD1fT4ug8VrNoY0u3KqjMUOZ7FV4S+8tldyA48a7O51OSuSOJFudnRXoS8aI64E/dyBUFAaK0ca8z7bg45GyQXz/lB1VqDgXfVkMhCxm9f5FL7CBcIyoDZYl08hwrY3SliyOTGqcMgqRxNuoXBzgq2f4boQdIkUx/gcXDpn+vOu3UJKTFJAYuw2+IHgRKAxHgC0yF+w9+3OwCmTKfoG1UPSUkkcOjdg0xZZwu3cXKDsysXiO+/g464oqyiZRfBoiA18o2zvv/V1WByWYDnNRy8M1oAfNgqnCN3S0sbhTnisQpgglgvfB8WNR0H4WBJSfS99mzGZjJhHwU//16D6QL+HjfpM+ysuL4py2AmxLKSyGws/tt2pAjS3ffR8w60s3mdbvh2Tynpqj/S8Fbq5xu6OVDIVvWvvPswMfMqE71866q6CsNH0OYzg+t6fBvrnHuNwBQOoyTqeAALLMuofvLlYNG3X0Js0B6E08IHrL3uqYqcQyUtIF8dc0eA9yixEC8ymKl7rqFwaAAUH1ZhBouJHgnwrp 95UtWMXI Zrapiq/8EPRWhe5TgNnGZYnf83GtXzGxU5aNM2lzuQfeUgSjG49fSvMIrN1xTiST8sqgnfbmOpeZVYLNLL64dqu1E31b4Esu1zSDXbjCaa86UkyEvd7cLt7hILQ0KLICttAN72x5UIakepv5AKBeefr8R+cuDxc5iS7H1bjbkIgoZJjuyDKQoXb0CJs5X8s5HgjkEsYkftsBLTFAnEz1x2x8GhoqMZmkJgRc+pT6nfIpBhHXvKuI1PVVYN69n4AbbRokUi/khzN3vOb/Q/45DDHHRB+BMgaYp63Mh6rnkmF0LgwvtYrr/yUt3DSoDNMmTyK5DQ5jnoCHcNt0pJ5lbharLWruiC5KGw3NyaXWgZZRxDSKtrNOSlXABbk5uAFSLpqqkvPf6jMQeZHVD/ZFm6S2qrii1KrkVc7rUzRTEKzwqUyEG5w1YRmemU78zEws8aQMwWCExjXR0VjO41vEQOMHjznImbrsE8f1ib7NHDpEiK5zUQgMwZ5khjicJJdkW0S5xoN16Ohk5GYivkTQfBSr0DAKJRscNJBPlCGE/wAhyhyT21DZ98M1uZmXhM5R/q9044iC17rh/2aPjxMHUTSPh1E3brSUam6gum29EZseBtoApcS6pnUlwAj21wiGeQVGtoWylZwP9PoLThl/CQ2fvaLsvvbecgVq4Rni4pH654qkiz4mFNF9iHTfkOGGWEfQgaXd3Qtfy7l4ofFYa4ClWQS0bfOF0/h7QFk1DzUTPC3vjnaM+qz22RwhcLL+F6X+b9gs8kMVk4Iojev1EfmHw04Cm+wFoTnc/7EVfbApwmrNpunqt/j07hHicdEWGizWy6LEmmpwICqtYSdXLStYZAkWESF4U7NSTt80WoktI6MARYAnM3VC97bOWuPXClkNAGv6BQYErINgogRZWmebb1nuFW03b7tKaLarixse0A7iaFSKkzXIxuLIOej7ay7lTkKUBHdL2ZViU6LGY3bQLTp5g 1TL4rD9h P7TPgwgDKrM+EARQGLXjo3EapqNfgLV6YlT+PB8pAvtc4dharD2DoUJry3xuyxjOc+WJMFvcCVk49zl4UlFAl3nBkCAqw4Aa6zOrZSsAzMhxB7KZWJbQfk6r1OrtO0tVPaFEsgDzBKPOEQa+UQ/XH6iOtqL4017BpABC9ocO3wCCK1l13aV2CsAFvf5zwDaoV70Z/KLDRHPhRf+yLklRKW56qK95gewG9gDZwcyLWRXEAjKk2iEFFclYPvUG7tnEjVzhyl7+bb9kWSzzND6EmsAF7lrTj82TWtxV/18xp9sU3lNhllNcGjclpAqgewJ8rAXayQk2+h5rS9204DPh6TaZrWAnLKR57zqtRRN6VCYUrImYVed3KsQEuk6+xPUWENOCU1ZD76Fs9MYLpcT9XUeMhBp4ZbwgzkLAtTeu9UKux4CtOrpkxYcNm1udFTIzAs9XAeTgKVuPRyHsEoWmlFentFECVoT+qYS5nl+eNARfvw5aOTmY+J1HmrNWv/FRZA2RsVe5CttZXD8HyLkBFEqJKp+er/Tk/FWcirMuQNInOiQGR4gsDUvHVfAX20Ddoj1AmDpFibjSXCw33DkX8JQZpCEn0ANwBmNGXfNe0OLF5SO2aqKhMCk7/4iSl2qJjslgij79BqAk/kFGuGZd+9GCNB87MVIt6+xj44pEvFnURQaSkwl3Eh1fZfRaOiWZ+Wnh3Is/5LNIJ0h6mmljep5Nbc5iu8BZ8vxF2EhVGhOSyAjoO2wgPwJeZAh7fI2kAapBWvDiSY/y0kkrhfT0xhtWyrh4NrtSEKW2qrw9weRlmMG5BnNSlPQrL+HFUXjjWcn5df5ON2pdRuDSccDiuPkAiHAHP3VGPc8xeOhMDhvnBixFHyEuhJfhAY9HHD6XtgtqrRMeh3KY2LXm8ofoPV8pZMDCGjioEpURqr+Hx50Vu1Q7zPygPNWktboO7daSfAJhsFBjfu9YiLPS4sJ4Pe3Kv8iOu iTnPhfWF kc4RBIlJ0A2RCcdSCgTBbEOPqg4roP+rFU0XqODfet8ZhczYfqQgSh2jSQCbr9UzFQvmQEu+yGU+u6r9U4KGh1Sz7KuBHSPjRld5NV3hSMs1kynCY8t2kKweGVXqMr2uFx0/ZMYgAgVQfrzm1AadWbqcaLOr7NkuJDjnq2FdTrOsx6ePhdE+EDDbu/CxX7LWPNDKmxEkBbU7/ngcpafmUqr/9/dk/iS9Ih5046HcU+jlzhUpZzLliaN06eyZyvXrYZmYgqOKfckg0e/j+ElTkM7i7SXWIfOuvKZP0dERVWC6zIj9hlBkKC6Pfs5WyAf2xHWy37kuIUNXE8CnM+oeJPGWDxcaFsB0E1MwS38ibij197VVX7TP6fSUQR+L4Syl+IOBprfctUVWJMOjTD4nR82ifQGRDDisRA+bEastjvSFHqFGz+73CYobVuLuIruNXkKJheSqjeGyBYiWpX6CwSyXktc7Yk/O6jUPnSZ/olW9CjHz9yNEslblr+tSqJOH5SxJem+4InkyTaqOrqxIrdKjMYFvZbUkqvBuN0MVO7tOpGTZMn/WM6rd2XBRtYItGeuSISNBa4iQdBMqdRPlcjw4sTAosotzye+csSyxy5db/fOW4eM1/rnbGU3BLKRgCgteUnPobV0m6euJNVghMj9FLe5Uttdxo/x/xqJZ4tkJm/+x8VyCT2Z2ZWeO/6+MAZ9ya+A2CfXHTQA4wdQ9kjZSKyHY+7uuM3O+gXpKpjXzUy8fOuCmyvngKbLGTKlaeQa71Q7hlXoamv9qX4K6y9AzuFgITjhc7dhQax/Q7fwBAcKOmVWGlAm5tIZ8VigVW+hJBEMLS27BZ2gb1r1SZYlwIwf7cSY5BlFRT6Td21T18CPiBFNhtheO4567C5gGc84L0oJ47FRGyvZ9NvAzbCSwhHWm3fNWm9qMRcfxrDMCH+5F0yF25KN4NkPzvhCpzmz/y13lolFqCTQ+GnZnygTxw5CVN 4bqO5EGi WKb1UfsVXrxOjO4FqK6kShsh+Vpu6yFFKYaNlCtOp7i3kugmr+DY5uLH2lGjeJW51OcNLasP7hV7zVdxvfC7MDlkHNNYpv1F2V3aSmvyXJirfq8IeoxvQuAvwJvNyKq5i2KtNUm7F8cVcZ566wTJMK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: No callers left that have already disabled RCU. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Mark Rutland Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- kernel/time/tick-broadcast-hrtimer.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) --- a/kernel/time/tick-broadcast-hrtimer.c +++ b/kernel/time/tick-broadcast-hrtimer.c @@ -56,25 +56,20 @@ static int bc_set_next(ktime_t expires, * hrtimer callback function is currently running, then * hrtimer_start() cannot move it and the timer stays on the CPU on * which it is assigned at the moment. + */ + hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD); + /* + * The core tick broadcast mode expects bc->bound_on to be set + * correctly to prevent a CPU which has the broadcast hrtimer + * armed from going deep idle. * - * As this can be called from idle code, the hrtimer_start() - * invocation has to be wrapped with RCU_NONIDLE() as - * hrtimer_start() can call into tracing. + * As tick_broadcast_lock is held, nothing can change the cpu + * base which was just established in hrtimer_start() above. So + * the below access is safe even without holding the hrtimer + * base lock. */ - RCU_NONIDLE( { - hrtimer_start(&bctimer, expires, HRTIMER_MODE_ABS_PINNED_HARD); - /* - * The core tick broadcast mode expects bc->bound_on to be set - * correctly to prevent a CPU which has the broadcast hrtimer - * armed from going deep idle. - * - * As tick_broadcast_lock is held, nothing can change the cpu - * base which was just established in hrtimer_start() above. So - * the below access is safe even without holding the hrtimer - * base lock. - */ - bc->bound_on = bctimer.base->cpu_base->cpu; - } ); + bc->bound_on = bctimer.base->cpu_base->cpu; + return 0; }