From patchwork Thu Jan 12 19:43:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13098761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7F0C54EBE for ; Thu, 12 Jan 2023 19:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BBB0900002; Thu, 12 Jan 2023 14:57:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A8038E0009; Thu, 12 Jan 2023 14:57:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02ECF80007; Thu, 12 Jan 2023 14:57:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C502E900002 for ; Thu, 12 Jan 2023 14:57:26 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 76050140E19 for ; Thu, 12 Jan 2023 19:57:26 +0000 (UTC) X-FDA: 80347206492.04.70A8A44 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 0273F140003 for ; Thu, 12 Jan 2023 19:57:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ATY8kiKn; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=KLAmYUkc5o4iaLgWEzyq0DD4W34Vw8wzkDDZ9nw8rNA=; b=QzvHwkU9VlnfGQJlqn49FZa9g9BqOgxFzzmA+Eeo2/3hxF9PgOHLWs1r4E6+2EPTnXl60s eEo4zOU1H9u9i5V2PgFr82JPQRyprhiovx9pAgm8xkclP8P71UsfFP4bHB4PMmSh5kj+Fs ELNy672q5GY/k5nMeIYanglcP32Pvzs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ATY8kiKn; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553445; a=rsa-sha256; cv=none; b=eYgTPpDAVJF6KqtAaJVUlf+7UJYrASPO7VH/cBfLiwKNwHnjowih8jecgdu/lQteNas/VO 0Y4Lfh++OGZdNqpzo4rJQgMpP8nFDUdUUB4krANO+h2x0TGv5YXt5XlXz3jFuq9CeGxin0 fG2eAOJghLJyiu3CL4kM+BD3hYc89Ng= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=KLAmYUkc5o4iaLgWEzyq0DD4W34Vw8wzkDDZ9nw8rNA=; b=ATY8kiKnvovNgLEm6qSQ1EQvbq whhVrHfsY0Boal85ZRoFmxTUxBK5B9bIvgSX8kVgT6BcX1L66jwQCdPl/BWOSqcQGl2XmwgaBL4PW OKdsLfeNG0cKIyK4qLBg5dTibPOilkbVEo3W2vYUVl/MzGrlgC59H1LNDjakisaklXFACDQXCVqgH X3HA2n0rfn3BN7gYs5ZEmCkrHIhhMF7I5lLP2nRilVRm9iYl7qlU43ypHe2kjKrxVavesmViWu98M YhMWMygFonCR9p+h3EzH9ve+5v/3v/1iCRvb+1bzQnO8SY3rlhjeY9n904kFy8Lg9quCma5so/ETV SIrS144Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3he-005OgL-KO; Thu, 12 Jan 2023 19:57:34 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D5966303459; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 3DD3A2CCFB77A; Thu, 12 Jan 2023 20:57:08 +0100 (CET) Message-ID: <20230112195541.538053457@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:50 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 36/51] cpuidle,omap3: Use WFI for omap3_pm_idle() References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0273F140003 X-Stat-Signature: c4ghgmqf5b8fz7d9a5531hu3djbtuu86 X-Rspam-User: X-HE-Tag: 1673553443-256748 X-HE-Meta: U2FsdGVkX1+pgCAEvWx5TrfMsDySBkTI3ehUS++drgsFNCmmeBt1LsyMq2w+hNt+6qSEniXw3ZaI3yeWQgPdIy6RHEV0OG5gB3ycDRwUP15jQYIDV6rBfawgDClvRqfAZoCeSNOwly0fGUVE0y5A4RYDl6S1Ja9f247ZD/x3mdQ+e+0Bj+gDVch+ZHrIczwePFzJFkM8rSLizxzvR84mCDAf5//dcc0wRJcvPKXXndhO7R/65KUSnXXM8DRadH4HOiFLq1P2d4zgiT0bng3a0Ooy2zBSjHZGvSve6+pEf61yPA+jKU8avtumWKhwesYOIAH3kK6BhHUlm76sVVe7EwdRofB5aBWGAGeLmzSBld9DKKals1IyfUbv8bjeya7WuArzj4Gf2fjx5KIJQe932xKfzbWKDewcQYPxxUl6VM0TW5jCxAlceEsf8tiYaQhvCf/ogA/NWOwTC2Us87+sQOvoeGw4G6ifX0Upyokebl99KH+gpFQNnnJYSjxwbbQlFRfpkTBAxwI6qjboh1HGxm2WisQivOE85sYW5E6fgESDhUJdgTjeth19nmBgbsS0CzsF/IkHR34Pb1YIkrB49FWg1hJ+eX+Cwm3t7eNbC9STNpQ9XchdfnC4UYO8QfZ7zOjWukB6K0jG/+TvbCLZe5zNsGEEC1Ak3C2jXHSVP5Di//vkidgHGOr2yiDYyww9HdwnKtFiy4imMhRBMICSW6kITlnbDQ/ddVB7GUQbzpfF1IvYM+GZi2lgGcWUa6ujrM6t7Vu7lipKLWkSB6hL+xUcC/VtFo5nlaH1il8sz5aRRUdipBLamqXZeLqe5at/Q9aLPAgwGOSC0ZM0GiE3sHv7hyP1tyMYEXSNS46Ql2nCYXJAHLD3haVlbjTCFxiIGkfAUt9VVAJ159bk7NlMa7WA4BEKmoyZ4RCDuIIqj06OBI1KL2Mc26ul2TlNzGYDsWDQbMNrkqrZUc3LeLo KgiRu8nG b/4ptU0sL6merkqd4BR35CS8M3tpahFAl+Vuxqd6fuALtsiJ0h+cE+SGDzubslutdOGWe6Szg6rQNANAwrfsEcf6QzkPWOHbSHzALDAk3OCuyKWoW1X5+fVLzKCbeX9hq8as9TqvsNZ2sitJ0sDUUaK9NGfynch8FTOruY6cow4D/3qAMzaJAd0koo1QmVF8Hw9Yir/8h02+MZlC9YI5kpnGRxkq9pB7/UpWpOnJh3XatmusHsUFRbA4xQDWTFT+2oSGVeOXMxX5ryh7ZwLn7a1Lx24zgu82tTueE6uIA62AXUe66SpexHOA6+vm/N21KL8wdNPGAMFzxQKNtG9PXrJmBKNshSdBpK6jP2tOHubDqqMRKVdq7UoUwdd5jyKmZUL007lVQbSuwV7FN2Y8LDCuod2z6XIUOOLx2eK+dOnq/hLDSnA5DFIAEEHSA5WkzLQWA8TE3JLcdCMIaba1ySSPXsJZcNrxfSr2P2xDsz1LM7M4nfCkmyQJ8xxa6IQU5j7HGz3j1lddQBJqsgy421T7I9/1bdIdOjFD+yGhhzVGUY6W9UR8iE4eMoDL3UxVOu1uAYH9pNFfo/AH23HWBX1M1MjWrIpFFOT/R3G2PAnr0W8bpEueMLH3lz1F6smkWH6F+8WppjL2fxGmNm8mNxYPumDlM2ZLbDA1dDBri7XnN5A6PKiokX2rGn9zmtG2CjOvxrc/HZ5KC18THUctn+CsyKQMVDQEdRArF9Z1w58thDGZwwtRPCsihoSQF9wCaaQ5QQ0WlzRg0xBUuyZJ5z84YmpAdkTzeHwR2jlkoW6CZBIOETQEbGVncW82nigg35O1oQI0korOPMLgqGxTXHyZlOBfHxax7tU8m6MCdcy0tNRVsXfC8/PcFGoWU0Gc1nDm56b2tnxzJCdEUhHp0Z9Gg5yu/ZBsp8ING9+09AqyOhgnOQCIDlKB1wT3EjLarcRVyVy09+1Cg2HUHMZSUNUEOC+Cn G55GzD7e xxI+uwUQ7r2dJ0AO9cpWXelumbJl9LmSdtP/xkmQ5kwyMOO+7cDYrY0j96Ppbso5rdXW7IoCTr5MY2dWPpMZ/Yzbp9JNf1yG5naxkj2CgYVAGwzeFs4IF4szpeRJYE2Jz93q7mMq2xo4peBK9QO8tsB3VxT+SMV3DBd1gXvL+jf1mG4NrMbTGyxzALqMK1pS2OV+1J8YjPie7YPML3F7bCoz+nPZX2q5OKk1XaI//+7aVBtUgu9kr/3J893Mjyg8ZznRoYkqUCX2mDlmZ3FDBd9JHZs60dJXoi+nE0N1nQr8DCfNsn7oZ3CEvZwj/Tn3QjLf4baURhjLiKkL+QyBtThuuusXUQ0mvz60JaDRL1RQ3owdScMLW1Y3iQvEqd8HvxNmr2DN9czxpL9pZuSzycszEqnn5L7b4HJcmVORtP87R86mSsotKGx4XXsThdNGyYex38S+PM8bY8a7GX9U9eUjoRd2Zw8UlrqvYlKN8sZo+kBnsgw1RJ1Uw+bY9S9b4GLrsIh8klrG5CrlkO3WZv+JOZ4In4brEogzZwoQ5XuLSDBiQ1dH75NE/bfW3r7r3FV3Ot/wVRPaV2CaIhJaIJ1GzjSUeSOW0J9fLkxGWyIA7Fbfz/m2KTVnKK5F5knoFo0uPOoYiq187u4KvTTZEeNMAgSX2GtvYnW7bySv/BfXZ5f7DVXDOhSnrLCZv4QgiYif9n/4iFVeZsLevGaWHx+fozowrk47p0hxdZH9nNarJxMk0ow/Gj9zsGB6I/Nb3pJk3uBdvGxZfqq2hv7bzpVRid0juqLXgbV47eBf1pAdacfr2eUzazHg9v07YzTx+Y+Rw5RVwq2W+WhFE5fAMi4OVc/r+HJGwL9o1Seu4dcazm6+r7GpsNV7S++AGRPFyjYCZ55+i+bSpSQUxKcEwnVKpiQpREcjWqG7nWPsQDzMDrbBsZCsH8LrqVBL+1t55qe6kWpeyst6OiFaS2BdGfeancTfr SVZ8Yyx8 uJMRpRis37GlTc+7PXa7q7MFd9JN588My+kMsUpUt4tHZdOLmRcipZTyiIwjDj/E5nqY+wwJ3fHXo4AsrPZPoktok7gHCQqxwHImVhjwbEuAad1vNSyfYOEoV8AnY26EgHrIRTqlbnG41rRcwt9BXlWHtZ0JHLsl2KppXvbhWWLtEHzB4SlO27MK/FxBOGC6DdTLWqFftQfA8jRjaQdvV9RPkyRXwj5YDdkT3DvDdTpfAq7yxNuKn1FH8yFnEFy2ph9Sk0bu1VsYoFhX0Jwbrn5A29wnheCf1AUaY1z2yHGJRQAS68La2SidQObROODZlKqTxeZ7bKVA1ML0JxMPKPSvhURt0KQsNn+uTqXfqgnr6dQ+cGTKWFj31fXNwydj3dEQAqHwlnytAjcsW0TEo0OSbgTb2eGLI+MRdSYrQGTuISkZkgBE9ykAmMq2a4xIKPETZ7cYgIN8hrenqJ0Dgs5yRXaw59uPooh3CZ6pNrFElEU7ABPANsUNAlV0EHC1p5M7RkumoZoS7HQ7yjIDTm3RAXRx08v1mYO11zZ7adBZgexcKLAaVjGIz/quiPO0mGF2y/fd+FxUSD/UWw/IrLBD+gXk4CIx2zo8FGX489ldzwrh1ypkjz0eMUjZ7uHd+zoJ/7RB4YOaHss5iRw9EGK3GwSMsW80lCpREbZPI8NCim1GecfenmhEWMp6Gikt4qntpk9fhiBWwnrOOZXMDwErWrXqAp5JKByuhZ+nchwJ7DZvvOC+SVLh8NiH1C+RgxDCNLHQI2dtYLxubtCzQrcIH/OGxwzLvq3AS+ib+uoIoQNN9kwJCDt9X7tC/L2lJ8MaO+owRP3jXTvQ/gxa/EXb/GycPJ+yBsdJ4VYXBB3/pqUjHSdDQhA0JEZPjLQUqWZZsJ+HZAye4CuKQDVgBOzJ8TXfutXqaM54jxGsB3B4iSJ7AmWpKunGzsydEScYYNgkH4LxeCFFVZZPpO4tTkp5Lt5Wq UZbgOSKr cfQlYoTQQOExUt1JpMWD87wg9cBmBcSy9kfmBB+kopucCnxm1IckzGv1FOIiJ3MgW5tQ+xe/XsER1qF7tYoqK698scVqJz67x+vNcnLGC3blh+FtuRh7kJR08Y/oUBqo0IbcxvUi6B0toxSv9dneTP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: arch_cpu_idle() is a very simple idle interface and exposes only a single idle state and is expected to not require RCU and not do any tracing/instrumentation. As such, omap_sram_idle() is not a valid implementation. Replace it with the simple (shallow) omap3_do_wfi() call. Leaving the more complicated idle states for the cpuidle driver. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Tony Lindgren Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- arch/arm/mach-omap2/pm34xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -294,7 +294,7 @@ static void omap3_pm_idle(void) if (omap_irq_pending()) return; - omap_sram_idle(); + omap3_do_wfi(); } #ifdef CONFIG_SUSPEND