From patchwork Thu Jan 12 19:44:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13098784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC9FC678D6 for ; Thu, 12 Jan 2023 19:58:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFE178001E; Thu, 12 Jan 2023 14:57:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C39808001D; Thu, 12 Jan 2023 14:57:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99FA28001E; Thu, 12 Jan 2023 14:57:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 84F648001D for ; Thu, 12 Jan 2023 14:57:44 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 45938A0E18 for ; Thu, 12 Jan 2023 19:57:44 +0000 (UTC) X-FDA: 80347207248.02.71FA2AF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 479BF40012 for ; Thu, 12 Jan 2023 19:57:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UFhO8sQy; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553462; a=rsa-sha256; cv=none; b=bceGqSkXyCiBPRJLV18AjTcLebM92tUEEG58Z1aBKtXJB1g9ba4MQy4Oh1MZXkXHKwgKat atFYAEmh41Qz479EX/ylOG5RK3cjOSk+eo1TwwQ2Q5He4/Hy1i7gJ8V/+6buQoZ8v4cUu9 +o+BMI3Q+WO2QsTjuFBIxyPA/c0/l8c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UFhO8sQy; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=ljNIHChdlymEt0s4DtY+Ji5/5ZFr1jFKrzucPLjcAFA=; b=ypDcJGGo87gO+plSSDUAxTiroDgCc7aO91LHPQ67yQWa2BGCKnsQGQrL2n3MNl5DH9ggyc rBBQLwlcrCkMAqOUwHvTalWOrmMPXgtLYPMtc13aKj+lUxNbo/6BUfHazh17h+RFVN+bxH cBCPS8+QZKrJ7ols9OkdkL92kRFi4w8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=ljNIHChdlymEt0s4DtY+Ji5/5ZFr1jFKrzucPLjcAFA=; b=UFhO8sQycbOykP9WLmHLr8syH1 9tKpgf+RH4+2oIWu+p1NsZyG1ZQUQEWQKyB7rZeJqKLqT/EpPMTLJSHpi/eniYQI6kNhYX80bC7rp v4DYtLIywV5PM3hyi+6d9VreCBIfyUq0bOE4EJwgP1PAPqwc5ULRKbQuNPzHKcYXFJ+bhA18Sk3BK 0SHi+ZzW5d72kp/7epWf2U0Zao67mw1W6KZFzu9PuzdtQCB/RZo73P/7KFSV/9Z+EgMtlu14sgzCt LY3p+teRO7dsISyeJIOJS/fTB2tiC6ZycPsflBP3cBseh7aef5nb+O7jgwPbkvWsd95ol/bFuNb6B 77LSYyRg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3hu-005P6M-DU; Thu, 12 Jan 2023 19:57:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 2E2C5303477; Thu, 12 Jan 2023 20:57:14 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 68B912CD066DC; Thu, 12 Jan 2023 20:57:08 +0100 (CET) Message-ID: <20230112195542.151174682@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:44:00 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 46/51] arm64,riscv,perf: Remove RCU_NONIDLE() usage References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 479BF40012 X-Rspamd-Server: rspam01 X-Stat-Signature: bpehet7pqqxfr1o9ehn3ma8xm819ru4t X-HE-Tag: 1673553460-359958 X-HE-Meta: U2FsdGVkX196BxBmROGp1NFxLwFxwR05CBG8Ok4uQAD+ognqd7+WUNUXIeKzCXRmDmuZ0FBB2plz0+pKxmmh+UbcWABVknWmCM/u/bOh+8Sp8Z8URuWWH9mtlP20jqXeTnPBmC+ivt642j6QNMn0VZK5uH3/RaIY5ViWCV+BQ1JtlcYOaCgeBT4XoF66zOei9bTRvMzz/r0UW5UR6N6wqfhHnHY+sXt0YLJHsX/5rhRpNUN7DateEtjTbofFbv6OLdjGsVEuKA60KHuwdU5XqmyN/r1hXMgq2UDDUwU1TsOohujSS6ztpzM2Kih2j0u3tOS/eBVA5RwHRRceLX/ONQp/frQqZAeQa+KP7omHpYZQmhbFc2qWETGw+ODtY833UqTs+IuwBLk3Ks7L/XL/TtpPOFOqPZpSiPNhwycjhFaMrtduu+jbrd0J4gzsFWUTjP2XQRd23kGXJXCpis09e3zby4laDMGtHMoNeJjvsbaUPsExHdxFn2Sta5/mZ2DByohhAMJf8/fUm4peyE/GjYhLOq2Nrh7x4UD8aL+4YM3plZ0zXpZk02teO/StY6Ud6UoYtFjQZMGWXrdDDY65veUP2oIYFAins6S8Yex0qtlVB8kEOA842YGpN2GTCXIunLDZ/Ij7NGjhrOGiw0QH32N0++ue+AOBdGYysCFTbDQXqZcZB5Ih3HX4duylLfUUBdpLYyJ+PhKaNeKghVkvvVzZ/txP5xlc5uIn7KOIMd/ja8XrSFj5WJgt0KmBrhKMLKP8+YRe/YQO2sOlzko/0eD5tqCe1f9WC8vA5LeziHh80vYcrdDEr0dhDhQJUDJlZ1ehwJg8sZW1jdM03KyOpAd+qFxk74i0gYb2mMccBWBc0WaSBJ7GPYkIzX1D+02+imF0l4ZigA036cOnsa7GNH6e9h+O4m5wl6LYobCAKtyHhAUHSsA6pnTGq6j/7zeNH/ufmZ3csYxL7qj3e5H COGdJrms ErHVpDrxw9xj1olAgMY0pk0VypbO/0axYnSDNQLjRI40OFZYYAkj7P2EYYe0MXlVp2BBNOf67FsL+UAJEvg3hW9gKs2iqUquhQLF9egJkZOLo24yDL1qcwklU4NRKxBrR3k+Xxb1hm4V14vsQYq9WdxhHfHw0Y2a2wTo73Gle9qo/NDl0MZTFrN7822MGCtiMgxKdzxOVOwbekdi3hiloCbaX0FmeYXyzYQEqun0+FfvSUB3bWHXFsRpjcrKBbksdJR12Aye56OP6vOTV+AQFkzfMsumgMX9+GBZd5WQbQs+OpWWqYmftbvTOBCwSDMKglbdyoF52BVyjaQbQocWnf4MrDOHcSxeaHdi/LqntUhvPG8vZb91Jta6CYwKQOl2DwyiOzOsdvypvU4DtmDrgJrTnIiK64sV3lTswyF110BUa6ULZagkpdYlHVpUYZcRYaoklIOePsTrQBJD138MeUJQxA6T5c855haT8SViD+SPW1nHkIWgry6r3SWJGU95lWv1q53iuTDFQnLnlAKfJ8ODAGW1UZqYzJFt4twU25Kn87AbXRU5VzPHr05Y9yWZGiFKZb3ytlpfy6y8d0UwseWdftMnAkueHFOyTXhpHUtAaSvMd+QkxE+ATVI0H2UYoVXbWzqZU8NT5Yw4h0gJiZBqCZhU4c6C6Sv+cr+HOTRyhEt6zDclR0mLWrwlsSf3pwwbODchpDof4b5otEbKaXch7WaPT6LGQXcs3AyEqXfdjEyDKEfhZVB0yZG9XfOwNRVGGewmZqwsADT4MdWHMaNMamd9Ul4CvC0Vigl/v+GN8VQLNHl4k0axbBjpBL14MEiEpCis8m+0xeDDc5IWpsOkrxLBNMoJ7+ziwOLJ85tUC6qszu0IJ3/eQBguZql7N5aKmMhJbNW8wYO58t31ue5ZNAIbDpJi53KqqwM4KE7q7HEnqZ9CqzM4dH6+qFEtKpHfK0aiWa2zj1kjFCdZb3zKGZ0fC W9HGAfzx bsAHC9kHhkZz+ryT5acL3AWGLea3O/Bg7Sj66Jk94g8vsxk41k1BPnaey9/XtU45/sYOw9g2LJ6d/0iu5ADHiq4tushp+MHhnjc3/G94vRa4nH/l/BDW+obK88Fr1XP7qrXgYvKMjh8bCUFJr/q5ejn/dUFQrqOl+fA3Ana0FfXjLSnbKYHQTL6p2fpaimzvJLiOIXS61F7cGhiL8swGT62pWzhwYS8YyhYraYyZkhm5oIFHYe7CjS4la+z8yqPXpCMQH+jFEQ7wpng4VwLZYkBMbAqkbypPXcO1bo/HHER0tLnQ2/BW/cc9OdekCvi6Ij4IJkcUOGGUaK5l9ZS7rM1DDvl4xZqhzOwANa+YqrZDeDYw38Gk16cfYApw+QnMVxZAIR/mZUDApLOBWsrJLqQIIIBVfL3CF8uKoavovPy5RecolIjWY38pQAlyOriIgRAnW9Un+6op98PJ92rLHeFF0wddWa1s+kOYV3GuehW3lZ3FT9n7sZixgCc6WBTQ2IyOpsxOo85a7aQy/PVrYDK1XH9vTuT479Jp/l39OkKLY3Fmf81u2Abgn1T31iazmXSl8WqQ+LxGkEuOk/FrbV2qGKXh8NmKtQzcbHnLnIyvioCNXmCh0fWzVJAOy7/aAPoUz/kaQUujwLk1tO0iXNn0rCQ+4iTbsOdHWoSQMf3HjzmoY7Q64F+GCVfB21/Fm0eqmyj0mPl/t4lnMIYTOTDYk5RUQGCoU6Uwk9ObVYZhbIG7r/TF83tZ9aJhJTaYogx3xezTftfIU9BHaQRg0Xp7IeapI/vQyxAFdI6CpNzVByUNPs2wmEcuqky5YaWydnmDwZQwt0emUemZ7dH74fflTYVjBOSLKFP5RdbpqXLqlqUIcxt/oUcxJVbeHs/pduJGXoCPxAQ4xuRRqyFSKrwezMOhxG3vTPKEuY69z1XVVWMPDYsS1ENquBwQ7jNfiIpAAVgWaakuI3QMKGX38K9REupNd DSphVHbC aC3zonfafok60bfwlvwlUNPCkRvZjdA/Nk/t+Reye/OKsy4Z1l//Xl5jTNbqjbZ3nofWEk/xcX55BdszLy0lDf9z9DrwVu4Mnit47pjuAje5OZX+YjbcPPeIENovRTCsj1dfio8TbH8qIQDQFXW7oQXqCEf2u50vvhdN3Nx/psyVJY/3zbPJGa76iKc26DAjM3o556KDBlLQWsTmLflLRGO5MBoBJxxDvRInzfBKCVIAl7w8pHVkrzVBZmTaJDj30CN7sLSgHD0OQCVKP9OhtaE2zyNz46fGsuTAygLwBzeMZDFp80KLSzTs2LfXuFz9W9/2sPzYL365QIy9LXioFF4ko+dmjm2m1ME+oCiDmCuaFliss8JjWj4MW1EKf+IsKYMZMg5mVuofAtkadUywPC3KQtDz4S24d0J/EjbHX5vnpGqoBfF0Z482wCTscM7A07ACFoxAoCyB82d80LkAM7HNwT7rmQ9sLEnPl9fPHu4P8TOIfE1YzWqHTwGkBY9mQMfIug70e7vn8w0m4FGiMMdWVHde5EsOU9AKO1NSrLOws49PLAT+45A7ioEpgIxqRSOJnJ7bfqXKiUmQNk4llSY2YB6Ymr//tp4LQ/Hs7xA4+1ZrhR4IwU4Ij2WtcAn10wpd/w3YV5SR0blanCQl02j96Sd/u0Kc+qdGh6tbijFlZraLGtb47mre9uclYdRmPROKaQltjif/j3ylShgvA4ENYSdcBy9ZFhvuGVAAMN+hWJzEzIFnakKHNJpuLmDZpzjjOPzuf1ZFadAfxkqd3rU39AohEqNRsGvrpe+HwJShU5jRly4bm55iO1Mn1n+Q1pU0F1R+R4lEZTxrenw/VT0bTSK3+v2AIO/7TClKagEjwuB9ge4oPtB5bOHRSF4aDwrtajSX3WnQVfs7X7g2kRTKcA1FQGcUZsouvy50ImCBySdRfXHTb1WpvU8/86ElzPAb2obOd+k5Fm0XP05nC9EVhdDls /FyPR0X2 JUXcGNEWaQsRw8HfCcgHD1O1MfviNMS2DpKcSw0FUqMwEpLnLuaR0i/UI7K+d/auTVbx7VAFT7hwMU3lzOCFFoEx5JWwayUR4HqZ9bY+Y+dOs4MAOtXX7T6Uj9l8VEgM8RVzbeyd6eeuRKe5cQFL7+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The PM notifiers should no longer be ran with RCU disabled (per the previous patches), as such this hack is no longer required either. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- drivers/perf/arm_pmu.c | 11 +---------- drivers/perf/riscv_pmu_sbi.c | 8 +------- 2 files changed, 2 insertions(+), 17 deletions(-) --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c @@ -762,17 +762,8 @@ static void cpu_pm_pmu_setup(struct arm_ case CPU_PM_ENTER_FAILED: /* * Restore and enable the counter. - * armpmu_start() indirectly calls - * - * perf_event_update_userpage() - * - * that requires RCU read locking to be functional, - * wrap the call within RCU_NONIDLE to make the - * RCU subsystem aware this cpu is not idle from - * an RCU perspective for the armpmu_start() call - * duration. */ - RCU_NONIDLE(armpmu_start(event, PERF_EF_RELOAD)); + armpmu_start(event, PERF_EF_RELOAD); break; default: break; --- a/drivers/perf/riscv_pmu_sbi.c +++ b/drivers/perf/riscv_pmu_sbi.c @@ -747,14 +747,8 @@ static int riscv_pm_pmu_notify(struct no case CPU_PM_ENTER_FAILED: /* * Restore and enable the counter. - * - * Requires RCU read locking to be functional, - * wrap the call within RCU_NONIDLE to make the - * RCU subsystem aware this cpu is not idle from - * an RCU perspective for the riscv_pmu_start() call - * duration. */ - RCU_NONIDLE(riscv_pmu_start(event, PERF_EF_RELOAD)); + riscv_pmu_start(event, PERF_EF_RELOAD); break; default: break;