diff mbox series

[linux-next] mm/hugetlb: replace get_hwpoison_huge_page() with get_hwpoison_hugetlb_folio() when !CONFIG_HUGETLBFS

Message ID 202301201036092738081@zte.com.cn (mailing list archive)
State New
Headers show
Series [linux-next] mm/hugetlb: replace get_hwpoison_huge_page() with get_hwpoison_hugetlb_folio() when !CONFIG_HUGETLBFS | expand

Commit Message

Yang Yang Jan. 20, 2023, 2:36 a.m. UTC 
From: Yang Yang <yang.yang29@zte.com.cn>

When CONFIG_HUGETLBFS is not set, there are two problems. One
is implicit declaration of function get_hwpoison_hugetlb_folio(),
the other is get_hwpoison_huge_page() is defined but not used.
Fix them all by defining get_hwpoison_hugetlb_folio() instead of
get_hwpoison_huge_page() when !CONFIG_HUGETLB_PAGE.

Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
---
 include/linux/hugetlb.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sidhartha Kumar Jan. 20, 2023, 5:56 a.m. UTC | #1 
On 1/19/23 6:36 PM, yang.yang29@zte.com.cn wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
> 
> When CONFIG_HUGETLBFS is not set, there are two problems. One
> is implicit declaration of function get_hwpoison_hugetlb_folio(),
> the other is get_hwpoison_huge_page() is defined but not used.
> Fix them all by defining get_hwpoison_hugetlb_folio() instead of
> get_hwpoison_huge_page() when !CONFIG_HUGETLB_PAGE.
> 
> Fixes: 92e109a2c5a7 ("mm/hugetlb: convert get_hwpoison_huge_page() to folios")
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> ---
>   include/linux/hugetlb.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index f14a6bd2a6ed..9189cc359c64 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -417,7 +417,8 @@ static inline int isolate_hugetlb(struct folio *folio, struct list_head *list)
>   	return -EBUSY;
>   }
> 
> -static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison)
> +static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb,
> +			bool unpoison)
>   {
>   	return 0;
>   }

I believe this issue has been fixed by this patch:

https://lore.kernel.org/linux-mm/20230119111920.635260-1-arnd@kernel.org/T/

which has been added to mm-unstable now.

Thanks,
Sidhartha Kumar
diff mbox series

Patch

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index f14a6bd2a6ed..9189cc359c64 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -417,7 +417,8 @@  static inline int isolate_hugetlb(struct folio *folio, struct list_head *list)
 	return -EBUSY;
 }

-static inline int get_hwpoison_huge_page(struct page *page, bool *hugetlb, bool unpoison)
+static inline int get_hwpoison_hugetlb_folio(struct folio *folio, bool *hugetlb,
+			bool unpoison)
 {
 	return 0;
 }