From patchwork Thu Jan 26 14:16:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13117194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079E9C54E94 for ; Thu, 26 Jan 2023 14:16:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87A916B0075; Thu, 26 Jan 2023 09:16:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DBF56B0078; Thu, 26 Jan 2023 09:16:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62DDE8E0001; Thu, 26 Jan 2023 09:16:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 536E96B0075 for ; Thu, 26 Jan 2023 09:16:48 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F56EAAFAD for ; Thu, 26 Jan 2023 14:16:48 +0000 (UTC) X-FDA: 80397151296.19.F454111 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 7A3A416001A for ; Thu, 26 Jan 2023 14:16:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V3QiqFn8; spf=pass (imf08.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674742606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=UUeroDmTl+H3UYSLKfx3UyVjFR2p+V0BTEnxRsCOJP+EYOtuDy1kR/RKo6soVsQ4P5CYom u+BAjKnMLodEz8qq0dll6aOb7xKYuB4iKgc4QInqHCgBg1u4NPPAbrN9LvkLISbDLGayJp 0UUXrdFu+gN+hfHVZzoHQNn2u+TL1vg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V3QiqFn8; spf=pass (imf08.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674742606; a=rsa-sha256; cv=none; b=1XwSvYHgMkngKUZ6KhkmmilCI36qE7KPm4LpwzqvrJCxO0F4vKwGWt1qE6Yncj97R7nLmj IC17DJ6zoIaLf8rqNVaJBYMyua/aUPCCuQ1aogsYy6FPdC9HMRqE6YzTOmWsSAi1R86Jt+ E/tEk0mthBDof+jXNV8njlgz+mpexvw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674742605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=V3QiqFn8d02UZ1ovwc4hMqXd14d4PnPtEqGQfgjZTp6jopZ8v2zeE/oH10u7GqyZpB6oKJ TQGEDRJ+trca/8I7ufB8sOF4fVOxHLXX1/oo66YKcbJin9+GlRBgIu67HR3JW7jYO9mfHv 7n5dKsMloCAn0Cm0s2Mz6X6W8XqLV8M= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-24XiFfRTO8-Jed3P6qNVRg-1; Thu, 26 Jan 2023 09:16:42 -0500 X-MC-Unique: 24XiFfRTO8-Jed3P6qNVRg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 013E41C29D45; Thu, 26 Jan 2023 14:16:41 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B45E492B01; Thu, 26 Jan 2023 14:16:39 +0000 (UTC) From: David Howells To: Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: [PATCH v11 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Thu, 26 Jan 2023 14:16:21 +0000 Message-Id: <20230126141626.2809643-4-dhowells@redhat.com> In-Reply-To: <20230126141626.2809643-1-dhowells@redhat.com> References: <20230126141626.2809643-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A3A416001A X-Rspam-User: X-Stat-Signature: hbrfgxehbrpz46jffneudmrp7ttc9ygw X-HE-Tag: 1674742606-546009 X-HE-Meta: U2FsdGVkX1/vYz22u1tavRLqEqZk75nWX5ciEyCjGywSrSmXmM1gcuDeKDPNAJqbz0PCWP6x/P36wFGrktv7cnHp6Kt+VgHwsq+/mVe/zt4m9wWFrDLEW+NancNiH57JE39oBa71cVvywIwfykUp8ZlPVXFDfyHfoTgVU2Ti4DWUvlPpyjTCz4luvOtcLbaBBMuW9n8GJlG6UGHsqi3PkOMuKp/DQIdY/xxrEh7OoOr8iRwM5B+nmIiLpG4zarqvvSoi7DoX5JDdQpHIzRNXdHOm3kX4ae6jl74nJGzUD+RuFDsKB8btj90SjExBTDtDRJkIqJ05IGCF1SogFopppK3GI9cY5Q5DqcFa98T4Tj9MWnrjWnALyocq4sGcxb0gdZFWJ+Ns8zpXH/YTKKR3X7AOhfaWNoXi0EtlpXwJjDLUOTX3yEjRm7+BdxvmP6VpsnnfZpKdjjNLqph866ozBYRF7c/RH7ulLrM+hL7+3Jz0HHtBNC/SlUKCt/Rs4iLQxJtE3WlrjpaQ1Jt3XziingjIJPOAIMl2YvGH+Avrt6cVXjp3/TxuOmdcgfd0C0ayNmPEOLVb3qwodvYwM2TiZeSUxKztGYwXo/SIULg+3rUbt5OaSMK8EKvJIk/+a1Jp6hF+V2pjECRI5Y/Vbh9lQO6wtbUYdAosIG5AqOPMPPG8aUzG0ZRv+fBrB1czPl5uphT1sfrm+eYPmMqhwqSCvEwy6Rmx9kuSvaNws4O5kYhWkxqeocS0fz7sSKf41ZSLS8J0drB5YCodVmwT8ldxc1y6GPEP87XuT8dBzaxqZGwUSkpUp/Otmha0K7HOf6VO4bcbUEa06UFxltUAq8grI2P3ERjdTOgNH1tUATx1v8a7dR6XK0AiyllQvTdDi3NyvHQ4K9N+8GSMMQwZX1f7zdX5fvYUuk55iAXfw6p4yCqPxrG1JxYHhPQE6Gj7XhRZlmFrGXMculqf7QVzple mQSHnWvM s+t5CIuD9iu7UBaLVv1Dh80m3OAVty4cC9uq5wN3s+sLqVODtXy3uvYiEw4xwmrwPMvAf/m2eJbmoRJWLiUNhSxI9OlwWOlvf5RWG7vEiUXJcPegeerdcuDexUgyEObdGWKaLk06pIu/S1kp4thC/VivKegMjurfOU1lP1KwwIiDBLqSwxJbFXXVcGCyLUfG6T6vg2xGVaTjiZFEbwLlgILFieHayOC2Nnv5kunnLPBQ77GciRJm9eenQ4Hy8dcC4pNbdvQdK0kITIObVXhve9we7eAme+HK6gE7x6F/aSo8bKVpTuPZbcm2eg/gnhd3Bn5GY8eioDvw8npVQztvXYknAJpkObUo+iyK8cHKCqIw475Npz/mrvdFelarCYtJlEYbd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard cc: Al Viro cc: David Hildenbrand cc: linux-fsdevel@vger.kernel.org Reviewed-by: Christoph Hellwig --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }