From patchwork Sun Jan 29 04:06:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tong Tiangen X-Patchwork-Id: 13120024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E8DC05027 for ; Sun, 29 Jan 2023 04:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6957A6B0072; Sat, 28 Jan 2023 23:07:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 645BF6B0073; Sat, 28 Jan 2023 23:07:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5344C6B0074; Sat, 28 Jan 2023 23:07:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 416096B0072 for ; Sat, 28 Jan 2023 23:07:01 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0B08614035A for ; Sun, 29 Jan 2023 04:07:01 +0000 (UTC) X-FDA: 80406501042.07.289B135 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id E2C3E40007 for ; Sun, 29 Jan 2023 04:06:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674965219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=v3LUQEGcp2AJAVpi/XguHPJq5//d4cUzfSNrHXFgHFk=; b=EYVPLGmUDmf5LLjp27leqL3qUkqlmxSR3aUi8q1OlVT32JETflwRWfsZGVcDAHnjWmIUHc 4OFcm0FciGKcoJc+QWHgG13PeUT9AtbwIFYzRl2hYP1tcgdomNogqHZmRccVgmowUmN/ul s7xVcs3Ste3ucrrMNBHsKhveyOOzPB8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674965219; a=rsa-sha256; cv=none; b=PqyQwDMRYIhxiv9HDvSF6t3Qr9/HyN2Lyc2ji2zVrkrR07q/s8wIPo8cy0T8QY9GClsPn0 eFNEJQT/OvKgsmJToKLQWZqmnHE39dD5Sgh+EjlzVZKcdNl0Fb5wz/Dh82hH8TeLwXfxjk 6bli3SquhSWJemP9f20tWWrP4Ndle2g= Received: from kwepemm600017.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P4Hl13WRHzRnvL; Sun, 29 Jan 2023 12:04:45 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sun, 29 Jan 2023 12:06:53 +0800 From: Tong Tiangen To: Andrew Morton , "Aneesh Kumar K . V" CC: , , Tong Tiangen , , Guohanjun Subject: [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier() Date: Sun, 29 Jan 2023 04:06:51 +0000 Message-ID: <20230129040651.1329208-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: d4tftedbsrcqzot4oawknktcn445yqqm X-Rspamd-Queue-Id: E2C3E40007 X-HE-Tag: 1674965217-981764 X-HE-Meta: U2FsdGVkX1/6ZfDRHjBmQ3nu7LH2obKsHVuvw9ixUcZiBGmof1Vt44cNvyB5G5DYOZ2klEUxCzjo3xvtqFkF/5bSte2UuaDEXjgpXoj+LWs0el8D0mlaY4McK3QuKDShXACwh1ssQI+vrktdGZGGWPoicegHCPyaOX+ejeA9CqtKzvVM4yC/zdnJC+FHK2G7h1gQlQSKeX1nsh21qYFaui7XnGWEgSryIEY9+1H64hAKKOSaYIvTUdV3kbx9a48UwdOFhl6ZEp7b37+568HlsKxvRzVBcLvkEI9vkoH8wDMMgvhg8U78kyA8Ex0qd8zBxXw7P6mSEcEaXefc3zuY0VTddmNBJmNp71t4vyo1n3+mqQVLOIvdlzZjoE00cz2RCaWuCbsmT1nYW4EbWy+jVi/9t8kz9CUVLzZf2EPNLjllS24gZHJLWtuQKLOgQ93TcLYu2PW/kOJ1pIki9sml0XbVgyvfrNswfoyUL2n+o75inkHWkjVrt8WB0HX6U6AHc7SvxyO0vbGDnEzAMjMppk5j3zsgOgdBbep1XLoXEzb7vGxzr3O+qyRVvr+fL14IH/X5P7xvTKTUoV+B+zru1GstsZ3amcrgbZuVm85WBGwnnEZxTF8iOYBto5M3i0fhQoLGQmPTN5NXZbEQt6ZLLXgi09ao4W25fjJpitP7H2rIa/k7elJ9bWSCUyHGfHe8oTO8TFBnZMhUDs0LaivVMSFMwsUQif3GQ8z1ucAGA6csx8YI12aAozbSxcM3TlcOaAHv3MXQXj8eu7K3UJpiPafogZRPwa8T30KUSJd5Hji1lE+kYblkHIo98DPnWUraf7XkPVBb57h06i9V4zs3a2fBWGGlpita49rC/LrUB9ab4eD3gdbV9nDwtg2abTwn3rpyrYx7CyKOAYjYzcSFw6y5V8ephgFEmxU79o2cz33CEfn/qjKOCFy+nBpX+5llA2FG6M2o9/xQ/mAjVsp 2QT7YHAm 46AZRP75KYxuHI30CcD+i9gqtWLDdD2z8276ABorlHacTq5eWJqBBDEf51m0Fc2lbOyZ0YNkMUAepJG1inGjzTna/eWSPF4ZeJCJRs9/40oWdP7uit99uoqfRR0R08MkyeJ6+775HhpFOIm0YWqAaebjzG9v4Mzvk/pSnT2UnSeaiN0EXzdKxdXxWL2eo4fDuJxHzCpVibG+qrZbQ5w/VI00raw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In find_create_memory_tier(), if failed to register device, then we should release new_memtier from the tier list and put device instead of memtier. Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs") Signed-off-by: Tong Tiangen --- mm/memory-tiers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index c734658c6242..e593e56e530b 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty ret = device_register(&new_memtier->dev); if (ret) { - list_del(&memtier->list); - put_device(&memtier->dev); + list_del(&new_memtier->list); + put_device(&new_memtier->dev); return ERR_PTR(ret); } memtier = new_memtier;