From patchwork Mon Feb 6 06:33:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Ying" X-Patchwork-Id: 13129354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414E4C636D3 for ; Mon, 6 Feb 2023 06:33:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D513F6B007D; Mon, 6 Feb 2023 01:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D01426B007E; Mon, 6 Feb 2023 01:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC93F6B0080; Mon, 6 Feb 2023 01:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AEC476B007D for ; Mon, 6 Feb 2023 01:33:51 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 87B961C61EE for ; Mon, 6 Feb 2023 06:33:51 +0000 (UTC) X-FDA: 80435901462.16.6353180 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf11.hostedemail.com (Postfix) with ESMTP id 5616240009 for ; Mon, 6 Feb 2023 06:33:49 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="c/eRc4e5"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675665229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6zVVJXnpq/vW46SiufXNLdBJlTQFDfAZrTjpW/WPTas=; b=2mYaiNZR2/cP34qiGHyiuXbFF3PwUJw3z5hNNephSfy0nSOP3UKPwStg+6bydQIVzQDOcN QKKDRgzOJh/vX3NZhVMw10yClcX0v4r9lUMy4kwXhiaRB/BgND9iuTFDGH4gHAMhSBqm58 ij+lqdIQk2RMUGCGRJ8z7UjVpDnGbxU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="c/eRc4e5"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675665229; a=rsa-sha256; cv=none; b=OG1g1zZTxngl22J7kHkAksDIhmE/mSMjm+jU2Ojyz/WHp1ga0/j6GKNh5jBtVOxffHpiLk RGUOH4OiNaaL+lvWE2paNcH5yFjMQHu+l6eJnXtHA3KNGaKTjPOLI18iQqOJVHuwCF6J+3 HxnZ9WGTXfH3oiRNFimSsSNSxHWebnI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675665229; x=1707201229; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=G5ZfaUuXgSxehPG875BTf4HRHOPcGYUMTs8SwIYJqho=; b=c/eRc4e5U0Hp/1Rj7FSmCbHUEVuByAQufYHuCKuKcCqtvsN2uuTSS64D xt1FAiOdaQGOiLD67hceC/WBOzJJQdroOqpONukjLNxsq/QutPYhhZMuN ZCbiCBuzT04MKkcZk+rHZrKrjQQUOwfdGesy61sGKanLzxi9l9mbKn5tS K1dBeNcsCRzlPZKav+nD3ODXbb5vPAQ4fo2d5nnngK5hy6NLuYws8dNxP uzFlmsptSE4ESzMTyHT8EpgyM1pCBrRPsVkXA5I64MvNa1OlHQg7zezO/ ZdZ9UR9Kspst3M+VSxYRAfEmvRDI6zEXNPgDi48GvQRs+vdSjwEMZ9awE A==; X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="330432684" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="330432684" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 22:33:48 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10612"; a="659744706" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="659744706" Received: from baoyumen-mobl.ccr.corp.intel.com (HELO yhuang6-mobl2.smartont.net) ([10.255.30.227]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2023 22:33:43 -0800 From: Huang Ying To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Huang Ying , Baolin Wang , Zi Yan , Yang Shi , Oscar Salvador , Matthew Wilcox , Bharata B Rao , Alistair Popple , haoxin , Minchan Kim , Mike Kravetz , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [PATCH -v4 4/9] migrate_pages: split unmap_and_move() to _unmap() and _move() Date: Mon, 6 Feb 2023 14:33:08 +0800 Message-Id: <20230206063313.635011-5-ying.huang@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230206063313.635011-1-ying.huang@intel.com> References: <20230206063313.635011-1-ying.huang@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 5616240009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: g54nbwyhefffnaabmt4fg9fqu5xj4b1e X-HE-Tag: 1675665229-311703 X-HE-Meta: U2FsdGVkX18knrBZWX61sJSAv3+io8UV59cbFdwK1uUamWXDXxpWCN9dwdtsgMCiLtIiGsfupaVOGWCzcO7sAS9YPNRYywxntQQdoDUKIxjwW6l1Cvay+igO96HHWOQff8SHWddDaIMZh08IN4ZLUYMnK/mWt194vgHWHwWhtxFCdfl1tlKJzta3HcSSenHPcadNX/Q8lXLX2GYcBNPv7pdclKlnSvr9sdgBDByrXEhWHd/RBJRYhi6ET/TvvVqfh8lEZldUXhcRZ1EQJ57cddnFS0CrF4drfPXARBrqBxsFWHl3h+Tjv/9JzFKGs846TNBlWjXWfEfn+O3FHLP4TtFaWSv/HoW3p/DdWfmHOtoHFf9Ehxq6jnFybDwLv+opBf0ekC6THp/eL231IYRt2m6QASIpKfMzmiqWWre6z6y5g4DjtQ0EheLEJy5jqWT2DlKKpF+xMiR5PGvs+gWflZNaWyKU+xIddWs65BW6zmdoD/ECbjWavrcL9mIUtMpCV/eR0DSG2zreZybtxU/yFn864QXDok+5J3KRsNB2oVPwpCJBe5TxLLXiTt6JHFv0Z6+PHQoFYitxASSeK+af/TyE4avenwmPlif5SNqctN2WNLr9yMX+aTtoXhZXZhIE8o4ACUZkYoyXRzbKt24sXhQC1lBRrqueuImHE8XGPLmNTisK78DDcBK1fsQo2ekF4Hx5By08DNm29i8A8WyJ3MTWq86afqrt/X5lINxYBb/aQ7LjAepWKOlsyf4TsCavYnRgIAoQsUGdfA7r0jkHNFPqxcMEGN3cXNbjlXP4DcYXNoqfo2M9+7MeKrKFtZ+jfvUctUhBRy6d4RrtRXfnT71zuderCWSi4+VouIN5kB4C7Ia76tYcoAkhffqEHq1Y7gkrc1afKav2/cwSHB78ikv2jZkzGwKsbs0v4sLIXnu0b7fvgiEO3ATtkBsQT6LqiV9RFKuOdnHxZr5p6HB F5wcFeEl 0xv/hVr8p0kylaJHFOPVTB2/LmLqYjKIfIs15EiJMl25DSp4a+MRlvrerW4JSX0qPajOuV4p3rVZVim0UZxNMUdBd2dHjpuglttPjkavJ0zXDeVCnnNhOYd0FsSeTEkrjoxOeByCBJyGRbfXf7PVu3hpZOXwlPnJL4GKUoyzt0u/N6KjipjI2AhQcPs8fgYIlZpn4tU6kDze7an6adtUOSO0HILOqe9aHqjoyz7qk6JJ0nXyk3wO6ub57YZI8Gx2yo4U+ZgYLinWMdNLHtUIvMmobGxuhR7zH+Yq75OZtXPxS4aR/u5lSlHcapQzHKepRTlMhuWHsvOnG9yGQvTugitn8jR2kNl2mjgoOOz6WIMFhAJvG+r0XOLQqnXxdlk5zU5RqB8B0zl8tnoDlX5QBRjzesS5hl0BEjfsAe8YQxMcib4WPourWS80ejI9SdpfJj7TJ7OJeDzD3Bci6PSwi83X+07ogW83iPrtcFd2izvzY4tBqFLS8wSquCAX72D0EqX6YvWrWoE0/CiUslpzGU6sofjKM9nO+DunHlc4d0QBs0BH2RjyNgqC61WPVRG7vuWv2xnbkilj5oaQbi1/JAmogiIHB22tOEnSflC5OvtDrdZ+Wt/dvhm3qhgc7o+wunhnnIS7QJp8LuuECqnTndNJJ7GicRKuiuz98 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a preparation patch to batch the folio unmapping and moving. In this patch, unmap_and_move() is split to migrate_folio_unmap() and migrate_folio_move(). So, we can batch _unmap() and _move() in different loops later. To pass some information between unmap and move, the original unused dst->mapping and dst->private are used. Signed-off-by: "Huang, Ying" Reviewed-by: Baolin Wang Cc: Zi Yan Cc: Yang Shi Cc: Oscar Salvador Cc: Matthew Wilcox Cc: Bharata B Rao Cc: Alistair Popple Cc: haoxin Cc: Minchan Kim Cc: Mike Kravetz Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Xin Hao --- include/linux/migrate.h | 1 + mm/migrate.c | 170 ++++++++++++++++++++++++++++++---------- 2 files changed, 130 insertions(+), 41 deletions(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index 3ef77f52a4f0..7376074f2e1e 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -18,6 +18,7 @@ struct migration_target_control; * - zero on page migration success; */ #define MIGRATEPAGE_SUCCESS 0 +#define MIGRATEPAGE_UNMAP 1 /** * struct movable_operations - Driver page migration diff --git a/mm/migrate.c b/mm/migrate.c index 9a667039c34c..0428449149f4 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1009,11 +1009,53 @@ static int move_to_new_folio(struct folio *dst, struct folio *src, return rc; } -static int __unmap_and_move(struct folio *src, struct folio *dst, +/* + * To record some information during migration, we uses some unused + * fields (mapping and private) of struct folio of the newly allocated + * destination folio. This is safe because nobody is using them + * except us. + */ +static void __migrate_folio_record(struct folio *dst, + unsigned long page_was_mapped, + struct anon_vma *anon_vma) +{ + dst->mapping = (void *)anon_vma; + dst->private = (void *)page_was_mapped; +} + +static void __migrate_folio_extract(struct folio *dst, + int *page_was_mappedp, + struct anon_vma **anon_vmap) +{ + *anon_vmap = (void *)dst->mapping; + *page_was_mappedp = (unsigned long)dst->private; + dst->mapping = NULL; + dst->private = NULL; +} + +/* Cleanup src folio upon migration success */ +static void migrate_folio_done(struct folio *src, + enum migrate_reason reason) +{ + /* + * Compaction can migrate also non-LRU pages which are + * not accounted to NR_ISOLATED_*. They can be recognized + * as __PageMovable + */ + if (likely(!__folio_test_movable(src))) + mod_node_page_state(folio_pgdat(src), NR_ISOLATED_ANON + + folio_is_file_lru(src), -folio_nr_pages(src)); + + if (reason != MR_MEMORY_FAILURE) + /* We release the page in page_handle_poison. */ + folio_put(src); +} + +static int __migrate_folio_unmap(struct folio *src, struct folio *dst, int force, enum migrate_mode mode) { int rc = -EAGAIN; - bool page_was_mapped = false; + int page_was_mapped = 0; struct anon_vma *anon_vma = NULL; bool is_lru = !__PageMovable(&src->page); @@ -1089,8 +1131,8 @@ static int __unmap_and_move(struct folio *src, struct folio *dst, goto out_unlock; if (unlikely(!is_lru)) { - rc = move_to_new_folio(dst, src, mode); - goto out_unlock_both; + __migrate_folio_record(dst, page_was_mapped, anon_vma); + return MIGRATEPAGE_UNMAP; } /* @@ -1115,11 +1157,42 @@ static int __unmap_and_move(struct folio *src, struct folio *dst, VM_BUG_ON_FOLIO(folio_test_anon(src) && !folio_test_ksm(src) && !anon_vma, src); try_to_migrate(src, 0); - page_was_mapped = true; + page_was_mapped = 1; } - if (!folio_mapped(src)) - rc = move_to_new_folio(dst, src, mode); + if (!folio_mapped(src)) { + __migrate_folio_record(dst, page_was_mapped, anon_vma); + return MIGRATEPAGE_UNMAP; + } + + if (page_was_mapped) + remove_migration_ptes(src, src, false); + +out_unlock_both: + folio_unlock(dst); +out_unlock: + /* Drop an anon_vma reference if we took one */ + if (anon_vma) + put_anon_vma(anon_vma); + folio_unlock(src); +out: + + return rc; +} + +static int __migrate_folio_move(struct folio *src, struct folio *dst, + enum migrate_mode mode) +{ + int rc; + int page_was_mapped = 0; + struct anon_vma *anon_vma = NULL; + bool is_lru = !__PageMovable(&src->page); + + __migrate_folio_extract(dst, &page_was_mapped, &anon_vma); + + rc = move_to_new_folio(dst, src, mode); + if (unlikely(!is_lru)) + goto out_unlock_both; /* * When successful, push dst to LRU immediately: so that if it @@ -1142,12 +1215,10 @@ static int __unmap_and_move(struct folio *src, struct folio *dst, out_unlock_both: folio_unlock(dst); -out_unlock: /* Drop an anon_vma reference if we took one */ if (anon_vma) put_anon_vma(anon_vma); folio_unlock(src); -out: /* * If migration is successful, decrease refcount of dst, * which will not free the page because new page owner increased @@ -1159,19 +1230,15 @@ static int __unmap_and_move(struct folio *src, struct folio *dst, return rc; } -/* - * Obtain the lock on folio, remove all ptes and migrate the folio - * to the newly allocated folio in dst. - */ -static int unmap_and_move(new_page_t get_new_page, - free_page_t put_new_page, - unsigned long private, struct folio *src, - int force, enum migrate_mode mode, - enum migrate_reason reason, - struct list_head *ret) +/* Obtain the lock on page, remove all ptes. */ +static int migrate_folio_unmap(new_page_t get_new_page, free_page_t put_new_page, + unsigned long private, struct folio *src, + struct folio **dstp, int force, + enum migrate_mode mode, enum migrate_reason reason, + struct list_head *ret) { struct folio *dst; - int rc = MIGRATEPAGE_SUCCESS; + int rc = MIGRATEPAGE_UNMAP; struct page *newpage = NULL; if (!thp_migration_supported() && folio_test_transhuge(src)) @@ -1182,20 +1249,50 @@ static int unmap_and_move(new_page_t get_new_page, folio_clear_active(src); folio_clear_unevictable(src); /* free_pages_prepare() will clear PG_isolated. */ - goto out; + list_del(&src->lru); + migrate_folio_done(src, reason); + return MIGRATEPAGE_SUCCESS; } newpage = get_new_page(&src->page, private); if (!newpage) return -ENOMEM; dst = page_folio(newpage); + *dstp = dst; dst->private = NULL; - rc = __unmap_and_move(src, dst, force, mode); + rc = __migrate_folio_unmap(src, dst, force, mode); + if (rc == MIGRATEPAGE_UNMAP) + return rc; + + /* + * A page that has not been migrated will have kept its + * references and be restored. + */ + /* restore the folio to right list. */ + if (rc != -EAGAIN) + list_move_tail(&src->lru, ret); + + if (put_new_page) + put_new_page(&dst->page, private); + else + folio_put(dst); + + return rc; +} + +/* Migrate the folio to the newly allocated folio in dst. */ +static int migrate_folio_move(free_page_t put_new_page, unsigned long private, + struct folio *src, struct folio *dst, + enum migrate_mode mode, enum migrate_reason reason, + struct list_head *ret) +{ + int rc; + + rc = __migrate_folio_move(src, dst, mode); if (rc == MIGRATEPAGE_SUCCESS) set_page_owner_migrate_reason(&dst->page, reason); -out: if (rc != -EAGAIN) { /* * A folio that has been migrated has all references @@ -1211,20 +1308,7 @@ static int unmap_and_move(new_page_t get_new_page, * we want to retry. */ if (rc == MIGRATEPAGE_SUCCESS) { - /* - * Compaction can migrate also non-LRU folios which are - * not accounted to NR_ISOLATED_*. They can be recognized - * as __folio_test_movable - */ - if (likely(!__folio_test_movable(src))) - mod_node_page_state(folio_pgdat(src), NR_ISOLATED_ANON + - folio_is_file_lru(src), -folio_nr_pages(src)); - - if (reason != MR_MEMORY_FAILURE) - /* - * We release the folio in page_handle_poison. - */ - folio_put(src); + migrate_folio_done(src, reason); } else { if (rc != -EAGAIN) list_add_tail(&src->lru, ret); @@ -1516,7 +1600,7 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page, int pass = 0; bool is_large = false; bool is_thp = false; - struct folio *folio, *folio2; + struct folio *folio, *folio2, *dst = NULL; int rc, nr_pages; LIST_HEAD(split_folios); bool nosplit = (reason == MR_NUMA_MISPLACED); @@ -1543,9 +1627,13 @@ static int migrate_pages_batch(struct list_head *from, new_page_t get_new_page, cond_resched(); - rc = unmap_and_move(get_new_page, put_new_page, - private, folio, pass > 2, mode, - reason, ret_folios); + rc = migrate_folio_unmap(get_new_page, put_new_page, private, + folio, &dst, pass > 2, mode, + reason, ret_folios); + if (rc == MIGRATEPAGE_UNMAP) + rc = migrate_folio_move(put_new_page, private, + folio, dst, mode, + reason, ret_folios); /* * The rules are: * Success: folio will be freed