Message ID | 20230209123206.3548-2-jack@suse.cz (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E42C636D3 for <linux-mm@archiver.kernel.org>; Thu, 9 Feb 2023 12:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7FFB6B0072; Thu, 9 Feb 2023 07:32:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D091F6B0078; Thu, 9 Feb 2023 07:32:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E006B0074; Thu, 9 Feb 2023 07:32:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A148A6B0071 for <linux-mm@kvack.org>; Thu, 9 Feb 2023 07:32:12 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73159160E56 for <linux-mm@kvack.org>; Thu, 9 Feb 2023 12:32:12 +0000 (UTC) X-FDA: 80447690904.25.A8E3DF6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 56BD518000B for <linux-mm@kvack.org>; Thu, 9 Feb 2023 12:32:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pcl1MoPj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PDjlgzwz; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675945930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y67/jfZcaQ1t6XqJfCmKWgTl2+zDLO5vmdBow0/F1TM=; b=UwUhEtYYnpWnT9HhPZh1Sc3ERzR5gEYAnwl1ii363VCPlf864tWeXovxLXBgjd9Djj3aHW yppcHvDvAduem3f1etr6mLcl0AhUZQHo0mCFoIgUazNmuqdB4HqnhKrYvEdrD9cMIq8h1e y3AJbSc+2oIPfNLqje9yiycKKYvY5B0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pcl1MoPj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PDjlgzwz; spf=pass (imf16.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675945930; a=rsa-sha256; cv=none; b=yhchThm9tUAPGFaaWOmoFadDaz/k6+rCw9rqtUi2OSrzwPqMitPfM3QtC5hWC+crQVyXKc 9YgnlWW6t99OpU6nh4FmHFQ7GxKRQnq/2272p8xPkcyVDzEhAbasz9rcZ1qlJlwy5ctqH1 gZNlB80/yksCxHabHzfmCqEoe1HkzfE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC86C37476; Thu, 9 Feb 2023 12:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675945928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y67/jfZcaQ1t6XqJfCmKWgTl2+zDLO5vmdBow0/F1TM=; b=pcl1MoPjJrqtKQ7VmePmRZ7GSAV/t0ZTMCVMmqRZCJ85r+TM8FrAlpGX/+nAs3me2AXnYb +oke6O/NQry6pTkbUjFbiVswTcGKk9ZQFYdh4OHfafnnrpGnZ1pej1bEf6SbTjy7BfGODI svinGNwGJ7TU+ao9NGN2AirHgWvY8zk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675945928; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y67/jfZcaQ1t6XqJfCmKWgTl2+zDLO5vmdBow0/F1TM=; b=PDjlgzwzWa9eJisya0ohOe7XJZPKSBlvylyTL+RO3mNo9e0ewsIVxbK1yEk9GtbxNYZrsO 2/GoNszJEVhzIVDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF77E138E4; Thu, 9 Feb 2023 12:32:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YAcqKsjn5GO4WQAAMHmgww (envelope-from <jack@suse.cz>); Thu, 09 Feb 2023 12:32:08 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 86927A06E2; Thu, 9 Feb 2023 13:32:06 +0100 (CET) From: Jan Kara <jack@suse.cz> To: <linux-fsdevel@vger.kernel.org> Cc: <linux-block@vger.kernel.org>, <linux-mm@kvack.org>, John Hubbard <jhubbard@nvidia.com>, David Howells <dhowells@redhat.com>, David Hildenbrand <david@redhat.com>, Jan Kara <jack@suse.cz> Subject: [PATCH 2/5] ext4: Drop workaround for mm reclaiming fs private page data Date: Thu, 9 Feb 2023 13:31:54 +0100 Message-Id: <20230209123206.3548-2-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230209121046.25360-1-jack@suse.cz> References: <20230209121046.25360-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1260; i=jack@suse.cz; h=from:subject; bh=h6csu2b8ZDggoYb6LWh5Isk6fkPmNiQSaSJRB+AFypk=; b=owGbwMvMwME4Z+4qdvsUh5uMp9WSGJKfPN911EVb7Lxqrw/bhdnTl4YmLDJx6uvdmPG5OEUtKpjn 1MIbnYzGLAyMHAyyYoosqyMval+bZ9S1NVRDBmYQKxPIFAYuTgGYyF9z9p+My7lNKjr+msd0J2bUzV h/9LhvRJ1jtImdb/yynSvc5vnoCr18rjdflL2vn/Mp7+Udld06EQ1v1+9nL6zZ/Mxgf5/4idOvs24r 2yrlKHs/PvMyhlf74w9l2b73W8L8Pl3s+G+y886HMN7rqfNkjD+ltn/LWf26t07ENUBt760Vjqq2Md dqbRhe62mpCqnuqrvqIW6ukLn9psn9tJ2/eARvBzQ6TmvRtNhlys2eIdOxxXNKsQxH8WL5T31OUS2L PivPPbkmnj/N4vtW9uhH7QoFz241XCjfOO3l34TDv0Qi5na15usteDHlky9XVoy80GlfqUeMLH0f/B QC22VLkxRdNq4oPX29ybHkxLY5AA== X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 56BD518000B X-Stat-Signature: 9ch7pe46dhdhschho93w8tfsw19gz3mt X-Rspam-User: X-HE-Tag: 1675945930-854119 X-HE-Meta: U2FsdGVkX19BF0M+xvZBFLRsnPYBKyinDsx91USlr7X3ez1A/fSqB0ysEn3Tneb2JXsU3VV9cAfz+zW40izSWokZswAvRoe4VWyIXkZVvs8v1+xBsynOhouSOBG7oxEJdyj40RUI1W84zYAhwK+zgv5H7RinDzK/x1qX8vGEUkdMVyELKrO0LpHuATHmQobwFa56JOj3Ba2S8aUbLj57bOWwcxyk+IdwqNR56mpZPVpuEw/lg6B1IGweYwkIgUzEWrd9IXbKH3iPZAyE/pE3B8UU+JJTpiSR62KhbfcjerYVrceuDUcgLmxkYyu1KDmdcnMCviZuCUuZkwzeQ5G8gSc7aNJtZsH8lUhHTbxhsvdRYouqAsEkPAjgOan0fc5qhVq1JdzOtBuLOAKiAwz/H98OymoCRgYHbVE7PfBCJmmOicQeVPMAubor+bhBYxL74GRj3mFwWXcJs/j5du1e7AcGM9oy/ouegzizIa9qsfEClzay2CmNbEyMEeEs/vKiZbRkhfhceaPaCC3Rgl3W0Cm6H32f3bR7mZJ6TYVltStbsCQhzNmjJBLgX2caNX1nAfy3iaEGjt0SdZiYDNbhOarmuE3pYWsBbZuBiJ5uDUK5Mvh5DE9ppW75VpAWoKL4amhlluCv8VioHa+S2RfwjMgoe2akixk6xorH5JV7rGTNx/agWr2sLrcVGcCm2HUxK26lBjUWdvsP1SIns9v/6To/gzhPOpRHq0nBY9hKfnVp+Zl0avcJCDQhHFv+19hM3Dn3+sGEJAjnOq4TlGtcYztgkEhddvIjMxKgUolk2OGxqgzBRm8wGBLmHswNM4mztDJPfn9E8q6hWpOIW7oNmsAvwECFOm0NrLL3qJPXbWxuoR7JKS9TvvM2drMjYobbqktzdHZYJNTnVo3Vr4akwpduQ9a1uWJi1fBhK0xXHad1utE50hFed3dGLy7wiyN9C++eri+N3v7MthEuteH C5Ua1+Go 7i3SYd/l5bqUicLL69CC+JNODnO3nv8mmJSgBb6oKEAYy7R6R11F8+ATe1wfrUw3sYR6/oGkq67jLe6aBouiIQS89mlNiMIBsVieDulvKspaQEvC278q+z/p518qfUm9yxRQtDRL1YwcICygpgjYtkL3IjXc1xA/MtFn7qjFUUtPfgR+TvJfnykkeuTaqFniUu5zoRCHtMNaeqIrCt9IrlxZMQePB8FuVC6aOKBNey7S09o1CGvqDw41WUOmXhsJz4ZSJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
Writeback handling of pinned pages
|
expand
|
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 9d9f414f99fe..46078651ce32 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -2657,22 +2657,6 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd) wait_on_page_writeback(page); BUG_ON(PageWriteback(page)); - /* - * Should never happen but for buggy code in - * other subsystems that call - * set_page_dirty() without properly warning - * the file system first. See [1] for more - * information. - * - * [1] https://lore.kernel.org/linux-mm/20180103100430.GE4911@quack2.suse.cz - */ - if (!page_has_buffers(page)) { - ext4_warning_inode(mpd->inode, "page %lu does not have buffers attached", page->index); - ClearPageDirty(page); - unlock_page(page); - continue; - } - if (mpd->map.m_len == 0) mpd->first_page = page->index; mpd->next_page = page->index + 1;
Drop workaround in ext4 writeback code to handle a situation when MM reclaims fs-private page data from a page that is (or becomes) dirty. After the previous commit this should not happen anymore. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ext4/inode.c | 16 ---------------- 1 file changed, 16 deletions(-)