From patchwork Thu Feb 9 15:01:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 13134757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EEDC61DA4 for ; Thu, 9 Feb 2023 15:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 862B76B007B; Thu, 9 Feb 2023 10:33:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 555DB6B007E; Thu, 9 Feb 2023 10:33:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA02B6B007E; Thu, 9 Feb 2023 10:33:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 85E2B6B0074 for ; Thu, 9 Feb 2023 10:33:24 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A63216095F for ; Thu, 9 Feb 2023 15:33:24 +0000 (UTC) X-FDA: 80448147528.17.EA44765 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 74B5B20025 for ; Thu, 9 Feb 2023 15:33:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QivdhWtA; spf=pass (imf03.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675956802; a=rsa-sha256; cv=none; b=MUuTZIs6BsFRBaRhUnBdlbmP5t5Pk9DvEsB65DY/sFEfUQi/nGVz47YOku7i2qBvRvFYsR yVtW0Ct4KdpKuhOHui28SNeFCrpQuanKYO/ynOfHUVB+jIGXcmhKVecEJ2CmHnUsSrq7DH UjHhMQ5ZgCiWnI3OGKoof4TbUslVah0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QivdhWtA; spf=pass (imf03.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675956802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=7C1hmy1E7+0MQkK/mZzmUZ/gKoFVIBd7d2YZY/3tmcQ=; b=m1VqNzAYXe45NVPDiyuTDxwntmEB+jnMDBfCGLtrJFepvarTGiwI9cIC9tXuTPprkb+y0m 8/4C7TG6vwT7sSbz6ni82VSPGxzBb5poUpB6vXnclCFwFhgU+lmn0mPopei2eO1citv2Y7 MpT5Y/mRMOa+tauylYvSQQ1RpQM1nCM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675956801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=7C1hmy1E7+0MQkK/mZzmUZ/gKoFVIBd7d2YZY/3tmcQ=; b=QivdhWtAjo+dpj9QfLMVel84Y3Y9CGg1CN97RKTOhkoDU8AK1uQQCCdJ55iooAtZIhKwFU GObu7ZAiQ4NCUxUHqZGbZyL29yOaMLfv0SuNSSB1LxvjCnSDIg1Kl0rfctevYXOFLMe3k7 /Ox8NL/qypZ78WCauU2hT0+kbsRlm4Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-532-6n2BmqIWMciXOAiOSVn0Kg-1; Thu, 09 Feb 2023 10:33:17 -0500 X-MC-Unique: 6n2BmqIWMciXOAiOSVn0Kg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0E6E802C1D; Thu, 9 Feb 2023 15:33:14 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-3.gru2.redhat.com [10.97.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DF9A2026D4B; Thu, 9 Feb 2023 15:33:14 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 6390E403CC06B; Thu, 9 Feb 2023 12:32:51 -0300 (-03) Message-ID: <20230209153204.656996515@redhat.com> User-Agent: quilt/0.67 Date: Thu, 09 Feb 2023 12:01:51 -0300 From: Marcelo Tosatti To: Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Marcelo Tosatti Subject: [PATCH v2 01/11] mm/vmstat: remove remote node draining References: <20230209150150.380060673@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspam-User: X-Rspamd-Queue-Id: 74B5B20025 X-Rspamd-Server: rspam01 X-Stat-Signature: 5hhn6m9s8sidasgtrh5ntoodwd6iyzpa X-HE-Tag: 1675956802-643740 X-HE-Meta: U2FsdGVkX1+wOYU7p25dNF9JvMLhynJSoZkNXTRsu4TusRNmWggVO8HvtXGYPSuExtqDNjDEVH7bvc1yUrvNSQk0NWY450XsVHV0I4NAbugpc3X/fsJWp+nXEY45U4NHEtLYgetcXa59atHntBt5uLyzXZ3DvnJCRveqi8xYEEdYQy/bUE3BOyi/IUMpce8eAtmGVaOrDfOMij9MOcLUCH8Y8YNJnFRrfA9+0q6dbeCUTdKeHtYjZX7e97oQ+n1oZI448dU1nycGumBJRxnTfEKfV/XcGRiBj0Hcr6WP5plD+JFvOjqYXgRS/8+0oid0j9GoVOSlc+C/26lZ3G3JKl6i8yHWiJqsKaw2dS0QqRVGXyNYP0oFBz6BMM+T4ArqvS7tD9T5ZukiyVMqUPoY3umpxVc+tbyTioeYSpHfr9hUznvPBD+eqaVvCvZYStP7J2tF7F0d2ZJOn1bCvP+0PPqlCoLFUpUxMlr0lBUtqLzmOkSkzVVr9iXCz1PoenpFSA9wI80GwqsfAXuj++ko4x7yIDDb9VmQMpjE92AqyfQRSqEw4LCSsQqs72BYATKGZtuLg1syOyh3uGrckNl7miKDUTph9Lt2yF6DlT/hVl8vgDopIzSphHTaK6r7Irz5VEgdjDPUzym6xfie1YtM7COFRn2HavmYZxqPu3gmzIibofMEydOq08ayHGKZKwMlOvtqZ95PktrTs4Tukwf6yJg6ybyCNbJXn3FsHFbPhM+71CVz/VrRMAusNhp0wmOWdimBRuoouXhpA5cSHLm9wRias6neazUWygTq2El63Zg3VV3bMlhtyTNYI2S4cRPhfVO2oUE5vjho+4i7cg5Se6cUGH9NvTuF7cGtwvj99p0vqggUMezuj01tB/jP8Q28uLVAwNihXJ3/0vaOxXMQzyQ2hOOKldp2DnJtfggBb3yMDIdJBkRZLfd9WBuclk0ze3Zd1c2mPQdafDyY8kF g7uDkafu vFyRmaSvvyi6sePnz/B9uGAfvQCpO09TiNCg5R8f6jaAgpftiVY4ETKxFDFMl4bX0BzKzV86WHsJzO3DDSeut+VTpvLle8bdDNcnQRBgctKHJVol0vqkNv05wYGQ8AqJn9C6nqII9JUMm8ODhuR0nEro63J1ITFLtq+Wev+GQciIRj5c76jJeHK9NssDYqK0Ow9sQSDlZTaSZ0+DwmK1/V/lureuue4p5RgTg6TY4qg4GSP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Draining of pages from the local pcp for a remote zone was necessary since: "Note that remote node draining is a somewhat esoteric feature that is required on large NUMA systems because otherwise significant portions of system memory can become trapped in pcp queues. The number of pcp is determined by the number of processors and nodes in a system. A system with 4 processors and 2 nodes has 8 pcps which is okay. But a system with 1024 processors and 512 nodes has 512k pcps with a high potential for large amount of memory being caught in them." Since commit 443c2accd1b6679a1320167f8f56eed6536b806e ("mm/page_alloc: remotely drain per-cpu lists"), drain_all_pages() is able to remotely free those pages when necessary. Signed-off-by: Marcelo Tosatti Acked-by: David Hildenbrand Index: linux-vmstat-remote/include/linux/mmzone.h =================================================================== --- linux-vmstat-remote.orig/include/linux/mmzone.h +++ linux-vmstat-remote/include/linux/mmzone.h @@ -577,9 +577,6 @@ struct per_cpu_pages { int high; /* high watermark, emptying needed */ int batch; /* chunk size for buddy add/remove */ short free_factor; /* batch scaling factor during free */ -#ifdef CONFIG_NUMA - short expire; /* When 0, remote pagesets are drained */ -#endif /* Lists of pages, one per migrate type stored on the pcp-lists */ struct list_head lists[NR_PCP_LISTS]; Index: linux-vmstat-remote/mm/vmstat.c =================================================================== --- linux-vmstat-remote.orig/mm/vmstat.c +++ linux-vmstat-remote/mm/vmstat.c @@ -803,7 +803,7 @@ static int fold_diff(int *zone_diff, int * * The function returns the number of global counters updated. */ -static int refresh_cpu_vm_stats(bool do_pagesets) +static int refresh_cpu_vm_stats(void) { struct pglist_data *pgdat; struct zone *zone; @@ -814,9 +814,6 @@ static int refresh_cpu_vm_stats(bool do_ for_each_populated_zone(zone) { struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; -#ifdef CONFIG_NUMA - struct per_cpu_pages __percpu *pcp = zone->per_cpu_pageset; -#endif for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) { int v; @@ -826,44 +823,8 @@ static int refresh_cpu_vm_stats(bool do_ atomic_long_add(v, &zone->vm_stat[i]); global_zone_diff[i] += v; -#ifdef CONFIG_NUMA - /* 3 seconds idle till flush */ - __this_cpu_write(pcp->expire, 3); -#endif } } -#ifdef CONFIG_NUMA - - if (do_pagesets) { - cond_resched(); - /* - * Deal with draining the remote pageset of this - * processor - * - * Check if there are pages remaining in this pageset - * if not then there is nothing to expire. - */ - if (!__this_cpu_read(pcp->expire) || - !__this_cpu_read(pcp->count)) - continue; - - /* - * We never drain zones local to this processor. - */ - if (zone_to_nid(zone) == numa_node_id()) { - __this_cpu_write(pcp->expire, 0); - continue; - } - - if (__this_cpu_dec_return(pcp->expire)) - continue; - - if (__this_cpu_read(pcp->count)) { - drain_zone_pages(zone, this_cpu_ptr(pcp)); - changes++; - } - } -#endif } for_each_online_pgdat(pgdat) { @@ -1864,7 +1825,7 @@ int sysctl_stat_interval __read_mostly = #ifdef CONFIG_PROC_FS static void refresh_vm_stats(struct work_struct *work) { - refresh_cpu_vm_stats(true); + refresh_cpu_vm_stats(); } int vmstat_refresh(struct ctl_table *table, int write, @@ -1928,7 +1889,7 @@ int vmstat_refresh(struct ctl_table *tab static void vmstat_update(struct work_struct *w) { - if (refresh_cpu_vm_stats(true)) { + if (refresh_cpu_vm_stats()) { /* * Counters were updated so we expect more updates * to occur in the future. Keep on running the @@ -1991,7 +1952,7 @@ void quiet_vmstat(void) * it would be too expensive from this path. * vmstat_shepherd will take care about that for us. */ - refresh_cpu_vm_stats(false); + refresh_cpu_vm_stats(); } /*