Message ID | 20230216051750.3125598-15-surenb@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFF4C636CC for <linux-mm@archiver.kernel.org>; Thu, 16 Feb 2023 05:18:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 390916B0092; Thu, 16 Feb 2023 00:18:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F0F46B0093; Thu, 16 Feb 2023 00:18:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16B1C6B0095; Thu, 16 Feb 2023 00:18:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EFBE46B0092 for <linux-mm@kvack.org>; Thu, 16 Feb 2023 00:18:31 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C182DAABF5 for <linux-mm@kvack.org>; Thu, 16 Feb 2023 05:18:31 +0000 (UTC) X-FDA: 80471999622.17.5559685 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf04.hostedemail.com (Postfix) with ESMTP id 0B11140006 for <linux-mm@kvack.org>; Thu, 16 Feb 2023 05:18:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Aww5hQNu; spf=pass (imf04.hostedemail.com: domain of 3pbztYwYKCPouwtgpdiqqing.eqonkpwz-oomxcem.qti@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3pbztYwYKCPouwtgpdiqqing.eqonkpwz-oomxcem.qti@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676524710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pCPLSRzUXQbjlFnRzNKKqjCLNtpc7ieGcBzd48Gb76w=; b=oyKk9ZqBc3Z26ol/DduVCOj5LN/SfoJHwiK9d5TTN3MjeNOVjRoC4K+NIsj+bZWguxJeoW ehr+BJFPralYXYncxC7D9W40TIFFQ1dAacnuwL/NAWhfzKrHGebLTYx2Uli52Fr79Uyvk9 3JgUq8aVYxGq6G98r4SI1vprvGW2g/Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Aww5hQNu; spf=pass (imf04.hostedemail.com: domain of 3pbztYwYKCPouwtgpdiqqing.eqonkpwz-oomxcem.qti@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3pbztYwYKCPouwtgpdiqqing.eqonkpwz-oomxcem.qti@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676524710; a=rsa-sha256; cv=none; b=INLtCSACjZ1MKOImnwjY0D7vMEL6aLK65MmavSCC4KdmzTYzMXzxirCcKezv2cjWGkCmMa q9YB3jRzmlW2wQfrUwzMC83DySCp4n9jCP+uLOZLWpxXyGnk744JjWfGuWT0sTUYnRA0DQ noHGHubIvt7sIZKi0K17aDxWFV8JLXo= Received: by mail-yb1-f201.google.com with SMTP id a1-20020a258701000000b008e1de4c1e7dso847927ybl.17 for <linux-mm@kvack.org>; Wed, 15 Feb 2023 21:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pCPLSRzUXQbjlFnRzNKKqjCLNtpc7ieGcBzd48Gb76w=; b=Aww5hQNuikXrQshFEtykppDfMBP38yEIiv8YZeHijhJepfYOC8bhl72PA7W7euJsgq UTdE3Yop6yuQ+QJ/imxEBpOD963eWsY1ljkA0jBaqGGg7cF+cENyfejTL2VbGXvtI8Gp zk9pQRaFettmR6L6WtIha8F6CvO6a31a83bm3SVswwIqM5PcX+z7DGQBjncH/5EAGpUc AT/XTvZe03bL8P4vyUJmA5jKJVVP1mrUYpMWnBW8gSUZQLx6c9BBl7Qtd+VfpJh9LBNJ HXZBHaakiRojDQMlDwmDxwqFzGyn5/4IdZKihfypYjTTs63kUZWxAGQtxOSq8MgWRU/t uPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pCPLSRzUXQbjlFnRzNKKqjCLNtpc7ieGcBzd48Gb76w=; b=A0961sFvxiATHdCxTp4CoYuiJCWhXWLtHDCZ5gkhuDkorPriSeyh2kyVKULZdx/z8T 1WOhKIX4qeS1afQ3bQndsKnDgOpRJr+oGhealJnAs1tDWHeHPyrmdzTZYBsbiMePGCQC d4Zt8F3xFcpSh4fKQVj70x8hipjm11dltVZzhPtHbkFBlze06cUZPM8RNB0DqfeuKf+/ L0zGjuyutWJXWTVFy6dPWS7sMNm3nSNJof3LuL0RYEtgGJcz8difZ0sbv1tcIWsRmlFm d3esooqPyHjNcU+oaY+TDaFuTr2xrW+PCVmtl21b1SiiflSGI72PALOA3IRBfnOTJ2Os Z6FQ== X-Gm-Message-State: AO0yUKWlM9ihThOD82I396LhmMBzRDui0BoJIJa9/S87zZF4m9yIkdAe mHdM2aRm9LqmDqb4KfR+sxM3rgSxbfg= X-Google-Smtp-Source: AK7set+U14wrD6Ap1lad6EVJBTJXnEdfFV5kP7qrWMf6wQhZaMdydVfue60wPwI1XeNtgIFp8aY/q1HqCcY= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a0d:d5c6:0:b0:500:e6a3:a141 with SMTP id x189-20020a0dd5c6000000b00500e6a3a141mr575676ywd.470.1676524709201; Wed, 15 Feb 2023 21:18:29 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:29 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-15-surenb@google.com> Subject: [PATCH v3 14/35] mm/mmap: move VMA locking before vma_adjust_trans_huge call From: Suren Baghdasaryan <surenb@google.com> To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Suren Baghdasaryan <surenb@google.com> Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0B11140006 X-Stat-Signature: 9kdig5ju8ibkaac5budujdkarjf87b5h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676524709-542336 X-HE-Meta: U2FsdGVkX19hR+M/bQfvALyatpNxeVmlZBisswt4n7KdsjjzF8NhvVQ57a9EEcieco10hlJILp5AvzCWqAhYH7WZlpc+LuvmWaijuyBhDWh3R4CM1AH+NVR0MW92SsP+hg9xz4HKGRLbwzVeK9QQfvdFgv7q7Q/042Kqf7TIsi/An70BG90CVPAcW4FqIPNNIH0tDif7lfHUbEqZXsqUCkK0QVzRkfINI9lsKbvR260gyQ47Y5Wr8dlcX0HsUrfzvHe9z78n0hoeyt1P8SLfNd773Ux8Rw6waC3oLE+WifYu31ybdYGYABw1R3eWVtbiow1gCdDnkaza0dJRTZbCUxOCkvbykokjoQOGYHJ3GSZpBqgFRa4XNr0I7cn9YhIYvRaFV+A1VfoQZyy5Qh/PU0BrWZuANCc+07wp9QEC60P7K0JxqAJP6h+teGCKtBYc4L1MRaRFXoFeVcUVkaDlqGdyK5BTHbBH0a8pp1ZhY6vKOJNjqp5TelAo+sBjtD+M7GVWZwcvrGDzLYet7FqDdpgIrDG2rgBJbWuKf3CFg177BukSYaEPCRdIYkNyN/PVktAXCtJq/kUM3ziF+RlUaMHAECb6JJ4KTs0mTzVAwzNPTlL9/F6HAzu+IFMdAQytsGO4OHzkRWHY/DxjGg+rZcKxlYRQmPGIlzCu7pMdjBRF1w7JJsz5f5GMIblMbjcQkXRKI2pKdaVWKWGI/3sYGDqbHmt843KumKgjMBSgzYdRZ9LyhabRIE4urHBu1mipDIGPpn/za3xXgiyDn4+eq2jq9/2VrSrU3hRNMoYI5P3Bluikll9dpQwOFLNgkn0WR/9vimCtEbsElbDn0nhA1LJ1knAHLUVAx7QDZA3sj22FkINRhXp+p9uqyz4TgNEfv/58uawgTU4StSiIUVBTZpKtVVf08cb1/8ESyvFW4oSnBQt+bETOe5EncMfxLRLEkBtMB/3ie7M3m7T2LlA QMdLkJlc iWpyIhT7j45LtcKxCandomSKGIxe+EIww8jcLhT0XRTHF7IOwxqs5az90jFjpYanURWx3fK+AumieWQslTpiAxi2DUKlWPCPkRrmh6J0E+3UXAg8lYPAcBzhRGTmUa2ocnbmkfbybZpc90FRkwfELiT4dJBxv7Npe1DS2g+MnUvKpR2D85tTO0Q6tagT6RgHl6kqVyUPNzbkGI1CMXC6BWV182n4aPLWStarWsepf8wEN9n4Fac6EELU+lP5JxleVqiTndaW84pgfNTOY6iPOQbXQxlO6r3MzJVbYhvsS5un1UeoV7/Hbv/Eq64g4PLcSjRPA6SdV3xBfsuS8hk+yiakrIRPPkSOuYnXmoxnH34bK0sBBMmRJSMDjbcukpj3IwFOIpT8oTSFUplicMcocyGN/eDRSKLjto68n9ZrMmOHTASPDxhjsTKzg2eS9yimgIi3eqUkMPKT4s3z6m29Nho6RX0WrBobJIa6QpdnvmvC+RVBubK8CW8VAzQJt7rVXr81yncOuGK2rhMLwDWhwfnjgLqRaJiQbmJQGdQxohehBI5A1mGv1/Qs9YgYG6NR3NouhlCO7J2N5jto= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
Per-VMA locks
|
expand
|
diff --git a/mm/mmap.c b/mm/mmap.c index 06c0f6686de8..c5f2ddf17b87 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2910,11 +2910,12 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, if (vma_iter_prealloc(vmi)) goto unacct_fail; + /* Set flags first to implicitly lock the VMA before updates */ + vm_flags_set(vma, VM_SOFTDIRTY); vma_adjust_trans_huge(vma, vma->vm_start, addr + len, 0); init_vma_prep(&vp, vma); vma_prepare(&vp); vma->vm_end = addr + len; - vm_flags_set(vma, VM_SOFTDIRTY); vma_iter_store(vmi, vma); vma_complete(&vp, vmi, mm);
vma_adjust_trans_huge() modifies the VMA and such modifications should be done after VMA is marked as being written. Therefore move VMA flag modifications before vma_adjust_trans_huge() so that VMA is marked before all these modifications. Signed-off-by: Suren Baghdasaryan <surenb@google.com> --- mm/mmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)