From patchwork Thu Feb 16 05:17:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13142514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53EE5C636D7 for ; Thu, 16 Feb 2023 05:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E15D16B009C; Thu, 16 Feb 2023 00:18:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA1116B009E; Thu, 16 Feb 2023 00:18:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18B76B009D; Thu, 16 Feb 2023 00:18:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A7A026B009B for ; Thu, 16 Feb 2023 00:18:48 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 82FDF141007 for ; Thu, 16 Feb 2023 05:18:48 +0000 (UTC) X-FDA: 80472000336.26.65EBBF9 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf07.hostedemail.com (Postfix) with ESMTP id BA39B40009 for ; Thu, 16 Feb 2023 05:18:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Hd3NZlon; spf=pass (imf07.hostedemail.com: domain of 3tbztYwYKCAw463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3tbztYwYKCAw463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676524726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zeEKIs6RouZ3NeHI7ZJ8m5Jmv1yLdTyFBRJo2pt5tCE=; b=ob6xidXd+WxxnR2HLVpcFdquFX65vZgiE2hayDhdQPiagrUzT6hqJvH+LuQ46LGNrpoCKX SD1XJzTBv+S0O3y3BHrLM56NqwsT+CXlrLZL5MV32p2t0YkavLYLMsnTzVv+CTgk/TcOK4 w3TG5xyrVcEVWcxyvPJ33PZIJ30u+Zs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Hd3NZlon; spf=pass (imf07.hostedemail.com: domain of 3tbztYwYKCAw463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3tbztYwYKCAw463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676524726; a=rsa-sha256; cv=none; b=FZhIDPBhltlEg1VyEQxhruhMcNz1x4hfeGPWrVhhPdfKzlMBe4fqc8rCplDugFogl4x5zh wldhAB7rA+ts1Qwmhz7gu7eIoWDvXvHH8rvMFFFPAcPRGzLnrmeov69jOI9KaGt1H+bMOa 0ubiyhRoeVw9kGCIa8K176+LE9FeWLE= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-52f2ab6a942so8475667b3.14 for ; Wed, 15 Feb 2023 21:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zeEKIs6RouZ3NeHI7ZJ8m5Jmv1yLdTyFBRJo2pt5tCE=; b=Hd3NZlonbpCzy5K7Z5feVeMneevLupNr2wIBk8xrF2F0FeVHuTW7v0p8Iwz465OudO Kz/cwziHnFST/NwsyYv9H1NpjXxfHSGLxO5ukc+3xsoPYXaSl8+RA3RdmvmM4fbLpXN9 gimJ3OxJZ4Ep64JmtioAuz7PGMRMavPtJuthlMhEIfRvRDzYwwXEt+kIY/UhQ/1ohnXV Mp7Yg73p6F/OdwNe1qmUkwSe8yYAoyBy/8c1r/0Zsdj45B+B6DEhDKlW7MvfqHG54uOt TWogzsTy9UemTUaeFAzTdpALJEgq+fwHHnoe+QVimQT+Dp4bg9S2kMJXbPj9+Gb2VnGT o48A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zeEKIs6RouZ3NeHI7ZJ8m5Jmv1yLdTyFBRJo2pt5tCE=; b=ss/hWwyybaKEvKrUab4PAsB5A2oc9WZfRGu+x75dqIqv5cex4hlI7eCuCDtRDkPA6w peWFdEyf36BirgheG2UTMxquGVy/D5NZDOX82EuC5a3bQMRD9EXl2dXyzyUTBJgf10aR RgRT/Vx7WbPCbfITWGXGCq8VX6LM6RoGPpAnS1FfvdzIMgOdK9MRgFpLaNl5zwNBd/oE xCwdDkDugiA1ltCwfhtstHmC7unkpKKLYMIi299DcmuAk6F5Y9D3IB/qHbOvX7PLVSvm 8H/ncnB2Uy+QxgWRn0wzJd1BJqZKp0TGWXglUEeVy8yAC8qxvXvDGSpfeTVCm+ObMfuB MaSw== X-Gm-Message-State: AO0yUKVW66pTML9c2iWdn47i1LFAaEL4Kl6ElGYBH4GuGfKU7vHKgoQR VGTDw4mInQEB+ZgNFwLGFDQjgnSaTcc= X-Google-Smtp-Source: AK7set9EG6pwKD6Qe8/WGqDgk7Um8RE2RvPxkguhsK1CKP8nzrHSAEE/Znnb7/ves5IDs/PTEla86+djibg= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a5b:604:0:b0:859:2acc:deb6 with SMTP id d4-20020a5b0604000000b008592accdeb6mr561571ybq.79.1676524725671; Wed, 15 Feb 2023 21:18:45 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:36 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-22-surenb@google.com> Subject: [PATCH v3 21/35] mm/mmap: write-lock adjacent VMAs if they can grow into unmapped area From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Suren Baghdasaryan X-Stat-Signature: f9kdzpxids4dhi7tisiepf136o1joymk X-Rspam-User: X-Rspamd-Queue-Id: BA39B40009 X-Rspamd-Server: rspam06 X-HE-Tag: 1676524726-184247 X-HE-Meta: U2FsdGVkX1+5kTV9jVOswGh4102IWTkhxcD9yFoOy9SjPUI7xukusqcgYDZHKskq6sGwdDsx3VehXXMcbqH4P0BE0+lUeIjLj7uXojwO6AVdRBFDcC8dnhlKwi3EnYZyy1b2L0HRKeObAX6xVR0dYI9NNzXPyAjLdT2xD9kDyYfFIWszdUFsP1piZPACUOw5d6D5QHtwDVv2TB2gwanbBwsmMo3xPqh7GoaZ7zg7l3fZbd7teqYKGbzIfKYdN45lExxINKQUXAXeJR8i2paz4hVMq9NpWYjop24Rb/s6NHHXLMFtA6W/BBswi1pBXHXHQpXFGScmy7b2TNRsqkFcQr5RsYEnoYy9A3U6qtl4YAOZnSjWrFQvTcz+SN8YTjgvXYIH++3cEpWtrZ23hr1pTSpYt3qgXgZjRbx7OAvlRQ4w1eDdyjbW2mRQlfVmH6w0ez3YBtr23JWgNXoPh8QpJJ1WUYh0I9AAkJDZ4OGO6RKOyFwgd9KyWZ2UbzkpAvqr32td8vtZTxBGm4ggKOcjaoESFTSrJc0Bsj1mfn5g2IkWriDnn7fR3SryyTjhc/ZMpr9P4pRNEJOM9LWqdBoOX6eIm+kB6jAxZpLZdJVsDGpRJdXVPNDWVE7RMc+nvhKsvJECuR5pVKUs6+545ZdcaTWfQZ8c8A1xwKJ2wrSvAivHYPo2jQ4ngViGlMu/E0bHKzhyc1rWaZxn4pIsS4nFtdd2cs3y5SvkKXHRu+8X0enOHW5ro2yfjZap/IRCIU6Zuk/J/6T3cvu4SA0f6nSQxNR+7YeaNGouVB7jOPd9RYAJcdTXt7fiMhHgPi6aQBqjRslsr4HIvWzyi/rwgcspexHfn5ENfUInAdqz88tG7Wh6SIvTmo+c55yp9WD5+YEzMueudwxFYh0DkEZPpUIOcdJ7MqRczPyVTLy+0HUfcSrMP+Y31MOGIpL+WrsVGEzXGEkIZDiEzfbYvTfnCqP 1yAywzGp QqyPkB+MKfLmnQqq885/01L9sm1PNuCaTpY0Mivao7Fk8nAUhO1/EPNj+1lUCSDOBzIeL00sg55wzLmrb3yqb+pORoAZnuIMblKk8CBQvZtBrySW99x4X/rpaTH1cJ3aCuhXTKDOwsqlt2Cnz6l993npCcjptuxOSTEkXr/T28COzjelAOIYaI1ozfc50ruiCrsfvaon0h4sIDVGQqxZxkc2x2f5lKaxPRWNXRJQb4nMH6HWQ0zg1e6bjPBo/4lVTRpXhJeMuxUZu2miTFHZl8UrWbEfRwf5qdMptd0GaP15KPnVSRpvfQfILBE9sSdKsS9m81Wk1sE+DP3DT//b9/vQDNNO6roBUC+eBS54WTGx6WTevLS4NdGmRaJqvi0yUa3G1YgZtNYDukv5lnN0P6R/Yko4wAY0e9er4O/nF2tFmwbWr5NaEGNXxCBsmEMnSxWsW2XA4EoAd+ytRYKWvsNJjfasGyX1sYstdtOkmlNjg7HyTl/0xCPSYnOpNCF0Xe/xGn0sVhWwrm3jTgc+YLUPekZcyeJr7hgrfSv9pYJibtUJgoyO1/iLoPvbKBEE0vajdD1ZhiScUgiae8CHebD1woA/9QONckU3PpGV+XxguBCjGeZ14J+Rjmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: While unmapping VMAs, adjacent VMAs might be able to grow into the area being unmapped. In such cases write-lock adjacent VMAs to prevent this growth. Signed-off-by: Suren Baghdasaryan --- mm/mmap.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 118b2246bba9..00f8c5798936 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2399,11 +2399,13 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma, * down_read(mmap_lock) and collide with the VMA we are about to unmap. */ if (downgrade) { - if (next && (next->vm_flags & VM_GROWSDOWN)) + if (next && (next->vm_flags & VM_GROWSDOWN)) { + vma_start_write(next); downgrade = false; - else if (prev && (prev->vm_flags & VM_GROWSUP)) + } else if (prev && (prev->vm_flags & VM_GROWSUP)) { + vma_start_write(prev); downgrade = false; - else + } else mmap_write_downgrade(mm); }