From patchwork Thu Feb 16 05:17:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13142523 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126F7C61DA4 for ; Thu, 16 Feb 2023 05:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F6F06B007B; Thu, 16 Feb 2023 00:19:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 959046B00AC; Thu, 16 Feb 2023 00:19:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F9666B00AD; Thu, 16 Feb 2023 00:19:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 665496B00AB for ; Thu, 16 Feb 2023 00:19:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4333A121010 for ; Thu, 16 Feb 2023 05:19:09 +0000 (UTC) X-FDA: 80472001218.27.B92948C Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf27.hostedemail.com (Postfix) with ESMTP id 7AD4C40008 for ; Thu, 16 Feb 2023 05:19:07 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=a3wN6yhQ; spf=pass (imf27.hostedemail.com: domain of 3yrztYwYKCCEPROBK8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3yrztYwYKCCEPROBK8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676524747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nAnyYB3Nw50vBlFaI5emapvq5zyyV08CcfGYNR6eiBY=; b=yj2G5AuW+jMluraaq03OPKvPk86YSEpcRxNakJIXzeejhUr6jrlYa6O/BpEm8EB2mqpvig IdA1lbhfFQF4FnCPobF0G4depq7feGYRRboLE8ajLe86tCBAp7yfX4yjJf2ajptYbA6hM9 ssjT87I9C9s2Ie8rNb148uNSewwGELE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=a3wN6yhQ; spf=pass (imf27.hostedemail.com: domain of 3yrztYwYKCCEPROBK8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3yrztYwYKCCEPROBK8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676524747; a=rsa-sha256; cv=none; b=shQ3N0tqYEGoYMg8pLbTcKLmMNar1DUPUCz/6omUZXuwe+P8lIdXPDG/RgLwazaAsHGoJJ obERASAkPghUw8vHhpCWn6Up+qotT1Ihz55xdvXzxBvwo2U2MNaI4iFo0u0/+2Hd8+lDPv IELz5L/YYJjoUfmyyJTTFbDbtzsWQAI= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-4bdeb1bbeafso8708277b3.4 for ; Wed, 15 Feb 2023 21:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nAnyYB3Nw50vBlFaI5emapvq5zyyV08CcfGYNR6eiBY=; b=a3wN6yhQzn6ykzBbjResLcztZyUFHxuHfZtRwk9INETFTCK3R+0qznDveEPm+o/T6G wJ3wEiieeEUcjgJFPl0Q1WJhoSjHld23FZEQoY2Aq8Bhu2X6QB+bcNMvcqIxTt4gpYGo 62C0Ezu+RzKHJNHqe8a2WWwzq3BWBtjKwlH9vropbhb+eXqNxVp6cua3PyUJuPb2PSda pEBwm4EDV55dFWt5TRT7+9jNt1+V85COwPZnyzclXtLSHEwvb2nMc9rLXuPiU2TfsCi1 1h3mje1L/1Q/DM34hGjfe9SSEWf4rBhdCLw8Ngy6TcviKT73/jmv3Lf0iRWhfdK1hSLg WjQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nAnyYB3Nw50vBlFaI5emapvq5zyyV08CcfGYNR6eiBY=; b=24+r9PwAb8upiElXPYwXsxM3Sx5N5CUXLmbY2ETJHz9N+QYFJnsI8SgGvYRL9EqRkk msoKNrpSGpZuah+Wsh7w6VlfwlNAr78LkTAIMaRcLHemMxHDzaXQCyvXMlLb+NbPPw1M kRw8WcqXNJWTqZN0YzS+gVN8cNe4xENvo8peEQS53HzTSB6i98hwJ5TAMtKXr/Rj596I wEGV0YF6oqP7O3cP3Sy9EBt7TTdGVJcNPu9e/ydmflmoNsj86WVasEib3lbjKvnlqctH gADirxm+BBO9aeYM/6DhWnDxUgljBerCJIVZn83h31PcW/sM2HdAgWImLELdDbhw2uKu 6g1w== X-Gm-Message-State: AO0yUKVarJgXCbYqFBbIhKTuBweRThbjgkIwovDkVrhNAdx8kFpBWybK MLgQUVal4qgxFf0T4MvZdGxVzRtsntU= X-Google-Smtp-Source: AK7set9XJXC8LdbYcGXxryYVlcRlcBZQcF1FMhZd/N4oCcpN8tIB1OMR+nLJJI9Pn7NEIXJu3Q5fjvT0dR0= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a05:6902:18cc:b0:8a3:d147:280b with SMTP id ck12-20020a05690218cc00b008a3d147280bmr5ybb.3.1676524746144; Wed, 15 Feb 2023 21:19:06 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:45 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-31-surenb@google.com> Subject: [PATCH v3 30/35] mm: introduce per-VMA lock statistics From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Suren Baghdasaryan X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7AD4C40008 X-Rspam-User: X-Stat-Signature: e66pgekci5dfe6ozgkbao1todkecsr5x X-HE-Tag: 1676524747-745479 X-HE-Meta: U2FsdGVkX1+hblfPoE9HeQsNyfzipjm/TepYUuffMNw4KCrk1o7CXDBsi64+fzR9CJTXSoXxGm0tnSEZUtKXdDKbpD2feHeXhOajK2wEE0eGZldFjUdJef/u/aamn9PAwuCAajZOSfEIL2YQUk85gZ+Rssl8JCDrkpPaxLPIkRdqCw2DOYdFtzu/rNRp/itSftgGgxzN2DEGpFCrESrp1zx/D+oa/zACUJ2hqODn5z2o5nP8brDN87gtPAmwHDXX9RZwcZ0jSaVQfi2neDuudc13QFS0EY4nCE6kG1ygb+rTDZ5ycHtmdPL85RoqhqeX5HJNLwhWPhZzMrIONLLv5tplgOELgrpV4Cpq5aa7zneGRVPP40s+03/5EczUHpNe/TuvKEy0TFEZK8ibcTpolb+ocyY/2iePN5KFUCuEKxQxSTdvek54ID665coblehIvTNOS5iIjfmYDteP3kJnx/gnj+bCHZmz5FG8QHYGEejyWuVOYOTi79LNgxccTVo1rs9eYeKJGHCNHKgKlTmDzU4dzPo0Pcv9KkF3mOUgKzrxeWUyghz5CYbImdH/uYAmE7H+GvjA7AX+af8g4JBjCa9Qp1wOIz+Yi3sPwx9CKYPcwjO+IrhNqpkBTRPmkShkgje5vy0sxCzRsNRu71JD8WDB9EXpxGjfMn5eRt+LyAQ4odZCMAZaF00qK69h/8bXM7bPgi6SiM/Qqpl0YEGUfIkerWhnvUwspkuKuUKBgkWng+9WvTjLvWQr85g1hVfJ9l5zxi9QWN6NjjKQBCDftD9oi4MkIFTdCrahkVjPOclC1Spkm/bMlx+bT67ZGv96VNbu9IYmahcSEmIkoEDbJ3sTif3UFo1Phipi5AofWRYXWiFGa+5TtlYDY9hk/6WFCw9R142Vgg6A0wPp6EM/ch5oDNtlk2whl7BOCdnDOunjpuqNzFbvlr2/ftinrc9SdeqqueVgt/s70wNnAuR 4eo8UA1h vo8UiE4V62TAYr8zD41iFOUtjaPzPQViwYnfzO8j4Vqv2ehrrca9NXXv30Y7nIrUeklmE1hw2ZCk6HISPE5Zl0ZyrT5i41hUkckbZctsk64sP0RppBfigh0cnDipckOo8/sc166feYbge9R3BZNLe2We9Vdv7vIsqQM6OFPr3wd9/HqmUx9Kl2VbqsHDPf6erA8Z1r4p+DRSmsN1nJ9XfR6Ju3HkZsdRw+CwicGKqhKGEddAawooVgmPTVNaScLrVc1vVoIi7tqNhghhemycI3w9SD0pLIa02wchZsRgPlaGuQEpdjOnqiB+fEYhkOGtXq6ocWM2hEIc/+4PExOdl0yfq1u/U5M2KHHul1ainFZI/ANedeVyIZa+tS0HQyccVWD6haDf6/9cXhopkNbpF8UnJIO9KOEe5Grbce8h6DpyYRsSvXh7hbO6HckAAfZlSiTCrwJGov9TDo3XVcHIsbk8u04EIyLmP2OA2PyIt+yHV53D6yLH/FDg3OD2eqJSj2U4rUHPLi0s23uD3euSPrTLODzG0ql0LwAzGy9qOejh/wuNHaPkKTX5iEbn1mmvKSQ8ymf381vEcojW3WKQCvIoj8HTRFS4XRC5Rwns+xy7YoA0BJtOpI55LuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add a new CONFIG_PER_VMA_LOCK_STATS config option to dump extra statistics about handling page fault under VMA lock. Signed-off-by: Suren Baghdasaryan --- include/linux/vm_event_item.h | 6 ++++++ include/linux/vmstat.h | 6 ++++++ mm/Kconfig.debug | 6 ++++++ mm/memory.c | 2 ++ mm/vmstat.c | 6 ++++++ 5 files changed, 26 insertions(+) diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h index 7f5d1caf5890..8abfa1240040 100644 --- a/include/linux/vm_event_item.h +++ b/include/linux/vm_event_item.h @@ -149,6 +149,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, #ifdef CONFIG_X86 DIRECT_MAP_LEVEL2_SPLIT, DIRECT_MAP_LEVEL3_SPLIT, +#endif +#ifdef CONFIG_PER_VMA_LOCK_STATS + VMA_LOCK_SUCCESS, + VMA_LOCK_ABORT, + VMA_LOCK_RETRY, + VMA_LOCK_MISS, #endif NR_VM_EVENT_ITEMS }; diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index 19cf5b6892ce..fed855bae6d8 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -125,6 +125,12 @@ static inline void vm_events_fold_cpu(int cpu) #define count_vm_tlb_events(x, y) do { (void)(y); } while (0) #endif +#ifdef CONFIG_PER_VMA_LOCK_STATS +#define count_vm_vma_lock_event(x) count_vm_event(x) +#else +#define count_vm_vma_lock_event(x) do {} while (0) +#endif + #define __count_zid_vm_events(item, zid, delta) \ __count_vm_events(item##_NORMAL - ZONE_NORMAL + zid, delta) diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index c3547a373c9c..4965a7333a3f 100644 --- a/mm/Kconfig.debug +++ b/mm/Kconfig.debug @@ -279,3 +279,9 @@ config DEBUG_KMEMLEAK_AUTO_SCAN If unsure, say Y. +config PER_VMA_LOCK_STATS + bool "Statistics for per-vma locks" + depends on PER_VMA_LOCK + default y + help + Statistics for per-vma locks. diff --git a/mm/memory.c b/mm/memory.c index 751aebc1b29f..94194a45ffa7 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5272,6 +5272,7 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm, /* Check if the VMA got isolated after we found it */ if (vma->detached) { vma_end_read(vma); + count_vm_vma_lock_event(VMA_LOCK_MISS); /* The area was replaced with another one */ goto retry; } @@ -5280,6 +5281,7 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm, return vma; inval: rcu_read_unlock(); + count_vm_vma_lock_event(VMA_LOCK_ABORT); return NULL; } #endif /* CONFIG_PER_VMA_LOCK */ diff --git a/mm/vmstat.c b/mm/vmstat.c index 1ea6a5ce1c41..4f1089a1860e 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1399,6 +1399,12 @@ const char * const vmstat_text[] = { "direct_map_level2_splits", "direct_map_level3_splits", #endif +#ifdef CONFIG_PER_VMA_LOCK_STATS + "vma_lock_success", + "vma_lock_abort", + "vma_lock_retry", + "vma_lock_miss", +#endif #endif /* CONFIG_VM_EVENT_COUNTERS || CONFIG_MEMCG */ }; #endif /* CONFIG_PROC_FS || CONFIG_SYSFS || CONFIG_NUMA || CONFIG_MEMCG */