From patchwork Thu Feb 16 05:17:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13142501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76388C61DA4 for ; Thu, 16 Feb 2023 05:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F8EE6B0085; Thu, 16 Feb 2023 00:18:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F264E6B0087; Thu, 16 Feb 2023 00:18:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D78A66B0088; Thu, 16 Feb 2023 00:18:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BBC2A6B0085 for ; Thu, 16 Feb 2023 00:18:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8B2751A09C7 for ; Thu, 16 Feb 2023 05:18:17 +0000 (UTC) X-FDA: 80471999034.07.4293B58 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf24.hostedemail.com (Postfix) with ESMTP id CBFD1180004 for ; Thu, 16 Feb 2023 05:18:15 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Xo1jDDVi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3lrztYwYKCOsfheRaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3lrztYwYKCOsfheRaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676524695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4opi4a+4wBSqIsfjyFGdOCf+RfFv13YZtxtXh5ocOUM=; b=tv0glaSS00KMP3R1lNggFDsXfmUM0ZOuCx8MnHFXFylI9Fay1qtEJhyn0Qw2PQf+byU14L Klh4fTmwRHq8GjWF0UiF2pliPv+JuIBdtdHCAlp1oBfW5SNkLd/eca4gP3//WJztin596b eIOBffTvCz0VVPEld73Zuf1M7G/gfCA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Xo1jDDVi; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3lrztYwYKCOsfheRaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--surenb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3lrztYwYKCOsfheRaOTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676524695; a=rsa-sha256; cv=none; b=k4keLIKc9RydGpz1Hl6UI9IZTn9wJdUWd1Gb1go9GfX7KpXYPqI28hZgE9358SWSVmWCFW YGBO90IAbEOAiOau4Hx/p/+EQBaBu7pKC/b92M6GdgiQM1I0y3JZro07STd6hKLNwExk2G fVx83HdStUjBClYmcl/UCt8aAUbziow= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-52f2ab6a942so8466397b3.14 for ; Wed, 15 Feb 2023 21:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4opi4a+4wBSqIsfjyFGdOCf+RfFv13YZtxtXh5ocOUM=; b=Xo1jDDViHSHN/alioaTDnw+zuoNPKrF9ZLXUf3ea0NE3bXPLl0z7WkGrQUW7AOG0Nr J8SsODBneQSeaMKO7nEqhtXELAqyVVzyHag3dRajS0MNlWpB1lyOtsy0oB8MM0CrQEnP Moe4iuqLi8ffYInMsJBu3lDYUcEPw1W16t68/pqdVg/PM7yHOfl4JRIe/AAV288dZ063 0OmpnGUH5/0w4iEIelRXBTS4gWduVmNFBkN/5ItORK5tiSjU8ab3rw3adCz9oFddo8Er mGSeo2MZqEM7cxpZTU0mXlOgRPyGjhgPgDiiUmvS//v9NEkdkZgUTyYfpCAeqd0avQoQ 0u1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4opi4a+4wBSqIsfjyFGdOCf+RfFv13YZtxtXh5ocOUM=; b=DctBjrBANyTnPTsyG1s7iaSmXfySh7mWxcYWFiMDUB7OVJBqceukHHmH2aAPNV64EH nm7nf/gvfraOdrNhzybdhZWWQYJYxaAwBr0qlsdbHlxinKEJHDUYNplvRhpmNv4P9GGQ PMWQ5/8wEsaqRpEHta5iHgubPKFHRvO1hQR19Wj15nw1rxGxBdr9O60y4HmfgUgiGCAx 1EqNp5pDqoztGDC7Z/TSaaZ++EoS6SUmOySPiv9baG1nWTzJj0ibcRgZh+ZDfKEKEpca UHn42V+nBw+RZbcg6w5akCrnDHouXAFitIIiHWO7NxPbhuIEexAPYTTog9Uz038ipSaz 5nHg== X-Gm-Message-State: AO0yUKXueiNgOxeU6lc2DYInySpU2L+++MHNjzmeJbVOjTPtj21sek5M XvZL0/kv/6ItwGzo3RgnVYsoqq9jz8E= X-Google-Smtp-Source: AK7set+/DgIBDY3hKjRHmWHVe7yByHJ3rZUqgnqz5mohiI9GciRP+9xmqTdnoEyOpn2/QPX/HT0hsnAfle8= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a05:6902:ca:b0:8f2:9e6:47a4 with SMTP id i10-20020a05690200ca00b008f209e647a4mr3ybs.7.1676524694561; Wed, 15 Feb 2023 21:18:14 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:23 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-9-surenb@google.com> Subject: [PATCH v3 08/35] mm: Enable maple tree RCU mode by default. From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, "Liam R. Howlett" , Suren Baghdasaryan X-Rspamd-Queue-Id: CBFD1180004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hit8smzbceajhhdhq1caoyx3fwb8hj8m X-HE-Tag: 1676524695-614475 X-HE-Meta: U2FsdGVkX19c8Y8m3GF+omTv+BqEHuLn1aEnhOyb+Mhz4+i3P8epm5xV38AQtqMvXYBhDVl53KuW2REUQXY1EqxfWmp4b5cBBQTqNckL0+HAdeP4WbdafJDlMk40FBLRxwwvttDjPtGYCFxDQnMHy4M1GTPgq98InVynTc5rI+g64MELCKUOHoFJNdwEnLLVC63L1Lunlqb/vnnvykk1d2iHJoefvLwLN2+UceOGojhnhL5SGqcC3tEE7OxNAHB5bfT7yQC4VajCeHEwPoAZJJc73dW/nWyu1wqAm1SPry/5jkXLgf7Djq6gQfKXq+ss5iEiVAllNg5ZRhoDoVAAtK68Oj3mL6PTwIEwOriebhrgvC7NSUY8MiwlTVnso4LcxQ3CCEBqdQELANnD2qkZ34AyviyE3HSLEZcxX0pukpb5za8cDrrMaJ0Bm4Y8oM0wgmbx3SNsQfXEcyOxUSDLHYm9g4oIf9Ze8lVXwoScdAdfXMf/2QjLdM0YdSVTmiq6HWhB16dLCqg39gbe9sm67v4QdGWj3fdGR1OgfxlnXcQk0q2NH9edCuaSDKN/FTLuW5plkNkXnjGpD4L/VC+Uz/GSKb1u+Lf3iSrCw7Ja+0rxTMR71UMyEvEEHmiLUnU/mm7tNc3LMZ2nDJiIHLlPuWSsWJhFhY+6PK+NtcScZp5cYlxGTZOLCZZ2jA4Te8qWdHy2HLTulETIiYZTlfl/mBu8MbuHPjkx44OR1Cdh4PTWmKPai6Yhgqf9j1V7ezXkzhg7+cDE32xNNtyEuWluoaO86s0K6veIkNl70tS75BLea4nOXb4KGRZI0K4Ad3sGrfgARQ0Bjjzctq8pxYh0ZM1NQaBcQvmqcyvvEodstuwnVy23z8cvEIxqGkliplrdFVi8qjvp6afkeGwkCWvmecTrzHV2Cwt/w13Z7hT0lHSYdKb2P+1QYn1Iz/C4kBZuTPKwDfQo/O018RoxWIm uSwNvoM4 dlAzqz1wZoqW3JME5eFT+nmC0fJ/O8hSwfYbcyrRH8aQyZlZImJuVVIG0o+18yQMJW40UQjr6RdvZpK+hHKluuuAGqnD6Mvf7ZCcPyzybG5R+CdxN2DHiwbHLUSWZ6+uebovZTbSMjWN7hR9e2ARKIPWzh0rUTOVe3cZVFMrir714hSPbWZmOoc60grv9wSllanAuCYMRTKfUo1RiVwXSMbcFHaVB4CwvTd7+oHzeap9PXHiKjF45WPnj611lWofxLRho7CaZfIMEP9oQdGimDhiqArAOJUCHaUm9MHP0q+hYpBhkokHkqYKZIuycRk/McYoOEQQkiK08oytOyFZpbXoy2Wr5M52DPUZ2dP3oeZW8vQam/TbCUZdCZbrBxKZPvKoVcX8knXYS/zVky3jZeTr/Xgciv/fDokyXHjxRxfnONjgkEH2eu9L5ioSdh5eBZCvq4nyh7nbuzsxiuiWRvsZPR98mKoclogJHd8xPqACt1hkBTFjZmIV/Egk0AR5IHrEEOw2q/XZ2kdoK0IskImy3sQIgCa6yF6tz6aQG7RXWSL3jg1JuMInzKWJa+hrEAx4OMQMQyHZCV4RCJPwUzjsmXzVIgmWMZ0CylR24orX07DtkJnfdI3efUCG8vWJe08j9gXrO1/Fwadv+YBCSuK8W9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Liam R. Howlett" Use the maple tree in RCU mode for VMA tracking. This is necessary for the use of per-VMA locking. RCU mode is enabled by default but disabled when exiting an mm and for the new tree during a fork. Also enable RCU for the tree used in munmap operations to ensure the nodes remain valid for readers. Signed-off-by: Liam R. Howlett Signed-off-by: Suren Baghdasaryan --- include/linux/mm_types.h | 3 ++- kernel/fork.c | 3 +++ mm/mmap.c | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 3cd60243c625..3fd5305dbbf9 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -768,7 +768,8 @@ struct mm_struct { unsigned long cpu_bitmap[]; }; -#define MM_MT_FLAGS (MT_FLAGS_ALLOC_RANGE | MT_FLAGS_LOCK_EXTERN) +#define MM_MT_FLAGS (MT_FLAGS_ALLOC_RANGE | MT_FLAGS_LOCK_EXTERN | \ + MT_FLAGS_USE_RCU) extern struct mm_struct init_mm; /* Pointer magic because the dynamic array size confuses some compilers. */ diff --git a/kernel/fork.c b/kernel/fork.c index 5e3029ea8e1e..5f23d5e03362 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -617,6 +617,7 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, if (retval) goto out; + mt_clear_in_rcu(vmi.mas.tree); for_each_vma(old_vmi, mpnt) { struct file *file; @@ -700,6 +701,8 @@ static __latent_entropy int dup_mmap(struct mm_struct *mm, retval = arch_dup_mmap(oldmm, mm); loop_out: vma_iter_free(&vmi); + if (!retval) + mt_set_in_rcu(vmi.mas.tree); out: mmap_write_unlock(mm); flush_tlb_mm(oldmm); diff --git a/mm/mmap.c b/mm/mmap.c index 20f21f0949dd..06c0f6686de8 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2277,7 +2277,8 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma, int count = 0; int error = -ENOMEM; MA_STATE(mas_detach, &mt_detach, 0, 0); - mt_init_flags(&mt_detach, MT_FLAGS_LOCK_EXTERN); + mt_init_flags(&mt_detach, vmi->mas.tree->ma_flags & + (MT_FLAGS_LOCK_MASK | MT_FLAGS_USE_RCU)); mt_set_external_lock(&mt_detach, &mm->mmap_lock); /* @@ -3042,6 +3043,7 @@ void exit_mmap(struct mm_struct *mm) */ set_bit(MMF_OOM_SKIP, &mm->flags); mmap_write_lock(mm); + mt_clear_in_rcu(&mm->mm_mt); free_pgtables(&tlb, &mm->mm_mt, vma, FIRST_USER_ADDRESS, USER_PGTABLES_CEILING); tlb_finish_mmu(&tlb);