From patchwork Thu Feb 16 07:34:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13142679 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D75C636CC for ; Thu, 16 Feb 2023 07:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E626B0072; Thu, 16 Feb 2023 02:34:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34DB06B0073; Thu, 16 Feb 2023 02:34:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 215D76B0074; Thu, 16 Feb 2023 02:34:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 129BB6B0072 for ; Thu, 16 Feb 2023 02:34:29 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF7FDC0F1A for ; Thu, 16 Feb 2023 07:34:26 +0000 (UTC) X-FDA: 80472342132.12.CFD3392 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 215224000F for ; Thu, 16 Feb 2023 07:34:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SkpWc/Ti"; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676532865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K8gjNmTSR559OlRy9/RjmiyCYfUP8oDtfxDvTzbUrgI=; b=rGiUl0JvBvv3of1gC5cqxHtMAlZIelKkepInk7ev84uF5amwTRYrppd8AOpjj9rWoE+9VL 3+cnAu2oJb5Mdf/WEwX7JICycrsvO01aI1Ntnw4nSl1ira3AKdwYE/E7rl6HmQf/XjYRzN T1FYuziqu+2cR7jf158PsN+U+pEfLtU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="SkpWc/Ti"; spf=pass (imf11.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676532865; a=rsa-sha256; cv=none; b=M4oQrXptjX/x/pt7sifea0zzXTyCZF+ybgqQkayN/31ci4IxY+koWNhP/de5scWdjJkMb5 JOr0UeDXfAKSxzKmXUd3r/GMLp1G4kWYQLM8kbF3hXLgnsCU4LA+YS1j1IrBn08JiR2wXx g984DUmfBxbiFMAgWFeyg/akMJZ6rxI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676532864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8gjNmTSR559OlRy9/RjmiyCYfUP8oDtfxDvTzbUrgI=; b=SkpWc/TiozrqE7zFRcbVQjqQAKRIcSGvfAePr72p+pDYmUbqjbrPuWj9eL1kIDO4kQ3pJz L1EKVY8T2C8qVOKHVsJNlssXZv1G1o3UpCCr4gJG0AO3A0tZYjbLOUR3CI+9nbna8D/+wT REdKO+F2fArUH6RiCqp8vvGcdi+/Dvo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-qFMrDV1tMX6QrEoyM6s7bg-1; Thu, 16 Feb 2023 02:34:18 -0500 X-MC-Unique: qFMrDV1tMX6QrEoyM6s7bg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B46D811E6E; Thu, 16 Feb 2023 07:34:18 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id F227C140EBF6; Thu, 16 Feb 2023 07:34:12 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Baoquan He , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: [PATCH 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Date: Thu, 16 Feb 2023 15:34:03 +0800 Message-Id: <20230216073403.451455-2-bhe@redhat.com> In-Reply-To: <20230216073403.451455-1-bhe@redhat.com> References: <20230216073403.451455-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 215224000F X-Rspam-User: X-Stat-Signature: ktpkpmn7ee8krte7h93r3zfbi5u5r8yk X-HE-Tag: 1676532864-997308 X-HE-Meta: U2FsdGVkX18/jBbfYHTIuYerdEgInyxdewNmusUYX+KG2c/f4g26xGvFTXkY7TCXbCnphYK2Av2ju2ylQ9wWfo+Jy2zhih9vDPsQDhbur8Rtqn/Vd1wizexNOwYjZi6t7Q0UWKNsGXutWgyOmCuPT6uxCB2hGVvS8YjdJDHalGQwVOC1Aet9BLLwFDX2XMgy87C7kNexHuWMIki/+SQQ4VXmJNEZWj86rv59HO5DhWqZ7E4FDgI51JO1m8+Vwqjv9Hzfczy8lwOJpuasaFZ3BMASJVfHV3nJI3PXj57MW4+weuTMcR+hw14CAPcqm3/gOdt+Cm9Tqd5U3QAD/FxNKbtsx1C/UQGIFeeV7pqWT5AKVe/WkvYCLFS6lN8KqbHWVM2kqZPvcXW/uVjs2MviPavFAJ5amWwph7llzFb0YHVrCWvz1RHbOHDwWtWTXnreKDs65uHIwhOlI4nrZlJxvx0fx0Psq/W3iBOyAC2VL+O5/T2uzP4mHYpuhGXRDfTrP6kAktMviknlcx/Zha1lT34ZmkpmnGCFe1MbiP9VQQNdOHGNinaZP2HJ56UchN95P8SewfBaw7008aAuZ8ZVIrvrR040QhUi0j6RQhyIAZub991jAzp9sr7EMnd00IsWhvkVA+ZIv9DHd+6tzT4lZ5vMrPpNE7EfTYxy466E0+IZ9CdWSmjowbz/h5qPr33BlsCMZ4nDFYA5eRSpfe1tRoCxqHmx1meFlssBquS5UI73OS2+DGPPp3IZiwGzLuvi0lLimtmklIBzz3ZNG8b4ou0nuOuAmB4AdAgrq9US4NLAQuVvznRAPHNjbmCX1H42klSCqGPXtrpYRfply1Zqj6JuLymylI8clpQtJZDQZEJkGtDGekS8Od0hf14yji/+f9+HgOzJ8sXQ01+qzdCiRcI8mKWfCf5Fy8zOlZnAUZ8QAY3IuOy32ghPBtuYeQ8BCB5b7mJ0YgqeYrwyf0Q 2ABzZjhr tl3Urcy5CHa8fbp/VbwFWhpDEYIquG7R0PxVb/ZXwwUnzix6icgFcj+tO5c09ATRhnoUZdMiRplwEiAdmHO4ImhO0dTBKZwgaDLenDppNAQWkZkj+XruD9N37Y23D2WCXLQ6cKtCFFr3YHFb7OhTQb6kzFY15s9UR0Zv332a3ArmX3Y1w0tNvRCxNB2klR2a22qVOgHQNscytgkOZjt3EA0G18gQP7yj8AywyqWU+KdpN9tQ1v0reVegNTY8LHE91o9tWbgzk2rHcC/T+1zDH9LPcPGnDTsgASDrmUqvRvhSZ/vZIynMj9ITDcoEHfVx5h1QRyJ6comSxVcl6dccx0YscJtCFuI/6K7o4LLfIg3Qa8DU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. -------------------------------------------------------- ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 make: *** [Makefile:1264: vmlinux] Error 2 Link: https://lore.kernel.org/all/Y0TcaZD4nB1w+mAQ@MiWiFi-R3L-srv/T/#u Signed-off-by: Baoquan He Cc: Andy Gross Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Vinod Koul Cc: linux-arm-msm@vger.kernel.org Cc: dmaengine@vger.kernel.org Reviewed-by: Niklas Schnelle