From patchwork Thu Feb 16 09:16:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 13142746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8025EC636D6 for ; Thu, 16 Feb 2023 09:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17BD36B0072; Thu, 16 Feb 2023 04:18:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1053D6B0073; Thu, 16 Feb 2023 04:18:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D356B0074; Thu, 16 Feb 2023 04:18:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF3A26B0072 for ; Thu, 16 Feb 2023 04:18:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6EA741C6B05 for ; Thu, 16 Feb 2023 09:18:03 +0000 (UTC) X-FDA: 80472603246.06.5B768A9 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf27.hostedemail.com (Postfix) with ESMTP id BD24E40010 for ; Thu, 16 Feb 2023 09:18:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hXppeNF6; dmarc=pass (policy=reject) header.from=collabora.com; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676539081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K3lFMhak3aYOcGIprm04ZPQEkc3xI1jgYekJJdax6BQ=; b=SdmFsA10WES5p/WCovxrf6iPxeHZ7Kf9M+Zrn6ilXF6Vf/LrUW0GvHFc+UEE5O4kcwwmTm U/t7qWlPzDqd7xthhd8KGzqOyrXF/LyuItBms5WtHyVJJjmIJ5U3PykPQuyU+qR8Ik5Z2h mfpQH5AbCqcCaOHtiGsz5rmyWVgO5sg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hXppeNF6; dmarc=pass (policy=reject) header.from=collabora.com; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676539081; a=rsa-sha256; cv=none; b=x9kmkV2YUT9l4yDZkmQVAJqH+e0TRxkRhP6Nm93PZcszHZMcCnKnvdW8GZeONoLhVYRfrw bvCrqwqmT6LnCz7JBwISaWLHIzSgH/taNePTtBBpP92xrvA5qLUy9YBopWp4Ymg8icbVsE u7B1fol85+uWm3xpEucA0sL7LIs8tP4= Received: from localhost.localdomain (unknown [39.45.217.110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id B6820660219B; Thu, 16 Feb 2023 09:17:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676539080; bh=eN35qv1LQnqiL94LOpdwsRPxsfQxNRRB3+34BVt+3/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hXppeNF6RgBlcVGgaFAGBHmpAy9Zonunn8zH1SUsH0SbgvHwyDQ6xVh8Q/nxGdKFs 495IqxX+srlyIzYUvEvCyQortt7XmNpJJD/9gIdbyZ9xQi17ioi30ymeUajEeWYC83 4NxxHC/EeJnyJ4XK54d7AW+2IbrnTU/NcELTXRrHUQhgFQDztv+lMzZJTkp6yUQXhI vhoIewxGXKTkkD1izP+GxMFpAbSmMDPfm3RIoIdfZEQDsAFclK60r940C6p4XqQx8T cVTO2CKICrClksWOIx5b2asP1noUwXIORO3Y9rYczrtt8n9apz+wXM8QatF6yS+gI3 AIGihfHZqYJfg== From: Muhammad Usama Anjum To: peterx@redhat.com, david@redhat.com, Andrew Morton Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/2] mm/userfaultfd: add VM_WARN_ONCE() Date: Thu, 16 Feb 2023 14:16:56 +0500 Message-Id: <20230216091656.2045471-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230216091656.2045471-1-usama.anjum@collabora.com> References: <20230216091656.2045471-1-usama.anjum@collabora.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BD24E40010 X-Stat-Signature: kw5kwayhmcq9m4okw8aw89gckg194ihh X-HE-Tag: 1676539081-578823 X-HE-Meta: U2FsdGVkX18N8ufyHaEf+MYf6VFRCl5vX2uDIkwwJHFN+1Mm4OPKpU05m827eiROHIusqsneoLUXa3rOR94IXxqjDMHOK7/k8OB87IqTRAfFlnAeVVIrckyXmDlQ6v/8WqYIMas3YLtd70gVMde6lC+sX3lN9y7BgUbQuUPtLR/6rJcx+Vp3dJyQ7tTwNOHY/ciOQJ5YaLxCqBi8mvbSrV7YWS/6/31tmJ5K4lguEpo/YVVuyFNiJUM9HYm2F3ncgqBlx/7zcdHnqHQGXnkS2P1gC6mpazld50t/RUPwDAxNV/9waYwqfueqvHHpA+aVvJhk0gFmT1MLwv9QV+NXZDIr8VMv0CFS7B5Jv8j6FeJvXibSmOeJ9HiS0dJvyYKOIWsCfqpl8n554Kv6LxxQEHVlubm1an0WnEoPjBj7pK4eBW73BTzxLV0NSLAUbRMlKS+ICL4wgLeoWktpL73eBVtJBFOL6T3EijtCW5ygwME5p2VysmTBhXf3d7lnRLEF8+jh/j9gRrV0yjrSmVX5U6mpA7tgALpKLqV0kD/dpM4n1nVAXaKXWeyz/upBBk74HKXnHoVq7iCtmhA2Db8w0DHpeQpT1a6rOzbWcgSDQrcBSPmbdUfmormWnhi1egWIY+xr5wbYf3wNMhxQ9AYXtdoPlMzSkQzJ1Af5wwxXNVrAC1XkKWCVYpMep9zZb7UiZkMinTKzEvTKfBlStDxp+OIBZgVEAiPqOPn+ixss1yIL9271Ob8F2Njg7Z6Ij2wkdUd4ptdxJvJvdsf92KSYkcPWvPSEp4JdoqFATWv+rgG9YL19JHR8GOOWaBfiF4MfO9SAYQOJVq/co7sGPXc0WII/cPu5OkkfH4gtvsJCjOIEayNFYoKBhlWgatA7wRth5lfTdfCX5s7LSquOZ7IKZq11ty1goLDWwNQehrXzStWgj/r5PxtMBvAJkU4J04EcVS2g/oS/7fZlsYAL1WJ fAlwJhmu b2OV4QeMi5qICpjAAIq4kmzdj0snhWTtS4kqURIo4xVumo3KjBCQZg0qnHX9A51hEG0j9++WzdWJv70RzPH6eadjf8IrFPuexL05hcUh1F2U+twByaLAiCpVNlTNAv9MEwUt3G23aY+7+RrB5yLOIiQ4aKOuAQFWhdJ3RncTXomgiUPFRcjjtHV8r7TqaV/YmLFz875eRS8htE+GnZMUhQWl1eVK/WfQq9hKfW0uZP2mzoEUEol5WGUwdS9o/9drTwkl5CqxB0ALqMaGizjLmXg1qtc+GbbdammrmLggGsSKOEqjPJHXIRnLG1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. Signed-off-by: Muhammad Usama Anjum --- mm/userfaultfd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 77c5839e591c..d89ed44d2668 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -717,6 +717,8 @@ long uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *dst_vma, struct mmu_gather tlb; long ret; + VM_WARN_ONCE(start < dst_vma->vm_start || start + len > dst_vma->vm_end, + "The address range exceeds VMA boundary.\n"); if (enable_wp) mm_cp_flags = MM_CP_UFFD_WP; else