From patchwork Fri Feb 17 20:07:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaac Manjarres X-Patchwork-Id: 13145208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D6CC636D6 for ; Fri, 17 Feb 2023 20:07:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFD556B0075; Fri, 17 Feb 2023 15:07:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BACD66B0078; Fri, 17 Feb 2023 15:07:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A74586B007B; Fri, 17 Feb 2023 15:07:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 983866B0075 for ; Fri, 17 Feb 2023 15:07:44 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F9998031B for ; Fri, 17 Feb 2023 20:07:44 +0000 (UTC) X-FDA: 80477869248.04.A477CA2 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf20.hostedemail.com (Postfix) with ESMTP id B88D81C001F for ; Fri, 17 Feb 2023 20:07:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Rq55dr4I; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3jN7vYw4KCC8TdLLNXLYULccPdRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--isaacmanjarres.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3jN7vYw4KCC8TdLLNXLYULccPdRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--isaacmanjarres.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676664461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=U1nM6W22xHjS3Bc4zx0z84OyKRX34ntnrDpqWA7KxXE=; b=3XrzC2hbwRDCPKByQK6WkKyasYwxu+0mYrjeSG5iTmuEqAjsO3i9z4Jqg7AXxVqFJj3+cW SILtyWzV0hkc3RG5OFwsx/vOx+NqPXxdyGtEqRY17EMTV0hv6TRCUASUZfzY714qRtJ7KK poqdPEIcOnqTBjO8/1tzGWLhnvP8TII= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Rq55dr4I; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3jN7vYw4KCC8TdLLNXLYULccPdRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--isaacmanjarres.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3jN7vYw4KCC8TdLLNXLYULccPdRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--isaacmanjarres.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676664461; a=rsa-sha256; cv=none; b=2MwJxbmWOomRaGwyyRvWXwp2MROVJiBxYJg1qSSMS04cJzgV60/cNK9xL2syT8NU7t+UoB YAw9iyqklTLZZ0m1cv8kY0kgUe7OmHUD6ZySpmvZMZPUm9U5QcuXoz7m3vPbfbVABd7vsh JC+vTobQ+YYHqzegZTiJ2mHTyknVOiM= Received: by mail-yb1-f202.google.com with SMTP id 188-20020a2503c5000000b008e1de4c1e7dso1711266ybd.17 for ; Fri, 17 Feb 2023 12:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=U1nM6W22xHjS3Bc4zx0z84OyKRX34ntnrDpqWA7KxXE=; b=Rq55dr4IlqUaOCip4zZ6Bfk+GkgFZxk6avpazKoRSLojShtX34gYkNdC8/5SbhTzhE 4MZAJbUgib1m72WWVl4DX98FY0VipeLo3JbjLgwWqrnyMvf9E8/cpyyb+UHevXrKil5B OFSI6s5GRiEmESPGK5Mym34edcC6jcPzHNGj9fKb3z0Q7JKQU9Rk8bq9XGX0asjVIqMa 3Y/ftanfYZzyuJsazVqATYvrwQPpNp1pqC4h5bnBaoOIGcluscjTPWhlqmghiYk7hTCP 5m0zMNIOVvgn5s9wb7XSLLz9wIs2SItRvq6ibRdib84zXFWqaukJHmJ0yNIZQNG6iYPd AAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=U1nM6W22xHjS3Bc4zx0z84OyKRX34ntnrDpqWA7KxXE=; b=Nel8BzSYY4VgUSiM00t6QFExc8xOWmRxPSrK3lBeI1e7CD1IOG9A38FlX/56TPFeyG 37nZQLf/BSf/JLMEfgvhynRCILhA4ZRZtH4+KI4l12IpDPDFkCLk4vYaPhRqoHEm8+nI j2d5XMcESTJOsJN0ugVrexqHOZQvS9hEFCnjVE8ZE+5JYtMtgh1PQQm0x+xyW4Zy/CYk bYNH4k0cXALqKa1RskZ6Sd+pczUHVFr7c6Fdi6EZp02KCYyeuNci/SEVGR+LTUQzyroO CEz37V9ch/fPO/20Oq39w5nn78dUg7WeVLTRTVQTf6xCbIJXLDmc4yYZNBju5Pn9x1aP qEUQ== X-Gm-Message-State: AO0yUKWzXniRkxvYEneQb5PA61qciA8DQ+IjrwcuWhL8aLHZsKn2wRXm Mrp3fo2kuYDlxe2OoViDQYmV9QgOP10HnjbBliDGiA== X-Google-Smtp-Source: AK7set+IwRI9hRSSzsNSYknwwsteTFcswm8J6ufEohRY3jA3I/YoGe5TdkvTwxTX1AFimUbEPQLZIEhxMkSJ9cDiYtvt1Q== X-Received: from isaacmanjarres.irv.corp.google.com ([2620:15c:2d:3:723d:63ac:5b97:6d54]) (user=isaacmanjarres job=sendgmr) by 2002:a5b:d45:0:b0:8f2:9e6:47a4 with SMTP id f5-20020a5b0d45000000b008f209e647a4mr264475ybr.7.1676664460718; Fri, 17 Feb 2023 12:07:40 -0800 (PST) Date: Fri, 17 Feb 2023 12:07:30 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Message-ID: <20230217200731.285514-1-isaacmanjarres@google.com> Subject: [PATCH 5.15] of: reserved_mem: Have kmemleak ignore dynamically allocated reserved mem From: "Isaac J. Manjarres" To: Rob Herring , Frank Rowand , Andrew Morton , "Russell King (Oracle)" , Nick Kossifidis , Mike Rapoport Cc: Catalin Marinas , Saravana Kannan , linux-mm@kvack.org, "Isaac J. Manjarres" , "Kirill A . Shutemov" , "Rafael J . Wysocki" , Rob Herring , stable@vger.kernel.org, kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Rspamd-Queue-Id: B88D81C001F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: pgzufqskxgpgsgwe8f4upodz3dyxhwqo X-HE-Tag: 1676664461-923963 X-HE-Meta: U2FsdGVkX1+3Xgj0yEsLR2Tm72ZQijzTYKxyGgjdHrY2l40UESoTHvLfy5B+s6sto8PMiky4sBSM2O/3yy8ezYSabE7OrywaEdx+jQPeA7tXIvD9R9klsm0lUzKBvgTwY2hegKuLrSVCK6eA02kkk9LtkaIcP3JEU8KKy2t3i5vibWZcFC8rrkVdLF5NZOGQ3lPtkgXurfSVGkkkszM29e0gXujc1pLSEughLdmxF9R/iPTr7+aqZfCNcuNg9A3KmPPDtvft6K3FYNN+jiZJTAs1bVgRGHC1ExZ8RSu5paS8+/JeXV7Tpy7e+/erQAAVW5SSprixpt56zoQASj+gpw0jc0OcnCVN/rwD4NOLZjoEYaB2JVWlgwiRsmEPa3KC5/ECAT6s+t8dl4DRPsw2IAqy0I83q/kXDzAPNiYjA2muxgoI3FYqLqhBaubET4Kxy4PD+HZYS11C7kHeQtKIH+9shbxdxluhyen7wrFSazPh7DMRVLGiupvU+aBrGNvEh09Z+qbg3arV2YMDRAA+dL0R4OMrX1YIdT6F2MrSHHAP9HFki0tDCwZe8KRKllGGfNWcTHByoKv6R7gfHwP79CBe+mil7xth8LL2dUN99MAUAFHcW30stH1x0mg4rp50SJO68OsaSZLjJB9YW3jQErkWay5+yp0sGoe7uzR1gmmyiPpDoivWBllm92ermwCX2iCiHUc4n/fNUpBiUol8+IzSn1VWTlEt5kQIwVv722+t9m+Dlzi1Fhm8ikzYBfc6xdDRBXFNbbfj5W9Hdz6YGnXPs6/cqAcoeeHTAoHzeUYQ3c16GCmrMf2DOhntshevSYdAxrF3QbEx60hlSUib7EXDzGXh0OAL5P6G/nsr3Ly/p4o/CrZkZI8zWF1cpst8rHbU/TjBXRjXoRD4tBgEJn1iavqNVZHYJ2q1/uQ8mgbbbd6o2mij5K60GKHpwLZK+L37rT4Cdmnuv6lMRip tsJdgPO9 pg/CG62wwZflPBhiJ2fLcvWP81w7hBplisFX8IGBgezZzW1kgINVsGQoNKhhIPikYVUT+tdr6TpLqM1xCU4YzvLE6hSB1iwP8j+/hXhqBtBjL+5KS46WMHW2RkS7OsOqLQ0yUiySkhvQEDfltk9ztIDK7LOCt9kvZSuYS7Ctf9WNoBX5w9av1xxHxUSt9aJNUtNKphQyRciIVVd9tyxqaPZv/MzYxqsLHWgqgbMP8Wchl/Ek/j+J9kUyPAONC72bGwIYI8VmMQK23Af5/NurFV1vck/CPqGwut5XxRC01zMAbJWq9ITHcuexSR38oosN83bbXaO+Ka+4xq3ozzzSlhVjM3x/outuWWO6GoLb4pWPBD+Smk2wk000WyL/HREyGE/UTz/v3xLD0alQ5LnTniYBDwykVTxsx/jMunZ0qBJhpuRql398p9dHqlapj6pLUIeJ1m5ad+aVALL0OdFdyPucRlTSYZC0xZB/43Skh9oK4Xm48XAR0gDE6wglNAEYArZ6QO+JK1uDskaTC26Xg9YwL1PlV8dUpmedNL+kzYpRel/LqG3uJptCtvXhM+vf570utwoUH4KRCJeexUOGi0nmfefayNz5pvOpYEq12R7yyH+YwoDVTdE1Ev63ltci3LWMjWuZw1gDDkp9n88ldbxXLvwwrkrTRr4QOTu7dOljmo7d8run/KA4lE/GsvBpSu5lHLLd6AnI2nyg0kdY5msEceC9Do0FhwFgNlXLQBHTahma2yuJdI7aoU+c0boLf1AiquQ8VZJi4hwIMxMqLmanGUzWxiFyZhTx/Zux8U8cia0ICFfoAdjjE6OzZDsjCY9yTxMRZhyO881kCL4BI4qiXZdmrDlCN5RqKqX0erpr7JNflfCOUoDwzF1uEGxMVVcOgf6yrEJN9K+Lo3ShO5PPyVtrRJZ3EEHbqE6jDth7FSiMBUoazX5sHIvCQ5tsZXiuKvzhs+d/8Yabl5JAebHLknphN /7VYlO0T x3NbO0HQFzTV3QCI115bRwB17PH2Z7Mk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: commit ce4d9a1ea35ac5429e822c4106cb2859d5c71f3e upstream. Patch series "Fix kmemleak crashes when scanning CMA regions", v2. When trying to boot a device with an ARM64 kernel with the following config options enabled: CONFIG_DEBUG_PAGEALLOC=y CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT=y CONFIG_DEBUG_KMEMLEAK=y a crash is encountered when kmemleak starts to scan the list of gray or allocated objects that it maintains. Upon closer inspection, it was observed that these page-faults always occurred when kmemleak attempted to scan a CMA region. At the moment, kmemleak is made aware of CMA regions that are specified through the devicetree to be dynamically allocated within a range of addresses. However, kmemleak should not need to scan CMA regions or any reserved memory region, as those regions can be used for DMA transfers between drivers and peripherals, and thus wouldn't contain anything useful for kmemleak. Additionally, since CMA regions are unmapped from the kernel's address space when they are freed to the buddy allocator at boot when CONFIG_DEBUG_PAGEALLOC is enabled, kmemleak shouldn't attempt to access those memory regions, as that will trigger a crash. Thus, kmemleak should ignore all dynamically allocated reserved memory regions. This patch (of 1): Currently, kmemleak ignores dynamically allocated reserved memory regions that don't have a kernel mapping. However, regions that do retain a kernel mapping (e.g. CMA regions) do get scanned by kmemleak. This is not ideal for two reasons: 1 kmemleak works by scanning memory regions for pointers to allocated objects to determine if those objects have been leaked or not. However, reserved memory regions can be used between drivers and peripherals for DMA transfers, and thus, would not contain pointers to allocated objects, making it unnecessary for kmemleak to scan these reserved memory regions. 2 When CONFIG_DEBUG_PAGEALLOC is enabled, along with kmemleak, the CMA reserved memory regions are unmapped from the kernel's address space when they are freed to buddy at boot. These CMA reserved regions are still tracked by kmemleak, however, and when kmemleak attempts to scan them, a crash will happen, as accessing the CMA region will result in a page-fault, since the regions are unmapped. Thus, use kmemleak_ignore_phys() for all dynamically allocated reserved memory regions, instead of those that do not have a kernel mapping associated with them. Link: https://lkml.kernel.org/r/20230208232001.2052777-1-isaacmanjarres@google.com Link: https://lkml.kernel.org/r/20230208232001.2052777-2-isaacmanjarres@google.com Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") Signed-off-by: Isaac J. Manjarres Acked-by: Mike Rapoport (IBM) Acked-by: Catalin Marinas Cc: Frank Rowand Cc: Kirill A. Shutemov Cc: Nick Kossifidis Cc: Rafael J. Wysocki Cc: Rob Herring Cc: Russell King (Oracle) Cc: Saravana Kannan Cc: [5.15+] Signed-off-by: Andrew Morton --- drivers/of/of_reserved_mem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 9da8835ba5a5..9e949ddcb146 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -47,9 +47,10 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, err = memblock_mark_nomap(base, size); if (err) memblock_free(base, size); - kmemleak_ignore_phys(base); } + kmemleak_ignore_phys(base); + return err; }