From patchwork Sun Feb 19 07:33:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13145804 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CE5C636CC for ; Sun, 19 Feb 2023 07:33:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794EF6B0075; Sun, 19 Feb 2023 02:33:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 745B76B0078; Sun, 19 Feb 2023 02:33:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E6806B007B; Sun, 19 Feb 2023 02:33:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4E64B6B0075 for ; Sun, 19 Feb 2023 02:33:48 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B42581494 for ; Sun, 19 Feb 2023 07:33:48 +0000 (UTC) X-FDA: 80483226936.24.ED81985 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by imf30.hostedemail.com (Postfix) with ESMTP id 4B62F8000F for ; Sun, 19 Feb 2023 07:33:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="VIXw+j/9"; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676792026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A6ekRPQWIOO9h97zjQvvrZJ6rFQp5B1ODkwvrN46IL8=; b=qnBV0ujua4fI64FIBainOdfEtJRdNSE3/evqn9ZBPao9vrILQ0fwLeYrPFxSCEiz7I5UN+ 3qtoBXzS4ktlT1B0ji0l+iJYDX0INSQq7NiDt6w1DF97Lif/7HPtIORpd8cy+dnOCpt4l8 2PON4EAcqfqqhSyLqWvAuN8dxZC08UU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="VIXw+j/9"; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.160.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676792026; a=rsa-sha256; cv=none; b=Cv0vkt7M6lIS8l6Cbq1bJpPV6gInL0qjzaCKHhosxBUje72PtydX2iKaMy1YVAFKv9oCkt WS9m+2j9rVY0Z+rWf3KE267Cbsfif/EVbdRiTXXAIQTcgPyJ67drCXmRVU5eQQ2psilhx8 CGEguwG5IDICDi+7Y7fOPhjD/9azpyE= Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-171d9ff4af8so130819fac.2 for ; Sat, 18 Feb 2023 23:33:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A6ekRPQWIOO9h97zjQvvrZJ6rFQp5B1ODkwvrN46IL8=; b=VIXw+j/9K0ueRJ3XZk56qe8QOL0Cmpp7GG1nfaoqd3mrwXvQjCOiuvqI3MWGdIsqPh NaQSgSHqheGO1jZax3FsreUoTTAOxducCXCHLU9jQ1cnIjpNfQxt3HsFKsigcuIdyN3Y +9YWSZPcHl0mF+YL7hl2tQ35jopvi/ziMoQxKbIO7pHLy9syY3n4EDs0LsO2UAUkDTwN uG7VPb4moTRdlVk93TwqFHZU1f9QlzzuW2Y+BjvqunA5mn3GKnxB3ishhVrg4z1YNkFD /T8V5EU+PYcLGlt8OQeA+DQDK9MxHrY5tRy4KkGmItFO0ftXjFIOeHG2GLQdWaSb9onW oxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A6ekRPQWIOO9h97zjQvvrZJ6rFQp5B1ODkwvrN46IL8=; b=E5pZs0ki/h0vVRWuQ1mNAg77xHRftBf2PaREf4n4HTeh7e5Z9Tr6pArfua9o7441Jw JKLfDeO69bsxCvoEZ0CuiAUPJj7uPiD4fFsw238ExhwleFuNo/4irRjmjoNeNAG/opdT Ta7eLS8yiz5k6EQgsrcWTKs2JWQ8BjfDQsVFILhhtHO+AHyVl5gAApk2rn3OBDt15qCi WDP8Q0DRsNoyE/Mkmckl6GYBgK9TRujnXkoVsOfLtAA8BiByr1tRjp0xMTdEXwfXyOwE P0PDIxoefngdJ1MqL0lyxfPS4UMbGtBWV+/lHZwPL/WK+Wsac0rG7mXewNRUXmv9wEVs Lczg== X-Gm-Message-State: AO0yUKUVmwpWzewBHpBprVahtR1T0s/864MZphmP3xIExB0dytqrMIuH C/1vCxM7WETxa1xgK8Kph3ltgI7UKWU26g== X-Google-Smtp-Source: AK7set/euVT54/mP9eiDg5UqVSwppotAHlDPyulAeUH1zq9S122GwNodRLkwuxHh1XZXG6+8OX1bNA== X-Received: by 2002:a05:6870:a693:b0:16e:8556:41e4 with SMTP id i19-20020a056870a69300b0016e855641e4mr6822908oam.3.1676792025333; Sat, 18 Feb 2023 23:33:45 -0800 (PST) Received: from localhost (227.sub-174-197-65.myvzw.com. [174.197.65.227]) by smtp.gmail.com with ESMTPSA id r8-20020a056870624800b0016b7fe3be05sm3412107oak.39.2023.02.18.23.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Feb 2023 23:33:45 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, arnd@arndb.de, linux-api@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v10 3/3] selftests: Add selftests for cachestat Date: Sat, 18 Feb 2023 23:33:18 -0800 Message-Id: <20230219073318.366189-4-nphamcs@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230219073318.366189-1-nphamcs@gmail.com> References: <20230219073318.366189-1-nphamcs@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4B62F8000F X-Stat-Signature: 6wp594xeymtrms8pem7sfj7zrnq1i8dz X-HE-Tag: 1676792026-62093 X-HE-Meta: U2FsdGVkX19EWPNb3lD17EtfmBJj4MEeL9X1GvcEG14Faxk8NAyARuOBrpHcsMOuHGkuC8zpqeSBmf+YflmjXniRHpFjuruRKilt6/HpbKIEpQcZR9wctWRJ1WdnTGSYBr+qyMSr2Ms29yt5HxKXgR30Gf5gQNjoU6/48ObGC5EHV23up/j3ea1Noq6VtmXdMyvNqGQ2BxFYUYmJ0+Gspol4bkMlehpaGJmgIoP8ddQKKdId2LgyW7IDicJXvgAAGW7VrBJukpOAtaJs7KT6XNEx+CmTVFz+07FXPOrDq/MDh8F8DUwi2d3hQBp753voV+gwZOhFeqQzu3BE/ihq9mgfQTZCz2tcI7hPfc43ZRpI2cEC/8hpEM/VPvhZ0mRtVwpHfVTXs3kUfRuqOwrYFgAqW5ShEAdhta52upPLb2ZWUd++DxJmF+ganf+USoNBiBS7m2cucZExfLc6W2G6pNUNOvMGIJ64nQXqaLSlDujRvLwTSlXXSEsDmIBBHdV4h1OMt0djfsxojNarszSBsmu5y8qXMDOmLvKJtiOdbqSp1GB2Dj08K7+9uuCpdRXsapKfSWJ+V/1j/9ijRi6mH+hhJvW1y9zWnh0UDNDVquzwg8/pCZ245b7d8mDGW90LShPBcNRL6yuLZm3F3Zo0WJ3kgVi8wCR0nqLiS7wGGgBsBBErQtxiFPxPBgnk+0MJoDzgfSiTAQPVc4y9t/oF8vNeWl/DVLWcsAjrFhlqQcqFFaunPNoYlPy8oGSVGcGxOhsX9RPWtBEWnwmQHSI5W0KVO84j4lolnLJUs0nng8opPa2UVh9m4jbVXOuSjk5r4syJnCTXW1MMVnKhX2lGQpKFvaNXFC035yW4gHD5zQtp2mkXEbfm4ImBLBQQLEbjPt2ZmwaZju2M2VeVQfGip1hhxKBPGU5O8WHb5oMswY1OHlidh2uRqglchli44seHLRo7OPxLvUTXiMVY8+9 tLcioz0f rn/2e5j3Hx0TjCTCILNzrU4X3mWXeoPJPjFmpK6IpFliEKqJJcXp/eBb9ngtoXDwGGRQUGfHg7lOvEHIZMVQkAbvMa+mbGlWCyXlCKz19F5xjwASr5CI1OtZoKptPW7ZtchdORkSGn+VCJuVi5e5B6nlk/DaL6HpR0oyD8DwYcjencZ4PM/zPNr4l7kfi5HyxgwWxffAdeIGcKg0clRzsph4gnlOXb9pkLg/FArHr7Z7aoCPtrAPV5LUwbILYRLAF8TDWDIwptKeFhcd+cpZlDQwKLUlU/y7R38WgNye7nn3mnLKMctG6+7v9Zil0cNfygtltBLoFJlbynXC4r2CcO6s5M9o6HELo+PGXsWZWzZvwejvMgE7+YR9tLEDYtpK5C4MK7a/tB0Sx+X+wouZRvgkOgLnaUSJri+DoCnAXqZD09FxReblLsUmUUvCsK9vsVsI8M4QkQIT4xQgwes/7Q8oIKELJNr7sxmQuoI/i30Hoycm1tIqZ9Zg/ypaNu0mvdYEjDW63tShg/0jIj9lVsB3vWAPKh0x0FVgiXjxaf/f0XYgjtJz6HWl74bVVETTaTkGglxBnFCRhSWvHh/h8Ews2Uyc692IFd/qDLOSwBGjGLqowLcFROoERjuj5YNkJNrwz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Test cachestat on a newly created file, /dev/ files, and /proc/ files. Also test on a shmem file (which can also be tested with huge pages since tmpfs supports huge pages). Signed-off-by: Nhat Pham --- MAINTAINERS | 7 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cachestat/.gitignore | 2 + tools/testing/selftests/cachestat/Makefile | 8 + .../selftests/cachestat/test_cachestat.c | 256 ++++++++++++++++++ 5 files changed, 274 insertions(+) create mode 100644 tools/testing/selftests/cachestat/.gitignore create mode 100644 tools/testing/selftests/cachestat/Makefile create mode 100644 tools/testing/selftests/cachestat/test_cachestat.c -- 2.39.1 diff --git a/MAINTAINERS b/MAINTAINERS index a198da986146..792a866353ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4552,6 +4552,13 @@ S: Supported F: Documentation/filesystems/caching/cachefiles.rst F: fs/cachefiles/ +CACHESTAT: PAGE CACHE STATS FOR A FILE +M: Nhat Pham +M: Johannes Weiner +L: linux-mm@kvack.org +S: Maintained +F: tools/testing/selftests/cachestat/test_cachestat.c + CADENCE MIPI-CSI2 BRIDGES M: Maxime Ripard L: linux-media@vger.kernel.org diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 0464b2c6c1e4..3cad0b38c5c2 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -4,6 +4,7 @@ TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints +TARGETS += cachestat TARGETS += capabilities TARGETS += cgroup TARGETS += clone3 diff --git a/tools/testing/selftests/cachestat/.gitignore b/tools/testing/selftests/cachestat/.gitignore new file mode 100644 index 000000000000..d6c30b43a4bb --- /dev/null +++ b/tools/testing/selftests/cachestat/.gitignore @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +test_cachestat diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile new file mode 100644 index 000000000000..fca73aaa7d14 --- /dev/null +++ b/tools/testing/selftests/cachestat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +TEST_GEN_PROGS := test_cachestat + +CFLAGS += $(KHDR_INCLUDES) +CFLAGS += -Wall +CFLAGS += -lrt + +include ../lib.mk diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c new file mode 100644 index 000000000000..5d0fe5ae62f1 --- /dev/null +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -0,0 +1,256 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../kselftest.h" + +static const char * const dev_files[] = { + "/dev/zero", "/dev/null", "/dev/urandom", + "/proc/version", "/proc" +}; +static const int cachestat_nr = 451; + +void print_cachestat(struct cachestat *cs) +{ + ksft_print_msg( + "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n", + cs->nr_cache, cs->nr_dirty, cs->nr_writeback, + cs->nr_evicted, cs->nr_recently_evicted); +} + +bool write_exactly(int fd, size_t filesize) +{ + char data[filesize]; + bool ret = true; + int random_fd = open("/dev/urandom", O_RDONLY); + + if (random_fd < 0) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out; + } else { + int remained = filesize; + char *cursor = data; + + while (remained) { + ssize_t read_len = read(random_fd, cursor, remained); + + if (read_len <= 0) { + ksft_print_msg("Unable to read from urandom.\n"); + ret = false; + goto close_random_fd; + } + + remained -= read_len; + cursor += read_len; + } + + /* write random data to fd */ + remained = filesize; + cursor = data; + while (remained) { + ssize_t write_len = write(fd, cursor, remained); + + if (write_len <= 0) { + ksft_print_msg("Unable write random data to file.\n"); + ret = false; + goto close_random_fd; + } + + remained -= write_len; + cursor += write_len; + } + } + +close_random_fd: + close(random_fd); +out: + return ret; +} + +/* + * Open/create the file at filename, (optionally) write random data to it + * (exactly num_pages), then test the cachestat syscall on this file. + * + * If test_fsync == true, fsync the file, then check the number of dirty + * pages. + */ +bool test_cachestat(const char *filename, bool write_random, bool create, + bool test_fsync, unsigned long num_pages, int open_flags, + mode_t open_mode) +{ + size_t PS = sysconf(_SC_PAGESIZE); + int filesize = num_pages * PS; + bool ret = true; + long syscall_ret; + struct cachestat cs; + + int fd = open(filename, open_flags, open_mode); + + if (fd == -1) { + ksft_print_msg("Unable to create/open file.\n"); + goto out; + } else { + ksft_print_msg("Create/open %s\n", filename); + } + + if (write_random) { + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out1; + } + } + + syscall_ret = syscall(cachestat_nr, fd, filesize, 0, &cs, 0); + + ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto out1; + + } else { + print_cachestat(&cs); + + if (write_random) { + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + } + + if (test_fsync) { + if (fsync(fd)) { + ksft_print_msg("fsync fails.\n"); + ret = false; + } else { + syscall_ret = syscall(cachestat_nr, fd, filesize, 0, &cs, 0); + + ksft_print_msg("Cachestat call (after fsync) returned %ld\n", + syscall_ret); + + if (!syscall_ret) { + print_cachestat(&cs); + + if (cs.nr_dirty) { + ret = false; + ksft_print_msg( + "Number of dirty should be zero after fsync.\n"); + } + } else { + ksft_print_msg("Cachestat (after fsync) returned non-zero.\n"); + ret = false; + goto out1; + } + } + } + +out1: + close(fd); + + if (create) + remove(filename); +out: + return ret; +} + +bool test_cachestat_shmem(void) +{ + size_t PS = sysconf(_SC_PAGESIZE); + size_t filesize = PS * 512 * 2; /* 2 2MB huge pages */ + int syscall_ret; + off_t off = PS; + size_t compute_len = PS * 512; + char *filename = "tmpshmcstat"; + struct cachestat cs; + bool ret = true; + unsigned long num_pages = compute_len / PS; + int fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + + if (fd < 0) { + ksft_print_msg("Unable to create shmem file.\n"); + ret = false; + goto out; + } + + if (ftruncate(fd, filesize)) { + ksft_print_msg("Unable to trucate shmem file.\n"); + ret = false; + goto close_fd; + } + + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to write to shmem file.\n"); + ret = false; + goto close_fd; + } + + syscall_ret = syscall(cachestat_nr, fd, compute_len, off, &cs, 0); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto close_fd; + } else { + print_cachestat(&cs); + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + +close_fd: + shm_unlink(filename); +out: + return ret; +} + +int main(void) +{ + int ret = 0; + + for (int i = 0; i < 5; i++) { + const char *dev_filename = dev_files[i]; + + if (test_cachestat(dev_filename, false, false, false, + 4, O_RDONLY, 0400)) + ksft_test_result_pass("cachestat works with %s\n", dev_filename); + else { + ksft_test_result_fail("cachestat fails with %s\n", dev_filename); + ret = 1; + } + } + + if (test_cachestat("tmpfilecachestat", true, true, + true, 4, O_CREAT | O_RDWR, 0400 | 0600)) + ksft_test_result_pass("cachestat works with a normal file\n"); + else { + ksft_test_result_fail("cachestat fails with normal file\n"); + ret = 1; + } + + if (test_cachestat_shmem()) + ksft_test_result_pass("cachestat works with a shmem file\n"); + else { + ksft_test_result_fail("cachestat fails with a shmem file\n"); + ret = 1; + } + + return ret; +}