From patchwork Wed Mar 1 10:22:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13155805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84EC1C64EC7 for ; Wed, 1 Mar 2023 10:22:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBABE6B0073; Wed, 1 Mar 2023 05:22:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D42F66B0074; Wed, 1 Mar 2023 05:22:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6ED46B0075; Wed, 1 Mar 2023 05:22:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98D3B6B0073 for ; Wed, 1 Mar 2023 05:22:30 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 65C881215B1 for ; Wed, 1 Mar 2023 10:22:30 +0000 (UTC) X-FDA: 80519940060.08.1987E9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 8A52840013 for ; Wed, 1 Mar 2023 10:22:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P0uPbH03; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677666148; a=rsa-sha256; cv=none; b=RlqWDUstkxuLWtYxYKPh8SBj8lEgpJi9mbwyft+7P48tEwUd+e0OAJR55USGusGeo7QKdf uBp2Brhd8v3C4pCE6ksZa0lXp4ynwO8R8tze0/2N+SmPIsgXS2fOTTct7/NEAn2NyM3bCq rw8d0G1tUiEJQgG4WWCb5Da1WQEpM68= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P0uPbH03; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677666148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XOyiQKIdMnvfgHK0+JM6b4NpBz3+X6fBNBNCgpa23Zk=; b=nlrSlrpwuHaokU9/nuCAfAiA9e3ofyt76MkPZ4kJH+STHNUZtJ46to5+fXS9xf9bcmgmOM Dofat8VpAgrLTS5T9PWXnrlrhtYmj1Oep+W2YSI/A1g6hRrDphOL0vZNwmZuk8CjI9zliv sGN0ApRlpWHYB4DsHp+mvPaalIDmNSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677666147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XOyiQKIdMnvfgHK0+JM6b4NpBz3+X6fBNBNCgpa23Zk=; b=P0uPbH03xmg5PExl8DSeKS3KOxRGdu6kYX4YemvVXvOgsZ6etEgNGwSaSTsdwcbfFqKWb0 nr9a4t3b8R58oKXnOlt4cozAT2P0CMcJ2ZS/2ksiMKptRrUOgrPwavGIomeNxOeUGBZHTr 7LYe448yQ1bMpxcs9a2K0FCCJqVdmtA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-jPx6-0M8MLWGe2Rl2uX8Wg-1; Wed, 01 Mar 2023 05:22:24 -0500 X-MC-Unique: jPx6-0M8MLWGe2Rl2uX8Wg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59A9F864761; Wed, 1 Mar 2023 10:22:24 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-13-180.pek2.redhat.com [10.72.13.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44439492C18; Wed, 1 Mar 2023 10:22:20 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, geert@linux-m68k.org, hch@infradead.org, mcgrof@kernel.org, Baoquan He Subject: [PATCH v2 2/2] arch/*/io.h: remove ioremap_uc in some architectures Date: Wed, 1 Mar 2023 18:22:08 +0800 Message-Id: <20230301102208.148490-3-bhe@redhat.com> In-Reply-To: <20230301102208.148490-1-bhe@redhat.com> References: <20230301102208.148490-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspam-User: X-Rspamd-Queue-Id: 8A52840013 X-Rspamd-Server: rspam01 X-Stat-Signature: c3iwc9thi61pau39kigjqeamxxpp4f3r X-HE-Tag: 1677666148-917372 X-HE-Meta: U2FsdGVkX19CPTDmDxBYmhF/nPudGvTF9SSmXKy+gqJ2H+fcDNyMal5h4HpyyWq/G4bbk7dGdUUeLsRG92R4nUMhLMwoPdEqBT01GhO6mfA5SkubAjU255Iv/G4vL9A1eBIPgdFNQFp1deRX/4kTz6k8yIig2AbZ+uO2pgFkb8d4QOXB9YTYuA/6stVsMcjQFtvH2cJJE/5DS9t28mlt002lgK+MxqIgMD3L7uX70t5EV7sKHGNtQBQNXm7w0umCZ65+nPWaMXTCRWUkL3qX1HzjgSsYHGjv6TjLoNfwGBzMyYqP/iiw48xfNupZFAO8uRKQaSJzTj/Tac6TWAlq/OYYb+ztv2+Emuyqgn2dJI+0pwqEvZnYZ3dWIuZmxjzawKvjcplT7BQ+Y4n0ooifNQkFPylBuvVfTHQCy6KfD2CEgtU3IGHwH8l4AgrzFeibC7LHoDH3PyMJR1BXaiIGx/gaiH4CuJLy8OT1v+y908Xi+VfF2DszJtTUrVgHuhEHzE6StVF7JGBDkVE/mvXHkhraYOo6eToje/aR/BNpGnDXGnod0q+TH6AnkVqG32cgmQ7jxfdm8tusc9SazDyxE+Upb9FdDqMM3Xt+qGrgLvi9R86UxpvEiGRTrsFbMnu20AJjrCqC51goIO4s5wIfIfXISitfmpJq45b52y8w10hUWRpesR7aEk98gPmKOS8FcFL8fNExbXbUHV0liiZBRd/OY4p38W5nzXcjtT2jWpfhTR9OXh04Y660YnIEupfHdqDoAY9eyarMH/yveQLtf2R/twSKFhWXWrubrK8yqYAzKL2rijoUCg8tEfN2unxHRb9znRUFXhadSizSfs1rw4R/rRth8Baib+NvAmaxcjg09ZBoEm/tRlQ3n44XVJk6J9AFJhchI04joZwttkfa7uUl5vJO/hJQ+iZw+CbMhfs6lNVa2yuV+eL5oCXjdL/4JwbFOZjb9o1cNOuMCZI T+ywpVKy CBYSY+9iKlm5A/5/qPswGvFUes+tj9t4U45unhFhJIdRTW5QT6ViVO99ood1/utXSzFccZmxOuP/7NgQLtegYlHqnOTnSJm6gZEzbgOCu35VzOAyasVTWkcgnjIvoNAi+AY4qcTgCV3EfOpTEik1JkuNQ4HDAz9GZflk1dY4T6AhTmj5dX/v9xuuv3KHU6ogfZOKM0OYAjQYCUhE786+1VywLe+FoGwwCW+0e45/uUrTdbKJPsL3fIufrQWDFVmn1P/v5i09UeuLLwCF7M+HIeDHgf8O4u9dXFhSkCGAnlrihBGXVaAHYLHgju5Rzj9yqdLkjagfdiKloYJPahxwnFEipgG+o8+40XR16jW6Htgg33SQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Here, remove the ioremap_uc() definition in architecutures other than x86 and ia64. These architectures all have asm-generic/io.h included and will have the default ioremap_uc() definition which returns NULL. Note: This changes the existing behaviour and could break code calling ioremap_uc(). If any ARCH meets this breakage and really needs a specific ioremap_uc() for its own usage, one ioremap_uc() can be added in the ARCH. Link: https://lore.kernel.org/all/20191112105507.GA7122@lst.de/#t Signed-off-by: Baoquan He Acked-by: Geert Uytterhoeven --- Documentation/driver-api/device-io.rst | 11 +++++++++-- arch/alpha/include/asm/io.h | 1 - arch/hexagon/include/asm/io.h | 3 --- arch/m68k/include/asm/kmap.h | 1 - arch/mips/include/asm/io.h | 1 - arch/parisc/include/asm/io.h | 2 -- arch/powerpc/include/asm/io.h | 1 - arch/sh/include/asm/io.h | 2 -- arch/sparc/include/asm/io_64.h | 1 - 9 files changed, 9 insertions(+), 14 deletions(-) diff --git a/Documentation/driver-api/device-io.rst b/Documentation/driver-api/device-io.rst index 4d2baac0311c..ec37faa37a37 100644 --- a/Documentation/driver-api/device-io.rst +++ b/Documentation/driver-api/device-io.rst @@ -408,9 +408,16 @@ functions for details on the CPU side of things. ioremap_uc() ------------ -ioremap_uc() behaves like ioremap() except that on the x86 architecture without +ioremap_uc() behaves like ioremap() except that on x86 architecture without 'PAT' mode, it marks memory as uncached even when the MTRR has designated -it as cacheable, see Documentation/x86/pat.rst. +it as cacheable, see Documentation/x86/pat.rst, and on ia64 which checks if +attributes don't match. + + +ioremap_uc() behaves like ioremap() except that on x86 and ia64 architectures. +X86 non-PAT system marks memory as uncached even when the MTRR has designated +it as cacheable in ioremap_uc()(see Documentation/x86/pat.rst). While ia64 +system firstly checks if attributes match ioremap_uc(), otherwise fails. Portable drivers should avoid the use of ioremap_uc(). diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h index 7aeaf7c30a6f..076f0e4e7f1e 100644 --- a/arch/alpha/include/asm/io.h +++ b/arch/alpha/include/asm/io.h @@ -308,7 +308,6 @@ static inline void __iomem *ioremap(unsigned long port, unsigned long size) } #define ioremap_wc ioremap -#define ioremap_uc ioremap static inline void iounmap(volatile void __iomem *addr) { diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h index dcd9cbbf5934..b9847472f25c 100644 --- a/arch/hexagon/include/asm/io.h +++ b/arch/hexagon/include/asm/io.h @@ -176,9 +176,6 @@ static inline void writel(u32 data, volatile void __iomem *addr) #define _PAGE_IOREMAP (_PAGE_PRESENT | _PAGE_READ | _PAGE_WRITE | \ (__HEXAGON_C_DEV << 6)) -#define ioremap_uc(addr, size) ioremap((addr), (size)) - - #define __raw_writel writel static inline void memcpy_fromio(void *dst, const volatile void __iomem *src, diff --git a/arch/m68k/include/asm/kmap.h b/arch/m68k/include/asm/kmap.h index 4efb3efa593a..b778f015c917 100644 --- a/arch/m68k/include/asm/kmap.h +++ b/arch/m68k/include/asm/kmap.h @@ -25,7 +25,6 @@ static inline void __iomem *ioremap(unsigned long physaddr, unsigned long size) return __ioremap(physaddr, size, IOMAP_NOCACHE_SER); } -#define ioremap_uc ioremap #define ioremap_wt ioremap_wt static inline void __iomem *ioremap_wt(unsigned long physaddr, unsigned long size) diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h index 3737b48f37dd..9d93e27f7c82 100644 --- a/arch/mips/include/asm/io.h +++ b/arch/mips/include/asm/io.h @@ -167,7 +167,6 @@ void iounmap(const volatile void __iomem *addr); */ #define ioremap(offset, size) \ ioremap_prot((offset), (size), _CACHE_UNCACHED) -#define ioremap_uc ioremap /* * ioremap_cache - map bus memory into CPU space diff --git a/arch/parisc/include/asm/io.h b/arch/parisc/include/asm/io.h index 366537042465..48630c78714a 100644 --- a/arch/parisc/include/asm/io.h +++ b/arch/parisc/include/asm/io.h @@ -132,8 +132,6 @@ static inline void gsc_writeq(unsigned long long val, unsigned long addr) #define ioremap_wc(addr, size) \ ioremap_prot((addr), (size), _PAGE_IOREMAP) -#define ioremap_uc(addr, size) \ - ioremap_prot((addr), (size), _PAGE_IOREMAP) #define pci_iounmap pci_iounmap diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h index 978d687edf32..7873fc83c82c 100644 --- a/arch/powerpc/include/asm/io.h +++ b/arch/powerpc/include/asm/io.h @@ -863,7 +863,6 @@ void __iomem *ioremap_wt(phys_addr_t address, unsigned long size); #endif void __iomem *ioremap_coherent(phys_addr_t address, unsigned long size); -#define ioremap_uc(addr, size) ioremap((addr), (size)) #define ioremap_cache(addr, size) \ ioremap_prot((addr), (size), pgprot_val(PAGE_KERNEL)) diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index b3a26b405c8d..12a892804082 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -278,8 +278,6 @@ unsigned long long poke_real_address_q(unsigned long long addr, ioremap_prot((addr), (size), pgprot_val(PAGE_KERNEL)) #endif /* CONFIG_MMU */ -#define ioremap_uc ioremap - /* * Convert a physical pointer to a virtual kernel pointer for /dev/mem * access diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h index 9303270b22f3..d8ee1442f303 100644 --- a/arch/sparc/include/asm/io_64.h +++ b/arch/sparc/include/asm/io_64.h @@ -423,7 +423,6 @@ static inline void __iomem *ioremap(unsigned long offset, unsigned long size) return (void __iomem *)offset; } -#define ioremap_uc(X,Y) ioremap((X),(Y)) #define ioremap_wc(X,Y) ioremap((X),(Y)) #define ioremap_wt(X,Y) ioremap((X),(Y)) static inline void __iomem *ioremap_np(unsigned long offset, unsigned long size)