| Message ID | 20230302025349.358341-1-anshuman.khandual@arm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/migrate: Drop pte_mkhuge() in remove_migration_pte() | expand |
On 02.03.23 03:53, Anshuman Khandual wrote: > Since the following commit, arch_make_huge_pte() should be used directly in > generic memory subsystem as a platform provided page table helper, instead > of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(), > which has now become redundant. > > 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu> > Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > This applies on latest mainline. > > mm/migrate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 37865f85df6d..d3964c414010 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio, > if (folio_test_hugetlb(folio)) { > unsigned int shift = huge_page_shift(hstate_vma(vma)); > > - pte = pte_mkhuge(pte); > pte = arch_make_huge_pte(pte, shift, vma->vm_flags); > if (folio_test_anon(folio)) > hugepage_add_anon_rmap(new, vma, pvmw.address, Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/migrate.c b/mm/migrate.c index 37865f85df6d..d3964c414010 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio, if (folio_test_hugetlb(folio)) { unsigned int shift = huge_page_shift(hstate_vma(vma)); - pte = pte_mkhuge(pte); pte = arch_make_huge_pte(pte, shift, vma->vm_flags); if (folio_test_anon(folio)) hugepage_add_anon_rmap(new, vma, pvmw.address,
Since the following commit, arch_make_huge_pte() should be used directly in generic memory subsystem as a platform provided page table helper, instead of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(), which has now become redundant. 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' Cc: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu> Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- This applies on latest mainline. mm/migrate.c | 1 - 1 file changed, 1 deletion(-)