From patchwork Wed Mar 8 03:27:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13165173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F090C6FD20 for ; Wed, 8 Mar 2023 03:28:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A864280004; Tue, 7 Mar 2023 22:28:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25811280002; Tue, 7 Mar 2023 22:28:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F939280004; Tue, 7 Mar 2023 22:28:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 01978280002 for ; Tue, 7 Mar 2023 22:28:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C30DB160449 for ; Wed, 8 Mar 2023 03:28:04 +0000 (UTC) X-FDA: 80544297288.09.70DADF6 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf13.hostedemail.com (Postfix) with ESMTP id E833F20009 for ; Wed, 8 Mar 2023 03:28:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kUKIsUtS; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678246082; a=rsa-sha256; cv=none; b=SCK+gFjI8GxT47GPH5Ka3+ybWMpqGiy/H2eykQheDtRqk97PzcOwhzvXO/D3zMmb5wW8I1 290NNEFVozEwL4R06rKQ4fz4P+PE28mjjwjxZK3kRpY6AlUId6IfRNVQbJvfz/ppTezyv9 Ew10P/LdYPqjfqlFidJDJTspbOeh2O4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kUKIsUtS; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678246082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZJj61gxvsnAstCshIubsPwP+A0RbNepTL+cBruG18fI=; b=P+Ac3WUpgUXW9XJBv4MdlzKjgWXvnT4wZpnFTDNVLjqYarq6h7r8viP0Dg+QGsOj7s3bcZ bSiTE9dUFQ5Qz32LUVK1n8ZDf0JOCwstkJN5qlU5iaYYzFVKExoDitp7t50YV61yztIB2P VdFDz41bFlN270SUG62zubrnRL/Tlpo= Received: by mail-pj1-f46.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so752844pjp.2 for ; Tue, 07 Mar 2023 19:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678246081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZJj61gxvsnAstCshIubsPwP+A0RbNepTL+cBruG18fI=; b=kUKIsUtSoY9R865fkCKNln1t0/fKx/SCe94OH795eL5Lfa+Nn1+J+Lj7ehZ6gy3zpG OLJ4Qv6mjQm6sLq0vEYlsRVMYvB7xp7X6G74y1NQgyaFHoXeRR3pNmFSfJK5mJvXcij9 92MZUnJqOstODkwyhg9NA9hC4EHkOnZtX0uGftovs4WKe++q950nzDQEq3E9bpAhocyH znmndCfttp+xFyqLHbGhIvp0K9frH0qnHZpE0s5JUIvOlUORaNTbO/FyJpzU947Kbkkr B/R+RhJWNDMsrOhzNAzFgyU8cfdEB1unkN/XgFKj68j19zz7KrnYAuBSzhN0K2NbMgTd ttRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678246081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZJj61gxvsnAstCshIubsPwP+A0RbNepTL+cBruG18fI=; b=c+6rycUFBeHwJAtWeSSO+lsXX8Vi4SRqqmRQzm7A7OBubki+VvLQacsKUnPfaQGp1Y 2w+bo8pO04D09wmb+5PGivgtVEJuyQvd/v5ic1j3KavAZGaVkr4ZJ5AEyCyMgpSvz4Av BTx/27A3Z56cRNi+dR0ozXuUAA6VTTlijggh+I9V5mROD4Nro322gptT/XYVor3d2M5z lNfHfZWLpNmvG7fzduQ3SEpAQPjdxHsNBlh5rudalJVcitHdXomvQWZTdx+OXMypu+pj 8eDkcwnYZ6GOTnSx1iw2mlJqcNgK44iwFK7Qhq3A4Mb+ePHkq7QazQgJGdMWT+YC1VI3 FJNw== X-Gm-Message-State: AO0yUKVddiYGX5k+PRYuw8tMMEM/j0MmefgQK6xBPdFYk0eu1UF90uDQ UorwybY9vDf/16DHAc0KdB0= X-Google-Smtp-Source: AK7set+8SnebsneKhPvyDFp5O084nHnP6g0GvM4DJ6TX2M7C6M6QYy1qnIil9ZUCnpZgvyB1FzHs7w== X-Received: by 2002:a17:902:a416:b0:19e:b5d3:170f with SMTP id p22-20020a170902a41600b0019eb5d3170fmr9392693plq.4.1678246080761; Tue, 07 Mar 2023 19:28:00 -0800 (PST) Received: from localhost ([113.161.42.54]) by smtp.gmail.com with ESMTPSA id y8-20020a170902700800b001993a1fce7bsm8966354plk.196.2023.03.07.19.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 19:28:00 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, arnd@arndb.de, linux-api@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v11 3/3] selftests: Add selftests for cachestat Date: Tue, 7 Mar 2023 19:27:48 -0800 Message-Id: <20230308032748.609510-4-nphamcs@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230308032748.609510-1-nphamcs@gmail.com> References: <20230308032748.609510-1-nphamcs@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E833F20009 X-Rspamd-Server: rspam01 X-Stat-Signature: 1mg7uf18kmcs5us848erirs81767d3np X-HE-Tag: 1678246081-534367 X-HE-Meta: U2FsdGVkX19vrqI+4LF9PSjhgrKTYTFXLmO/zJFXnG2/4nrtmPMpEqqIhTCC9HPZ/dp/RGTJU64jr6sAGar8wPyPUKS6DQRVapj1dKYuDDIBooINAxOxLjja2vSf7/zQdeXLlNDfs2CgNnBMfYR43klzUpXC9UFZdUC/dtN9sR320QTrTBJ1Pr1o7gbkECix7yHBdE40LEEe1R2LKPS6oWqBXxSFDuWDI5pj7IXjMQa1wuZjzKHLqFxUAxak9qiYkkEo/iD7cANGUvmkYkpjM8mkmfGLidJxuOsZx8c+esF4YTDuM4pXOqEev6aaJAmbd7Vzi3cuapxsjPxztovI5YYo4JC4tw7Ywv3pZiIMe+E/cwEmR/fULhcpBQrrJpMAwe0i3U0IeYigoX0+zmVfSQHwI6szGyg1MWNnmXwNkOPaHfYC9ROE9eU0XwdyxZnp3hn9uxljsCGBBzWSj1PqVBTYVhHToq+15Gc1Xsat6LLmMJRoNjO9SeO8PFlzsE8HZ+Uimdpldo6oHzLn+puFSsVcTZIK3qG8QvuNmw68SX62XKKtWP7vJJZowc1fyTP9xYGyEUj7p35ANXO8ibbxZVJWQuAPeWzCpJ9uyv2kQ34cu+Esl6k0O8c8OWgDrECr2JgDQdJpUolMQz6rubgUTxdPYGFvn5JFQDpOEeL/AnLpqp1WmM72e2nuRL6ds6y32PWhVnBOLGCOnD2qwzuX9PnAHeOAPJtMHW+8rvznIy2uH7X6PozZyfiLZhqEBNtdT3b9WuNMOI+Dts39U5s6LUmyd7ieTakjiJA04zrpU0DieE9KRJFnVGMoUyJZClfzvG/1hLUmveEEGHJeCjyAxGFt168HzSQdVwDcZ4IGMThZqcJs8sWW+hU74lre0btfx7fIxajYPvKn+RG0qz5FzEeHjH3+MGQMcoBF/S3eY1FqpuR0CLW8ZDpvC88lIOfD15WQtQ7mpy8V4si7YaX vis0sDM8 wt5W20jJD/0ikf4wm/EpOB97umdzvlKc3jDLYW6BwZP5w9ctzk/LmoNcCYDRyAbc+0T64FbBE72WODBJcV+xp6GTPTCyI9hL8QeuuRN2A08F1wIyNKw52RYAjfih3FeMCmaz/tjD0EJyk2jA9pRA9IGF7VoTytYkiVJtqZWnE78WlSj96GXbTUjnzs8k7DLjkBrzL98M+y8zDTFeGInrF/ZowvNqR+NDJs5b4Z4mjVnT+lJpdWe09iLlgonECqoNt/GKGz9Ej+/xDvS0buIyNNutgqxz5drzVu6DLMdrhRvPpsixyheLU3n3mVDwKYYtpKbt0+DgL7niBzlRd6TQ3lb52ihDbIhhSsoqomoM/r7ZLjTJwUuyUa0aZAcbvVeoQSJyu3dAqoUBWlkn8poWOFAr771DDdc5EqmuVCSlmaVzgDFDEt0ol94CAIWZ82GJz+TJ8Hep/ru2AWZ9IYDRr7YYH4jgW7BrX8MjhBTugpFmo5Cek7Ns9BPdeWfSu5oji+1EC4mF8uDmwWTR5x7sJmpt/0mjgwEJA4HXHEnvhblwcfRwzZpUx/0sEQ8+kxHKTH37EQ4rzlCocd0IDYrOq3mrxX3utkcUHLv6wUumfCV2Tr7vskq9GR2Cxl+yiCQGGdQHE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Test cachestat on a newly created file, /dev/ files, and /proc/ files. Also test on a shmem file (which can also be tested with huge pages since tmpfs supports huge pages). Signed-off-by: Nhat Pham --- MAINTAINERS | 7 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cachestat/.gitignore | 2 + tools/testing/selftests/cachestat/Makefile | 8 + .../selftests/cachestat/test_cachestat.c | 257 ++++++++++++++++++ 5 files changed, 275 insertions(+) create mode 100644 tools/testing/selftests/cachestat/.gitignore create mode 100644 tools/testing/selftests/cachestat/Makefile create mode 100644 tools/testing/selftests/cachestat/test_cachestat.c -- 2.39.2 diff --git a/MAINTAINERS b/MAINTAINERS index a198da986146..792a866353ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4552,6 +4552,13 @@ S: Supported F: Documentation/filesystems/caching/cachefiles.rst F: fs/cachefiles/ +CACHESTAT: PAGE CACHE STATS FOR A FILE +M: Nhat Pham +M: Johannes Weiner +L: linux-mm@kvack.org +S: Maintained +F: tools/testing/selftests/cachestat/test_cachestat.c + CADENCE MIPI-CSI2 BRIDGES M: Maxime Ripard L: linux-media@vger.kernel.org diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 0464b2c6c1e4..3cad0b38c5c2 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -4,6 +4,7 @@ TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints +TARGETS += cachestat TARGETS += capabilities TARGETS += cgroup TARGETS += clone3 diff --git a/tools/testing/selftests/cachestat/.gitignore b/tools/testing/selftests/cachestat/.gitignore new file mode 100644 index 000000000000..d6c30b43a4bb --- /dev/null +++ b/tools/testing/selftests/cachestat/.gitignore @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +test_cachestat diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile new file mode 100644 index 000000000000..fca73aaa7d14 --- /dev/null +++ b/tools/testing/selftests/cachestat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +TEST_GEN_PROGS := test_cachestat + +CFLAGS += $(KHDR_INCLUDES) +CFLAGS += -Wall +CFLAGS += -lrt + +include ../lib.mk diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c new file mode 100644 index 000000000000..f62ffb30f8ca --- /dev/null +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -0,0 +1,257 @@ +// SPDX-License-Identifier: GPL-2.0 +#define _GNU_SOURCE + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../kselftest.h" + +static const char * const dev_files[] = { + "/dev/zero", "/dev/null", "/dev/urandom", + "/proc/version", "/proc" +}; +static const int cachestat_nr = 451; + +void print_cachestat(struct cachestat *cs) +{ + ksft_print_msg( + "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicted: %lu, Recently Evicted: %lu\n", + cs->nr_cache, cs->nr_dirty, cs->nr_writeback, + cs->nr_evicted, cs->nr_recently_evicted); +} + +bool write_exactly(int fd, size_t filesize) +{ + char data[filesize]; + bool ret = true; + int random_fd = open("/dev/urandom", O_RDONLY); + + if (random_fd < 0) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out; + } else { + int remained = filesize; + char *cursor = data; + + while (remained) { + ssize_t read_len = read(random_fd, cursor, remained); + + if (read_len <= 0) { + ksft_print_msg("Unable to read from urandom.\n"); + ret = false; + goto close_random_fd; + } + + remained -= read_len; + cursor += read_len; + } + + /* write random data to fd */ + remained = filesize; + cursor = data; + while (remained) { + ssize_t write_len = write(fd, cursor, remained); + + if (write_len <= 0) { + ksft_print_msg("Unable write random data to file.\n"); + ret = false; + goto close_random_fd; + } + + remained -= write_len; + cursor += write_len; + } + } + +close_random_fd: + close(random_fd); +out: + return ret; +} + +/* + * Open/create the file at filename, (optionally) write random data to it + * (exactly num_pages), then test the cachestat syscall on this file. + * + * If test_fsync == true, fsync the file, then check the number of dirty + * pages. + */ +bool test_cachestat(const char *filename, bool write_random, bool create, + bool test_fsync, unsigned long num_pages, int open_flags, + mode_t open_mode) +{ + size_t PS = sysconf(_SC_PAGESIZE); + int filesize = num_pages * PS; + bool ret = true; + long syscall_ret; + struct cachestat cs; + + int fd = open(filename, open_flags, open_mode); + + if (fd == -1) { + ksft_print_msg("Unable to create/open file.\n"); + ret = false; + goto out; + } else { + ksft_print_msg("Create/open %s\n", filename); + } + + if (write_random) { + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to access urandom.\n"); + ret = false; + goto out1; + } + } + + syscall_ret = syscall(cachestat_nr, fd, filesize, 0, &cs, 0); + + ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto out1; + + } else { + print_cachestat(&cs); + + if (write_random) { + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + } + + if (test_fsync) { + if (fsync(fd)) { + ksft_print_msg("fsync fails.\n"); + ret = false; + } else { + syscall_ret = syscall(cachestat_nr, fd, filesize, 0, &cs, 0); + + ksft_print_msg("Cachestat call (after fsync) returned %ld\n", + syscall_ret); + + if (!syscall_ret) { + print_cachestat(&cs); + + if (cs.nr_dirty) { + ret = false; + ksft_print_msg( + "Number of dirty should be zero after fsync.\n"); + } + } else { + ksft_print_msg("Cachestat (after fsync) returned non-zero.\n"); + ret = false; + goto out1; + } + } + } + +out1: + close(fd); + + if (create) + remove(filename); +out: + return ret; +} + +bool test_cachestat_shmem(void) +{ + size_t PS = sysconf(_SC_PAGESIZE); + size_t filesize = PS * 512 * 2; /* 2 2MB huge pages */ + int syscall_ret; + off_t off = PS; + size_t compute_len = PS * 512; + char *filename = "tmpshmcstat"; + struct cachestat cs; + bool ret = true; + unsigned long num_pages = compute_len / PS; + int fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + + if (fd < 0) { + ksft_print_msg("Unable to create shmem file.\n"); + ret = false; + goto out; + } + + if (ftruncate(fd, filesize)) { + ksft_print_msg("Unable to trucate shmem file.\n"); + ret = false; + goto close_fd; + } + + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to write to shmem file.\n"); + ret = false; + goto close_fd; + } + + syscall_ret = syscall(cachestat_nr, fd, compute_len, off, &cs, 0); + + if (syscall_ret) { + ksft_print_msg("Cachestat returned non-zero.\n"); + ret = false; + goto close_fd; + } else { + print_cachestat(&cs); + if (cs.nr_cache + cs.nr_evicted != num_pages) { + ksft_print_msg( + "Total number of cached and evicted pages is off.\n"); + ret = false; + } + } + +close_fd: + shm_unlink(filename); +out: + return ret; +} + +int main(void) +{ + int ret = 0; + + for (int i = 0; i < 5; i++) { + const char *dev_filename = dev_files[i]; + + if (test_cachestat(dev_filename, false, false, false, + 4, O_RDONLY, 0400)) + ksft_test_result_pass("cachestat works with %s\n", dev_filename); + else { + ksft_test_result_fail("cachestat fails with %s\n", dev_filename); + ret = 1; + } + } + + if (test_cachestat("tmpfilecachestat", true, true, + true, 4, O_CREAT | O_RDWR, 0400 | 0600)) + ksft_test_result_pass("cachestat works with a normal file\n"); + else { + ksft_test_result_fail("cachestat fails with normal file\n"); + ret = 1; + } + + if (test_cachestat_shmem()) + ksft_test_result_pass("cachestat works with a shmem file\n"); + else { + ksft_test_result_fail("cachestat fails with a shmem file\n"); + ret = 1; + } + + return ret; +}