[v5,7/8] mm: vmscan: remove shrinker_rwsem from synchronize_shrinkers()

Commit Message

Qi Zheng March 13, 2023, 11:28 a.m. UTC

Currently, the synchronize_shrinkers() is only used by TTM
pool. It only requires that no shrinkers run in parallel,
and doesn't care about registering and unregistering of
shrinkers.

Since slab shrink is protected by SRCU, synchronize_srcu()
is sufficient to ensure that no shrinker is running in
parallel. So the shrinker_rwsem in synchronize_shrinkers()
is no longer needed, just remove it.

Signed-off-by: Qi Zheng <[e-mail]>
Acked-by: Vlastimil Babka <[e-mail]>
Acked-by: Kirill Tkhai <[e-mail]>
---
 mm/vmscan.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Patch

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 8c1ae7ea8dea..2b22a42d83c4 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -790,15 +790,11 @@  EXPORT_SYMBOL(unregister_shrinker);
 /**
  * synchronize_shrinkers - Wait for all running shrinkers to complete.
  *
- * This is equivalent to calling unregister_shrink() and register_shrinker(),
- * but atomically and with less overhead. This is useful to guarantee that all
- * shrinker invocations have seen an update, before freeing memory, similar to
- * rcu.
+ * This is useful to guarantee that all shrinker invocations have seen an
+ * update, before freeing memory.
  */
 void synchronize_shrinkers(void)
 {
-	down_write(&shrinker_rwsem);
-	up_write(&shrinker_rwsem);
 	atomic_inc(&shrinker_srcu_generation);
 	synchronize_srcu(&shrinker_srcu);
 }