From patchwork Mon Mar 13 16:25:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 13172857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EB6C61DA4 for ; Mon, 13 Mar 2023 16:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15886B0085; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9BD56B0089; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 960AF6B008A; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B93D6B0085 for ; Mon, 13 Mar 2023 12:27:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B05AA120C0C for ; Mon, 13 Mar 2023 16:27:49 +0000 (UTC) X-FDA: 80564406258.10.8C43D2C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id E25CA80017 for ; Mon, 13 Mar 2023 16:27:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R9glNPjQ; spf=pass (imf02.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678724867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=iUvNynje4NLXuVViJqGVXz34mfwfY1r+EmC29iXiBlQ=; b=4oQtwdfhDtmRySahNTjHTZp/pLgf5DxrRbskxg1WxT2L+7Grp3jpwmtQ3lBATfiCvAGo7T GANQV6jtaUp2nGmbgojJ99ncrkfqxyl8gC1VSdii630HOCGcigS9mAL2u3YpKcsIib9SgV 0yhqe0qsYfEZPcIpQIxSlgtFVRqykZY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R9glNPjQ; spf=pass (imf02.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678724867; a=rsa-sha256; cv=none; b=hsehvyXCoKj9UBtYhkyVloQnTaO3CdfySf741LBaLhjhqbxEKrny90zwxMWSiKkzTua5qS jycnhLa6Tji4RntuIO3lRU1MYbLPxm6XO6+TqvO0LZC55tr0yd2igQUSkluLNRut+P6UJ2 5oSRd+MFDlDoZhouE9tmD6yzsOeFDAw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678724867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=iUvNynje4NLXuVViJqGVXz34mfwfY1r+EmC29iXiBlQ=; b=R9glNPjQ9JH41ZUUhZm78C36m6D7U/izmO00owo2Xjm/m6eHJapvMEmTvr7RTjHBlhfW8t anaNQC4wC79oXfRssqtONlYHzYmI93UG72fyYBcaoflIG61SKF7qsuD5RrPVUE8pkaawRt cY1gHCzGHxrYsg2LMxtiI46QmzaDhI0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-_i-nT0qoM-Wt4M1D21UMfQ-1; Mon, 13 Mar 2023 12:27:40 -0400 X-MC-Unique: _i-nT0qoM-Wt4M1D21UMfQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32BC618E0044; Mon, 13 Mar 2023 16:27:40 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E93CA1121318; Mon, 13 Mar 2023 16:27:39 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 11E84401344A4; Mon, 13 Mar 2023 13:26:44 -0300 (-03) Message-ID: <20230313162634.283504192@redhat.com> User-Agent: quilt/0.67 Date: Mon, 13 Mar 2023 13:25:08 -0300 From: Marcelo Tosatti To: Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org, Vlastimil Babka , Marcelo Tosatti Subject: [PATCH v5 01/12] this_cpu_cmpxchg: ARM64: switch this_cpu_cmpxchg to locked, add _local function References: <20230313162507.032200398@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E25CA80017 X-Stat-Signature: 59hmarrzf513pjt3hg3j5nimqz5drbsr X-HE-Tag: 1678724867-536217 X-HE-Meta: U2FsdGVkX18yIpAQ5oFmGsr1AnOAsYklQxGNHKdc6f5BOt86aU68B/O9rpUKVgVVichDom9Rt05H1NFvc+2SBKwvZw+NzNSlnHuD6nEDxIz/4GSug8qVUPwg2vbn9+aBZ8hmWkqvOND0Hj4zBsthtLDgG3J120qmc8svKh5Lif1og3ENlwkcAgpXZ1FQ/1pmUMVMQHJHlVhkTIM66zfzyiQC+pkh2d1XEGjOd4+pkztWTeYQidENHiEcIc8RbaecJYvOX+3z0qiMCfX9pZ2CY0EDNVQdsdmF1mNL3SbDCAJ2xp+0zc9fmVTC1fpA7SJBKRDokDef8V9DvlUhHLBryQ3zCyzJWf2WNYB7NIkIm+RygDF7TqyI5UR6fHu1w+Ct89xJH1Zi7lqcdbT3l2yDK6d+zjTMahK8ovVZ+pVzWixAf7gkPgWIoxy6rrusXNPuP0G5eZ5SYns8BeNxl+JbiiH0X4f9vGeUSkKJOGcolBy5HyL/4EnoYhtumUUtfM6JZ2Muk8Ou9CLBDEqwxBSxns/v9+06in00TL8O7PY7UnNZe+DkLFeDHCgyJJl9yw70mJP7Wu+Fk3wcDYWAFBgWgyCOgcjHUpyEwivsgs4f6N3Ar5yER3Rz9APooQXBX8EGYbfWZIe6lR51ltwP9IwcfT/XWafj2yPtr5qTdWVL/RsXBcHi5Qr2DS4d8hk3Yjw4MnZF8v6XNxPhd3MemhlAczIo//bF2UqTXa7AYP4b30S9HNeNyQf9ZMFG3XPAVFQNNcrqq/XxThbK0dmZIjvVNJjHKGVkPgbD5e4juVU5Pk0YDloSHCUyGYNSG4E+Esmhp6YH8TrSvFSnQ4Ek+cgZfCMH0jHpiQiuZtlCcHWhjKIIdaOwu4kj+BHKqr0JF9gaUOuIN9Qqdo9Q2ShP/hPXC2jhq0Ts1GOesgbY2/G7/+AW+gJsQ+BoyvhscjwPHgDc55TdM/dVmldgpuXarvh m2NclvMm ENzRp4HJW49xfwmpWpHB8xrRscHPONexrAhUGgv4gmKo+3meVi8tZogHVqH8vOSiml8tjdYgDx5R8Y7v4/BrJ5yIN9kiohQC+rM6ezNqVJN+pl/5SbaOYSDMeF7ZB+d1cT7UnT9HnpU4BoC2VkYRmdoWy8nWllewS34W9BKGgw6VUuLPy1USbZjvB43zqcRgBhO32k9VnJnLQcXoSgXfeg7HspAfVctTIzAtl6TmzqNwQYwnYdwVjjGntZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Goal is to have vmstat_shepherd to transfer from per-CPU counters to global counters remotely. For this, an atomic this_cpu_cmpxchg is necessary. Following the kernel convention for cmpxchg/cmpxchg_local, change ARM's this_cpu_cmpxchg_ helpers to be atomic, and add this_cpu_cmpxchg_local_ helpers which are not atomic. Signed-off-by: Marcelo Tosatti Index: linux-vmstat-remote/arch/arm64/include/asm/percpu.h =================================================================== --- linux-vmstat-remote.orig/arch/arm64/include/asm/percpu.h +++ linux-vmstat-remote/arch/arm64/include/asm/percpu.h @@ -232,13 +232,23 @@ PERCPU_RET_OP(add, add, ldadd) _pcp_protect_return(xchg_relaxed, pcp, val) #define this_cpu_cmpxchg_1(pcp, o, n) \ - _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) + _pcp_protect_return(cmpxchg, pcp, o, n) #define this_cpu_cmpxchg_2(pcp, o, n) \ - _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) + _pcp_protect_return(cmpxchg, pcp, o, n) #define this_cpu_cmpxchg_4(pcp, o, n) \ - _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) + _pcp_protect_return(cmpxchg, pcp, o, n) #define this_cpu_cmpxchg_8(pcp, o, n) \ + _pcp_protect_return(cmpxchg, pcp, o, n) + +#define this_cpu_cmpxchg_local_1(pcp, o, n) \ _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) +#define this_cpu_cmpxchg_local_2(pcp, o, n) \ + _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) +#define this_cpu_cmpxchg_local_4(pcp, o, n) \ + _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) +#define this_cpu_cmpxchg_local_8(pcp, o, n) \ + _pcp_protect_return(cmpxchg_relaxed, pcp, o, n) + #ifdef __KVM_NVHE_HYPERVISOR__ extern unsigned long __hyp_per_cpu_offset(unsigned int cpu);