| Message ID | 20230324052233.2654090-12-rppt@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER | expand |
On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" <rppt@kernel.org> > > The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to > describe this configuration option. > > Update both to actually describe what this option does. > > Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > --- > arch/sh/mm/Kconfig | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch/sh/mm/Kconfig b/arch/sh/mm/Kconfig > index 40271090bd7d..fb15ba1052ba 100644 > --- a/arch/sh/mm/Kconfig > +++ b/arch/sh/mm/Kconfig > @@ -19,8 +19,7 @@ config PAGE_OFFSET > default "0x00000000" > > config ARCH_FORCE_MAX_ORDER > - int "Maximum zone order" > - range 8 63 if PAGE_SIZE_16KB This range is dropped in current patch, but the other ranges are dropped in the next patch. But feel free to ignore this since ultimately the ranges are all dropped. > + int "Order of maximal physically contiguous allocations" > default "8" if PAGE_SIZE_16KB > range 6 63 if PAGE_SIZE_64KB > default "6" if PAGE_SIZE_64KB > @@ -28,16 +27,18 @@ config ARCH_FORCE_MAX_ORDER > default "13" if !MMU > default "10" > help > - The kernel memory allocator divides physically contiguous memory > - blocks into "zones", where each zone is a power of two number of > - pages. This option selects the largest power of two that the kernel > - keeps in the memory allocator. If you need to allocate very large > - blocks of physically contiguous memory, then you may need to > - increase this value. > + The kernel page allocator limits the size of maximal physically > + contiguous allocations. The limit is called MAX_ORDER and it > + defines the maximal power of two of number of pages that can be > + allocated as a single contiguous block. This option allows > + overriding the default setting when ability to allocate very > + large blocks of physically contiguous memory is required. > > The page size is not necessarily 4KB. Keep this in mind when > choosing a value for this option. > > + Don't change if unsure. > + > config MEMORY_START > hex "Physical memory start address" > default "0x08000000" > -- > 2.35.1 -- Best Regards, Yan, Zi
diff --git a/arch/sh/mm/Kconfig b/arch/sh/mm/Kconfig index 40271090bd7d..fb15ba1052ba 100644 --- a/arch/sh/mm/Kconfig +++ b/arch/sh/mm/Kconfig @@ -19,8 +19,7 @@ config PAGE_OFFSET default "0x00000000" config ARCH_FORCE_MAX_ORDER - int "Maximum zone order" - range 8 63 if PAGE_SIZE_16KB + int "Order of maximal physically contiguous allocations" default "8" if PAGE_SIZE_16KB range 6 63 if PAGE_SIZE_64KB default "6" if PAGE_SIZE_64KB @@ -28,16 +27,18 @@ config ARCH_FORCE_MAX_ORDER default "13" if !MMU default "10" help - The kernel memory allocator divides physically contiguous memory - blocks into "zones", where each zone is a power of two number of - pages. This option selects the largest power of two that the kernel - keeps in the memory allocator. If you need to allocate very large - blocks of physically contiguous memory, then you may need to - increase this value. + The kernel page allocator limits the size of maximal physically + contiguous allocations. The limit is called MAX_ORDER and it + defines the maximal power of two of number of pages that can be + allocated as a single contiguous block. This option allows + overriding the default setting when ability to allocate very + large blocks of physically contiguous memory is required. The page size is not necessarily 4KB. Keep this in mind when choosing a value for this option. + Don't change if unsure. + config MEMORY_START hex "Physical memory start address" default "0x08000000"