From patchwork Sat Mar 25 06:08:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13187579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D5AC6FD1C for ; Sat, 25 Mar 2023 06:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9082900003; Sat, 25 Mar 2023 02:09:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A40936B007B; Sat, 25 Mar 2023 02:09:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90944900003; Sat, 25 Mar 2023 02:09:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8241C6B0078 for ; Sat, 25 Mar 2023 02:09:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 41A1A40B5E for ; Sat, 25 Mar 2023 06:09:04 +0000 (UTC) X-FDA: 80606392608.14.B40DA94 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 95926A000E for ; Sat, 25 Mar 2023 06:09:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="frI6wY/7"; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679724542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DZV4Qv1GF0HfhldDScHuyLR2hmV0139ZNHNue7Ojjj8=; b=M/ME9h3oFywiOlHm73acUoGTUCY0y0gvpxHWspBV8vejC6iZ8b3MsDP0ew0QUM6ObyHWQw /YgMKtIPHp5/CfPCwwfSGrXcx7rfSnEKry7wkYFY7QoSlO8NnZLUWkKlyRXpz1c7SjgQmk pC2kuS0NtJ0DLva5g+uO3TUo7zfM7P8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="frI6wY/7"; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679724542; a=rsa-sha256; cv=none; b=Q6SbclYQwxhLdQzRQXxvXkyccr1/OGN6j1koNC/1X6KRx71i7CvUGoLiHYGJ1WwTeFeWum dnQpzhB2WZTjsR6aQLjARD0pY5BHl1W27gNeXC7moQ97bJJwgstc4IQXaMkcXSUSa4jUOr lr0BqMd2+xsn/nrrGj8NZ/i74jAQIDE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 50FA2B826FB; Sat, 25 Mar 2023 06:09:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F625C4339B; Sat, 25 Mar 2023 06:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679724540; bh=AZxdkgPPk5uvF+BQxbM9LjXE7h2xyoTV5CHwXU/8HBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=frI6wY/7y9Ugq/kDdNPQDTAIrUL1Ibp1tX6t7Wkvuc4peDLOUS0FLn14dUsWo/UVP KtNbpypjIDQfLX5Sa2evDMHXVx61HvtQHFOB9PKZEAXW6tzkIYZ7paJcUl7b6QDkDd XhemG7a6NpMMwzsAA5r8YA40P6xhw2fdg7YT8O/KlzdC1TBydkuv+gJo7kkTOrB7+s enMaqi5rZNqjbwsUTqTpvzzTnA0aG8BdvkEhvLbQnSOQX291OOqIQDs7NKNHFmtArR Nv401z48Zg8rkh8YIDSIShaFEhib6B5rPElKdicGjHXH6RCXcm7FcU+nr/k4vFBvHI +2xif/sknb2gQ== From: Mike Rapoport To: Andrew Morton Cc: Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Mike Rapoport , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: [PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER Date: Sat, 25 Mar 2023 09:08:16 +0300 Message-Id: <20230325060828.2662773-3-rppt@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230325060828.2662773-1-rppt@kernel.org> References: <20230325060828.2662773-1-rppt@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 95926A000E X-Stat-Signature: hzyr5bredgh4mjd6uy9u5ow6ok3ogw5m X-HE-Tag: 1679724542-897156 X-HE-Meta: U2FsdGVkX1/dzoQTzVlxuGexL5++N7KjNj0LNZHY9UgX4mSPocHwHpD3+wiUfvGDgWj3EKaukp+kUMh2nR3wBRFkqo5neilvHVaRIa0Fxvy+MSYlMGyqdebCSTgvJS+b/xM6rl6jfhrbpgkGLwxs9rOFMA6UdHS/CjZEYbX6eaMl6gHYar/KbqUF42q6N3D4OSNNQkn8FLtWQ/ammfqx0na33BT3ERTV+G0FZZ+cpZpfV8rQHn8828coOKASJ+Th7bL0rlISTHXnwrYsOGU3x6t64ky1853r9z8Yw7TQk8Kz6aqn6R3rWOmtWEjDQ+wkJtArcv4qBaWCdGElLu1vzQAi8/5ckLUxsmozH0LLqcA3c6e2u9itpaBLwA+/lYL8d+R0c1OUKyL6DXJZL4nq4t0R5rH3OMYM78L/1rbqyT/muyvu+1uY/bs7+HSQkN9GwFEeidUFgNwbi7OPcq21TeTAoCM0qtBpp3UC+GGMPVnCto/dNZuwFGqDyVAcSQV3iAadlXnBQYb9vJRFpXB0kCNf+aW4hcms8Fls8c5u9US1OSahSAy1p7GJXa4q5+TWbjwvsFHxS9jK7J+X954/Sk5HKJRv+8wrodrTrepH8HE6oANsp9gG9M6YBITP/6kxoULmCVah/KgFt/DqLmGrhQ0EZth4OS3HMdrsvsK7L6BWeJueqDVC9IvJWBGmW6IMlS4TNmymeaxLjE5eEm8NGlE+11UxQQzWcrlek2U3pL1sr3+0DSXuSmqW2G3jcOXrVBj1ZQH2pYjsZp39o19KRTKrb9uCAaq1iAf4qe7TGmQKXZZVM2Pr8VLFeLklkjw0JVlseQjTRHVq0bqzY3nrUQi1XuuQl+uoN9H4PcjEqUTPqVQj4cFjoLsaAYb5RRg38cBiDcrUXOevLr2HPulU5e9OKSGai+lWUxwoBJzwCGe1S/4ye7dA6g3mHld5Nd5FJdLHYNf1s7+cY4WHsNU I6pEDoXo ZmIV9yOpF/NU7o/qZQT3HOvcOmbG9ahUqWF5E6Wg3jOBHt5SLhOsDSI4lnNkSXBYG6lUvSaCb5ClGv97Sh/wvDW0e/R3M4o3qLmitcsdMjoPNDoAx5VDoNOPsl/Cq6YndQ+yVxxL3UQ7Wj4PMTVeQ44RniH3kC083Cv3Qtyse15VNS4zsnzvBX8899rvGbLsby1EcNpCZSTeEjf8Moqx/f8sCJzQdrrhb82X9w1UL9DeWH88DnQbtlpNHgFm3IEkIlrXK5RJhH3ieV5PECo4a2/mpIDZL6R2YVEjdYz9h1jjttVvBiHCthA6zua3gtREIQ3zx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Mike Rapoport (IBM)" It is not a good idea to change fundamental parameters of core memory management. Having predefined ranges suggests that the values within those ranges are sensible, but one has to *really* understand implications of changing MAX_ORDER before actually amending it and ranges don't help here. Drop ranges in definition of ARCH_FORCE_MAX_ORDER and make its prompt visible only if EXPERT=y Acked-by: Kirill A. Shutemov Reviewed-by: Zi Yan Signed-off-by: Mike Rapoport (IBM) Reviewed-by: Kefeng Wang --- arch/arm64/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index e60baf7859d1..7324032af859 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1487,11 +1487,9 @@ config XEN # 16K | 27 | 14 | 13 | 11 | # 64K | 29 | 16 | 13 | 13 | config ARCH_FORCE_MAX_ORDER - int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES + int "Maximum zone order" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES) default "13" if ARM64_64K_PAGES - range 11 13 if ARM64_16K_PAGES default "11" if ARM64_16K_PAGES - range 10 15 if ARM64_4K_PAGES default "10" help The kernel memory allocator divides physically contiguous memory