From patchwork Mon Mar 27 03:41:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 13188563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6F0C7619A for ; Mon, 27 Mar 2023 03:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 575A76B0071; Sun, 26 Mar 2023 23:46:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5269A6B0072; Sun, 26 Mar 2023 23:46:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 414236B0074; Sun, 26 Mar 2023 23:46:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E9C66B0071 for ; Sun, 26 Mar 2023 23:46:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB5581203D9 for ; Mon, 27 Mar 2023 03:46:00 +0000 (UTC) X-FDA: 80613289680.04.D63329A Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf08.hostedemail.com (Postfix) with ESMTP id B80CE160005 for ; Mon, 27 Mar 2023 03:45:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of thunder.leizhen@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=thunder.leizhen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679888759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=hHtIkdZcgKJHiusW3p25nmgnoJpfPHJgOBjS5cAzEEc=; b=lFlhkRP+ozLxY45St7wKEGtQcVElvmpxMawX1Gtc73FBfkBJ4a8pNZmHM099TSz239Cfl+ e0YXgEg+qc2HuD8gOuj+w5GPumAHllyn3k5quMPN0ogiMp5Xs0d3SuoR+OIv8aJ5Z3R+cH Ke4qdr3Kci4gBPVr+eRHt7OXIdO49yI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of thunder.leizhen@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=thunder.leizhen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679888759; a=rsa-sha256; cv=none; b=znJuWle/5MV6eY/HT7hFfBLLYkgZRxpymoPWvUdIeLLvPq5ETtxKjP/uTW83Hk5geZMG8p 07Td2L9ceSiXHQQsmd0UcnDqwYTff9D0Xakl3i8FkdwznISh+R97JLIjse9BQnS0F6eXf1 XXXshbzO7bJWuZpUim29hX2QJuCNRSQ= Received: from dggpemm500006.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PlJby6q14zL66b; Mon, 27 Mar 2023 11:45:02 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 27 Mar 2023 11:45:29 +0800 From: Zhen Lei To: Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , , , CC: Zhen Lei Subject: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags() Date: Mon, 27 Mar 2023 11:41:49 +0800 Message-ID: <20230327034149.942-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B80CE160005 X-Stat-Signature: 94f7u7ztcmrfxz63xuh89c8ugw856yj6 X-HE-Tag: 1679888757-852448 X-HE-Meta: U2FsdGVkX1/VsMOvb1pa4yZuVyam2f/BVpvmG2NdO/GvMwIv0V3hQCUeIpx4dlwzedBmHHwpw75NyV0foh8nMWtRiTWwkeUB0h1bEPWQR0gVwDWTEuBrj5jNXDpt46KELb2vaT4A+IQuLo7tZ1wehj3I7C4l5mx3fgL9eO2NoQrcOx4fyoNPB9JH2zyFE657QN2ZQRqk95vvBLZ2Jf3bqhLGIvkVrENX0ppqr8gRijL1l9KaHlgc0ojqUX5TXJoA+mZeGwZxYdDVCPqsLAfRHalClHWtlqMg9fpbWLlX50bO59LNeLUK2MQCfZWvBwPY2z6DYw+IqWLbLOXBV+rhe+ENCb6hhYMm1hoVArXZPIvVj5DfLGx9VrOIaMcDsaJ0AAigMtkP6Pd8+76tE+uIGOML03ZkDeP00U1nhccr7jEOf+WI2rtLIGfbM9XEy8xuMFuxGUZsSTVS0NEyVY1ZjaycKW7szWM22ldJo9KGWYZ2YZf9NMMu98gbkutWyo9cDjWxoH17wNqj757wNpGjSkX35OmlCrc9tNvhir5MJrFk80t1fhuhvR7b1BZLrxfLdyCYhBNgNr6pGjMmxlAuy/DnLI4xOh6FCmNk4PPCM6OGKoPcM/SSveOj8UwBfPMOT6lp3wsl7efvOEDXV0ovi+nIZWJnZZzBObsx9XyvAUaSKLYtwLrX4NUB8f1RnPSigRaTzHFZpPlMn2MMMCEQWwB99CB2r+s2OObMhTm1xp9mNcjEV6NMYS+rS7AGk0u464tGIN1uAbUipbvvPjkai7eopDR9ez0VUqdskXm1SyMSpZsVQ1nvxgWRfkUn5WZJfJtRSdzWv1qzlQuIRGiV3ATKPXJQ517Adft5t+f2TMGdcGJ4kNzrW7qT5zQgQl/Nl5UzUPUZ1auLVGpZFq7luWGI17JbgTBqKTNbs6SN37FX+VG98Au8eSYOtjcLSjo3dcFse76JCFIeDGVThJx E8DeyQFG BESIEThMV7ULR+GSL5a1sO3avjSd4TpnXkZzzgl5XB0jWhKC4g9J6Sskb8RQEJbKh+pnZ7u/TSW1b7MEN8GAtpqlmaYoCeanvr09ym1dVW0wHqwIuJGLtv31Q+h/NTWLnZmgzIGemjB+BQKzXFr6g5VpxWuLH8NjUk2MEOFeac2TRvqrcG9n4iwczT3qHrGv8flc0L6RVA8YXOYNFNA1I2yO3iQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and __alloc_pages_nodemask"), the comment is no longer accurate. Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the comment rather than update it. Signed-off-by: Zhen Lei Reviewed-by: Alexander Potapenko --- mm/kmsan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmsan/core.c b/mm/kmsan/core.c index f710257d68670ee..7d1e4aa30bae622 100644 --- a/mm/kmsan/core.c +++ b/mm/kmsan/core.c @@ -73,7 +73,7 @@ depot_stack_handle_t kmsan_save_stack_with_flags(gfp_t flags, nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0); - /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */ + /* Don't sleep. */ flags &= ~__GFP_DIRECT_RECLAIM; handle = __stack_depot_save(entries, nr_entries, flags, true);