From patchwork Mon Apr 3 20:18:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 13198727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21005C761AF for ; Mon, 3 Apr 2023 20:19:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 733AB6B0078; Mon, 3 Apr 2023 16:19:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BCD16B007B; Mon, 3 Apr 2023 16:19:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E78D6B007D; Mon, 3 Apr 2023 16:19:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39AA16B0078 for ; Mon, 3 Apr 2023 16:19:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EBCB2140D60 for ; Mon, 3 Apr 2023 20:19:06 +0000 (UTC) X-FDA: 80641193892.12.A8F9575 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by imf29.hostedemail.com (Postfix) with ESMTP id DA49F120009 for ; Mon, 3 Apr 2023 20:19:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=sent.com header.s=fm2 header.b=T1hetx0z; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=sXEJDM7K; spf=pass (imf29.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.27 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680553145; a=rsa-sha256; cv=none; b=g7a7MROYBSZ6+OUuaE3PjRs5z1C+J60Wn/p3qzPD5qE7ZmdUM3JBxzTy9zREypO9Igxk2t Q3bUaQCJrdMgkTmeAHGumYnzRwgwD1W+Hu6OCCk+zYfmIckoLgrt/g1NUD6faiCxGl/aFH fIW1ZmfWIbAO963VuvtEj9NW/gaBf3Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=sent.com header.s=fm2 header.b=T1hetx0z; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=sXEJDM7K; spf=pass (imf29.hostedemail.com: domain of zi.yan@sent.com designates 66.111.4.27 as permitted sender) smtp.mailfrom=zi.yan@sent.com; dmarc=pass (policy=none) header.from=sent.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680553145; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yr+uFjBJL/0qCDkJMJuMYA8+4U49oyS8kQRIZ4QnQ48=; b=kbLNV3DQZ6vbgy9I3jmEgfgY3tmogKd8S0B98E/mZafZx3isWUF8g1QizUEUNBvkrCE0dK hxLE2jmpXyhDxnBdUdrzf+nZ6r4S3M63qh4Z8i/86+3rURqGkHtIIO16IMzMUuIh7B/JLr ShVrWs2HH2PpbqIYN5bkRNJvYx1VY3c= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3D5C55C0077; Mon, 3 Apr 2023 16:19:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 03 Apr 2023 16:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1680553144; x=1680639544; bh=Yr+uFjBJL/0qCDkJMJuMYA8+4U49oyS8kQR IZ4QnQ48=; b=T1hetx0z1aJK2O8iBf1XvbqRSf2LI5NbMRJIZbD7uStCjfYTwWu LJGnCoWYcbaqpoiUrntElnYceDUE5dsSh5Ku+hBbgvndzIdg1RoPOlpMQblhIZEj Gj9N8O5K106uCqM170WRD7HzCaPjrz+LrVUSe85Y2mDdavpdEAQwrn4H17Ft3gZV 4i1+Y9GQdBSJAMy41kpcfLa/idIEkFFLl3C4BwKjk/9zNnr+jhhFMl8lURKOJePr WUFqi+HV8uSXTAynXN9pclE+IFtgQQ5tFcHeF3Hdw+WTPtgbvTJf/fpYERORW3zX w9l3SsHoMN9zpXheXCSyiSDa8U3ezvl9WFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680553144; x=1680639544; bh=Yr+uFjBJL/0qCDkJMJuMYA8+4U49oyS8kQR IZ4QnQ48=; b=sXEJDM7KET2Hz2FHW38uAUF1gFqDFEOhVRtiWCqszLoqwd1QDsa XpDhu5g5zULZEpHyMzC0XVamd3bmgfGCMbzr8ic5lVeNWN+70QI+kqdzTDEJVJlQ lF5zFAKYBWZxkHlKZ/5jObCMfNlOGCacD3+oDf582G15K8Un92Y2c5oKigRFMxqa ZXeJYHTlEteuxWOv4laEB07bJgRtG5KeX65vfCX09baLQsAuneHGOMJxAm6qe1z0 +eOvk/9J9zol6wjU0NxawPfRaYWPNDFUvbyjqYXN0nwNts9yMrGDgrS/wuklV3dq WcJctYgIhA+94PoWt+7EwS1GfgHOq/BOyvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfrhgggfestdhqredtredttdenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepge eghedugfduuddvleehheetgeeltdetieevuefhffevkefhveeufeeiieejgedvnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 16:19:03 -0400 (EDT) From: Zi Yan To: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org Cc: Zi Yan , "Kirill A . Shutemov" , Ryan Roberts , =?utf-8?q?Michal_Koutn=C3=BD?= , Roman Gushchin , "Zach O'Keefe" , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v3 1/7] mm/memcg: use order instead of nr in split_page_memcg() Date: Mon, 3 Apr 2023 16:18:33 -0400 Message-Id: <20230403201839.4097845-2-zi.yan@sent.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230403201839.4097845-1-zi.yan@sent.com> References: <20230403201839.4097845-1-zi.yan@sent.com> Reply-To: Zi Yan MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: DA49F120009 X-Rspamd-Server: rspam01 X-Stat-Signature: imqab9j4j1pum77y3dhxgmcm5nekraba X-HE-Tag: 1680553144-69691 X-HE-Meta: U2FsdGVkX18/o6jjvejz8mYXoDiqXpFtwaVf/38RNi0T39W+htHwjTYMp7PGqJNUFjnNWOkNSvZrg62nrjFcZKqrTqkaLG6Q9HiRbsOI64uzkRI92lmZOOUkj3AK6iH38zZX/Xye6BPj5/bxukX7Laei6f7msb8uJGB1SijVKKUAxZr0Z/9X5tYkaE5QwspQkWB6LqOFObVUmXJPEgYOllZsLUNntNdV8HXGD3ZkdK7tpOMctvUOqF6pNPOB7Arfk0iczOmlzpDlJzLdy4yWY8ytCEg2Mdw3mVQfkIBdaGcix+mE608quGbZS8a02jvqHx2usb3xZ8kzMtwqptd7VCCAhJ94M5QMD2Grx45vAFWKJTkC0FhZWcysWrUSuf+Tt0vkBHhsFv+tZqP6RKbobnW4QZ2/1OUzAT02ekg+s0C5neCBuwyXzDQCBEGWDEV8+E3IpfYaVIRV0bj7zoCeztL1ufQbl9mAy7azI8IQHLeYTgynTetoV0/Dfili39edmDbwqV4Kqxab4Wp2+th8gH/Ay4SU2evzKzMvFOtxy0Mzba2Qt27R8Yn9sowVznUILXrGR/m9vV98yOKL1VFgtnOx4ntzaFD6ef5oq/rmJCK+Kngn8pIcjIJlTCHItmTkq8jQ6SQFYHNF28eavZ/r8axQk5QQT4WTEWvrS+jC300RHeeTHsvXrQjm8AOkmTJAU10jxwxS+xHy+cFHKSAkw09UvXt1Ut0RXM5yDkBR2bG3Bw+WYauyEO958WKFZX1BuCtc2usHJIxeexBIjSxfjkEfispBlM+wx6oxL35wLwCqPCcIUqkyKEDug01oH3KnIYF8IRt2+tharUcsncRAwKpYuCSUBpJzJECGgCd07gm9qeCu/q57wTti3TLQKVfspU+qc317hyNUzTZykLaRzWx7WVwvd+OjK2nsUXJFVSO5VPL9t2kui9pdXwXaJpua0P/wGjjuBX1JpCai4pP QOCqPJnN tajx/4cQ04FiSebrQHdJd7uXou6zcluRQOOIr6qMxWvC47l65Vb+4V20hm9meCgpbjiFWmbQRfuiED57pytAuSRaOgKAf8SIPMcur+rkZype+hy4jIbSJdt25dNAeaC+zEmHnbx6xaCln10gKMMakFGLG1VzxoxlW78r7e/5bBpozyKsXZxbzrxAcyRSStnDdSQeV2+biQP5ra/G4Z5e7XvUkiTbUtHEV8f+Ot+3ecgM8e0GQHhHxkIus0j1ki3xs0L3l2KlfhSPLO4RP+HeVytx9qt1/bFX4qr2vsBa67GQiCI3bSNcfclkmwIIQUyyin9o23niEvzKxizCuygIwiuFaBWRwtaUV3o62wsKOeu02DJRy/ES7Jz+Y38DymqZ+q/8VJ1OKP7zqfknH0m4mHcAjcPoWr1a/FXPTqTUB06YHYCorr8zH99X0UyT7QAR+Oid8Tp6x72ydkrAFijfCkdP1tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zi Yan We do not have non power of two pages, using nr is error prone if nr is not power-of-two. Use page order instead. Signed-off-by: Zi Yan --- include/linux/memcontrol.h | 4 ++-- mm/huge_memory.c | 3 ++- mm/memcontrol.c | 3 ++- mm/page_alloc.c | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index aa69ea98e2d8..e06a61ea4fc1 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1151,7 +1151,7 @@ static inline void memcg_memory_event_mm(struct mm_struct *mm, rcu_read_unlock(); } -void split_page_memcg(struct page *head, unsigned int nr); +void split_page_memcg(struct page *head, int order); unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, gfp_t gfp_mask, @@ -1588,7 +1588,7 @@ void count_memcg_event_mm(struct mm_struct *mm, enum vm_event_item idx) { } -static inline void split_page_memcg(struct page *head, unsigned int nr) +static inline void split_page_memcg(struct page *head, int order) { } diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 81a5689806af..3bb003eb80a3 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2512,10 +2512,11 @@ static void __split_huge_page(struct page *page, struct list_head *list, struct address_space *swap_cache = NULL; unsigned long offset = 0; unsigned int nr = thp_nr_pages(head); + int order = folio_order(folio); int i; /* complete memcg works before add pages to LRU */ - split_page_memcg(head, nr); + split_page_memcg(head, order); if (PageAnon(head) && PageSwapCache(head)) { swp_entry_t entry = { .val = page_private(head) }; diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 681e7528a714..cab2828e188d 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3414,11 +3414,12 @@ void obj_cgroup_uncharge(struct obj_cgroup *objcg, size_t size) /* * Because page_memcg(head) is not set on tails, set it now. */ -void split_page_memcg(struct page *head, unsigned int nr) +void split_page_memcg(struct page *head, int order) { struct folio *folio = page_folio(head); struct mem_cgroup *memcg = folio_memcg(folio); int i; + unsigned int nr = 1 << order; if (mem_cgroup_disabled() || !memcg) return; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 0767dd6bc5ba..d84b121d1e03 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2781,7 +2781,7 @@ void split_page(struct page *page, unsigned int order) for (i = 1; i < (1 << order); i++) set_page_refcounted(page + i); split_page_owner(page, 1 << order); - split_page_memcg(page, 1 << order); + split_page_memcg(page, order); } EXPORT_SYMBOL_GPL(split_page); @@ -4997,7 +4997,7 @@ static void *make_alloc_exact(unsigned long addr, unsigned int order, struct page *last = page + nr; split_page_owner(page, 1 << order); - split_page_memcg(page, 1 << order); + split_page_memcg(page, order); while (page < --last) set_page_refcounted(last);