Message ID | 20230404085636.121409-1-david@redhat.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BAC4C6FD1D for <linux-mm@archiver.kernel.org>; Tue, 4 Apr 2023 08:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A77626B0071; Tue, 4 Apr 2023 04:56:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A016E6B0074; Tue, 4 Apr 2023 04:56:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C8C16B0075; Tue, 4 Apr 2023 04:56:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7999E6B0071 for <linux-mm@kvack.org>; Tue, 4 Apr 2023 04:56:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F6D01C6369 for <linux-mm@kvack.org>; Tue, 4 Apr 2023 08:56:46 +0000 (UTC) X-FDA: 80643103212.14.7468F04 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id B32A320017 for <linux-mm@kvack.org>; Tue, 4 Apr 2023 08:56:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKJsCgwh; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680598604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=mfDdyKVcifJZLH02TcTIG5kV3xa5JKdcM7nY2dpg5xs=; b=gNLvVoPbMK8L+rtQNFQC0ov4kzUVI4QIicCKAYtojx5dJg2CZWQUFd1aBCtHLA2YSaJZ2R HW1WQkTtdNtmfEHigNZfEHVZzhWxK3XH9Rn10IrlhiJK79T7AXKMYpXh6rsQ/NBCBc4YhJ uqwVjs8Ylu4zaIKqOV9nTb8aEiQW+04= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKJsCgwh; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680598604; a=rsa-sha256; cv=none; b=AVml0ZziVVmPXRxOeTJJl4gTZTjlKFzUKIDAiyWxoYtDW4alFAf1OmEirm1zTBgpEmINCt gg7hOPT/EooRU1P9bApbnhkyg5z/y9wjGZUfnPrVScp+4ze//QHxZJ04ZSRIfO5MoEaAvd oSK2py83g+lTMaUDctW9CnE3s1sYgXk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680598602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mfDdyKVcifJZLH02TcTIG5kV3xa5JKdcM7nY2dpg5xs=; b=KKJsCgwhhzj7bVCeawec5RmQRQVvyorys7rYxe+dEafr21cx7391+bOaRizAFQ+AfEK2NR HcHBsQH9krw+z4n5pqPyZUu+CsBVXOOMjZj79hZFX0DioWFtbxOWMNx/0TE0lTFCVfJdwi zbV5kjzpaCdtECBxbBkroayOyWoGcKc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-126-rcAuzLC2OHW6ZU8PpU3jBQ-1; Tue, 04 Apr 2023 04:56:39 -0400 X-MC-Unique: rcAuzLC2OHW6ZU8PpU3jBQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9EE9C85A588; Tue, 4 Apr 2023 08:56:38 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.194.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF92E40C83AC; Tue, 4 Apr 2023 08:56:36 +0000 (UTC) From: David Hildenbrand <david@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, David Hildenbrand <david@redhat.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@linux-foundation.org> Subject: [PATCH v1] m68k/mm: Use correct bit number in _PAGE_SWP_EXCLUSIVE comment Date: Tue, 4 Apr 2023 10:56:36 +0200 Message-Id: <20230404085636.121409-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B32A320017 X-Rspam-User: X-Stat-Signature: rdg5k8y1x4uoyk6r3o1r19a3kg6od8gz X-HE-Tag: 1680598603-891691 X-HE-Meta: U2FsdGVkX1+dv//C4RLXDKsKz8sAMm66c8EdBpBHK+RjXD3IB90WiqYO/nilLxRwR+swvJmhfS0iW9TqK5PBuEP8ZIHuz15hv5KU/0RsQkcM9e3U0PPVRWLwpERhsigWbhVwHeRpygLL1oOlkxoi3lilxuQKFDWTD5inOXHeZT5g1yKDRbe+QHD+hTtS6bzOJa2+yOW/MZ32IG/+rGZP7xon+qfVDNk8fKT/GaLCL0ePZtWl9E1E6XdQmYMupg9GyM5AOGIR9YvMf9FTZmsaZo3zGVlx8s6MrWlGM+sHaMaXZPDjXZNtFUUKIkW/ta3hD8YmDDuu8jxJY20FQY9YQTE83qY6EgrnGsfv5+KT5nFC0amYvujlQ1Kh9+FMYS/BDtZ7ZAnFUkdG2GE1CqoLT2lq8w3XfRsmguTWENKEB8ulnjWLjRwxLjtlLoTxT46WvEQNN4Dv3DUBHsCaA8pasymsZsaHl7gnm3jAqKMXuY5yjcq4hK8ZhI8tW72T2B8yjsUxYPS2wtiIZGeeagPMgLlOxxUV78hE+YkC/fUzdVU/fGMTjQNTz9FRahnYAfif0z6OZWANT0LheFHSKSDbN69CltEzEFqFTVIkmBrQYf2h+4OPhaKCwhscM3hxatu94KkpenmRbfZmU3T4YShgElRlDFyp9Hnjeh+GQSTefIx4lwCYR3mZULWlzIlP3QNW3lCZIpvlgfkpXRV7KwpOSipNEbq+trttDdzFz6Q0H22Rlcug9l9Vuyu7bPtBXPaeBPnRpPdZIz483r0aN2dKWbE6BAnlS70+Hp/PTVtrDxYFaI8Y4BG67LhkmkMs2tSzAk6OgzZQ//WAEPoPi6f2CnIOSxAfQAGC7exQJpM4CheijexxVATnHEXHu/zVk/mByNAYnVVh1N3+hzutdBMq+VR5a+4wqwFcZ1LnESVGcF8kpk2iXwZ+AtwpK9aJF3Db93LdhmVHz7KD7j7VUoY xf9DwmTH BIqmldZZshsnO07HZ+pukuL1mSkuRQQyHfSVklh/HCB+cbOb5Z5PlyhxJnWcFk9tfHa8VGJfzBFXlL2u8xXpoSyoklpW4YVe3lB3tKo9qNK3DOBfI2kQy4qhW9a4I1oGNAdir3Atu6L82AIzvz7949jFyPS1JnLc2oWYndpdkNV53V61dc4OvBOFhkphWjp6/eVeHnH1HKOhbkalgbK1fVCdZeks7LuYaTPBvQQ04cDfOZvrAIjuRvi8E6UDB+EeQqP8SBHt0JwM8zKXCjdtj8bs+DTeBfK4XTbk92pKxtL0BHOLn07QFBzM5HIcQZdOWnXavU24338uOsjbjnHE5XuEQ1EoR/7NdJzMZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
[v1] m68k/mm: Use correct bit number in _PAGE_SWP_EXCLUSIVE comment
|
expand
|
diff --git a/arch/m68k/include/asm/mcf_pgtable.h b/arch/m68k/include/asm/mcf_pgtable.h index 13741c1245e1..d97fbb812f63 100644 --- a/arch/m68k/include/asm/mcf_pgtable.h +++ b/arch/m68k/include/asm/mcf_pgtable.h @@ -46,7 +46,7 @@ #define _CACHEMASK040 (~0x060) #define _PAGE_GLOBAL040 0x400 /* 68040 global bit, used for kva descs */ -/* We borrow bit 24 to store the exclusive marker in swap PTEs. */ +/* We borrow bit 7 to store the exclusive marker in swap PTEs. */ #define _PAGE_SWP_EXCLUSIVE CF_PAGE_NOCACHE /*
As noticed by Geert, commit b5c88f21531c ("microblaze/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE") modified m68k code by accident. While replacing 0x080 by CF_PAGE_NOCACHE is correct, although it should have been part of commit ed4154067a08 ("m68k/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE"), replacing "bit 7" by "bit 24" in the comment was wrong. Let's revert to the previous, correct, comment. Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David Hildenbrand <david@redhat.com> --- arch/m68k/include/asm/mcf_pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)