From patchwork Tue Apr 4 12:01:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Stevens X-Patchwork-Id: 13199708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16A0C6FD1D for ; Tue, 4 Apr 2023 12:01:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EDE6B007D; Tue, 4 Apr 2023 08:01:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BFA56B007E; Tue, 4 Apr 2023 08:01:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 142DC6B0080; Tue, 4 Apr 2023 08:01:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 023E06B007D for ; Tue, 4 Apr 2023 08:01:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7DF7B140E8E for ; Tue, 4 Apr 2023 12:01:42 +0000 (UTC) X-FDA: 80643569244.27.43A49B4 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf24.hostedemail.com (Postfix) with ESMTP id 4E07D180020 for ; Tue, 4 Apr 2023 12:01:40 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gGkyBqM8; spf=pass (imf24.hostedemail.com: domain of stevensd@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=stevensd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680609700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4qUt+bgMbpOhTRgQhL+AHDV3zlnHqzmbomM5Wqo2t8M=; b=tdbeO26pqoPX/WEZ9MQ9pwyTypzK9FaX07eVNIbiR2cnxvzuMew5JIXQXNw1m58W4g7Gkw 7GMEOVoqUUivyL8jyXivHO1ZQvSD5CbQOcBeranLpSA3YjT4Es//4rgcYhm6oVDpiHFET+ 9FtYeqi+6T4G+HkG1vHdVdX1mT+IrYk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gGkyBqM8; spf=pass (imf24.hostedemail.com: domain of stevensd@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=stevensd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680609700; a=rsa-sha256; cv=none; b=waSXloEIJ54RL8JFARgM8N5CVjRRs/BYFiFpgyHLRwTUUnHAj4Z9RtWlPtdXfUORqfhmbp wES1vcHClZZ4JDBrrMD2YL0UW0wZ5YpnrjsV3nmah3HNvxgS+xDzQ6Td9Wvt4Gt03XhI9S ncOEA2D7/09Ft48Ph6ulxDoShUSPqGU= Received: by mail-pj1-f50.google.com with SMTP id r7-20020a17090b050700b002404be7920aso31833472pjz.5 for ; Tue, 04 Apr 2023 05:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680609698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4qUt+bgMbpOhTRgQhL+AHDV3zlnHqzmbomM5Wqo2t8M=; b=gGkyBqM897kTx3mCEJLjxur+giZZePN0hsSQZRggvEHfuxcLZ/xAHZn7d/zocZ+B/t 1cIzL09rih7OgQJFA0TJpSLo18rTYMeEnbExDfttmiQbIW+B8qdcJ1V6KdSL3C2CVoIk uhn8K/3B8O1z7wv+u/gk9GUet3CqJe2QvDgOU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680609698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4qUt+bgMbpOhTRgQhL+AHDV3zlnHqzmbomM5Wqo2t8M=; b=yfOG9cKN+/7x8RflN2B4PfdAAqNvkMZObZ2Yrc0KQiREJZ7OTUiBOT6OyYLbYNETk9 sJB7W/3MRReDLzZEMYKcHrP70hs3Wm42DB+5XzbTHAeKZUZVFiZkbfOxbBAr+HVyf9yY wfO5hvUSFu8WQBVs3vufTFaqakaSBftFv14f2FFhQ5NOeJteqHPAPO0Wv/tB+1IjDE/A 28juvQYr8U6Sdiz1vR6+JG2hhrWELheV4W8OCDa5j6RGwZ6ed/NA1QMj2U7sU+2NwmGZ YwRF/dbSX8G4cClD1uJUlJHID4W8+MHWAcnlpiUNo2FhcHmp+T/QwKCVGqcOznkYO7MD LL6Q== X-Gm-Message-State: AAQBX9fl2JXvU+OGK7VRlYFP9bX2VUDL48v1fTArUUYk6q4nRNYD6i6+ zurJALVElTsLyzY2SwHxuRr9g8HYbLMOtZZTemA= X-Google-Smtp-Source: AKy350YJmn368SsJA0s1UjNOINFx3s/OTYEKafflR1j6AXeAzEBTEXX+E3A7d0NoY4XJPEiZqkDcUw== X-Received: by 2002:a17:90b:1a86:b0:23f:7c82:2463 with SMTP id ng6-20020a17090b1a8600b0023f7c822463mr2874580pjb.9.1680609698541; Tue, 04 Apr 2023 05:01:38 -0700 (PDT) Received: from localhost ([2401:fa00:8f:203:959b:21ea:166b:c273]) by smtp.gmail.com with UTF8SMTPSA id q3-20020a17090a938300b0023b15e61f07sm7879485pjo.12.2023.04.04.05.01.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 05:01:38 -0700 (PDT) From: David Stevens X-Google-Original-From: David Stevens To: linux-mm@kvack.org, Peter Xu , Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Jiaqi Yan , linux-kernel@vger.kernel.org, David Stevens Subject: [PATCH v6 3/4] mm/khugepaged: skip shmem with userfaultfd Date: Tue, 4 Apr 2023 21:01:16 +0900 Message-Id: <20230404120117.2562166-4-stevensd@google.com> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230404120117.2562166-1-stevensd@google.com> References: <20230404120117.2562166-1-stevensd@google.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4E07D180020 X-Stat-Signature: agzqmfg7ohcre1id5jyxp1rh64t89yiz X-HE-Tag: 1680609700-235826 X-HE-Meta: U2FsdGVkX18IPwDXOczbU57cL7brT1llOHiTm/DUQwbdXIOt5RzXh0gD/g4s4uchxzX3in0z+pWiJhHuy0QeypVSaqn7IHj6oQuXveivEEBsG0nLjsbUH2LnmxNSwdnb8wtsJhxckDkna6YdBSMOEiqUzFWH56QneodeMGpeYhczbzRcf1fTiUw/8QP6OTiKzENgNcg3C12+QgrxrqyTZqH7+XXj8veBvxQKYVHgci/Myj5kCQ6NyLsPs3cHZbb8LOBnt1rKcknsiOLcNXyZAo0+Zq4vCysIAzmkp7meHfYdW4rNuvpFuMc/7iapN5me7uHCHe9DWLfZeKWv5Erdu9kuzRjSwFxOoUQcNQWLLrcHvlr9pznLUOwEHu/GrzcQSYHqCLdc2xFeIrCb+VtIhpKnWhSjMdOaMUYneKQqZVK476HA6yoiJiWEPxz9+Q615SH9hEXFsvkfylo6v0s2cAOP0ZYEh8t1qb64wzU4FASxMRU78bB6HpdJXnCltdDgUSfAWNRDODaABFMFhnkXGFF+cbxA2CP0X1L6B7+o5craVbz2LeC6v4WTxQKAtbfE39LkCHdkFgNDp6VeCBL4J3O8JAKATjv7RFNcWcBQadh0PgRm7TYfn7veff0AVzPCHp8iOq9YEtPuZWQKH5j4AVXNGSuG9VW7y+Oc51KQ2xLhXDi19N3d1+qG3o/DX85czSF2Y6Bfg2eE3/jDEpcZxQymHJ+0Rl4xgGoWhEfMRdRU5Ra+XHbSzPalYQGRh3SbCg0UUBfHbzFTavYNKHZXYffL6v5oXuvaJ+XZ6Y0xXcWGd2ocm/0fptcC1igWNHAAgrhb/n0EQZgusmSD8qEpJKv0BZ8zj20BwpdHN+spS9efr9dNNUzvZ9E/1i7PsfFoLFyzAlnMo4Nb2eWh8gPuv6gEUSowK534iudI2ztuEIlekksEZ461oFvXVcxWcjN1zdn9TtgDdRoFZ19QYBp SbHtE4I+ Zc9Rl+Sg9QjC7qotYgt89qSTdHrBv9Ig/KaamSC5Sl+H2A21brD4MEPNd97OgZDowCq+UDJo6vyewWlNy5cjsc6M++kyALRZePQFN16ZvQkQbeISAC3IVjAJefsMXlCQCIxpS8GmoN64jQTdNthBUy2F75kf/cSvzFQHInd6rlSGv3LnnfYcV+cioT/PzqzeQvLtTxp5G3ILo4eIqXSbn8p5mt3c0fe8fYBs3FEfrkY4v9dmqkOP1Cl/tJKdz/1GpSKajhq1/BCNzGFuH07c9Mham/HOvdNoeJcX8ozCrqxjdE2EpQb2EFSxTvnzE6cV1HAhufeZ7tQD6lrYOVH0Q1n19UAfml3CBgWVAE3l9pt+WchknSqlQ/qCUPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: David Stevens Make sure that collapse_file respects any userfaultfds registered with MODE_MISSING. If userspace has any such userfaultfds registered, then for any page which it knows to be missing, it may expect a UFFD_EVENT_PAGEFAULT. This means collapse_file needs to be careful when collapsing a shmem range would result in replacing an empty page with a THP, to avoid breaking userfaultfd. Synchronization when checking for userfaultfds in collapse_file is tricky because the mmap locks can't be used to prevent races with the registration of new userfaultfds. Instead, we provide synchronization by ensuring that userspace cannot observe the fact that pages are missing before we check for userfaultfds. Although this allows registration of a userfaultfd to race with collapse_file, it ensures that userspace cannot observe any pages transition from missing to present after such a race occurs. This makes such a race indistinguishable to the collapse occurring immediately before the userfaultfd registration. The first step to provide this synchronization is to stop filling gaps during the loop iterating over the target range, since the page cache lock can be dropped during that loop. The second step is to fill the gaps with XA_RETRY_ENTRY after the page cache lock is acquired the final time, to avoid races with accesses to the page cache that only take the RCU read lock. The fact that we don't fill holes during the initial iteration means that collapse_file now has to handle faults occurring during the collapse. This is done by re-validating the number of missing pages after acquiring the page cache lock for the final time. This fix is targeted at khugepaged, but the change also applies to MADV_COLLAPSE. MADV_COLLAPSE on a range with a userfaultfd will now return EBUSY if there are any missing pages (instead of succeeding on shmem and returning EINVAL on anonymous memory). There is also now a window during MADV_COLLAPSE where a fault on a missing page will cause the syscall to fail with EAGAIN. The fact that intermediate page cache state can no longer be observed before the rollback of a failed collapse is also technically a userspace-visible change (via at least SEEK_DATA and SEEK_END), but it is exceedingly unlikely that anything relies on being able to observe that transient state. Signed-off-by: David Stevens Acked-by: Peter Xu --- include/trace/events/huge_memory.h | 3 +- mm/khugepaged.c | 109 +++++++++++++++++++++-------- 2 files changed, 81 insertions(+), 31 deletions(-) diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h index eca4c6f3625e..877cbf9fd2ec 100644 --- a/include/trace/events/huge_memory.h +++ b/include/trace/events/huge_memory.h @@ -38,7 +38,8 @@ EM( SCAN_TRUNCATED, "truncated") \ EM( SCAN_PAGE_HAS_PRIVATE, "page_has_private") \ EM( SCAN_STORE_FAILED, "store_failed") \ - EMe(SCAN_COPY_MC, "copy_poisoned_page") + EM( SCAN_COPY_MC, "copy_poisoned_page") \ + EMe(SCAN_PAGE_FILLED, "page_filled") \ #undef EM #undef EMe diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 90828272a065..7679551e9540 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -57,6 +57,7 @@ enum scan_result { SCAN_PAGE_HAS_PRIVATE, SCAN_COPY_MC, SCAN_STORE_FAILED, + SCAN_PAGE_FILLED, }; #define CREATE_TRACE_POINTS @@ -1856,8 +1857,8 @@ static int retract_page_tables(struct address_space *mapping, pgoff_t pgoff, * - allocate and lock a new huge page; * - scan page cache replacing old pages with the new one * + swap/gup in pages if necessary; - * + fill in gaps; * + keep old pages around in case rollback is required; + * - finalize updates to the page cache; * - if replacing succeeds: * + copy data over; * + free old pages; @@ -1935,22 +1936,12 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, result = SCAN_TRUNCATED; goto xa_locked; } - xas_set(&xas, index); + xas_set(&xas, index + 1); } if (!shmem_charge(mapping->host, 1)) { result = SCAN_FAIL; goto xa_locked; } - xas_store(&xas, hpage); - if (xas_error(&xas)) { - /* revert shmem_charge performed - * in the previous condition - */ - mapping->nrpages--; - shmem_uncharge(mapping->host, 1); - result = SCAN_STORE_FAILED; - goto xa_locked; - } nr_none++; continue; } @@ -2161,22 +2152,66 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, index++; } - /* - * Copying old pages to huge one has succeeded, now we - * need to free the old pages. - */ - list_for_each_entry_safe(page, tmp, &pagelist, lru) { - list_del(&page->lru); - page->mapping = NULL; - page_ref_unfreeze(page, 1); - ClearPageActive(page); - ClearPageUnevictable(page); - unlock_page(page); - put_page(page); + if (nr_none) { + struct vm_area_struct *vma; + int nr_none_check = 0; + + i_mmap_lock_read(mapping); + xas_lock_irq(&xas); + + xas_set(&xas, start); + for (index = start; index < end; index++) { + if (!xas_next(&xas)) { + xas_store(&xas, XA_RETRY_ENTRY); + if (xas_error(&xas)) { + result = SCAN_STORE_FAILED; + goto immap_locked; + } + nr_none_check++; + } + } + + if (nr_none != nr_none_check) { + result = SCAN_PAGE_FILLED; + goto immap_locked; + } + + /* + * If userspace observed a missing page in a VMA with a MODE_MISSING + * userfaultfd, then it might expect a UFFD_EVENT_PAGEFAULT for that + * page. If so, we need to roll back to avoid suppressing such an + * event. Since wp/minor userfaultfds don't give userspace any + * guarantees that the kernel doesn't fill a missing page with a zero + * page, so they don't matter here. + * + * Any userfaultfds registered after this point will not be able to + * observe any missing pages due to the previously inserted retry + * entries. + */ + vma_interval_tree_foreach(vma, &mapping->i_mmap, start, end) { + if (userfaultfd_missing(vma)) { + result = SCAN_EXCEED_NONE_PTE; + goto immap_locked; + } + } + +immap_locked: + i_mmap_unlock_read(mapping); + if (result != SCAN_SUCCEED) { + xas_set(&xas, start); + for (index = start; index < end; index++) { + if (xas_next(&xas) == XA_RETRY_ENTRY) + xas_store(&xas, NULL); + } + + xas_unlock_irq(&xas); + goto rollback; + } + } else { + xas_lock_irq(&xas); } nr = thp_nr_pages(hpage); - xas_lock_irq(&xas); if (is_shmem) __mod_lruvec_page_state(hpage, NR_SHMEM_THPS, nr); else @@ -2206,6 +2241,20 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, result = retract_page_tables(mapping, start, mm, addr, hpage, cc); unlock_page(hpage); + + /* + * The collapse has succeeded, so free the old pages. + */ + list_for_each_entry_safe(page, tmp, &pagelist, lru) { + list_del(&page->lru); + page->mapping = NULL; + page_ref_unfreeze(page, 1); + ClearPageActive(page); + ClearPageUnevictable(page); + unlock_page(page); + put_page(page); + } + goto out; rollback: @@ -2217,15 +2266,13 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, } xas_set(&xas, start); - xas_for_each(&xas, page, end - 1) { + end = index; + for (index = start; index < end; index++) { + xas_next(&xas); page = list_first_entry_or_null(&pagelist, struct page, lru); if (!page || xas.xa_index < page->index) { - if (!nr_none) - break; nr_none--; - /* Put holes back where they were */ - xas_store(&xas, NULL); continue; } @@ -2749,12 +2796,14 @@ static int madvise_collapse_errno(enum scan_result r) case SCAN_ALLOC_HUGE_PAGE_FAIL: return -ENOMEM; case SCAN_CGROUP_CHARGE_FAIL: + case SCAN_EXCEED_NONE_PTE: return -EBUSY; /* Resource temporary unavailable - trying again might succeed */ case SCAN_PAGE_COUNT: case SCAN_PAGE_LOCK: case SCAN_PAGE_LRU: case SCAN_DEL_PAGE_LRU: + case SCAN_PAGE_FILLED: return -EAGAIN; /* * Other: Trying again likely not to succeed / error intrinsic to