From patchwork Wed Apr 5 17:29:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 13202316 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECA2C7619A for ; Wed, 5 Apr 2023 17:30:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076246B0078; Wed, 5 Apr 2023 13:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 026336B007B; Wed, 5 Apr 2023 13:30:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E578B6B007D; Wed, 5 Apr 2023 13:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D71D36B0078 for ; Wed, 5 Apr 2023 13:30:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ADA1D120D14 for ; Wed, 5 Apr 2023 17:30:11 +0000 (UTC) X-FDA: 80648025822.05.6B0193B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 748E71C0018 for ; Wed, 5 Apr 2023 17:30:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ra9q1p5b; spf=pass (imf20.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680715808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=z+HYQefqgvcXIdDLfIVXnweBRVYhQpoNmawVUXP8h/Y=; b=AM/z9IGyt3CGUmNtjxyDOETdFWoH8SGm35jGMdc5JNTpeeMY4HrZ6ngH9S0oylysZoUm95 cz2QRIiWNgtcYXXZy3AOP3B3xUsdnTWHNUQEBCBn2IZG1bHkFJhWHHvS7/xiiLqZ120K33 vvbLiUnQC5QENnQWuhSoyEK1gwQ/qrU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ra9q1p5b; spf=pass (imf20.hostedemail.com: domain of horms@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=horms@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680715808; a=rsa-sha256; cv=none; b=Z0ed6adICajLLEp7ctOSKqrcp4Eov+KVEOdl0UrcmiiOaxW3BhgKCBvvL1WbhZ1ZAeqMSl 9X/9Qs6pSGULAZ4HeO95Xr43OHHAdLtr8I/FR4/hx6JTkwwT66kF7bFL9/Fu/QiwU2B7Vy 7iiNkAe0T0vib0f7AtL1xrp7e5pWxKY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6DF2263CAE; Wed, 5 Apr 2023 17:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C881BC433D2; Wed, 5 Apr 2023 17:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680715806; bh=MTlSWkTVvQnj8bCbTnc5vIL49pqfkTClsa++NdTazCs=; h=From:Date:Subject:To:Cc:From; b=ra9q1p5bmBMGWpFgB4v4l6pgMweSZ39xkScSBol3GZgeY/cHHHzKh2ngiGKiZuab1 Q2tiW81XjCEiSpZywmVvCx2jwPIpbpUdGWetARjxtx7IuNk+2vLW/UgKaeOlHx6HaG bJmpCr+w0cKAwzpIJPCicRYW64MFIlAmzHjtywCJ9CKKQjZvjVNjoJiwWqFSLQ7cDl tzXdjnvs2+3Shtz7WX8kLmFDw3/6tCBkyBzrAUYCvDla9Ny5JCeePSRTr7e62xPpZg PNYRoT4Mzwn333ihQj1Ph2GnSXJUQMI/H7rJcaXmdJVi6o0Wmn7JsSFd7DrylGt2kd fwasqzz7SlSLQ== From: Simon Horman Date: Wed, 05 Apr 2023 19:29:48 +0200 Subject: [PATCH net-next] net: sunhme: move asm includes to below linux includes MIME-Version: 1.0 Message-Id: <20230405-sunhme-includes-fix-v1-1-bf17cc5de20d@kernel.org> X-B4-Tracking: v=1; b=H4sIAAywLWQC/x2NywoCMQxFf2XI2kAdLaK/Ii76SG2gRmmmMjDMv xtcnsM93A2UOpPCbdqg05eV32JwPEyQapAnIWdjmN18cmfnUYfUl1lJbWRSLLxi8T7ma8mX4Ap YGYMSxh4kVWtltGby08m2/6s7CC0otC7w2PcfiPhXhoQAAAA= To: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni Cc: Sean Anderson , Geert Uytterhoeven , kernel test robot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , linux-m68k@lists.linux-m68k.org X-Mailer: b4 0.12.2 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 748E71C0018 X-Rspam-User: X-Stat-Signature: etj6ts6i6fb3uabcxkhhtw59h54fwfxj X-HE-Tag: 1680715808-430630 X-HE-Meta: U2FsdGVkX1/zetEC4k/cHtlenpeQuoKXS3h8b/YTjd0+RENW+L07ITBnddPK8/ZKNyi5rhIHPRmjDw03rsUYjm3NnSkQC/Tvz/lpKWt8UV8F4Vq71fRwqR8L6lLQ/askdguGPKpiO1/fZ8nNlrs14FPeUFin3+uRsl8Onupxrs3uUA/4yCwqIIW+tdSoOotrovxD73OkSLmrYZen76CG8lZg3Yb80XgVGCjRS4kU2wxc66DE+3IXFTzX/WZDJCM5fbsjhaa3SVajghZfY+I12nFCzW8BkHl9m+7pnLbL81qRpsLQNmjbUgY2hDzeF42N34j3pec1EVHrDXbs4Cw/wOgs0yi/a1hYyHd2d6c5DYV2/XPrs0JXZ+3ut2ba/yO82KQ0lMxVigXgKGy0B8NNYBXIC8rkvmjxQpaUzChv/INEHoN86yUHiZ5QlB63tXfJjesNWe4KO3u5kIrjAmj7PN7i4/3KWUhwFtLUhCfb5vbtgiOZKgdoDyrN1EwvDRPk+gIkfMB5MCGy9N5j0GGoX3932/Tw/sR12UcTcs4gWmUTy4bOwO3+FRYLP7PN5mhaVetMpWp/PSL3xL1xEkwXZt9saK1AP0ar4/uphM04+dg5g5xmieI7zsu8mm5KzzBpArBkq/07toLMoMV1Lj+9mB+5bJfkjQdBo3PsnuI6ELRrODsAYtzCF357vZnbm25UGXHzTY+Z6PGeteSpxBov9KzfMsW1DFvsD7IMQVPfUf36+ny5or8s1MRH3Erpa5uTNsOKm8jqpRp0W8fCXCZh+s8eaWD2CC6v15geL60y3R5oUUBIRGK3o2d1udNTP7t6Kj1UUP+s+5Aq5rjYgSFW6HpUF9oCnLBScaZPerxQOu18zBnLpaOB79KX8IbbBHN9tr3Fnhr+wFgJCQqc0IgeuxJGOgvORfABVZ9lWDOL9SwS6SwhK/zqqNFyYD80mUxIrbTe62rGiZAI1nkLZGG eezlOUPQ D66Qx2hQ7E5V95b90r2iYde6X4MuAnzHjgL7Ht1yEnIyPj5gy7wmTsSJYvfoiHW6/FrzpasLCX/WSAxkkzQXhrbYw9eTUFrCJreE1B6V6agLPOvDkDEKZETyaRAtnlVYLWtroQyTlzS8Aj61TwmYYtHTx7HEdI4DnDDsLWN4C5LMsczXOrvuPCKlqO2n7jWWCrcUibjwqvn/Br4k9y7F2cjvTVqGaMHs7Nc0Dp4IJx82jt0rg2MQ8SqC5uNBe49Ont40tzrB6bj+oYhOt0wzfM2IJ43IAIUmgfEuMyGSfD9mNBsEoRrk7zm/P7nwLBDjimrnXydnz61Y1zAPpEH5EK8Y7R4QhJzR2uVdm1BDdfoiGJdWXrWTvr9zL/0x1kCPuVXm8ztjfhGmmVYaTPmi95GR+TCKcKlgG2/kAwZEeKWI1Zh+QAvonIq4+QXvOqVeFIUC6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A recent rearrangement of includes has lead to a problem on m68k as flagged by the kernel test robot. Resolve this by moving the block asm includes to below linux includes. A side effect i that non-Sparc asm includes are now immediately before Sparc asm includes, which seems nice. Using sparse v0.6.4 I was able to reproduce this problem as follows using the config provided by the kernel test robot: $ wget https://download.01.org/0day-ci/archive/20230404/202304041748.0sQc4K4l-lkp@intel.com/config $ cp config .config $ make ARCH=m68k oldconfig $ make ARCH=m68k C=2 M=drivers/net/ethernet/sun CC [M] drivers/net/ethernet/sun/sunhme.o In file included from drivers/net/ethernet/sun/sunhme.c:19: ./arch/m68k/include/asm/irq.h:78:11: error: expected ‘;’ before ‘void’ 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); | ^~~~~ | ; ./arch/m68k/include/asm/irq.h:78:40: warning: ‘struct pt_regs’ declared inside parameter list will not be visible outside of this definition or declaration 78 | asmlinkage void do_IRQ(int irq, struct pt_regs *regs); | ^~~~~~~ Compile tested only. Fixes: 1ff4f42aef60 ("net: sunhme: Alphabetize includes") Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202304041748.0sQc4K4l-lkp@intel.com/ Signed-off-by: Simon Horman --- drivers/net/ethernet/sun/sunhme.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c index ec85aef35bf9..b93613cd1994 100644 --- a/drivers/net/ethernet/sun/sunhme.c +++ b/drivers/net/ethernet/sun/sunhme.c @@ -14,9 +14,6 @@ * argument : macaddr=0x00,0x10,0x20,0x30,0x40,0x50 */ -#include -#include -#include #include #include #include @@ -45,6 +42,10 @@ #include #include +#include +#include +#include + #ifdef CONFIG_SPARC #include #include