Message ID | 20230405161854.6931-2-zhengqi.arch@bytedance.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E195C76188 for <linux-mm@archiver.kernel.org>; Wed, 5 Apr 2023 16:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3EA26B0078; Wed, 5 Apr 2023 12:19:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBAAA6B0075; Wed, 5 Apr 2023 12:19:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0DD86B0078; Wed, 5 Apr 2023 12:19:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1D9D6B0074 for <linux-mm@kvack.org>; Wed, 5 Apr 2023 12:19:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C2D57A0D34 for <linux-mm@kvack.org>; Wed, 5 Apr 2023 16:19:15 +0000 (UTC) X-FDA: 80647847070.07.90BAFB7 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf01.hostedemail.com (Postfix) with ESMTP id AD2D040013 for <linux-mm@kvack.org>; Wed, 5 Apr 2023 16:19:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GyF6XruE; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680711553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIf6WOekKcX5cYk5n6UfHyTuwolCuQ5aOTxYYMf+HPA=; b=NS2UqCOYIl8a1kbvizPfnRG0awp4syx4AquGq7XonQu5SWXUpePyCtsYypXNtmqNuWv9A+ iZb+NUJ9Qt9kMz8a0wWNTkR49amiyOf+Ue7Gwfw7DDTJk5r+U9P0o5rR4ZRygrnYmUsSIu EdK7XPaIO6Dkiplu3iPHp0Qp/0mosTY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=GyF6XruE; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680711553; a=rsa-sha256; cv=none; b=Z+BZuAtM9SBHfsBZjfI0hDukwKak/2MSxsNW5KMaMVE20sc7SVJ3ONN/n/+6LoFXQSgTN4 f48aExLwQj1tPZ0JSL3dTTmdSMKs2xh+Hf/2w5i1Q6BLxyIf8UidzriePEjrIjgn8S+9JK FxtRqP2cdGDD7tsWxRQoobSarfxZBi8= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-242cb01a788so121646a91.1 for <linux-mm@kvack.org>; Wed, 05 Apr 2023 09:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1680711552; x=1683303552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hIf6WOekKcX5cYk5n6UfHyTuwolCuQ5aOTxYYMf+HPA=; b=GyF6XruEcbEScRnuqs6RQtdnVAffeAwDNhR2YCAmw+Qc8S0WRFoL3Sxb4xjqjwQnQq OJ8Jiu9y2bolJdZp3mVpP2NSYELRJRHnJhmmEf704erywyOH/2UMAWbPe1zUpU1HuWGv VSOVAZddOLhrbspdDkzCd879KiYIXO2SObxHTSB/0VdvDjNYdSg/GRsAtG8hhds2RC8i 0YQxpgt1eQwUExDD4y4em5xkDQ4Ja2RDE4QesV1V72RAvOfmTpQ6TgOhMRmSY1LBV0Jw Y3K4AtG7RcIN10tIjIywe0UgWQ8Pfvq8uXWnf35XFo8HTAEdN8X6iyZOXwZycLtwVXuD 6flw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680711552; x=1683303552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hIf6WOekKcX5cYk5n6UfHyTuwolCuQ5aOTxYYMf+HPA=; b=MARkDTYOSe+b5F4tfCsDrQ5MkdIFID0cAtnJCqY1RM6LXBnDouSttwdHev0rXKSrxu hlaMm9mbKe7/nLeSKU90pyN48HIp5TAcSp7h27jBj74Msb54PBQtcfJ6vJx9JMqwlqo3 1UI7argrcSNxAWto4Afyw1I7ckrDnD1DPLX3P6chd6LjR/PzNmmifqv97SUQ3I+xpDQI xx8AkH8yX8ZoxfCd8Yfh/avo4NtZeGxIfYM36cdFJD9L8NbkEZIEAuhtb3Tkof9MlwpB xYRu4ipq1hTAXzJqgLwOvJzv9f2z8mhZ4RdjiDMhbjIEUfsQFOIpR9yt9MLGVQB0cQja ditg== X-Gm-Message-State: AAQBX9fXxovzhd4tDiYVDOIQBpATqR+bMQFy3456Sk/F3CVYHwkrNZVe vM+c3eZPVQFS5QjBEQwH/GXeKw== X-Google-Smtp-Source: AKy350YuR4SzIqLhfXjHdCg5Q5TcgtTe9L4cP8UXNGekibda/wa7NCXzFPTK0foK5aYzgJ9lqM59Vw== X-Received: by 2002:a05:6a00:139d:b0:62d:e32a:8b5a with SMTP id t29-20020a056a00139d00b0062de32a8b5amr2835918pfg.2.1680711552583; Wed, 05 Apr 2023 09:19:12 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.244]) by smtp.gmail.com with ESMTPSA id x24-20020a62fb18000000b00582f222f088sm10878011pfm.47.2023.04.05.09.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 09:19:12 -0700 (PDT) From: Qi Zheng <zhengqi.arch@bytedance.com> To: akpm@linux-foundation.org, willy@infradead.org, lstoakes@gmail.com Cc: mgorman@suse.de, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng <zhengqi.arch@bytedance.com> Subject: [PATCH v2 2/2] mm: mlock: use folios_put() in mlock_folio_batch() Date: Thu, 6 Apr 2023 00:18:54 +0800 Message-Id: <20230405161854.6931-2-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230405161854.6931-1-zhengqi.arch@bytedance.com> References: <20230405161854.6931-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: bcg4p54jfoi9md36rq4p71hkuhu4whqc X-Rspam-User: X-Rspamd-Queue-Id: AD2D040013 X-Rspamd-Server: rspam06 X-HE-Tag: 1680711553-320930 X-HE-Meta: U2FsdGVkX1+AbdvpPgpSrx0B/EXfT3hn+rHZCgLKI64fIksjxV2F5rJe0h9Kxbs4mZLGPp5rJWIelQ08ajunHrbntXpnF0EVUQCN4YZgXAoRAxlfJ3K6OjXoKIOsxQ9JZoXPfZReZDO9QTjrTFII7o8bYF5GObiyhycww/jwRSEWj66dlhpUqQajxdHn3K6Z3p4TSAhONQmeM6VZJWKjn+WMeKz7NF7PlBEESWuEGgRC4dE7r/jrDjIZOwKcngWIO1iGNj/f/Z2Rg///Tan9ko2szpIMttHXkL7N42svCatTbIo7MQILnCocVIWMRRH8Gb8SCm320/csSVypT4Ahp0ajsRDml/NmJ340LHPZQuYE0J6Q9anIQOqkRbQBwH+DqA7jkSPST2sorl5O2VdBvpsrcXxcY61nz22k3iHYGqXw2BOnAiNhChcyVwDIObgd/k9hqTi+wYX3Wslp3fSMENSqYHHg71VQlLjv9L9YBcqc3VCbjedapKqcsIZQPFzz9YTC23vk06+EMrbtLaO5DmhbEbMKq90zSOliCty7FgI5on/r158+yVzAjg1ARDPgy2eRQv3XKg4Zi8TvkajREL632bK/nsp3HAlxkjjy0uD6cJFK081XfVianycPNVqpoFun2ggPoiXN0yEVWvvJpM9B4RQ/gD4ioZVmYgXdM5hGipC4bdcRiCfw8nFwh7AgGtx6l2CvBtUAqfMyLe9afRb3nfNpMAoVEmifk2XpD1LFLkHjiAQtkj92O+mTqEgMm6dp0v7g+u4BfIfmU3bPXjseU2kp7IzSwznxZCPYtSf3EjxF+Krx/hDIxtPo6bsZ8heerLhQrtG3/YmbBwzN27SoqKosSNArp0bIS4PlcSeqHUVYT+nLmVTG+fUcKQOiOb+v0HPeJ/UCBWpsHjcw0Co8ky86e5Vi8jCzWUCyc3ynshnmoX7FbGa783DMDYxtRtZlh89PaYYF6va31MX OHUJhBa9 sBr9PVbuVaIbX0ZrmtYJ9N8fE9kMaTlRzD7Xed6z+TwAQhUia9HYXT1eunEV9ONFikALcsZzcYwCUO61+5/H27zIS73r1zmxxkaukOu4ga5EPyQflAoIErtufGPZUpVYzN+3ug6hfpNL+bdu0T/SVVsDFBfCi2DQQ3DcZbpqv1IIssIvy2ou2Cv8JwjA5SBTIwY320IDgKMoZePMr0y49OxY8KzaWHZmLEV/h+FYVEE/Kl7J8C0gKAVa218tluNa7vs50aShiyGkgwcxkWZXdeA8TmGFCTwvYyBhNmXK5w8fKYQJgsb64sC6bj5sM0IFY6BxA+ebMOrt2qeh7AIO6tczfjrr4sVX50zNQ1+gFQlp80vYPONogDMOAy7auTo6nKOrXFgdisUGZbbjfLJTARineF9j6UuPMM/C5je8we+uvcdioC2m8I8bMUStgxiUOVb2G8Zu7cdsoJxtRpdLOx1dkC1PNO+g6UxEF X-Bogosity: Ham, tests=bogofilter, spamicity=0.001247, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
[v2,1/2] mm: swap: fix performance regression on sparsetruncate-tiny
|
expand
|
On Thu, Apr 06, 2023 at 12:18:54AM +0800, Qi Zheng wrote: > Since we have updated mlock to use folios, it's better > to call folios_put() instead of calling release_pages() > directly. > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> Acked-by: Mel Gorman <mgorman@suse.de>
diff --git a/mm/mlock.c b/mm/mlock.c index 617469fce96d..40b43f8740df 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -206,7 +206,7 @@ static void mlock_folio_batch(struct folio_batch *fbatch) if (lruvec) unlock_page_lruvec_irq(lruvec); - release_pages(fbatch->folios, fbatch->nr); + folios_put(fbatch->folios, folio_batch_count(fbatch)); folio_batch_reinit(fbatch); }
Since we have updated mlock to use folios, it's better to call folios_put() instead of calling release_pages() directly. Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> --- mm/mlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)