From patchwork Tue Apr 11 14:37:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13207695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E027FC76196 for ; Tue, 11 Apr 2023 14:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB31C280001; Tue, 11 Apr 2023 10:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D627E28000C; Tue, 11 Apr 2023 10:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C039D280001; Tue, 11 Apr 2023 10:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A82B928000C for ; Tue, 11 Apr 2023 10:37:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77DAF80DE7 for ; Tue, 11 Apr 2023 14:37:11 +0000 (UTC) X-FDA: 80669362662.06.72BB967 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 2DA5212001E for ; Tue, 11 Apr 2023 14:37:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzPI7v3S; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681223828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YHYJ58zGg50V/rRl2bjqWR/GYgPheUUBpiJEBWpxlTQ=; b=RoZzBIYuJ42zn5bqX36rrwGXmML7WievpU35Z+9SCxMuIi+6SvawJiPaXoP0paBzICWIbY DGOMPZNP+SUSTD/rWGt/DINJwXFh/qHmKGlep2zQ46vloOlNv74qcg6Q5/iSoS3CEs1aIe tsnaKkosNMuRcWDdx2dqkpa6yMfsivU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzPI7v3S; spf=pass (imf29.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681223828; a=rsa-sha256; cv=none; b=ByASHlFC3GZt3MUqEvj6UCX8lTt1tIQJjMy9VVvNvmb7PSeg2NIlKOMpWlmb/haA8tbMDo pEMxP+g2E3Tv8DPnPDAjPkl9b97hLBHjEDDMgyhGUD90aJBioOOrC2wWicNwLgJsrar5v0 AKBq0QyLishvkfmUBkY6ine7BCBkZYQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 60B3F627AF; Tue, 11 Apr 2023 14:37:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C8FC433EF; Tue, 11 Apr 2023 14:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681223826; bh=Awb6q4i/Q5m9mXXhrXc+BP9AQEQgndLooZSbj9YNpPE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fzPI7v3S7qN/G08Aq6LYTNv0NKM9fu4g0hJuZR6XFHbF7ihRuAeDxXOaXuJOkOTVp Vk1rmLqrdQE0rlLC/CqOsDXA3rEJ9n0UM7RjrHyyKk3FVCDD25Qocp/JA7evtaJrhV fse4d3jnaSqKPSTcjkn8BOl1WiY49jRMMJhM7BkLjuN7pwpyoeLx2J1lcU37Hfc8DK mqhThaLYJP7Y8795gicp9jSzG+8qpuHu1agOLxRQt7yjqMcbNzujso+isKjTK0A89U SpipD7P5bfXbxPE0ogu3SQv3WdMP94X/44cbGZwZLuRJbwRL3WiXIL9dI8iJf00K76 cY2LycIOshb4A== From: Jeff Layton To: Alexander Viro , Christian Brauner , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Dave Chinner , Chuck Lever Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: [RFC PATCH 1/3][RESEND] fs: add infrastructure for opportunistic high-res ctime/mtime updates Date: Tue, 11 Apr 2023 10:37:00 -0400 Message-Id: <20230411143702.64495-2-jlayton@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230411143702.64495-1-jlayton@kernel.org> References: <20230411143702.64495-1-jlayton@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2DA5212001E X-Stat-Signature: bfnk7brqtn8d753idjuqyy19ap3u5173 X-Rspam-User: X-HE-Tag: 1681223828-423608 X-HE-Meta: U2FsdGVkX180rbEyyA02ICyfh3eNwWxzgZd4ZcIow6g2JHQzSyPQb5fHK7E9qHEN3kKOap0BxuLbhyVGB2/1NGlNkfH83K/OwF8ZyUS30Edi5QQsYUbzmmciaMCCVJFUszN9/jfjXu5PR4auYjp/AHCcsI1p/cZ18IOzu4Sb5wijp1cLzLAlZOyPzyQGWxkzwunqjzzHqtA6/83LeYhDqiADGrwYlqs4lsZ3UYKwvPbm1AxTAAwocPcCEqwKMT3E0+Vy2/eTYpBp0e+2LXom+Bn+i38J+6astaF13QYvgOk78c5RFGNP9Gk2fB5LMbN8LKPcXqoqmeNg4FCeX5TazazkvKZeP7uo5up0iq7nK9HPGI6PahGr4zB0YIqQ5R5MbZLyajeVZA9IyEQ+z+s+G+JulfU2GYi+qS2iZ1ZR1Hhx46TAisw8Tvd/w03illfuDnbwoCpqcpNn5ZdR92ZVjr+bL3vfnK6KjUWbYFaj8It6G8drcOveXaKTGAxjkYNXsBKv1gOITWrbnjULDEq214KnsEG2rNjlKDDlRPqjK6vQRnLqJu2EnmlvqQABD6mqW9E2wNpRUaxzTOOoZj0R5qVsWRb3Oj6cQyu/hMWrhaJGcvqqbkLHlLD+BztuewsaT5rxYslKRBlH0nVxuy4V5C4sbUlg711ayNA3kHJpR8zg4dpTRYZyFQ7Ht6wj0tFeDypvgY5TrEauAuq2P5OwYr999GnDnjWqGbJYkjo2ffZSFzWPthOVG3PoQ7L5+iPsYnxgde2K8ammueQlTfYzL7RjU4jhPBVQ3tZovK9Y+3/NIiv8TbIO2kYa+NgqNhOhog1KeqJi+B6kwCMT5OfiFbIKP2BCxt2piy3b1KyO5hap4SVPMyzz59U8KqSvtHYA4SRIDUduUiN3xUrXWQk2x58RSO0qbFJk08cYnIdR2UE//wdNxbYS5VNociPqKBrJa2mtEPuqkDCWcMMFbeI BU4/6TFj saEid5YqUKET4irVNZySV2SlrElsH1l75+R1HVFNSodgCj4lwjJYix/Jy3Wq7+0r4KnI88vKVY7ChqBpYXTCUrRE6mg+K/yb0oc9HQ2z+gtu/Wr6j9b4U/ngd8IG6CxjhxC6ejEdKPpeSBNf3pBidrzqu1v+mX0M+CT+DWtC2CTox4IabC9SEuJHyJNhDScUmuJo5TYcJ245Lypxb6hdBJ/NKIDTv+UIYewSV9nS0zdQvmDfe2fXlVaj6WTFAJL5wck+jphbsFl+qWwpZM6Ue4IM10qYmoLUaN+KpbO4eVwPe1dGEPVXCw+Xwn+7sqpk7EQ6BrZ6yVNUBH9zWeBsunA6SL7LxKsZAQCcT0irkfs9UaMtdc15wu9/reApJWrj2KHH1duWOujEs3wecEPaSHNniXWgnX3ktMw8Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The VFS always uses coarse-grained timestamp updates for filling out the ctime and mtime after a change. This has the benefit of allowing filesystems to optimize away metadata updates. Unfortunately, this has always been an issue when we're exporting via NFSv3, which relies on timestamps to validate caches. Even with NFSv4, a lot of exported filesystems don't properly support a change attribute and are subject to the same problem of timestamp granularity. Other applications have similar issues (e.g backup applications). Switching to always using high resolution timestamps would improve the situation for NFS, but that becomes rather expensive, as we'd have to log a lot more metadata updates. This patch grabs a new i_state bit to use as a flag that filesystems can set in their getattr routine to indicate that the mtime or ctime was queried since it was last updated. It then adds a new current_cmtime function that acts like the current_time helper, but will conditionally grab high-res timestamps when the i_state flag is set in the inode. This allows NFS and other applications to reap the benefits of high-res ctime and mtime timestamps, but at a substantially lower cost than fetching them every time. Cc: Dave Chinner Signed-off-by: Jeff Layton --- fs/inode.c | 40 ++++++++++++++++++++++++++++++++++++++-- fs/stat.c | 10 ++++++++++ include/linux/fs.h | 5 ++++- 3 files changed, 52 insertions(+), 3 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 4558dc2f1355..3630f67fd042 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -2062,6 +2062,42 @@ static int __file_update_time(struct file *file, struct timespec64 *now, return ret; } +/** + * current_cmtime - Return FS time (possibly high-res) + * @inode: inode. + * + * Return the current time truncated to the time granularity supported by + * the fs, as suitable for a ctime or mtime change. If something recently + * fetched the ctime or mtime out of the inode via getattr, then get a + * high-resolution timestamp. + * + * Note that inode and inode->sb cannot be NULL. + * Otherwise, the function warns and returns coarse time without truncation. + */ +struct timespec64 current_cmtime(struct inode *inode) +{ + struct timespec64 now; + + if (unlikely(!inode->i_sb)) { + WARN(1, "%s() called with uninitialized super_block in the inode", __func__); + ktime_get_coarse_real_ts64(&now); + return now; + } + + /* Do a lockless check for the flag before taking the spinlock */ + if (READ_ONCE(inode->i_state) & I_CMTIME_QUERIED) { + ktime_get_real_ts64(&now); + spin_lock(&inode->i_lock); + inode->i_state &= ~I_CMTIME_QUERIED; + spin_unlock(&inode->i_lock); + } else { + ktime_get_coarse_real_ts64(&now); + } + + return timestamp_truncate(now, inode); +} +EXPORT_SYMBOL(current_cmtime); + /** * file_update_time - update mtime and ctime time * @file: file accessed @@ -2080,7 +2116,7 @@ int file_update_time(struct file *file) { int ret; struct inode *inode = file_inode(file); - struct timespec64 now = current_time(inode); + struct timespec64 now = current_cmtime(inode); ret = inode_needs_update_time(inode, &now); if (ret <= 0) @@ -2109,7 +2145,7 @@ static int file_modified_flags(struct file *file, int flags) { int ret; struct inode *inode = file_inode(file); - struct timespec64 now = current_time(inode); + struct timespec64 now = current_cmtime(inode); /* * Clear the security bits if the process is not being run by root. diff --git a/fs/stat.c b/fs/stat.c index 7c238da22ef0..d8b80a2e36b7 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -64,6 +64,16 @@ void generic_fillattr(struct mnt_idmap *idmap, struct inode *inode, } EXPORT_SYMBOL(generic_fillattr); +void fill_cmtime_and_mark(struct inode *inode, struct kstat *stat) +{ + spin_lock(&inode->i_lock); + inode->i_state |= I_CMTIME_QUERIED; + stat->ctime = inode->i_ctime; + stat->mtime = inode->i_mtime; + spin_unlock(&inode->i_lock); +} +EXPORT_SYMBOL(fill_cmtime_and_mark); + /** * generic_fill_statx_attr - Fill in the statx attributes from the inode flags * @inode: Inode to use as the source diff --git a/include/linux/fs.h b/include/linux/fs.h index c85916e9f7db..7dece4390979 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1457,7 +1457,8 @@ static inline bool fsuidgid_has_mapping(struct super_block *sb, kgid_has_mapping(fs_userns, kgid); } -extern struct timespec64 current_time(struct inode *inode); +struct timespec64 current_time(struct inode *inode); +struct timespec64 current_cmtime(struct inode *inode); /* * Snapshotting support. @@ -2116,6 +2117,7 @@ static inline void kiocb_clone(struct kiocb *kiocb, struct kiocb *kiocb_src, #define I_DONTCACHE (1 << 16) #define I_SYNC_QUEUED (1 << 17) #define I_PINNING_FSCACHE_WB (1 << 18) +#define I_CMTIME_QUERIED (1 << 19) #define I_DIRTY_INODE (I_DIRTY_SYNC | I_DIRTY_DATASYNC) #define I_DIRTY (I_DIRTY_INODE | I_DIRTY_PAGES) @@ -2839,6 +2841,7 @@ extern int page_symlink(struct inode *inode, const char *symname, int len); extern const struct inode_operations page_symlink_inode_operations; extern void kfree_link(void *); void generic_fillattr(struct mnt_idmap *, struct inode *, struct kstat *); +void fill_cmtime_and_mark(struct inode *inode, struct kstat *stat); void generic_fill_statx_attr(struct inode *inode, struct kstat *stat); extern int vfs_getattr_nosec(const struct path *, struct kstat *, u32, unsigned int); extern int vfs_getattr(const struct path *, struct kstat *, u32, unsigned int);