From patchwork Tue Apr 18 21:02:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 13216158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E3BC77B75 for ; Tue, 18 Apr 2023 21:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFDF88E0002; Tue, 18 Apr 2023 17:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAE4D8E0001; Tue, 18 Apr 2023 17:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9DBE8E0002; Tue, 18 Apr 2023 17:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA3968E0001 for ; Tue, 18 Apr 2023 17:05:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8EA471603E4 for ; Tue, 18 Apr 2023 21:05:10 +0000 (UTC) X-FDA: 80695741980.11.A689D32 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id DEBDAC000E for ; Tue, 18 Apr 2023 21:05:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NHeQkui+; spf=pass (imf28.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681851908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=laHOqnD3W3CUxia0m/O9KtMK5N8jzZS3g0NpgnSfrrc=; b=2lXx0m9id4p2a4G0NexLt9RYvNJAxx5EbKhq//KQDV0TZa7XeZsgbRePDzG71Rr9XdRckW IxiltdSEiw7xAKRlPsjOvOZIZfuDdbBGaVsUPHCyXBWnDB7BA7MZneaqDYbweUl2yKb3F2 n1WmkV8vFZdCwfW78fTW2/DGktkl5BE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NHeQkui+; spf=pass (imf28.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681851908; a=rsa-sha256; cv=none; b=LfJfZpnncIhdZOEKIuPUWx/xM3PKdnHoKTlu+EmKMC73s9INATA17w1Bdp+45/mS/TRGrA DGqS+xEwPhSS2hnvQRK/i6ajk75i7aK5FBHUNUVhhv9+TPR239ecpHJpLmexuZP8RCK98Z peXrick3CyyCq3uVuNOgZR4ITMp4qIM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681851907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=laHOqnD3W3CUxia0m/O9KtMK5N8jzZS3g0NpgnSfrrc=; b=NHeQkui+9NyvMQdS2fzo4ycQzckjd5eB7/binzPCQ+jWA3IoptojJMj13ix4Ji1bpEGwfU NXG5+hZdwSi73lJd5k5hvPLwtT1Quwa6oUINLRlK12RFHHGaaFgIVzTIJ6XnWNfOg50AdB co8jytI5KkOIXZh6c3Y7j5JBOB4xJ6U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-7qqHD665M82NvQjDcbQGIg-1; Tue, 18 Apr 2023 17:05:05 -0400 X-MC-Unique: 7qqHD665M82NvQjDcbQGIg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A60F811E7C; Tue, 18 Apr 2023 21:05:05 +0000 (UTC) Received: from llong.com (unknown [10.22.34.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id A57F920239E0; Tue, 18 Apr 2023 21:05:04 +0000 (UTC) From: Waiman Long To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joe Mario , Barry Marson , Rafael Aquini , Waiman Long Subject: [PATCH] mm/mmap: Map MAP_STACK to VM_STACK Date: Tue, 18 Apr 2023 17:02:30 -0400 Message-Id: <20230418210230.3495922-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: DEBDAC000E X-Stat-Signature: x6piuxqpa79wy8wpe9wd4zjdqs1e7rdg X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681851907-472531 X-HE-Meta: U2FsdGVkX19fZR2Yvh3rzzBt1DQtteWd6hISkpB4xIFmrqwgBYId94BsHNWV+XuEk4ro97cKmh8stVtodzUteUwhlWYRAMkuwTArEQ/7stQNuB0qBh4o6Ulq8EYxXfHleJUxGmnXQfsYMz/2DPBTbT57al/cemYc8bRkbrR8k4fOIGUdo766m+mSAqvBb1DO1qqg7EOla0EWYqfJFVUb2q031A1Ep5EzQOniXWvnBsNIRPadz4UC9aBxIl0363WU8sSjBiBhzmA/DaI3OB7wT+13HvNWWsPrBcwTnHKAXi0tvxK12V+c4xZdMlzbUovP3pXqwMsGJpN8UWeaaCqEmDpa60TdLjnsr1KToUo41H8Irbco1cR5nunU/K1zXSTc7J88fTT243BrB8xRXNmirsXHoO8Z1tIqj4Hfb7TITbiUkwp84Y0CYB7XHf/RJD3RuMhOhHOwDIiUTKZztkU2czi8wiDgbN64Mha4/E3gXk96NJZtD+8/h0P0wTXMUzauhqgalRx7+T6GSHckqdfi6JmQ+Yr7HRMOgRGPv+vmoA2/xXnPx4Xj+htDKvPWdYQdhR6J4qBk3+UeDUSYjm0Q/By/0zxmEtGRTnvLMQ5UzQ9soWAv/rg8j5ISU1OeN9/hSIK2q1dGJTd47rk68q46F4KkCFvYCon238xGGOuWjavDTapej3IDgXcesNErw1j4hh8hHfpkel9j5Ewki87cr+fYGZ27Rkz2PPOHtCEUJlUgnyS4gKKk/KdbU9vh7ZbU1idyVatBLsDMq857qFmyaw6RAkzZAy1tOogAEddNnJCmPmLmPhvi6hK2WomJcyQjiBD5jSWwPnGIJ+HD3BVgQZV7c+9/Mp+18rHQKZYNwEY+7JOFBnU7He/nsGxFP9rqY1OwWBl1q/OoGjHHxFZcBbIAxXVXI8GZVoBp/hG5+fDS+Ko9I2HB+7iT/M/y1+B2/eOtl83wzrICbnSLG4A 1MjrGixf 8C1wDu5mTbvbnlWyCTceMESptMNScwSipidnXlNElzpM9bSIA2bKeQC4PTnqcu0l7t+ajRZLaQ2H6iueaERNF5vMKsG/TEp5tW4Z3lPI7U+KZIgNd3zIkoBPeWgYKLPyDn7rWF0oqAGGVPoEVRCNioR8BCb88Es9P1QuBOooS2hfKcwOKThOqW3IHbggLDiIwVHXrLdPiYoI2vziJrOsB8e5YZcnz5hWUSgsl8OrAmx95pMY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: One of the flags of mmap(2) is MAP_STACK to request a memory segment suitable for a process or thread stack. The kernel currently ignores this flags. Glibc uses MAP_STACK when mmapping a thread stack. However, selinux has an execstack check in selinux_file_mprotect() which disallows a stack VMA to be made executable. Since MAP_STACK is a noop, it is possible for a stack VMA to be merged with an adjacent anonymous VMA. With that merging, using mprotect(2) to change a part of the merged anonymous VMA to make it executable may fail. This can lead to sporadic failure of applications that need to make those changes. One possible fix is to make sure that a stack VMA will not be merged with a non-stack anonymous VMA. That requires a vm flag that can be used to distinguish a stack VMA from a regular anonymous VMA. One can add a new dummy vm flag for that purpose. However, there is only 1 bit left in the lower 32 bits of vm_flags. Another alternative is to use an existing vm flag. VM_STACK (= VM_GROWSDOWN for most arches) can certainly be used for this purpose. The downside is that it is a slight change in existing behavior. Making a stack VMA growable by default certainly fits the need of a process or thread stack. This patch now maps MAP_STACK to VM_STACK to prevent unwanted merging with adjacent non-stack VMAs and make the VMA more suitable for being used as a stack. Reported-by: Joe Mario Signed-off-by: Waiman Long --- include/linux/mman.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/mman.h b/include/linux/mman.h index cee1e4b566d8..4b621d30ace9 100644 --- a/include/linux/mman.h +++ b/include/linux/mman.h @@ -152,6 +152,7 @@ calc_vm_flag_bits(unsigned long flags) return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | + _calc_vm_trans(flags, MAP_STACK, VM_STACK ) | arch_calc_vm_flag_bits(flags); }