From patchwork Wed Apr 19 14:09:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13216882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8AEC6FD18 for ; Wed, 19 Apr 2023 14:10:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195ED90000A; Wed, 19 Apr 2023 10:10:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121F2900007; Wed, 19 Apr 2023 10:10:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8CDD90000A; Wed, 19 Apr 2023 10:10:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D49E0900007 for ; Wed, 19 Apr 2023 10:10:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A113C160171 for ; Wed, 19 Apr 2023 14:10:50 +0000 (UTC) X-FDA: 80698326660.05.D9BCC9E Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf30.hostedemail.com (Postfix) with ESMTP id A604B8000D for ; Wed, 19 Apr 2023 14:10:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf30.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681913448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JN1Y2bvJVpq6/q4dmcPnKZ0rBsOm/7Q8Ad5f4nAyRoc=; b=8ksO9kgtIx4/LLQ944uv3+R5sZEhGNkrPVmUYqHIpf0MNVtGq8LL4Et8IN5Tt2A0P2fV4N nWrziOJ6/bhIfmaSqWHjIOfVgyzfugwtE62UV/WH6d+oTb8HY2bhTXiw36tmXyDu8GgGW/ rhQUWR4AIwM4BSCFNMP7+zO0WGDiSGY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf30.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681913448; a=rsa-sha256; cv=none; b=LQ9QhB5beH+wi8rxlBWD4anYcGO8flXHWkBPq14lBASUwMy5RDuy05O/x1t9YFPzgGyunV Ga6WF5LtPCxTyYLtaTeXJ0TFuAQvoGjWkXkq5dV5Lq0j47DML2Ogu17TeMTd6VklVOpwEq BOPGrhrk4gD6xJCIbxF09dHM/lkB0+E= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-2f27a9c7970so3015540f8f.2 for ; Wed, 19 Apr 2023 07:10:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681913447; x=1684505447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JN1Y2bvJVpq6/q4dmcPnKZ0rBsOm/7Q8Ad5f4nAyRoc=; b=RfofQquL01IG0dPCkrr+eIPV0z5eqbe3quhgrnMf10rvCUFu9/HT0334cOWwLIGo82 DVmQNjd2KYUdxxow29hNlo0FxxqDOUYGkpzV7TfIILKQn0/43LAhWgEhJX/JBFjipKvK H4agat4MyMo3TwFTv2BAs+uBQItI61DicB5BgeJ87aGyfxTPaPlxrzF/8EEEUdkHyIaW gKR77tT7RQqJkXXLf2cnxRxn2Nqzc4X3Oy5PCbyJMMt9EtNCYQxvGhkuRbW+PIQZFjMJ S2yzmI72haQtJNCyyYGFur/4TM6Oc8cfECvrzd5dNuH6JoLCVhzvmBgnp/k0tXuUWhm0 IEGA== X-Gm-Message-State: AAQBX9dFuPmOB3dwHKFNGHfGCMBl202YRNpAO11tIlLBBEdEjGXmZxUC alguhXL/fiTHubYsSG7sEw8= X-Google-Smtp-Source: AKy350Y02nCXtd9Ex2dTiMUqdMuZubY7+g/E9AAW5VIMPA7K0NU5P6NletE91Ad3MZoVtt3NEzGYVg== X-Received: by 2002:a5d:5546:0:b0:2f6:8ca4:a71e with SMTP id g6-20020a5d5546000000b002f68ca4a71emr4777763wrw.52.1681913447180; Wed, 19 Apr 2023 07:10:47 -0700 (PDT) Received: from localhost.localdomain (aftr-62-216-205-204.dynamic.mnet-online.de. [62.216.205.204]) by smtp.googlemail.com with ESMTPSA id q17-20020a5d61d1000000b002faaa9a1721sm7612089wrv.58.2023.04.19.07.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 07:10:46 -0700 (PDT) From: Johannes Thumshirn To: axboe@kernel.dk Cc: johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal Subject: [PATCH v3 12/19] zonefs: use __bio_add_page for adding single page to bio Date: Wed, 19 Apr 2023 16:09:22 +0200 Message-Id: <20230419140929.5924-13-jth@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419140929.5924-1-jth@kernel.org> References: <20230419140929.5924-1-jth@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A604B8000D X-Stat-Signature: 3t8xasf9iym5f4pq4cj94qf3bfyzijdx X-Rspam-User: X-HE-Tag: 1681913448-901154 X-HE-Meta: U2FsdGVkX1+1T37M1pH3sc+G4zvLVIp4bHe1DuRXOXrdECxtOpm7RQiuL0KZpWLd1n2+C/HEOhSDeJ5YlA3CKUMes4/lW7CrUC3bLEgRmpg6KT+8VwEpBJHyWGog//+SmP90kE+zBfqED68WrKzxPnBDI9u8NGlUHgNIAdzb/wsVcGr1eac2QWbBNu4UZX64HlwaOMHhrszDtQfErBqxNgtq7PNJLGWiHj5RtWTSGcRRid2LMddkYH6Uhe1lli1Aa/EmV06teHep+443RU5x9/J2lmPwrqKAhBNrgnDNgawPWRDshqPt5e25fEnzpLRl2fgrUYFiFW8j/7iQR+qdf71esDaeQrh1NpNMqwltH9WP7Cu7w6vSZdKs/CKqyMlhmkWiR+Oezlu+ufkDqq4WeXphOKnGYNbVFJux0KW2cbQEqfYcQhYDiPOd5qMi0m/CI6h6Tn8ETjbVC2X3RrIJlGx1nMV1P8r9u52k9uFRnZCoDUpH7kLf6pjTA2YJxkM/w/jj1IDYOrLsKLX9UiVzhgmumrO14NikZh8pIyn94dkN05qlcYdBVE8tTG82vnKXtBrqv4TfPuk1N8B+7dOlN8t4mxfIzgUblcQCljyNpbHDHcWrXovzrTOcotILyHfjnnG3U92c+jOQjtYw2k+wFpzDPWf11/etoQXNl9XG1jFDEZKsZ6wzyMr3+H6hjh5yQyctttP5tnYnO+dizbQg8gzL9//Rp/3RLTd+G0rfcA1hapBQoWuhgJGyvPtPdcPftbdYOdQvIwmLN9USLLObICSEM4xcm3obP7/7uuDVMH1lJ/UwBScQJp/M1ZR9EzP6wVO3MFyvqvsWYDFO4RGOpQJcjObBjOPHH8XMzO7ZHWbnxBLF4G5QJYul6Q5BaxZsjpbrUna9rbkbIRjQ5+V07W1L619C5RZbIK+nxAmY14EyTVpiDaEcQp/AhmpmV/dCjmq1pZwb36OlphFKAsH vwHvm/9u 49CCnJ3uH2m9PRcp9xFF1vWIKGPL/uLAppgG+2Yrfcl8oMcXTj2vwB8LmrbLrJrFKxl81SFqBegwF1eSRYDYGvpUDGxC6V7kGJaSxPngVmDX90H5qU8enJsBuNzSN3BFjJKrlTO+c6dUBPOIl6whyPxqNHPDJwqmOemCRYNdOUryr8LJwTPO/4QkGiQ/X7v5wljNCtSojeR5Qc7u3XB99DR5rWy8giRvZrmZ5VRO/kNabXT3iV5Rhm+pNapJJSUltHAar09zHXqpLOVrk4vM4ru1RS1iQXGrd30mxkuGllByqLbWuUaWkBQszKtGYGK6EOuCi5fgFl1dIpwtPwcNkwUM1awNNmBbaelx2+bRzNsaGazvEZVylvYvOVP3MhxFtZlzK95LtXlvnG2UiN13kD1FVgmxAggRlV2ZEN4fA/GJsyOX6Pdf30JP7BuB87kMjsOQpE2LEEzceY1ZCb+p1O55ys1bzgHMc734Sh18tAthoIRIMDe6VNU0b5o9oLJxAXlZK82L0JnLJWRD4bUHif+jLy2dckEDpR2kLNvLvGtWY59iquCsAepSaLSVVNDtYlZsePekd9p0OWQho54oOQ1SJIvLOtizUg1hr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Johannes Thumshirn The zonefs superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Acked-by: Damien Le Moal --- fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 23b8b299c64e..9350221abfc5 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ); bio.bi_iter.bi_sector = 0; - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); ret = submit_bio_wait(&bio); if (ret)