From patchwork Wed Apr 19 14:09:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13216884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FDDC77B73 for ; Wed, 19 Apr 2023 14:10:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9CEB90000C; Wed, 19 Apr 2023 10:10:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D1A6900007; Wed, 19 Apr 2023 10:10:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84BC390000C; Wed, 19 Apr 2023 10:10:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 71118900007 for ; Wed, 19 Apr 2023 10:10:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15713A02E8 for ; Wed, 19 Apr 2023 14:10:54 +0000 (UTC) X-FDA: 80698326828.17.00A9780 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 43110120010 for ; Wed, 19 Apr 2023 14:10:51 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681913452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KLQcibH4QQVSvQQ/bVwiqZIZ4Gz6ywI38VTMDoqxjbc=; b=VEDRDoDTUPj8qTcnOMqFBc6oNzCljMpY9Qww7wi7CfCf1li49UiqKiyP8QKY7SICsjtyJ5 sYtfvPNA/Z6k4bOIWZizh9xAvhXcaqhBz3IefH1ljZXVI2At6+y9o4jq5B3P8a+AYlo8PA ErBtC5aYx22QmdE3ZfXRa0WH74aCuIU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681913452; a=rsa-sha256; cv=none; b=UGcqaKbfQZZIJdZpeJj1JaBePNILWHtewCZ2v7+LkTo8cDlkTfGdxp1BispYoLQZuakzNs chdtNzkqUxA0xhs+x4MbnSjLN8zC8py0GXrWx2DymueZ/LbyYaTh6slFzu0EHlzl2BSW/B 0CSD8OUKZVLGDFenhHtPeFPPZTFP31k= Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-2f9b9aa9d75so1759495f8f.0 for ; Wed, 19 Apr 2023 07:10:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681913451; x=1684505451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KLQcibH4QQVSvQQ/bVwiqZIZ4Gz6ywI38VTMDoqxjbc=; b=kCNzm2TfTHTszfPv6TaCA9a8W222u9+0fWA0U9bHPYCiOzBhHC+pd5Vy2HVr+e0/51 0Yr/GPB1IRrjTNRiG74EK7Ag6iGNhIBUf1PJ6bTE7o2Yh/QdK42ynsqixm5zB8phknFY 1gW3Z/qFNwi09cCUJO/RSSC1TEM7bAB4VnQetYINQ8LUwTucD2ouQlx9UU9935kJAfR0 OKo1m02HpO5dI5HixaHX0i2y/7EuA/0/RnqxVEPYZ5P3xzPSpFl9KWJk1CMp8u+bba1D 8J7PPoEPLmDkGZlEU0aoGccIMCCQju8Kf5/tcwFdqXp2r1/u0ilHvNdffJpamOMH1RP5 H1dg== X-Gm-Message-State: AAQBX9cqChB73ZF7NNfBilspPrpKXmQI2HWv2Abk4DJMiXX3RuZnwk3+ ih+nN3vICMA3fzHLyCq/0Ms= X-Google-Smtp-Source: AKy350a8pHXX4xoTqjmCp8VzLpP9Mr6nWBR11mzOBYZ2TpzRIUZcgG4OmK15TMBBeqCZ8wsfO4biJw== X-Received: by 2002:adf:df05:0:b0:2ce:9d06:58c6 with SMTP id y5-20020adfdf05000000b002ce9d0658c6mr4762888wrl.53.1681913450788; Wed, 19 Apr 2023 07:10:50 -0700 (PDT) Received: from localhost.localdomain (aftr-62-216-205-204.dynamic.mnet-online.de. [62.216.205.204]) by smtp.googlemail.com with ESMTPSA id q17-20020a5d61d1000000b002faaa9a1721sm7612089wrv.58.2023.04.19.07.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 07:10:49 -0700 (PDT) From: Johannes Thumshirn To: axboe@kernel.dk Cc: johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal Subject: [PATCH v3 14/19] floppy: use __bio_add_page for adding single page to bio Date: Wed, 19 Apr 2023 16:09:24 +0200 Message-Id: <20230419140929.5924-15-jth@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419140929.5924-1-jth@kernel.org> References: <20230419140929.5924-1-jth@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5bkxjsqixpjeu5jqtqsonipgjd5xpr9j X-Rspamd-Queue-Id: 43110120010 X-HE-Tag: 1681913451-823519 X-HE-Meta: U2FsdGVkX18G2sF2Bo8gJm2gmkLodshJo8iFUmurQTViWkxN1MS57DEpAWFCZq0nL2zn7qL1Ae0gPXUVnMhbgUhJxxKArZ9PxGQf6FnrZMZlHjP4h+ICGir0KNC5UcuOQ7dyzAgo94mYpKWJ7c2W0j103pnYdUOQ93dInOvkR2cn1Wk5o5BsU6l5F5J9ATMpXqwcGr7NFQPtIN0zLNAIb6nobsE42KoWg3e4BzmBpkJPDf62DOux9XoyI2QQ124OVfCS3TZd0c++Cd+PHm9auln546499ouMScPsdaoHhcpnUHT4v3TszFPkxn5Mojqvm2kgWzyvF5En0IX7mZeDlVl1xLsUB+SLZM4+LIXPTEkrU2shOfWN/fjUviCHgz+iDSeGFUgeZMs/Z1h7QrRnBsNbc0LAzSoXGEyuywq6U2WTJmWMpa/gjP3MmxrcTc3+PVji5EBIdEXdSz3vZTCjK/6oDTSvhkHBP9KEsd3Ef7Zg/yg3nYFtnDlOYL7SlQ/W7HnFNSMEaXhTXF3N/QjXKzgNVtWH1leKXzKhlU3mzW2CbMxaPuXZsD6gimAELc9G+jqRDzyFBoewwQxSHn5++U7FxttMI2/Cg/w0/YnXELkWKHVGX9xD9NWpaxy2HRx+cK28CUvlVWvGQWGMtshLiwAzpcUbMIX+sWbNGcWOSNAOfNIgBmI9RGqT7IH5ouKTI9vCjqzHDpXYgc7cquiSQhIF6nbUH8r8G8D+gPrc6v/fWKL0GHNrevCdoYgUXfFxACnIGj6ZSSdRLFjcxMNVcuyxgxnZzYRhF5VT1OhJGu1/ShMlKCBi979ZoOCoF9jOY1tUydYWR3DxVcEwDoMVZoONt669k1ktVzDsPzRXsjW77AMLXd9RT34HnjEzkMGHAKJoIp+iGV9IY4JAwRLKLMMd4MjqTqgpiusGIA5PAUgNJLtce5sY5tNJuQhMMHVVHmYcXv8xdC0tfETKO2v PdUk8O2D Jaq3E95ehSqvPIhc4R1PuC48cQlAOVOaJ2P0YB9edgAxFreSp5vBLJ/R28alfaD/0/SpdU4JAqrDsJ8ZNB0Chh5Xd4D87KMaUQmReQJWlL3Jg3yTYQl43h5i66ARH2Te8WWRp/FQu2a81CguNPwSido7li1REib6DTEyfJ5JojtXA2fJwR58N2achJx98j0wrYxHwfrzgylNqr1vvazzfJJ1JCuGvXsSFah0fqghfiMyzqJeX25DwjksPk9RzjYRsbw2L3yHPKRt2s4Ko7/xGA0zD++XG8MeO104+RCc38iOZwcEzxA29/1abh0i8EydE5DoWzkadLqRErV3+E//cmW5Sx46VU93iVc0i5jsEcz3bD+HZ72txVQ2b4U1JLnp+4/L0s+9Ur0xvYx/2S86dxpX6fZkXptflodBHsCc7IpHcmwIAkqKzec90DuYu3tE1nsnsD2/t9UQePuk1G5uVonjM4Pl+xaJcgF0W9N5TeGz26MmSlhwhcKyXR1bhaYHCmtSPmr3ctgysWhn5w7KqpItMYgNPtovMZeb1j/W/u7JXVmFZygIBMbgouH0hOfszT7J1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Johannes Thumshirn The floppy code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- drivers/block/floppy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 487840e3564d..6f46a30f7c36 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4147,7 +4147,7 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive) cbdata.drive = drive; bio_init(&bio, bdev, &bio_vec, 1, REQ_OP_READ); - bio_add_page(&bio, page, block_size(bdev), 0); + __bio_add_page(&bio, page, block_size(bdev), 0); bio.bi_iter.bi_sector = 0; bio.bi_flags |= (1 << BIO_QUIET);