From patchwork Thu Apr 20 10:04:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13218304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B940EC77B73 for ; Thu, 20 Apr 2023 10:06:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CA76900008; Thu, 20 Apr 2023 06:06:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 579CB900002; Thu, 20 Apr 2023 06:06:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41AF2900008; Thu, 20 Apr 2023 06:06:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3543D900002 for ; Thu, 20 Apr 2023 06:06:06 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F2B151601C1 for ; Thu, 20 Apr 2023 10:06:05 +0000 (UTC) X-FDA: 80701338690.05.FDC699F Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf01.hostedemail.com (Postfix) with ESMTP id 332FE40025 for ; Thu, 20 Apr 2023 10:06:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681985164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3G8vgZAFagEXL1mcgIvsIV/u4Cz0QizBZkd2HYzCGxY=; b=MGiCnpD+3rp5XYb4nTxY1fos5R3lRiwVU8MS+B/VGxTI8YCnaPGtiXwiep1wU97hsGNsPV VSXX2ZiYL5sPtBF6fpVTLLVZgGwxViacIS1HrEMk9b00fempx6yURBneSg+cfa2EYwVGFv BbzbuBAXbUOGTMoQOIc6pUq9zqbfvb4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of morbidrsa@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=morbidrsa@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681985164; a=rsa-sha256; cv=none; b=OAhUovHONENupBFMtlu8uF5Hd4IGMp6gwW/1vVOC+vhAuvbowX50PWH/B0eldvSQN8Zy+s nFDYE9W+/LF3Ac1C9L9xlBZomn0Db59TFZvCgRsHazlXa7UZ9WgEBcQlaBVcJrCaYGsh5x r5AMbxjYpyp3pw6PNuH3H+VHt7FuL8w= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f17b967bfbso14827115e9.1 for ; Thu, 20 Apr 2023 03:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681985163; x=1684577163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3G8vgZAFagEXL1mcgIvsIV/u4Cz0QizBZkd2HYzCGxY=; b=GNLq4s2kl/m941UlcuciLoMpSiJU0oqNo9UMe225JsKo8j759bvsnY6le7xUhXFhOS IkW6oFWJsKe4M37GMwUesEOb4z81wpyf6sayxflnSodZf63fOXn8K+y3U5e3D4ZCMvn7 rANtvjE254ywd8AvTlp9tOub35ocvuSHKK5XqwFXIk4HGpRTNgzs1XdXN6EhcvFlQjBg fk/V9/ImhKLkKUyJ5h6tbcpVPcpH/RtCvw4DzEo37RvqTBltti+GnsZptr+xkO3tl+GS 6lokBq1/ANlz2equ87ylmw+w45qb+oqQPBcz3Fo0YgzqW6W5nWMjCNgLn0IFzUm4/N01 c1JA== X-Gm-Message-State: AAQBX9d5Mnif/YbiGe3m5I1FqQ7g8qrGACC+oqiMgm7V+KitoPZXvKpP bjQy8B6wYZmKW9G3L60nsBI= X-Google-Smtp-Source: AKy350Zwu6RqojLD2/82sYHKfY3An39L6ReZ+83ih6pfN87F+BwdyWXKO+szShokbvWeEtwYoIEk5g== X-Received: by 2002:a5d:544e:0:b0:2fb:539c:5e89 with SMTP id w14-20020a5d544e000000b002fb539c5e89mr1022598wrv.4.1681985163497; Thu, 20 Apr 2023 03:06:03 -0700 (PDT) Received: from localhost.localdomain (aftr-62-216-205-208.dynamic.mnet-online.de. [62.216.205.208]) by smtp.googlemail.com with ESMTPSA id l11-20020a5d674b000000b0030276f42f08sm201410wrw.88.2023.04.20.03.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 03:06:03 -0700 (PDT) From: Johannes Thumshirn To: axboe@kernel.dk Cc: johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Damien Le Moal Subject: [PATCH v4 11/22] gfs2: use __bio_add_page for adding single page to bio Date: Thu, 20 Apr 2023 12:04:50 +0200 Message-Id: <20230420100501.32981-12-jth@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230420100501.32981-1-jth@kernel.org> References: <20230420100501.32981-1-jth@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: gk8cuzmpmokx85ar3g194s4qphcffymc X-Rspamd-Queue-Id: 332FE40025 X-HE-Tag: 1681985164-606443 X-HE-Meta: U2FsdGVkX1/07JrRI0bCQfxdYvVgjZ9vzb0r7hHNxYxhXMVWdxsl9F72lMcdGGBXEqYASD+dTtUUDqSFMrBvV/xnDwZ/OSCV9QMFn0vXmsQNdWoAY5mcd7E4MbEZfIdk4MoAEo/sQLKUpkBBFj8F9ryZd9fDzRgIKb2Qh+VniPGb2pX0u0jMqieLjX7xQ4Nc+AtUXlBWGpgYLBKG7WNr/ckELqUIy7gBhMZLfesMKKiCVtXfeAtkqNN9BUus0t+9D5kykHKcsrwyvw0Mo/oU1T88nRRk5zjy8Y+6UIDIaSJcUS4QSShu4raXEy0lW7UqfxIfImCPijbvZXKPV2TNpw5ZmYBQl2vDKs0dztJrxTBe/hQ/ej00+LGgoBAFtXk1Tw+VdQ4dIetmrLPVNTOk3YVw7NgYeBer8idh39knZygclB0ZA5DT9kf5XR9QkbWIc8bQa0WllKHZlIedTPZK22fPHr1bLRmM7We0RBLIekH2gcJTTtlHFy2gbfhVgFJ/95qIS0WrQIfkwXK2M1lMVxZJBTyCoStCZ9o6XHvkcqgbPYRYSSHtK9JaoUWQLRKo1JcLZL/WrqngBlJtPCFbi0paUTQdtFwWFjvYW0Mi03vmWBmC7A8A1SCly9ysq6yfgde3d8uJe/bL6xxNpJwwSITlV5YIGEvKNZ7XQnHqCxr6sMJMFN12FnDoabbPlsdoAnFp8w3UMCSYC7cxABAoVtTz6o935z5M0mXEFtMH4w+nAFPurshtisYthVaw45Ivye4QLPwp19BW2MIDUm5t9q6QxCMW7V5SRO24KSBqKGlMy3fS7fqYowvJ2ubAMse4ui5YUjgMuM1iqmtV8kAcvVswp0usnFpDZwBOGILHy5LaWmjjlqLWzHM8cPpGc9kgX6agLK5l1dALS8OODLhlg9jj72HRHu+vPaqteLDKPLJQ7W79lk+XbczJ7e2J2iD9GbveEoPukJeoFyZwRxz WFHbsP4Z Ft7E7Qgp55iYX6vighHONJXufWUoOjjIXGLVz//oJyEXY4wMLRD/q6YxWNaTJVTi5RMbwXQEaYDrD4+/2HBOjCXE/OZWY6vFuQxxQJn3FOwZLTXxloXKGWl2ADPjU010GKRJNmZlKwXXEPy39sOEyyakXM/0OVa+3r60i4DnzdVkpyC5NXhWIvkBaL+HG5MIioLXHnR1yahp8c25XbCGXXzsi7HdF4uF1L/is4+8bww5G5B81z/5IGpQ9F5y02OUdfTA59rXAAAUES1dNiecLlJqomcjaKmoJmmONDlS3QegSrTH3pVguc8KOq9hgsWWHDPmw6YhW2kctCJ0iQ2ZOY0CjcnLxmj6gncizrIWYrzSV66lf+eJxOUKxaJ2ksgt4FrBgqwb3fmHX93m5PZmd9cnjGNTlS69XBNwpgeWEFcPdGrl3PeKoH13aX8ugUYb50OkPcB830N5zWe35Vn6NaeKBuf4TlsuqQHWfKG+Pb5ia1PXDmn8ISkbRI108SLhXoausCr1Vjym3FjOWQ4ei49CUyuAMpRTeKkK11zSUoIy5Ll9jIZChwbU7TJi0nJO9KOaitsGw22FO9wWGgk84uPXx5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Johannes Thumshirn The GFS2 superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal Reviewed-by: Andreas Gruenbacher --- fs/gfs2/ops_fstype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 6de901c3b89b..e0cd0d43b12f 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -254,7 +254,7 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector, int silent) bio = bio_alloc(sb->s_bdev, 1, REQ_OP_READ | REQ_META, GFP_NOFS); bio->bi_iter.bi_sector = sector * (sb->s_blocksize >> 9); - bio_add_page(bio, page, PAGE_SIZE, 0); + __bio_add_page(bio, page, PAGE_SIZE, 0); bio->bi_end_io = end_bio_io_page; bio->bi_private = page;