From patchwork Fri Apr 21 10:14:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13219768 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394E4C77B78 for ; Fri, 21 Apr 2023 10:14:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B72556B0074; Fri, 21 Apr 2023 06:14:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B24936B0075; Fri, 21 Apr 2023 06:14:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E976B0078; Fri, 21 Apr 2023 06:14:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 864786B0074 for ; Fri, 21 Apr 2023 06:14:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51F2B160637 for ; Fri, 21 Apr 2023 10:14:41 +0000 (UTC) X-FDA: 80704989162.07.6FEAADF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf04.hostedemail.com (Postfix) with ESMTP id 5083440017 for ; Fri, 21 Apr 2023 10:14:39 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LxPC06Rf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TfOtgFn8; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682072079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zE4KUQItN/3/UV4PaOZpW67hAUQM7k7JGXQXpSUX7jM=; b=2HCNbTi+NHPsvsrL59UUtCZgs0sleracfHk1HJXXGj43Ye5grLXUqfrwFjTJGTqm7KZjDr w5t0csHDeW5tzNMQvuyFA+6RrR/Ahj6rTLlvE3a7uZbiK6SdlvGrX/S4cQXbDjY06NWNyS R24ewNrewN6Z1twYSy/Wqof5OqGGyO8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LxPC06Rf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TfOtgFn8; spf=pass (imf04.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682072079; a=rsa-sha256; cv=none; b=ezZnq3to5XCd/BsN6osXDkuNTtWwLC2vH75PortY5BpUmoSuOmWf/NdViqnZiXqXdGuzc9 k/yTk/rYuqYqM30ij0SY88JBJMGckXM7GI8LKNQdw9Nhqx8mEPdrDCIQQnD06cug85xS1j O7S64sRbzvnScarx5Qoret62EH4KtRs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 236311FDDE; Fri, 21 Apr 2023 10:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682072078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zE4KUQItN/3/UV4PaOZpW67hAUQM7k7JGXQXpSUX7jM=; b=LxPC06RfpZaf/PV59ic/kcvwI8MQ/gLjs6JkYCNJ/RNb4xRaG70GAN+PGm+8H+ryznSgpc YrF8dckTbYzILZ5H8nPsp0rNBoS1mIsN58UGleQbLSkmKQt45pkJxWA4xeNLFKhm3E6CSB bgDU8rZ29b2J1dRT10rROtiAB8ISjTE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682072078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zE4KUQItN/3/UV4PaOZpW67hAUQM7k7JGXQXpSUX7jM=; b=TfOtgFn8V7n2eVcwCSKoDkdsIoC3KMz6ZTBfi4H+A0+FegXVYPQtLSIWwe1Nz6zW8lDvXx 1QolS+TvzBBDJnBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 542F01390E; Fri, 21 Apr 2023 10:14:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GNpvEQ1iQmRNaAAAMHmgww (envelope-from ); Fri, 21 Apr 2023 10:14:37 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH v4 2/3] mm, page_owner: Add page_owner_stacks file to print out only stacks and their counte Date: Fri, 21 Apr 2023 12:14:14 +0200 Message-Id: <20230421101415.5734-3-osalvador@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230421101415.5734-1-osalvador@suse.de> References: <20230421101415.5734-1-osalvador@suse.de> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5083440017 X-Stat-Signature: 5t1e7zs6dqf7re56tkzc5yinj7zru5xu X-Rspam-User: X-HE-Tag: 1682072079-570274 X-HE-Meta: U2FsdGVkX1+AExINR1gBkp/EF7XR1sln9EI0Bhap4TV7Az47KRVq3EQCWT9UOczn0W3fx5l/byZX58YLad5Eh1goH1cmsCZqwfpRHvjPxi0iCn+B0WRIrQZHVMRN4k5xdzlVBdg1V+sRPPdRqyExzKdBQVksImHhGSzkL5ybWC93J0O/d+Mq4ZBoawra08jjQ8eK9ferXSkfC1J/ddmQAzJzd2+wca046K2MToo4K22YnMUz+qWf5c7Rw9yvvCWFEMGbOLbeASNNH6idLd3eLz8tngeeNYOxCI/7sfH07X/PNqeZ0hNPYoc2xWk6QwkYEO0rpd2b606B/FjIJKA74/F/4Ihb3RcUbn4wbtLndpwJo5MBXyxNMOqbn2N0tbDo/FM+mafPO5+Vw/GEhdG5pvaB9I82hAwOkRjZk/aJlaLCzyy6u+pgcicYmVIAqkErIQdUagL//URGZpR7V6dKkhbkmWdFlFTCqiLAOgEUp1XnfxgRtNCNtAl5vP1a4MLizaBHMPSUoucgLful8H7UfrrLIRDpWOr/L/qI77fptDolXyiz/oHfErEj/9NOk2bkwvwK0NJqe+EmswphPvQ3EoJTv0WZxRLpJd7Vx8KztwohuyNXPxhQoNMFcjVfkPAmK/I7+38Sa07OCtwfNc4NutCs2jIaFo4JZtc5VdajzhzIPVZE+mV9AyrX4cNvJSs4st+F0N4PU8ozU9tILTxFPiMWNqMUtFx3xAMj0vnV6Yk1Wl+ZihrOtObwt6Q95Wi5JglRDcKvcs5OLYG5IT7+R+jM9h2bHHFOu97eKhWZ9LtKva2kjs7l6XYxmG2JfykAO0lASmQOOv4RSW+BoiPBvsMOkB/CP4e+Rns2+iAr7ApJJCfXgcQNFG8bxvtGwiJdOuL2qUrbYn8PGP7+qKqd6ywhPNtNTniuvITl82igZOlsRi19gniR93jn7I0rgtOF6CSI2egdgoTLemkKenA 3+vIdJvK tgG7u/IdCN7mxqCc7MOoAoKI4rvGPhY1VJE0KXWUzoUk/r2IQMw54spRszCESfDCbf+qPA1+/BSLFPQBuZwrmv4L9ewLTdqDwppGvVW02m+f9yBPFJSGx+n3Y0YABwn9T1zYlxq/5BKQmPAhMtgLRA8rHVaHVJf6M3WY/EqmWso5GZwiJDx+2et+pgd4L5im9EL7TuspR3NlBo2Jr0s13GiDOzgDf0d1POqLPi83hUOXjCBO1NwOD46ePlKF4LUdR8i5l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We might be only interested in knowing about stacks <-> count relationship, so instead of having to fiddle with page_owner output and screen through pfns, let us add a new file called 'page_owner_stacks' that does just that. By cating such file, we will get all the stacktraces followed by its counter, so we can have a more global view. Signed-off-by: Oscar Salvador #include #include +#include +#include #define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) @@ -499,6 +501,77 @@ static struct stack_record *stack_depot_getstack(depot_stack_handle_t handle) return stack; } +#ifdef CONFIG_PAGE_OWNER +void *stack_start(struct seq_file *m, loff_t *ppos) +{ + unsigned long *table = m->private; + struct stack_record **stacks, *stack; + + /* First time */ + if (*ppos == 0) + *table = 0; + + if (*ppos == -1UL) + return NULL; + + stacks = &stack_table[*table]; + stack = (struct stack_record *)stacks; + + return stack; +} + +void *stack_next(struct seq_file *m, void *v, loff_t *ppos) +{ + unsigned long *table = m->private; + unsigned long nr_table = *table; + struct stack_record *next = NULL, *stack = v, **stacks; + unsigned long stack_table_entries = stack_hash_mask + 1; + + if (!stack) { +new_table: + /* New table */ + nr_table++; + if (nr_table >= stack_table_entries) + goto out; + stacks = &stack_table[nr_table]; + stack = (struct stack_record *)stacks; + next = stack; + } else { + next = stack->next; + } + + if (!next) + goto new_table; + +out: + *table = nr_table; + *ppos = (nr_table >= stack_table_entries) ? -1UL : *ppos + 1; + return next; +} + +int stack_print(struct seq_file *m, void *v) +{ + char *buf; + int ret = 0; + struct stack_record *stack =v; + + if (!stack->size || stack->size < 0 || + stack->size > PAGE_SIZE || stack->handle.valid != 1 || + refcount_read(&stack->count) < 1) + return 0; + + buf = kzalloc(PAGE_SIZE, GFP_KERNEL); + ret += stack_trace_snprint(buf, PAGE_SIZE, stack->entries, stack->size, 0); + scnprintf(buf + ret, PAGE_SIZE - ret, "stack count: %d\n\n", + refcount_read(&stack->count)); + seq_printf(m, buf); + seq_puts(m, "\n\n"); + kfree(buf); + + return 0; +} +#endif + unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries) { diff --git a/mm/page_owner.c b/mm/page_owner.c index b6637524e442..b191ad1d41f9 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -718,6 +718,31 @@ static const struct file_operations proc_page_owner_operations = { .llseek = lseek_page_owner, }; +static void stack_stop(struct seq_file *m, void *v) +{ + return; +} + +static const struct seq_operations page_owner_stack_op = { + .start = stack_start, + .next = stack_next, + .stop = stack_stop, + .show = stack_print +}; + +static int page_owner_stack_open(struct inode *inode, struct file *file) +{ + return seq_open_private(file, &page_owner_stack_op, + sizeof(unsigned long)); +} + +const struct file_operations page_owner_stack_operations = { + .open = page_owner_stack_open, + .read = seq_read, + .llseek = seq_lseek, + .release = seq_release, +}; + static int __init pageowner_init(void) { if (!static_branch_unlikely(&page_owner_inited)) { @@ -728,6 +753,9 @@ static int __init pageowner_init(void) debugfs_create_file("page_owner", 0400, NULL, NULL, &proc_page_owner_operations); + debugfs_create_file("page_owner_stacks", S_IRUSR, NULL, NULL, + &page_owner_stack_operations); + return 0; } late_initcall(pageowner_init)