From patchwork Mon May 1 16:54:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13227662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F63AC77B73 for ; Mon, 1 May 2023 16:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA599900005; Mon, 1 May 2023 12:56:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF64900002; Mon, 1 May 2023 12:56:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8077900005; Mon, 1 May 2023 12:56:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B3B72900002 for ; Mon, 1 May 2023 12:56:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8CCA11A077A for ; Mon, 1 May 2023 16:56:12 +0000 (UTC) X-FDA: 80742288984.19.4A06E80 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf30.hostedemail.com (Postfix) with ESMTP id AC63680007 for ; Mon, 1 May 2023 16:56:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=WvFBiHp4; spf=pass (imf30.hostedemail.com: domain of 3Ke9PZAYKCHAgifSbPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Ke9PZAYKCHAgifSbPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682960170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sqvz5oeuoJjzyL5d6pTK46j/h0psspf4+63tRdELHAU=; b=0KpG04WPJ2slxSOv3qvRnfP+MNEz5C6q8C9o1AfPRLTuyg88ts5AVE4S9qqioFAVBR18if bGtYNE1qFsMfGQBaIIZWG9jaMiutdv8zrk7qlgwWm6yEGaOCWg8RydU0iBTvOgdC7xBAVL WZrjcl0g/Gnd+8A2K2MmVbQh2WaplDM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=WvFBiHp4; spf=pass (imf30.hostedemail.com: domain of 3Ke9PZAYKCHAgifSbPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Ke9PZAYKCHAgifSbPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682960170; a=rsa-sha256; cv=none; b=4kxdYq2H688++g6B+pGP+RNtvaQOcd/PNa3yoQ4/TRivJsiRPE9rMsvrVt0inFclD0spfq jwqSZc+VsICDnUqPSA1lhNEOUUE3aJvUaEKCgWo/HDJYx8bW4aY2LqlXdqNHT03H2HjJ+p z7GOYCy57oNlBn6Tkdw7WdrEVv/gnms= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-b9a7550dca3so4767345276.0 for ; Mon, 01 May 2023 09:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682960170; x=1685552170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sqvz5oeuoJjzyL5d6pTK46j/h0psspf4+63tRdELHAU=; b=WvFBiHp4GUaavo4X5tfWgjPPIzI4jGTUdYosSfeYytpBQUHvpJznwgCxcgtRl4137n /lBXJJHc248hdfGU59NQ6YgyXWglquQNEf83f6NZrWhqBExIs3wpePGzi3G6GXt6Q4EK YNi+IUVCZ2K+oon9eJeUuOHyA0Dti1Ev+im7AvpjkpEZ+nJa/TIMCcKnkDRhn07rC5v5 U+jUUTR0hv29E56yn3HNUOsZcTbbcZMOOzG+OmYRSipaveAVFeX44ceC3CgOIteuddHZ pJc9MAEnRvahuFY90dt+kNg7+emyX/nC+hRarTb4+wBTNE2Gp4VjzhmNP/RRS0EOHEJ7 5wQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682960170; x=1685552170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sqvz5oeuoJjzyL5d6pTK46j/h0psspf4+63tRdELHAU=; b=PSpv0+df+pJixmalSNcScfj5NLfccMpYN/1Hut1rBUKOX/mBEyOG8l0jPgYYSFosbi 9VJkuNPZYLXdAzoPsxHpnaoxaHv+SJYUI1gCiPpKWu0QSVAXhcf+sNd2JDDKPBUoxxW1 e0oda1nY0abKwC6bQr3iFYJANdunJSQq1IOtiHHUASlpDKTm8FGbZrgnpvyEklsC1/zM mLMPoSTZIdNzi+pUmWndOlana87B57bgQsU4jWTqiJV6twnMBWJtnZOPqh9zxT0Yfeca u8tiAAKPSpc+LTf7T2x1cZB1D8uI+QDoCCW7uFULw3VLefhshm5Fla0ZPHm3lxTDKb/8 vrQg== X-Gm-Message-State: AC+VfDzSdz7Zny6+TS7VKnV2j4Qj1UzI+WixzlmDdUxuJ/o2p9G3jW1F HAwdS+hD/lfwOfuLTib1DKya6mL3K+A= X-Google-Smtp-Source: ACHHUZ43Hwp6e3JER3sQv6NxKXEjKe/RSZbOmkRcgQXOYFHdzPjxH4Sg/oRvIRxv7gUZWm7HfdAOIYovC7U= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:6d24:3efd:facc:7ac4]) (user=surenb job=sendgmr) by 2002:a25:cd08:0:b0:b9a:7cfe:9bf1 with SMTP id d8-20020a25cd08000000b00b9a7cfe9bf1mr5044873ybf.8.1682960169618; Mon, 01 May 2023 09:56:09 -0700 (PDT) Date: Mon, 1 May 2023 09:54:37 -0700 In-Reply-To: <20230501165450.15352-1-surenb@google.com> Mime-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Message-ID: <20230501165450.15352-28-surenb@google.com> Subject: [PATCH 27/40] mempool: Hook up to memory allocation profiling From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, surenb@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AC63680007 X-Stat-Signature: rf975dmeoq8b5bz9d998hfn6epxi8u38 X-Rspam-User: X-HE-Tag: 1682960170-143512 X-HE-Meta: U2FsdGVkX19XGPD6wOmntEBmUyuvt55EU1UMs9ab24zOwd1IQxYAgWyGs9piPHq7Rf9WL/cNpaJQ/L8FT2Z3BbwO0kwAgSBFs1XQxNJgMDfOoQ78KBjAQeQpu7LvPe43GONG122+KkA/NegLo8newZ2iGQn/B84FInSzptaERRtzzriOw2o8wx4WPJdI34xlMgNlyN2yq6bdl++rys8S4cBhkOJ2u4SJ59s2kSL13ZZ91upHaXUplMJ2NHehLCJ7A563vO3STiRXBcowkrsMWJZ7KpZs8F/JL6mI5Rx0LWADgpuKjpybc+I1aFgDnEMXmbpWELXKSdBqeV5HJ7bwfoHGzfGe9wyVI72PUxyBAS1i3ijSlCJXGwge612es2GnG8WRQpF133drUSFX4Pvp16y2sM0BRyRiC54oah6hdG7NazJjxqrD+qvC8USx1le//GaLc5r8dxZJrbTlEdMqxY0xcaXtCQUuBq/b+RY79qgZT2P8JmEE7Ywr9fvdlTFx+hRuX+H/54TrhiWl4TutV9nDE+5h4TRakhtRe/34c0lc5lTT1I5nogRQYSAUYbWb0qOd0DqLFef87j+2m0qo4bXUiQRxaIcMy6pl9w5TLApUgEKKbDsI0ZlqqEKGXATi5wbP29UwrOdi81ucfkXjDBF1HW9pSLzCC9R47j+K3e2P35e8aH5XF1teIlcEABwTcpEqZ0iRz839K2Dm+BL5RBRotDj8xJbJrGvUfHhPbPTLElrqHHBrk8VtD2cDvaL1t1VktyZaTcjy+L1QMUeQbIDidoSL/1Ym8y97A6JviGC230xNuVfI7u8iGhutuIdhb3ihyFGhAq9RcwD8UaZSEkMK9i3Rgy4zRIz1HZ/2kgI6ZzIySXvoK2pTZxQC6jVQNm/JwnyGrLP9Lrx/BbRVUGQar4w9R4l8R8xMyX6PUTXVezS4vBn+e9uScN9WsYrMZ4W13wB50iDDqixKjDe eN5UgisG VRu4j01uWWeruE130DJXzpCeTl0NEIHIZD/8bUTB3/+E927X0qcKOaWVhlPPqE2TlbTmL2sGYsPc0+ILNmAXC1757YmjOSw1VpXjNQBOS/DscKnbfHvn+U/u3mw/CkkSwSuN9sT7CcwZgBRePGsKlUkBQ+a/AtdkdzTm4KFYeIj6sukFFy2WqaNCou+wMH+Y+lFLvpv+vBLSRDdEKqLGGg9hU6LtSHn5kPRpFd8X6tKG6NPSXYA6xa2GMnV7maAljx/URnEhf2Zig9QJtdTVl4bXmi7ghJ5+dd5n/czQFAz+8u1vF5icTmzFCWAA7JUZYAG1S2sz5JrBf7/TteOaPxpVVLYjB20v2YIOPXu/nIW1sHLgKoFuFPBvy2mU3hfWcm62jeRXRBmQU937acPRRflCPEOHIlRvWepQU/4GvOrYDtDSfl2cfjMuhfcsd5x11VV5tUZG1t/PjA6J+eVh7Sr8FLUfalQdLaBiZCOG/xg04yjHtGxl+wWdUQSPggLmSeF6IALYQTzrRsa07UxyR/VhuFn8wrUXdZOqtq5bmXHMAvmcqvPmarfJjwlI0mUymR5jX4YLzNG+IY9kzprnr2JDMKiTmf1wDDjGl3eAiv9ruVzG0AsLRaIEJjLPHNT0Ejwl8bxqaK4p0U+8rF7Jfxmi+3chsBhupyP2AiJ6H3m2nKYE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kent Overstreet This adds hooks to mempools for correctly annotating mempool-backed allocations at the correct source line, so they show up correctly in /sys/kernel/debug/allocations. Various inline functions are converted to wrappers so that we can invoke alloc_hooks() in fewer places. Signed-off-by: Kent Overstreet Signed-off-by: Suren Baghdasaryan --- include/linux/mempool.h | 73 ++++++++++++++++++++--------------------- mm/mempool.c | 28 ++++++---------- 2 files changed, 45 insertions(+), 56 deletions(-) diff --git a/include/linux/mempool.h b/include/linux/mempool.h index 4aae6c06c5f2..aa6e886b01d7 100644 --- a/include/linux/mempool.h +++ b/include/linux/mempool.h @@ -5,6 +5,8 @@ #ifndef _LINUX_MEMPOOL_H #define _LINUX_MEMPOOL_H +#include +#include #include #include @@ -39,18 +41,32 @@ void mempool_exit(mempool_t *pool); int mempool_init_node(mempool_t *pool, int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data, gfp_t gfp_mask, int node_id); -int mempool_init(mempool_t *pool, int min_nr, mempool_alloc_t *alloc_fn, + +int _mempool_init(mempool_t *pool, int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data); +#define mempool_init(...) \ + alloc_hooks(_mempool_init(__VA_ARGS__), int, -ENOMEM) extern mempool_t *mempool_create(int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data); -extern mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn, + +extern mempool_t *_mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data, gfp_t gfp_mask, int nid); +#define mempool_create_node(...) \ + alloc_hooks(_mempool_create_node(__VA_ARGS__), mempool_t *, NULL) + +#define mempool_create(_min_nr, _alloc_fn, _free_fn, _pool_data) \ + mempool_create_node(_min_nr, _alloc_fn, _free_fn, _pool_data, \ + GFP_KERNEL, NUMA_NO_NODE) extern int mempool_resize(mempool_t *pool, int new_min_nr); extern void mempool_destroy(mempool_t *pool); -extern void *mempool_alloc(mempool_t *pool, gfp_t gfp_mask) __malloc; + +extern void *_mempool_alloc(mempool_t *pool, gfp_t gfp_mask) __malloc; +#define mempool_alloc(_pool, _gfp) \ + alloc_hooks(_mempool_alloc((_pool), (_gfp)), void *, NULL) + extern void mempool_free(void *element, mempool_t *pool); /* @@ -61,19 +77,10 @@ extern void mempool_free(void *element, mempool_t *pool); void *mempool_alloc_slab(gfp_t gfp_mask, void *pool_data); void mempool_free_slab(void *element, void *pool_data); -static inline int -mempool_init_slab_pool(mempool_t *pool, int min_nr, struct kmem_cache *kc) -{ - return mempool_init(pool, min_nr, mempool_alloc_slab, - mempool_free_slab, (void *) kc); -} - -static inline mempool_t * -mempool_create_slab_pool(int min_nr, struct kmem_cache *kc) -{ - return mempool_create(min_nr, mempool_alloc_slab, mempool_free_slab, - (void *) kc); -} +#define mempool_init_slab_pool(_pool, _min_nr, _kc) \ + mempool_init(_pool, (_min_nr), mempool_alloc_slab, mempool_free_slab, (void *)(_kc)) +#define mempool_create_slab_pool(_min_nr, _kc) \ + mempool_create((_min_nr), mempool_alloc_slab, mempool_free_slab, (void *)(_kc)) /* * a mempool_alloc_t and a mempool_free_t to kmalloc and kfree the @@ -82,17 +89,12 @@ mempool_create_slab_pool(int min_nr, struct kmem_cache *kc) void *mempool_kmalloc(gfp_t gfp_mask, void *pool_data); void mempool_kfree(void *element, void *pool_data); -static inline int mempool_init_kmalloc_pool(mempool_t *pool, int min_nr, size_t size) -{ - return mempool_init(pool, min_nr, mempool_kmalloc, - mempool_kfree, (void *) size); -} - -static inline mempool_t *mempool_create_kmalloc_pool(int min_nr, size_t size) -{ - return mempool_create(min_nr, mempool_kmalloc, mempool_kfree, - (void *) size); -} +#define mempool_init_kmalloc_pool(_pool, _min_nr, _size) \ + mempool_init(_pool, (_min_nr), mempool_kmalloc, mempool_kfree, \ + (void *)(unsigned long)(_size)) +#define mempool_create_kmalloc_pool(_min_nr, _size) \ + mempool_create((_min_nr), mempool_kmalloc, mempool_kfree, \ + (void *)(unsigned long)(_size)) /* * A mempool_alloc_t and mempool_free_t for a simple page allocator that @@ -101,16 +103,11 @@ static inline mempool_t *mempool_create_kmalloc_pool(int min_nr, size_t size) void *mempool_alloc_pages(gfp_t gfp_mask, void *pool_data); void mempool_free_pages(void *element, void *pool_data); -static inline int mempool_init_page_pool(mempool_t *pool, int min_nr, int order) -{ - return mempool_init(pool, min_nr, mempool_alloc_pages, - mempool_free_pages, (void *)(long)order); -} - -static inline mempool_t *mempool_create_page_pool(int min_nr, int order) -{ - return mempool_create(min_nr, mempool_alloc_pages, mempool_free_pages, - (void *)(long)order); -} +#define mempool_init_page_pool(_pool, _min_nr, _order) \ + mempool_init(_pool, (_min_nr), mempool_alloc_pages, \ + mempool_free_pages, (void *)(long)(_order)) +#define mempool_create_page_pool(_min_nr, _order) \ + mempool_create((_min_nr), mempool_alloc_pages, \ + mempool_free_pages, (void *)(long)(_order)) #endif /* _LINUX_MEMPOOL_H */ diff --git a/mm/mempool.c b/mm/mempool.c index 734bcf5afbb7..4fc90735853c 100644 --- a/mm/mempool.c +++ b/mm/mempool.c @@ -230,17 +230,17 @@ EXPORT_SYMBOL(mempool_init_node); * * Return: %0 on success, negative error code otherwise. */ -int mempool_init(mempool_t *pool, int min_nr, mempool_alloc_t *alloc_fn, +int _mempool_init(mempool_t *pool, int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data) { return mempool_init_node(pool, min_nr, alloc_fn, free_fn, pool_data, GFP_KERNEL, NUMA_NO_NODE); } -EXPORT_SYMBOL(mempool_init); +EXPORT_SYMBOL(_mempool_init); /** - * mempool_create - create a memory pool + * mempool_create_node - create a memory pool * @min_nr: the minimum number of elements guaranteed to be * allocated for this pool. * @alloc_fn: user-defined element-allocation function. @@ -255,15 +255,7 @@ EXPORT_SYMBOL(mempool_init); * * Return: pointer to the created memory pool object or %NULL on error. */ -mempool_t *mempool_create(int min_nr, mempool_alloc_t *alloc_fn, - mempool_free_t *free_fn, void *pool_data) -{ - return mempool_create_node(min_nr, alloc_fn, free_fn, pool_data, - GFP_KERNEL, NUMA_NO_NODE); -} -EXPORT_SYMBOL(mempool_create); - -mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn, +mempool_t *_mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn, mempool_free_t *free_fn, void *pool_data, gfp_t gfp_mask, int node_id) { @@ -281,7 +273,7 @@ mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn, return pool; } -EXPORT_SYMBOL(mempool_create_node); +EXPORT_SYMBOL(_mempool_create_node); /** * mempool_resize - resize an existing memory pool @@ -377,7 +369,7 @@ EXPORT_SYMBOL(mempool_resize); * * Return: pointer to the allocated element or %NULL on error. */ -void *mempool_alloc(mempool_t *pool, gfp_t gfp_mask) +void *_mempool_alloc(mempool_t *pool, gfp_t gfp_mask) { void *element; unsigned long flags; @@ -444,7 +436,7 @@ void *mempool_alloc(mempool_t *pool, gfp_t gfp_mask) finish_wait(&pool->wait, &wait); goto repeat_alloc; } -EXPORT_SYMBOL(mempool_alloc); +EXPORT_SYMBOL(_mempool_alloc); /** * mempool_free - return an element to the pool. @@ -515,7 +507,7 @@ void *mempool_alloc_slab(gfp_t gfp_mask, void *pool_data) { struct kmem_cache *mem = pool_data; VM_BUG_ON(mem->ctor); - return kmem_cache_alloc(mem, gfp_mask); + return _kmem_cache_alloc(mem, gfp_mask); } EXPORT_SYMBOL(mempool_alloc_slab); @@ -533,7 +525,7 @@ EXPORT_SYMBOL(mempool_free_slab); void *mempool_kmalloc(gfp_t gfp_mask, void *pool_data) { size_t size = (size_t)pool_data; - return kmalloc(size, gfp_mask); + return _kmalloc(size, gfp_mask); } EXPORT_SYMBOL(mempool_kmalloc); @@ -550,7 +542,7 @@ EXPORT_SYMBOL(mempool_kfree); void *mempool_alloc_pages(gfp_t gfp_mask, void *pool_data) { int order = (int)(long)pool_data; - return alloc_pages(gfp_mask, order); + return _alloc_pages(gfp_mask, order); } EXPORT_SYMBOL(mempool_alloc_pages);