From patchwork Tue May 2 10:19:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13229191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A531EC77B73 for ; Tue, 2 May 2023 17:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30DD56B0071; Tue, 2 May 2023 13:04:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4716B0072; Tue, 2 May 2023 13:04:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D3AD900002; Tue, 2 May 2023 13:04:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 121426B0071 for ; Tue, 2 May 2023 13:04:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CEE5080CAC for ; Tue, 2 May 2023 17:04:39 +0000 (UTC) X-FDA: 80745939078.11.BEF80CE Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf05.hostedemail.com (Postfix) with ESMTP id 30A9D1016A9 for ; Tue, 2 May 2023 13:20:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=PgIn514w; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf05.hostedemail.com: domain of "prvs=479dded8d=johannes.thumshirn@wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=479dded8d=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683033682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QUuRbp5NP+IPgEW3PFFjEPb01UVY6wlfuqfl6L8i1Mw=; b=Bfq9p3BkTSJIw3u/yVHFMkDDZycf5hanWXJfYfF06unOukO0au79Djmya7KjgvSUbA7hsp H4HYvYZCSonahx720EAXpIzyuIwfJVFuUvAVY6T9zSVsRJe+PiQL1utH4nYIskDMWeYCUj Z2uKTk2E/w+pRw8dQ+TK+ref53Em5z4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=PgIn514w; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf05.hostedemail.com: domain of "prvs=479dded8d=johannes.thumshirn@wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=479dded8d=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683033682; a=rsa-sha256; cv=none; b=1TXy3GpKV1/lEeZjgBLUd23rjWO6lvahh4fgOeVhlx4HSqwLAeHr23avVvR/XCbpyPdqtJ Gg/+tAIUvi9kk8m//ZuhABcRe4ejuqSvj/pcJbWt9x4exf1/IA4Jm3RLtY4xEXnQabXLSc OS5obfcL7mnmjCAwAydRp09Kouoe0nQ= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1683033682; x=1714569682; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6AfPyqd2+81HTNsYYrGTux663HCZhra0xBEupwD85bc=; b=PgIn514wIoA5oghyGw3bFezvJARiId1m4OaMtovgwYEYIxw5PRi95Pj8 R4ycKGk/BxgsZ8LKfZnysiQtUx+Jznel9kh28rKCWy6etLGHw9NROh1N9 V8bSrnWOqOuSINSzigT8CTjdVkrCXBAd3Il7L7xKwsBjRcMk8RJIprDoS dMZ3Bk6nj6dza63PtEXxkc1QcDumNwmQg8+rR16qZ38t91QyI9IU4kH0z aoNZVdjACfIjE+/ZQHCiI7BpL9oSWvM5AXlT65o9xhKgb3oOyn+ZMICUA zRISK7pfePTdArkGtxlJFNktn247MdkgbM81VXU8yBMRfqt9nm9kodZTd A==; X-IronPort-AV: E=Sophos;i="5.99,243,1677513600"; d="scan'208";a="341747225" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 May 2023 18:21:54 +0800 IronPort-SDR: PUaPiGm3d+TX/DugMh7DZyqT8ii8ZZTZPzH4lcHlySkNTctPtOBzNf1VDEjzlWO7yILRqAFnuK SKwPVyeVuxg++i1XS4Od2qObe+6A+Wz4p8UlgMg6cQ30ohSds1HjXtDaih4Uejtv2WhQ0SZULq g9rY+wv4Ku5QkfotNTZ0aZ1t/22HwTod/Tts3TewaVqFPDejfc7Cn01GBG+Gtwn7sib1RvMj7C TlKPFLuFldfjQxqYeMTiw1zsYGPpJg2mJOlBeCo9Tyh8UBN7j9BVNVv1qqhCYUJVCUxfxRhlCj lWc= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 02:31:41 -0700 IronPort-SDR: xRv9qUm/jkFHj47mGNA/6praQO5Yqj7qnIh22218g9Ii/1T0IZaxn5IqFfB1tzk0UZbvAYefj0 /ajkmqJdSFIwqCAr1990sRV9STv6FmnvwMuCFh00tUkv1kcz55Tru+sZ+t3DxI2ItwUvm8O/TT gAhMfAT/LF6mCdTT/kjCHonXe81T0BejQwdHvS2IGUexu6EtwJUc2lkNjjtG2t8eY8jjwTl9Fp NYdkUfUEbsQHza/zSMGe0al18yoLgAUHBBNoGU5+ItYpshssTx8F6JYNPfvX9YwFGkWwD9ZVsN NOY= WDCIronportException: Internal Received: from myd008205.ad.shared (HELO localhost.localdomain) ([10.225.1.100]) by uls-op-cesaip02.wdc.com with ESMTP; 02 May 2023 03:21:50 -0700 From: Johannes Thumshirn To: "axboe @ kernel . dk" Cc: agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v5 17/20] block: mark bio_add_page as __must_check Date: Tue, 2 May 2023 12:19:31 +0200 Message-Id: <20230502101934.24901-18-johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com> References: <20230502101934.24901-1-johannes.thumshirn@wdc.com> MIME-Version: 1.0 X-Stat-Signature: zsuqw49oruy1czyu94uzeujm6y5ajs4w X-Rspam-User: X-Rspamd-Queue-Id: 30A9D1016A9 X-Rspamd-Server: rspam07 X-HE-Tag: 1683033652-50910 X-HE-Meta: U2FsdGVkX1/zbcVs+AOL0ErFp7q51XlohBvtkvkr+54XLD+7SKmBijHhWBwh1VUN6+kaAFI7NX+g0QfdO7wu6PNTUt8hFGdD/N2KMenwfFemtBoBU6qgUGxRKgPK0q3mXFl4Jl5K0CqnyHEg6qj+wiCLdRGg5pBrspgcWv2Bv8cGucGKXurVIpoCJ1wVqgvdT8/M7Z2DbGfN7wqN2N0YM/z4oX2oLQkOn+L89VJmDeRz3SWhr91duc2xLpbrSCmMjx/072HnO01k8pjmnvwQw3HKHXAMuQktLPVuftiT1rW5OXYoJBKGd0DNPWW6BNMrfX4cQximpzKy5W7IOVjkOHT3sTLvdPZoqhGx+MONa1Y6a9If2ml4WQQtrTcGwS8aMcH4uIfXWLRvbufXmAgMcqYkRM61kQwW6aEbpJWwPI6xzdLPIyBfhX3TJX/Las6UgdXxTGC457CYc27mEzZmQLttJhbp1+JVnbkexFvFfddn87PSby45fckrFUCJUhBd0XdTTW+gRkq1r/qGLutFbtMn/aB/8xmnSdcpyE3FlTplU1j9m0IMNmMa5Co2PHZ+IuE/g/aHt21K/jYjkD5VDT1jH3wfYasHK3OfuvcNlifJ9C+4GMTOpgF8OIhIxNiLht1bOe81p77IIGO61ZXlluP9oXmmaTpq9DZD4vp/d4i5URECJqrLvo/sihPDr4ATd1YFeooGCEnRjZESllcf3uw9u4fSY/J6sI/t1UjVbaZg58/zUuCvWkopDU7L6KcxbK0C1DkzBiElWZSM5u4PPX68C4zmq/J9dBdm4KBWSSMBcc1KgDef2tBbh5ZWDZmcpyHwvnnvXw5LhMSxwpqRlRtFAtvjkYeXeQkI/QXT3u5HgUAZZBfVIqjyfvEBXuEF8gJApfFEu2JrFZGcznqfx03u7G4wHkrc9/03VJJxx2Qv9hNhU+eCBk4AYXkoCizymILgZIXiVvC5AxNtjeR OfkN6f/9 RpaJrQ6FMlxCwLDRryhUWVzXWI7eWUQ78rp0/iuWxEsIu9xgQHmRQ0dXysQC1PyC1SvfOUOLqooRCa8FGHvqw7VGOzcQgB66mbHb2biFzw6fjvqypC829f9S6+QqD8BFvnYiMYLg6QZMdJ+r0XW+OP+H19gjd4chqRIT2lD+KsJM0tJZJhuSrYxjZiXW5b6jbVilO6hSK1cil9NZKKdR4+2u47PGCOOF2Ymj7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that all users of bio_add_page check for the return value, mark bio_add_page as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- include/linux/bio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index b3e7529ff55e..5d5b081ee062 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *); void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf); void bio_chain(struct bio *, struct bio *); -int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); +int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *, unsigned int, unsigned int);