From patchwork Tue May 2 10:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 13229122 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A598C77B7E for ; Tue, 2 May 2023 16:06:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 104826B0075; Tue, 2 May 2023 12:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D3F280002; Tue, 2 May 2023 12:06:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E45516B0078; Tue, 2 May 2023 12:06:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by kanga.kvack.org (Postfix) with ESMTP id 78DB4280002 for ; Tue, 2 May 2023 12:06:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1683043607; x=1714579607; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Td/xHpC7+cd6575Kox8h68Aq0j3mdhGpI0NO3tgGxpE=; b=OuO+roAoSYvqifVi+KlHznAbBHwi9ecwvg4gWNYzIiQtt5a1ZOuToPcR h7EpZyME1GCGNGmCS4+piD3UpYbt8mY/mAuw/HL4r9FzcNK/MjrMufwfv Wq4eQNvKs5r457w8mWYSWE9j1dC0ys/zIe7hu4xDQ8G65yoKfJlPwS6DF IeEwkzQK0rhKJ4ajzF+Wbc2Hg/872owaWWneTzdB0LqzAuelVKfTQLlyo LSi6/kRWKYF8C09rLTwW42IETmJ3K37/qVJzZtvqPXutgiBJKnfEW4ho6 P+cLp7RAZQLVJbrE/8Q2ZmdMzJNVf/AWfXsCmRapY37edPgrGyeDd8flL g==; X-IronPort-AV: E=Sophos;i="5.99,243,1677513600"; d="scan'208";a="229735916" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 May 2023 18:22:07 +0800 IronPort-SDR: 4/e/Lx1Ku6vn/uuZR9yAV8Ict2AsHGaIixh6XmVenzSzKZz23JfUOGFo8yvSt+JzcrrTAx7SL4 ZzOpVLghciS7AZXNhUrJDtkusiAJg69qNr1WunU6907S8oYVzQwFxJCrbpUEa5SqF2j96Hu+fA aFpu8PGz1FgmRxJzBKcymLRttCQc6csTkE/+aBCNLRn3mXi1UAEj6mon0a3Uj0IvqDPNHKTHhM I9ukvf2jn6ETtRwacn5mTUyrdcPLObq7adRlem7IFvmhq8dad3oIPIUboD87l9GbD9SnTtcdd8 EWI= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2023 02:31:55 -0700 IronPort-SDR: Vcxt7Z41NExxCvUESz1tELNOOoVAmCt8KMe9S2wfxXY5MtctxeNwByBgzDDJWsrhCsj1BHWV0Q ZGiNQRrLC1GqKKuIRpNOC2Vb5K9nW2DMjlmAKUuOtSKbHa7NR7aAFqUudcN/yAoLh311Vt4cBL y00A/34+CNpVnLGm46O2cceVC9lFxIP0NOPuIkoffYDZmLB2WN+NgV+aYC3+VTf4qWL5CbSVPK XjePJIBx125icTf/AqdLDhEFFImtpkj2dXIQOUMatT77zeeqXyuVF+60VJakWBDYsxQwY/CpIf OkY= WDCIronportException: Internal Received: from myd008205.ad.shared (HELO localhost.localdomain) ([10.225.1.100]) by uls-op-cesaip02.wdc.com with ESMTP; 02 May 2023 03:22:04 -0700 From: Johannes Thumshirn To: "axboe @ kernel . dk" Cc: agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org, Johannes Thumshirn Subject: [PATCH v5 20/20] block: mark bio_add_folio as __must_check Date: Tue, 2 May 2023 12:19:34 +0200 Message-Id: <20230502101934.24901-21-johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com> References: <20230502101934.24901-1-johannes.thumshirn@wdc.com> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now that all callers of bio_add_folio() check the return value, mark it as __must_check. Signed-off-by: Johannes Thumshirn --- include/linux/bio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index 4232a17e6b10..fef9f3085a02 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -466,7 +466,7 @@ void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf); void bio_chain(struct bio *, struct bio *); int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); -bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); +bool __must_check bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *, unsigned int, unsigned int); int bio_add_zone_append_page(struct bio *bio, struct page *page,