From patchwork Tue May 16 18:25:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13243495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C40C77B75 for ; Tue, 16 May 2023 18:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85AAF900004; Tue, 16 May 2023 14:25:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB15900002; Tue, 16 May 2023 14:25:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571F6900004; Tue, 16 May 2023 14:25:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 47D3C900002 for ; Tue, 16 May 2023 14:25:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E2BE1A02EE for ; Tue, 16 May 2023 18:25:54 +0000 (UTC) X-FDA: 80796947028.17.A659F1D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf30.hostedemail.com (Postfix) with ESMTP id DE88A80010 for ; Tue, 16 May 2023 18:25:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hVKBHkEf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tm91uIeD; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684261553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rnEOKM6Uzt/actmg7zEiIw7A6rReXqMZszIGv86v3Sc=; b=jRTgpYwU2fO3KqfK4vjL3hPEbGLZ3glSjD6CFqWh+6H1TW13ZqoLqKaaEodylTfly31hj/ dMs2EJ+pMBjrY7gc38ltyj0sisrdpOhqxt5efRQ99Fl9A3Z11BsLGMf3HgaHrIJpRrAhUK sK36o1g0OqoK7Ipa/qKiVmGAZu1M0Dk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hVKBHkEf; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tm91uIeD; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684261553; a=rsa-sha256; cv=none; b=x4cds/B+5h0dccHSg40IVLtvuphbt3gMDQcWgMyoSwL9TZV2NZBA/1y8Uc4zNb0UbdqSgM 9+9pQkODus4FA3xPRBszF5EiSsz/jTeC0tGhAToraqSVADb/ijNU8eKuPLf3Jmy5SRJiCM Woo9Q8p8kzJH1rY5CNDIkd/TP3QAybk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9BBCC21FC4; Tue, 16 May 2023 18:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684261551; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnEOKM6Uzt/actmg7zEiIw7A6rReXqMZszIGv86v3Sc=; b=hVKBHkEfp0G9WWvqDJIdHuFRXQZMHBevK/kn/dSawYU4vH2GOG6M/k8315ldc28XvmzHt7 JVVV+17V5fs2C8MT3gspinafb6B59kjzf+39pBAGAxZXwHkDOEZsIMRYRfYjKtd/j48MOe Ucek+oi57i2nKNml/BL1ltcex4CV/Ug= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684261551; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnEOKM6Uzt/actmg7zEiIw7A6rReXqMZszIGv86v3Sc=; b=tm91uIeD7vPtoub1sk+jMCmayoC3m/C8kJoTmIIOUbi0fGm7KoJe0U8e8lMF9s+yzr6liW Ai4d6LArAkKNwxBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD65E138F5; Tue, 16 May 2023 18:25:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mLsJL67KY2TeVQAAMHmgww (envelope-from ); Tue, 16 May 2023 18:25:50 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov , Eric Dumazet , Alexander Potapenko , Oscar Salvador Subject: [PATCH v5 3/3] mm,page_owner: Filter out stacks by a threshold counter Date: Tue, 16 May 2023 20:25:37 +0200 Message-Id: <20230516182537.3139-4-osalvador@suse.de> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230516182537.3139-1-osalvador@suse.de> References: <20230516182537.3139-1-osalvador@suse.de> MIME-Version: 1.0 X-Stat-Signature: 3ti64g1rs8tmyw4886p76jr8pwfz36ad X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DE88A80010 X-Rspam-User: X-HE-Tag: 1684261552-178355 X-HE-Meta: U2FsdGVkX19NErLnDRoBHx6YsMl5OQCmvkLdKRYUHBfgWrikcKYJX/qB9CbUoc6rsI1aDUAQWkVh28fHvmihjlhDlogt4VUWJMwN1iYyLAahUliTtSahvnTCrHF2UZdcE+VmZht5dfhSeOJkfyft9d4ZBz8ieqCSxDtFJ+88nCNKEAuaU71+Uhj8izrE9N41ixAhK6eKTMzLniDDYrWHMl8tKGE6aBUAYL+c5ib+EWyFkvD9ZLW8OPugz93ZfjfXll22ku7Pidj3Eq62BD1nVJR3Z+AqigJs0ONYPIXohxRP01xhTbYbSPPoRUEMvmtxvs7DUoIGqnzf4VHfAW5MO7iAWl/X0bdZksgzGpv5CzQpSEcwEeIqG0OuKfBGHMEAEZtRV4JT3+ldYNMJRCc3NN77kPLDObmeV61vGDB1gbz+LMjjl7q+FLqBW4FaPk0EYyujUtTQbaorVMck3cZeLECkNLRZ27k62WdrG4KJ9toPQs1dbWJwDx9Wj6TuQ1Mh2HtUElD1sAaMn+5jbc21/wwF94YalbjMf4UtFQTTqlIcwJQk+1p8w2z1jZzHgOTTU799liPM3nhXc7ogwXO8U5e+wHfSdMEPcv6bfQmecQ/7F1NXdCy3eYLUwmjmmID+OvN//IupVWsr4o3XHojF3YLNLhXyfaNqrT/3VmU2jj2QMbH6xkO/qCBpdUBuEQz5kOL5rxqRcxbCEFXtXaBi2Dnh3SewWsPxXvQLoNL8m7Fcad/eFEaHyfcn0+tdDOj6FjeY7Yz7HgJkmNOgcfa/SvXOs3mYoZ7eZPLWkC5dQ2Zv13BArYzlE/TgDrZdzav5gLLQDZBjFjQQ2f7dE88goXqEmA1lFq70mHeO76P6rWpXEWSfXtvxNRAQ36/+vV2lfhXUFxd1eDuL1j2mgxK/0maS5FwoG3GFq07x3XjGg9BkVMv8/PnB4Yo3SWLZmZCpG7QddylYcwBS561CRHX uAvlNNmi v8bg8shD4NcRAgl053CQrihs7o9lI+T94XMozDkL/fkav+FSwLC8sR/VtyiaqfbeeBnLWMCHYgqYNDkpowzWivSTGCR78vrcZautr4lpSuBAeliaZRTCVtQ72uSDbfzdoAhwmRbqPFN64KCg9mJVEUfSCaA9kqPnnR5p27k4Lz8vQUgmiXEPNHZ7qgjsOsnVQADi+TSPAOZ1h6ZkYIJlKCz93IcwzQ9dHhROGt6zcpch/sr0Xacq5kTSwCDX3OxBpmv2L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We want to be able to filter out the output on a threshold basis, in this way we can get rid of a lot of noise and focus only on those stacks which have an allegedly high counter. We can control the threshold value by a new file called 'page_owner_threshold', which is 0 by default. Signed-off-by: Oscar Salvador --- lib/stackdepot.c | 5 ++++- mm/page_owner.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index c4af2e946500..7053221ce1d8 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -488,6 +488,9 @@ static struct stack_record *stack_depot_getstack(depot_stack_handle_t handle) } #ifdef CONFIG_PAGE_OWNER + +extern unsigned long page_owner_stack_threshold; + void *stack_start(struct seq_file *m, loff_t *ppos) { unsigned long *table = m->private; @@ -543,7 +546,7 @@ int stack_print(struct seq_file *m, void *v) if (!stack->size || stack->size < 0 || stack->size > PAGE_SIZE || stack->handle.valid != 1 || - refcount_read(&stack->count) < 1) + refcount_read(&stack->count) < page_owner_stack_threshold) return 0; buf = kzalloc(PAGE_SIZE, GFP_KERNEL); diff --git a/mm/page_owner.c b/mm/page_owner.c index 2d97f6b34ea6..28c519fc9372 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -743,6 +743,23 @@ const struct file_operations page_owner_stack_operations = { .release = seq_release, }; +unsigned long page_owner_stack_threshold; + +int page_owner_threshold_get(void *data, u64 *val) +{ + *val = page_owner_stack_threshold; + return 0; +} + +int page_owner_threshold_set(void *data, u64 val) +{ + page_owner_stack_threshold = val; + return 0; +} + +DEFINE_SIMPLE_ATTRIBUTE(proc_page_owner_threshold, &page_owner_threshold_get, + &page_owner_threshold_set, "%llu"); + static int __init pageowner_init(void) { if (!static_branch_unlikely(&page_owner_inited)) { @@ -755,6 +772,10 @@ static int __init pageowner_init(void) debugfs_create_file("page_owner_stacks", 0400, NULL, NULL, &page_owner_stack_operations); + debugfs_create_file("page_owner_threshold", 0600, NULL, NULL, + &proc_page_owner_threshold); + + page_owner_stack_threshold = 0; return 0; }