From patchwork Tue May 16 19:35:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE957C77B7A for ; Tue, 16 May 2023 19:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50AA828000C; Tue, 16 May 2023 15:38:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BA21280001; Tue, 16 May 2023 15:38:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3834C28000C; Tue, 16 May 2023 15:38:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29C51280001 for ; Tue, 16 May 2023 15:38:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DAEE61C70FE for ; Tue, 16 May 2023 19:38:12 +0000 (UTC) X-FDA: 80797129224.16.1E0313B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 4EAC8140014 for ; Tue, 16 May 2023 19:38:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lJHg8XNu; spf=pass (imf23.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684265891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uCpGg4G0C1uvdYAB2F2/MnDucOjRXxzaC+xOYW+r6PE=; b=JTuKRDuRl2EZ1alF9EgNlD6F31SFkK9/6NBkmdbKh7Wxw34OgN0sRAqwfNPBux6705AigN 32xGz1nPaki5+1u6YEZ3QJkJKaK1vsdB/MW5c2gJEpDANM0Vz/Soh8jgopch1zAP3nTfKp alqluUiIQFRE7Q6+FbGDv0EboosS+3g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684265891; a=rsa-sha256; cv=none; b=vyQ6DHB9065yACQx3lYecwWfDgaV6wtw2arGAo1Fm9tLc9RGdoeVx39YPVJsWGvBuGr9ow +1vkvORPjq74eRIZV4dEHgGTFa3lUvoSB58F/Cnqbbmnxlp1218q9BSQWJL1udouvgDByS g3qug8/3eSea+AQVI0hkuO9qGaHPiyw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lJHg8XNu; spf=pass (imf23.hostedemail.com: domain of arnd@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 753B66183C; Tue, 16 May 2023 19:38:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28787C433EF; Tue, 16 May 2023 19:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684265889; bh=xg0nY/5XuAoC5Y+aT1n09akQv/zFSJ5XVH0JIB0YwTQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJHg8XNuGiy8jTFn+IFpgUXTvuRIAwq7VY4K/2aG+9oDXR9V6HWZw9BoV/Iby3Y3D ciQJCcSCN88ZGK79OW2jW+p1Mcr53FymRzsq3aD57yhmrL6X5s0JHYpe2CHPA22HlU vtyjpMlDJ94LuFullCZvqENjJQpN0VpNDcwlo9gDKsPudVss3sLnvUVGlKZDHrWJKC 9hYO4n8OiF35vwW0mCeLD6vxQ51+sc9aB2SOI5vmH0t/cuFzcMA5Ms2ki0dFUhjZ6z F+j0NZXOgRpsDihxxL0McykAWvZ3icJuNiaB3wLMzOKImpSeGeJaJv64l87FCV2Wpu UeiC9WTSfPICw== From: Arnd Bergmann To: x86@kernel.org Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Juergen Gross , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Peter Zijlstra , Darren Hart , Andy Shevchenko , Boris Ostrovsky , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 20/20] x86: olpc: avoid missing-prototype warnings Date: Tue, 16 May 2023 21:35:49 +0200 Message-Id: <20230516193549.544673-21-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516193549.544673-1-arnd@kernel.org> References: <20230516193549.544673-1-arnd@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4EAC8140014 X-Stat-Signature: ueiph83ta9t3ob3n1azt6j18ng376ybq X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684265891-138341 X-HE-Meta: U2FsdGVkX19kKF0gP9SiE7gVxdsI4iUEgOlva47b2qcSAjoy0OqT3+ctgs4iLu78qlRSFVp3RtOu45qY01K1XEjILrz9gca0KBT63plInK+uQFVRgz0FK+vQA8vyLwpAi4gDyyVRPZP4bX//0y4n0f9fRB0wWlhoE5nFkMDbKBRzn6iHdsW5YKkFC8USQ28ryz3SlHjg8lvXNVnq6Y56FcbmYnXfoginngrT/pVr3+b84dhZFbp1t0WaibEo0wYZaKtAJrBZFk6iBJH1VRS5r2TB65ksaR/finIpEJ1+kBZXKxnycG5LayZKd+POsO2vzvtjPNiqArgPwoHDIEa0UqEtMJrXLNxzd/PSTFpNGK1WdtM95WB0a4es0iDvMTrrpigYy0SI6Lg6Drpbw+pyS0hzOLniw7W5n/GjOashkKq+DVNz5ybUgDEKOSD7HQwCMvp253Mr5Ok2tG5GCOsgMC/t5XOnkBdw3iopuNfQUWlwP2FMkObirPl9ly/D/vSGoF77M1s5jjc1QZVME+L8oa3BUG2Gd9RBG1mtluFcqx/1jJlz9ZgAQOqKdriHvipG8I8XP3qfo+vwUqcxnoA4H/AYbrl+TZvvlSDOAEMrJMNmXCMOrmmyZkGI3auOOm7H9Gy8k0biQolq5eXMqcqFV2zk2eM6OFDJwGXoRhMCqLTzJzPCHAeYK5pa/fa4Qe0RtzpXFv4mag2B3jQDNQ+sjOiu1mRgZ5NSG94PTq0HKhfDIWrwhtqO8Umt3VYjfXKhVvkd84b834i7hmVmlO+AEYDV6O3SEtD0iKfNttRwkvhfm+Ww2e9VTo2KV8uW4GNfqgwbFV1C8sqwJe1HV9OHEyx+muKPkTGKGiD7ryy/CxJONW7KN6f0QeqcXrYkHWAtzL6XyGEERx90LLl+lWmUS60m6KtLNnGqiEb0tRv/Slec6VCDtycNVKCOE2NXaWYSPsmPU/rqIE+cSGhAJQo pLt6dv4k vboiQdCis2wqopGMFUmg+lHikDHajxiouAsIuC4ko10e8Lpb+IUKA07UpXOaPssk2rsH+EfA5IO87JiMEsMD7I/z4prkoys9N0SUNdYCQ7tX23Fj3RgIN7Wim0lhEhiZEjA/MwsJ5hLNVcpo3SWyIkh5WXpyYVwRzpdxOhFvML80GJmY8DJOuH9mf3jaInQi75BEM2UzYr+0JzuPM/FU1gw+xx7rXEXXY+Pd+IUmD3XesMseswyUc2R0lcFpDASVPX4e/AQp9NpJ6c/9ZZDC4VrkeIggYxhu5s9VfXIkI2logvx7IIMoG7m/84G5ozkQCQDxPnfLsmNXIVfc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann There are two functions in the olpc platform that have no prototype: arch/x86/platform/olpc/olpc_dt.c:237:13: error: no previous prototype for 'olpc_dt_fixup' [-Werror=missing-prototypes] arch/x86/platform/olpc/olpc-xo1-pm.c:73:26: error: no previous prototype for 'xo1_do_sleep' [-Werror=missing-prototypes] The first one should just be marked 'static' as there are no other callers, while the second one is called from assembler and is just a false-positive warning that can be silenced by adding a prototype. Signed-off-by: Arnd Bergmann --- arch/x86/platform/olpc/olpc_dt.c | 2 +- include/linux/olpc-ec.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/platform/olpc/olpc_dt.c b/arch/x86/platform/olpc/olpc_dt.c index 75e3319e8bee..74ebd6882690 100644 --- a/arch/x86/platform/olpc/olpc_dt.c +++ b/arch/x86/platform/olpc/olpc_dt.c @@ -234,7 +234,7 @@ static int __init olpc_dt_compatible_match(phandle node, const char *compat) return 0; } -void __init olpc_dt_fixup(void) +static void __init olpc_dt_fixup(void) { phandle node; u32 board_rev; diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h index c4602364e909..3c2891d85c41 100644 --- a/include/linux/olpc-ec.h +++ b/include/linux/olpc-ec.h @@ -56,6 +56,8 @@ extern int olpc_ec_sci_query(u16 *sci_value); extern bool olpc_ec_wakeup_available(void); +asmlinkage int xo1_do_sleep(u8 sleep_state); + #else static inline int olpc_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 *outbuf,