From patchwork Thu May 18 02:18:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13246056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD3FC77B7F for ; Thu, 18 May 2023 02:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56288900003; Wed, 17 May 2023 22:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CD06280001; Wed, 17 May 2023 22:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ABEF900003; Wed, 17 May 2023 22:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF26D900006 for ; Wed, 17 May 2023 22:18:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 989E4C06D6 for ; Thu, 18 May 2023 02:18:48 +0000 (UTC) X-FDA: 80801767536.08.48B3E21 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf30.hostedemail.com (Postfix) with ESMTP id C3DBF8000D for ; Thu, 18 May 2023 02:18:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=mQQrGh4h; spf=pass (imf30.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684376326; a=rsa-sha256; cv=none; b=zJUddC3l8hMtx7FLOYX87pgVLUdkVfuc86RFzvKOV9MIaaRjKrklXmouROQypmQqTPZG0J 7IcUBbmp6C9+z3ELRAucAy9OyifLNz/zxpuBClrDylxIX29s0F2Eg8quIWRdMJX2UXR6D5 B5avgX5SSNMoSAlNjlYM3VeC3vGweTQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=mQQrGh4h; spf=pass (imf30.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684376326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=jK+7q/E+o3RyoFwiAS46pPlCLBpEFsIFcKOdZJ6SGz2fVclzhBx/dxDchdaS4M2iq4Co1r cXb9wqQrYcZmU5Ci9M1VD8foAWc7n53LCHsqsQUR3VpXIIimmxwz3G1VrQrR/dqu67ZPis 5DajFe4iyLwf588KBERGqxc4unKlU04= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-3f5386d3e5dso3735971cf.0 for ; Wed, 17 May 2023 19:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684376326; x=1686968326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=mQQrGh4h/KNWIK2PoMB6Pztwf3cVCXmBMz0qqgOhBsvYUoYmvpqwqduJIzlAMMC7YK ZrUS/hiBuG72PkbcadbIrnygdqpWVUoSGwOt1fIX6LFaYv2ZtLweuzoryGI5e/lbAEvj QAZwZXY/iYOPxIXmup+iJ05KpzCFPd+H+MV7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684376326; x=1686968326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=WWDy/DD/9uMguZ13Jm5CP891WisJaJk9z48uOvvYpquyluY2tk47YEt13VrFrGH0k3 Uy/GkQnFhqzVl7J/G51QEf+0QnsmUv1MVczDu4M/C8uAmTOEX7GJn/L0nd7oIUKF1O9e Sul5gydIO8D2V1h+dCslXbNZMU6b/vSMgFrvLOcYna7ZRri93xEiyEsImqRcharUdSVQ vFiMoHAVDDewsjfYdd9jWS7u+WkIDBd1j4UvowddPnjQ7QmjbS45/nbjZOVB1VQe7ADc vy40YjfxHj7Dfx/PLH0WCikc72Qu6gGCK4bpOMpUjBXGL/dTG5/mcukiBVu/bJbftrCF XOJg== X-Gm-Message-State: AC+VfDzIn2s0opRAlFg2RigJbYF7H9A6iGyScvRh9KpcaqCIJJgW9VwG AUUStBeb387vdMYl2N/V96AR8w== X-Google-Smtp-Source: ACHHUZ7onnyA0YRXFWFSrDrQsTcQvuLRzQPOgD7sBT31Y/nwpybDDjLCC9uzwGCwdRjZeUxjOoHbXw== X-Received: by 2002:ac8:588f:0:b0:3f5:2fa4:43bd with SMTP id t15-20020ac8588f000000b003f52fa443bdmr3399132qta.3.1684376325860; Wed, 17 May 2023 19:18:45 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id j13-20020a05620a000d00b007577ccf566asm85082qki.93.2023.05.17.19.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 19:18:45 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" Subject: [PATCH RFC 2/4] selftests: mm: Fix failure case when new remap region was not found Date: Thu, 18 May 2023 02:18:23 +0000 Message-ID: <20230518021825.712742-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230518021825.712742-1-joel@joelfernandes.org> References: <20230518021825.712742-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C3DBF8000D X-Stat-Signature: sfjmbybmh8ocsriu3rqq5zrdy7t8dic5 X-HE-Tag: 1684376326-354086 X-HE-Meta: U2FsdGVkX18w0/Baru0GRQwOzv0p7tvb1W+Rhds5Xeh/Nwk27IXKd3z2JE17hj8Gr7daWXx8gJfv24e+8O5pMsxBsgpF6ZaMUi3b9NwJxJZX/G975Mq8GovD5s/OuVot4o4p/Esv/SKfEA1VAakRsALgE+TvgnMxMx41j87VmUizAPT66M3jhYoKttMAV6Ys/sQNqYTD5IbGKVFCt7Ar34W0v1RwmfW79rJiG4q0tJ8K2Lfq9p74kuWXrlnN+upqtsbG4FgOlCQC7YXldmBYbycRBavw9Y+gWtCYzxNb3RUULMpsWofrxbf0mFCVyoTPCqQ2CtCFv3RKxJPbgMEV5/KiNt8lBKosWfbZ3uATU7BJyTV/v283nJJluXGVKAZOfZ5H4u+WiTmwmFUJAtJd//3uYLKKMck3t4EdMM4OOuROh37NtDlgi74umvkP83N2Zyiff8nJyhbTvm2bN5mRRnUN6tzpZ6/DFIHTtjpJqY6QJ+973BFBGcljamw4Dk8SkRLCYZMBGllDN0J+W4D7GBga7epenbDKXFSfB6bdlCvxg2CcPYPDwFc37vEdXjCVYeAjcBzNmvP3S3oxrHlvLwEcbQ4CKCXlgwYUCoC46nwpNaU4/kCVlys/TmtochlWg26CgxdPwW1CTsPv6Oe+E7n8iAuenbbZ+OlxVDbJR9VvCO3ax6nF70WjHb1VvL+Mt4yh4lZwtUsIHJPGh7lEAxAyMEQNZyxPvRNhh4YT7n8YXthXjLMCp7SkSn3lHy842YrS7dmNPnUKxxG8UmtSkiGM4VD6qJxrjZUkmnPnwnk02kDI7PekkgpKZGzF/4EtePX/FLYxXOyuWNPlHmJDnGKSWDiphgtY2yi+MTd39XY1k5dNFOAHYTD4mVx356FiHaO+O4l8mCXzgarHc5hmaBJd6Qz7UH9LV+/KkSuBTcNgtLilMGr9qet1HQGKgMbS7NGr+gvkX+Lqda39w32 Zjqodz5t uBUesaN8CGUIsG3RymTBozxDFa5FaqJswGTV4hBD1CfdhqqbrqWyPgH0ZPURIK/04dDrw0U4s6tgPOigyIMfo80DXcA5HQTP83N/nh/AfJT5fUSCxAKLkhzoDT+whiRyih0QADUyHBJVJLadlqoszZPLRPhoFHcp50gxzAL2EkpwBZlpHmH3aM9ZVJsz20lO+3qT0hndGMmO9HCV3sPy/B8Zay0FlrKHMcA0jcbCvlqwBvN5kc7LdgG0y5V7+o8lOQdLi4CORxvdYkylrjmBv99uh9i9uwooiKfl+M8V7ZpwcGcjfua70RSqytUQDVmGRiUksPs9koFobjyfNQf+C//dcV4S00shKMN2A4agsWEE0ejwfHLyzh67ZAhbKezQhez7CmiqiWIIPSD142VsKE3X144Kc0l8RwIc1f6sI8snWsyU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1; - goto out; + goto clean_up_src; } addr += c.dest_alignment; }