From patchwork Wed May 31 13:08:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13262295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123E3C7EE32 for ; Wed, 31 May 2023 13:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B2EA8E000D; Wed, 31 May 2023 09:28:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53AD58E000E; Wed, 31 May 2023 09:28:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 325C58E000D; Wed, 31 May 2023 09:28:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 139DD8E000F for ; Wed, 31 May 2023 09:28:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D396D8013F for ; Wed, 31 May 2023 13:28:03 +0000 (UTC) X-FDA: 80850628446.15.58ECA4B Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf03.hostedemail.com (Postfix) with ESMTP id 167D02001A for ; Wed, 31 May 2023 13:28:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=qnjHbKiK; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685539682; a=rsa-sha256; cv=none; b=0aRqur9+h2zAcU3cZxRDYF0zGBCWfKsUb6pvv2vMiMahFQpW8B1fH4v3P5M97bkBjNV/d3 Wk+EEoXjBXTTmnuHhagrumT23N2UBikD+9GtjiL4Ph4snpSaCW6/+Apq+O9EikP8/SG+PH +YJ8tVRn67QPMLyZbF12lNBPYR+PztU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=qnjHbKiK; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685539682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=De02UbLJVMu0IFxxAICiUX86I0+CYVgCoxMLmGl76l8=; b=50FWky2VP2GufT+ngDWfWF671W0T+qt/MuUoxVyYlO7ezgDvX4eUZdup1PwgLoY5BFUlvr VNPCwHPw/edJnJ4INPnRYBjTrmhYuhwICVGk3oERttZUFznz3OT1CzqBpMUcj/nznUYB0+ PXBvyx68wTMcbrtvDwrvGBB2m9QhwL0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=De02UbLJVMu0IFxxAICiUX86I0+CYVgCoxMLmGl76l8=; b=qnjHbKiKPQHLXKyilOQKmohG2V GxBgsxD2zYySET8WbUC0G5aywathp8yHPni/OtulopKLf/OZwoJEOOexmOsH6Pm65LL3S6bqXg0nO j/0lmcJkKkIKaFw2sYNaRLJQ40H2FTEhwChB7YpLFfNOEim7WzUuwsGoEgtbevG7ocQ2aGO8BTCQl IW37BcTr7ZTB9XNV7eSjS06jPELWeyfqiNcQFr2zuwk/1zOc/QmbJPZsQmF7feuu9e0XkNvmjCoQP qDHHfVNgaD/t7GgN65ScBp7gQcmOAIJJynfNnxXzOcaC/oYSwaKixOLK+Qt00mpt8KpyTgbiYcEC2 PppYDfPw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q4LrF-00FTCW-2I; Wed, 31 May 2023 13:27:21 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 018523006C4; Wed, 31 May 2023 15:27:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 80187243B69E7; Wed, 31 May 2023 15:27:16 +0200 (CEST) Message-ID: <20230531132323.385005581@infradead.org> User-Agent: quilt/0.66 Date: Wed, 31 May 2023 15:08:35 +0200 From: Peter Zijlstra To: torvalds@linux-foundation.org Cc: corbet@lwn.net, will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au, mpe@ellerman.id.au, James.Bottomley@hansenpartnership.com, deller@gmx.de, linux-parisc@vger.kernel.org Subject: [PATCH 02/12] types: Introduce [us]128 References: <20230531130833.635651916@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 167D02001A X-Stat-Signature: nm6dyyjqz9eopsbhgfhw3qrwmdqg7rfz X-Rspam-User: X-HE-Tag: 1685539681-266567 X-HE-Meta: U2FsdGVkX1/FcgEFeCvMmPgNo4s892dhE/4IJ/McOiaIYouA3/jcQ0kO/0lAq8BU+Xugp/WE2Dghv18COWpCTWRcPR8SddOOgEMtcpIQdyvIL5QGv6UwnrwA8ovKOa8sm/1RZZpekN6lRSKh2WU7b1jQHKiFv55E4wP7hj2d8Em9H3588gvZeqg92UU4cy0W7U6kSIwBfBX6a+X9mDjj6gWQ8FK/CZUKPytape8N870rb0nYTC4scmYOPY8+nTQ7PW9c2OJs2j05+S9l+VII/SW8PkFcHuWNufazwPxIxkjiJp67mAoo5QVXQCgHpIoxpIAqnkoc09wIGg8H7OgUj0z0HbAYhc1xQ2Aw6J6ejsLY2RB4NjCQ28M9mCOhchktWiUVgKHzdvdJL0ODUTeaRW63XPSPd3t+Lzqg/Ws5UoGncnOoblhICZvy7IjJp93aZOJonVqXRWzGApp57s/1Wb3QZRFdmUjWTxyzVGqm6s1uCE8NspPHbuX+vcBQabx4fMDuxgH9atAX35B4PrODh53KkBhrZhjQTxAeJDoIyj8p2L2Bv+IXbkvYJ0CFklOTTYUxOAOfoYcIVouGcGj/9KpeG8vur5zrF2FkTT5OZuqfkJnDDwMBEunkM42crBuFAHtQFpuYmaqBb1TAlfA4svIIK0qkfykOPuHYQRRcZGdVtp0Dow1SfygzwWuCrfpi1m/2C69asQBjLlPQR+HlzopODRtR4K7KBhw2a3C1v0a58lGFXrY08c/2Sxhwz/pr4C+ldx5XjJ0quiKEe57u+TKQ5pyiLW7IDMi1Ldt7L0PYZvtbVl5PHv6TM2et8doW0/j/xLiRX/ir8jHMdWy7JkA+p44kCEfHGPMOa1WagAMyLf5vevnR6UXHRUMV6Dp3zd3kg4N8Wiil8zmPjeftfA+IybuI0EbpE9wdGrfqce78kPfHukSgEksBIGHm2yD+pvEHlMazBQVHlncetE6 izZc0FRr rX0MyBZ6YcbSswIhkXqv6CTAT9UjZcRHrhseH/eBZPDI+q4+2+SkxKZ8NKRJOHz0cUWXjQaVYZE+WeBimpkadh9tQtTR0u7ygEL4r2pyW9ZUn6A7Sf/M04J5oGL1/ga/keIjdzWlwyPLcI+DVF3yv3SwMWtvACyDQ3Sd3RSOZIY1ueThApjrAKQKbOF0zY3q1iFq8ayD3F9UXKDP8MDVnE/zWdjE9OcrpF85w6CCFXkrITOSPIe3ZOlgOWuVzR5H3xf1P8yXGuctK2dIY4nzStPKDT8gbve9242KTPkJOpqbwXiUQwWF7G3vYrWRIST1xSVUS8xp/aC0RvdY4spaRynzsg13Fw09PTwic98Ax81ZWkGMb367mncKJwmr8JwE5zMio0yiMesyjluf70OQe8UtYMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Introduce [us]128 (when available). Unlike [us]64, ensure they are always naturally aligned. This also enables 128bit wide atomics (which require natural alignment) such as cmpxchg128(). Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Arnd Bergmann Acked-by: Herbert Xu --- include/linux/types.h | 5 +++++ include/uapi/linux/types.h | 4 ++++ lib/crypto/curve25519-hacl64.c | 2 -- lib/crypto/poly1305-donna64.c | 2 -- 4 files changed, 9 insertions(+), 4 deletions(-) --- a/include/linux/types.h +++ b/include/linux/types.h @@ -10,6 +10,11 @@ #define DECLARE_BITMAP(name,bits) \ unsigned long name[BITS_TO_LONGS(bits)] +#ifdef __SIZEOF_INT128__ +typedef __s128 s128; +typedef __u128 u128; +#endif + typedef u32 __kernel_dev_t; typedef __kernel_fd_set fd_set; --- a/include/uapi/linux/types.h +++ b/include/uapi/linux/types.h @@ -13,6 +13,10 @@ #include +#ifdef __SIZEOF_INT128__ +typedef __signed__ __int128 __s128 __attribute__((aligned(16))); +typedef unsigned __int128 __u128 __attribute__((aligned(16))); +#endif /* * Below are truly Linux-specific types that should never collide with --- a/lib/crypto/curve25519-hacl64.c +++ b/lib/crypto/curve25519-hacl64.c @@ -14,8 +14,6 @@ #include #include -typedef __uint128_t u128; - static __always_inline u64 u64_eq_mask(u64 a, u64 b) { u64 x = a ^ b; --- a/lib/crypto/poly1305-donna64.c +++ b/lib/crypto/poly1305-donna64.c @@ -10,8 +10,6 @@ #include #include -typedef __uint128_t u128; - void poly1305_core_setkey(struct poly1305_core_key *key, const u8 raw_key[POLY1305_BLOCK_SIZE]) {