From patchwork Sat Jun 10 23:50:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mirsad Todorovac X-Patchwork-Id: 13275099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63530C77B7A for ; Sat, 10 Jun 2023 23:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83CB26B0072; Sat, 10 Jun 2023 19:51:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC466B0074; Sat, 10 Jun 2023 19:51:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4908E0002; Sat, 10 Jun 2023 19:51:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5C3E16B0072 for ; Sat, 10 Jun 2023 19:51:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1395412032C for ; Sat, 10 Jun 2023 23:51:54 +0000 (UTC) X-FDA: 80888488548.01.9A39537 Received: from domac.alu.hr (domac.alu.unizg.hr [161.53.235.3]) by imf14.hostedemail.com (Postfix) with ESMTP id C008E100008 for ; Sat, 10 Jun 2023 23:51:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Dii5rFne; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Ax0GnqZE; dmarc=pass (policy=none) header.from=alu.unizg.hr; spf=pass (imf14.hostedemail.com: domain of mirsad.todorovac@alu.unizg.hr designates 161.53.235.3 as permitted sender) smtp.mailfrom=mirsad.todorovac@alu.unizg.hr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686441112; a=rsa-sha256; cv=none; b=aZXGUE5qBi1JaeYIA8/F/zAagatoCQk++u8be+DHxPS7wPT9wsf8ILZKXFfgYlaQatd9w4 ipp7mLPpwM2KBuIV4VoJKMeeCRdj/SKVUA+GONQybQ+vAFW/D0dyDQMzRLNnFrG+Yf5u8m i1ZZ2+ZRAyBtXY+G6RoiDvUlgZ1BloU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Dii5rFne; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Ax0GnqZE; dmarc=pass (policy=none) header.from=alu.unizg.hr; spf=pass (imf14.hostedemail.com: domain of mirsad.todorovac@alu.unizg.hr designates 161.53.235.3 as permitted sender) smtp.mailfrom=mirsad.todorovac@alu.unizg.hr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686441112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=PyfLDo2O8yGfBZTW5eznG4aARyQsbXCl/jow7xuBumQ=; b=sljsO6G/Z6/jjwMQvlzX6vTtlRSIVuOVhj3wJfnR5iV7Lio5OAKw0V0vPvdUmKreXoEMvv 6lmP6EcMmLINSRnvzMu9Dpl+VnLG5TFGZGQE0APqooNV7B3o9dYYTNvXaNYuQ9IHkyZUh8 5h/dzLqfzyApjTDbI8tHkVeTCBSK7MI= Received: from localhost (localhost [127.0.0.1]) by domac.alu.hr (Postfix) with ESMTP id 01D4360174; Sun, 11 Jun 2023 01:51:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1686441109; bh=v4wXQstgWeUzNRuDlXeZ8k492Buj4zZppclAsNx/yB4=; h=From:To:Cc:Subject:Date:From; b=Dii5rFne6vQCW9tPVWTBPZfQD9cKJZr0IX09PnedfUe59CevjhlVSnf7vnT5hKyk0 qKygj+FbvV1XkQ9bdwOMmgb1Bv+xfNhCHrrScFKSuGQ71wqdBl0E7bfZKPs+CdgSlA ompFrtstnS1zKr0aBgGkDyodk3FzaDGHEj5Ok0dcjPgkSV/A7aJBBEtaTWagoFmYeC 92jOPmOLTyDpFeKhESZPWi2Kwbu6OhQ2MDD3n6L44EFBVEa3fnm6CtstSdrPGLfuG2 YwubeJBlc6g7n5zv8u9mdsHlPxoJyE4wYdQ526P18zpRGPyBk09rjugURRGOrMsbAY B5xAM1+MVekyQ== X-Virus-Scanned: Debian amavisd-new at domac.alu.hr Received: from domac.alu.hr ([127.0.0.1]) by localhost (domac.alu.hr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IcQZa6_0euSK; Sun, 11 Jun 2023 01:51:46 +0200 (CEST) Received: from defiant.. (unknown [77.237.113.62]) by domac.alu.hr (Postfix) with ESMTPSA id CC09F60173; Sun, 11 Jun 2023 01:51:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1686441105; bh=v4wXQstgWeUzNRuDlXeZ8k492Buj4zZppclAsNx/yB4=; h=From:To:Cc:Subject:Date:From; b=Ax0GnqZEGEiKjzWp2X8g3TpxfKrmXMmc4mK34qRy/toO5JyJKu0vIiWuOC7aUtO5z MRQh5299/46M+zzYmF833FRbJd18AoO0eOpgQ6M8SZKxJ9u481JixJtcJS9hlGjqD4 Su3Kn/YHyKb2av43WHmUHaEjKqBOtI26zxOgMftraBQS3+sqQpJTqcMGbKnEovciaf xcSvY1gzqqIQbl+JUU/dhm6Tj7rdMVEbT1zg9zSMrQ1YlKfON3j5NB5LfezKvUZoE9 u2NQd0fxmR1r7XMtO3rhPXyLRgd6vU6Y/t9vwxsRYs19FcZkUTf0xq8kNut4MYImXi BA90bYGJKAzqQ== From: Mirsad Todorovac To: Peter Xu , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shuah Khan , Mirsad Todorovac Subject: [PATCH v1 1/1] selftests: mm: uufd-unit-tests: remove a format warning in printf Date: Sun, 11 Jun 2023 01:50:17 +0200 Message-Id: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C008E100008 X-Stat-Signature: qc9zm5y99ip351szbkj9on41a1zu7ng3 X-HE-Tag: 1686441111-382554 X-HE-Meta: U2FsdGVkX1/RDWbZqysUKdHg2S9QYCF+SNBczPntEXGGzyDbs07mxQbnnI8oF9HbkL6LUwjdUNe5bKU8Ds28VPF3CfwtngFVrmYLMO0fITlA8z+q5wpIen5kPq2709PKA3am2m7rh5NYuMS9FpRiwCEIgzQYHFlVDGVydGzBag1gV46OuuzoAtyCCu7VEl192gpg+jvwvuOI/N3Z6qU0RPWTmJvbWTxKurbApAbynlqQ2/6dKcPfJ6r+VyHPLe8drelVjhI3V82Jdaj6TIlg2qWQmSrgyJbch49nUO2xgr6FTEjtX4lan/IrAE1WPUVOJANXBGJhix46bYFBogShDe/iQI0F+myPGpiTXHLOD4C/Ljj5awDD6lGPsF2eDVZ2zQFNfLpW8FAfVlF71IIQIWOrzaMmZ8+m4w5EMlvdYdhMstHv2BWPMiBF+nCUrwg2B6kFoSURjWvL0gkuxmUF2UN3QEWAACPiFsh+KSlgHF4Lo5A3B/IrQDDVsrjxONoRMU+NUw/DDjA6xF0slCNLd37yjR29aczn5e1rxNN3sBMPilzxrAfRz9yS0nohfVcWLEx+77wbYJ/PZuRKPvLARxBOvjSoiPFDFDjM9n2QBGhfhGOMi8XHJy4OjtjUj0flg7YXqfkoMeCwq6W0a1Ia3n9hq63RRZ1ga/9/tPJNtn2hl6fOPT2gVb36S703ZV+6kkckVAVCCH9/1bgyk3tSqYmHi7Md4BQe8Ypjme8FusikD2Owl1M9wgG4CuYPBL0G5HR1mrzKMApSqLNYkut/pe+iSaXacBwMmvjz+7wrgprVM8Xh0PSGgif4B9Bo7w8+IqgsPd46GdR4+/NJl4S0/ESvqxIMP4LsgQ3PY9BRUP+w8XbaXrNLyJE8g3GXBG/yiD5ZZ4laWGc6OmJsuQwVsWAK088/tgyhX3yMYRe0icaw5s3Fv9sQcdXPw7PEDqUeZcHwl/PO6KHJyDstHTu o29UNV36 nTkGGodlzkJvR78X6oLkOfkzsw1Sy0HTPbLLGUlAx6/Bx6JsA/8YgUYMYszBI1PgZ/w8Os+54e0r3MEGiFMQZN0rL8ce55pu5iEmyhR1utaX1hRUxCLVfAMyzAtCnjwhC5YeqB9ND547oiPgFhar4b6fuiUd5UcYdzY6C7aZf/BDHlFGZU/uWVgV1h6yKZMNzWJLJ40zaYdUmTzQSvnxJJxdrnADNFTaNUlMza41DtwmtKuX0KbxEgVQQmJguYQfiM9yoJfWckcPfgameHRdx7JSKNcEOcGGz9hw8AQWNDRYMmmbyvtLqPNy68w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: GCC 11.3.0 issued warnings about macros and types of arguments [edited]: gcc -Wall -I ../tools/testing/selftests/../../.. \ -I ../tools/testing/selftests/../../../tools/include/uapi \ -isystem ../usr/include -no-pie uffd-unit-tests.c vm_util.c \ uffd-common.c -lrt -lpthread -o \ ../tools/testing/selftests/mm/uffd-unit-tests uffd-unit-tests.c: In function ‘main’: uffd-unit-tests.c:1198:41: warning: format not a string literal and no \ format arguments [-Wformat-security] 1198 | uffd_test_start(test_name); | ^~~~~~~~~ uffd-unit-tests.c:100:24: note: in definition of macro ‘uffd_test_start’ 100 | printf(__VA_ARGS__); \ | ^~~~~~~~~~~ uffd-unit-tests.c:1205:33: warning: format not a string literal and no \ format arguments [-Wformat-security] 1205 | uffd_test_skip(errmsg); | ^~~~~~~~~~~~~~ The macros are defined as: #define uffd_test_start(...) do { \ printf("Testing "); \ printf(__VA_ARGS__); \ printf("... "); \ fflush(stdout); \ } while (0) #define uffd_test_skip(...) do { \ printf("skipped [reason: "); \ printf(__VA_ARGS__); \ printf("]\n"); \ ksft_inc_xskip_cnt(); \ } while (0) Minor workaround, adding "%s" first argument to macro expansion calls seems to be the easiest way to eliminate the warnings. Cc: Peter Xu Cc: linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org Fixes: 43759d44dc34 ("selftests/mm: add uffdio register ioctls test") Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/mm/uffd-unit-tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 269c86768a02..d356dd271c84 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -1195,14 +1195,14 @@ int main(int argc, char *argv[]) snprintf(test_name, sizeof(test_name), "%s on %s", test->name, mem_type->name); - uffd_test_start(test_name); + uffd_test_start("%s", test_name); if (!uffd_feature_supported(test)) { uffd_test_skip("feature missing"); continue; } if (uffd_setup_environment(&args, test, mem_type, &errmsg)) { - uffd_test_skip(errmsg); + uffd_test_skip("%s", errmsg); continue; } test->uffd_fn(&args);