From patchwork Thu Jun 22 08:39:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13288474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24274EB64DA for ; Thu, 22 Jun 2023 08:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A82318D0006; Thu, 22 Jun 2023 04:40:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A31068D0001; Thu, 22 Jun 2023 04:40:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AAE48D0006; Thu, 22 Jun 2023 04:40:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C4AB8D0001 for ; Thu, 22 Jun 2023 04:40:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4695380127 for ; Thu, 22 Jun 2023 08:40:16 +0000 (UTC) X-FDA: 80929736832.17.8428949 Received: from out-24.mta1.migadu.com (out-24.mta1.migadu.com [95.215.58.24]) by imf07.hostedemail.com (Postfix) with ESMTP id 8E94E40009 for ; Thu, 22 Jun 2023 08:40:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tMuOJ7tq; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.24 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687423214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oQpOCkSVz0jjdFm4oEP2NJJ+zKFOVCxqbVN/b6qKeiM=; b=jaw2GNPTYAKK1p1+WCTQoghWdYOtBXomfqjgSKZNACrowfetPGz72jnx7c3o7fp77CBfew 3Zc0GKsVFVDDPrv0SaNrrzwS8pTRYXrIgodI7YTnSzLWhftNZ+c2CMd+Yl1IwRLl1hjdOP UsR87c+aDPhHLHgZbw0Zd94cwYHfwBI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tMuOJ7tq; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.24 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687423214; a=rsa-sha256; cv=none; b=bmnk/ligtzo2XZuwXOK/A8mh+6KiDshpOY/b5VRrRcofRUWvQRHNGiCsphGFL16HzWUW5N QGi7cfRKLHVxk3+2oZ918S45UhQ241nOn5I/sQzn3n12wFTAmCVSQYeRdF49rOEwEq2+Tc IbSY9QWUVeA9MS/y15baFh9q+vdW6bA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687423212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQpOCkSVz0jjdFm4oEP2NJJ+zKFOVCxqbVN/b6qKeiM=; b=tMuOJ7tqKqRjBtP6rCX6dHgXMvUPla8/fh86ZTdJ8ioxIJNhWLtWE2XQneYSwy0aJnC1ss Ctc4pKKJIiQUSzscndToOCLVf8LWmRwZZbYvjVdCG6D1dQMZR1dzVK4v6YBfk82aTJO0UT 9p//2RwNkkyklDbHvlR7q6dPTNIpG/U= From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH 02/29] mm: vmscan: introduce some helpers for dynamically allocating shrinker Date: Thu, 22 Jun 2023 08:39:05 +0000 Message-Id: <20230622083932.4090339-3-qi.zheng@linux.dev> In-Reply-To: <20230622083932.4090339-1-qi.zheng@linux.dev> References: <20230622083932.4090339-1-qi.zheng@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8E94E40009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hbc38hi7ox5txhe987h6pc9nbznekmtc X-HE-Tag: 1687423214-840121 X-HE-Meta: U2FsdGVkX1/SbbAI7oPxVpQ2MLDFkYKcHvlw/n0vvU0wyaMvuKj0x6BKipVu+WZGQWluuZbDbBbTn4Hry3Il26QNkJd55uF/TDqbYuu4G3O23OVL0GCxqwtwjl7KEOgRz+jjd67aVVqbuT+yYB36mbuwcZW3Qx/dFW/o9/VgYFNuG/i9UPGe5K00u2BHM2uhDB+6uuKN1726SmTcAYBskJHMYi0DsJQ5d3GsgsLRPOmR5KFCiYNQZAOCbVfWKDSqzrRPE2CRR9HjnK5nO5J0achkW15e/Nwhpy/7Es034pQZMdKEoZhSmSYLHtqgiaavTqW8EAyAvP1BhG9CSZyYgFVHac1JQYv0OGtYjx3HmmldBJ4afUm9bAeB/dJnqKNwKeExQv0h+UIXo/UdR+OSVbM0UaOZ8GwbIbDnLMWLw4wm1iFEysYFFoIfx763xtOVQFi8FJ9Lln5mq4jSFLRIECMI47zRoq9bdTmkDSh01FwwoQGpmzmufqfCHVdKxbasu7rnQ5RE7sSVAdIrc10zMb6GEyMCBIkqNCFLjMaiIICgLClyWeksKNrS6vmEolLhixYMb48Ix9HZDnvQpe59M+ZH4aXunRqTe5FJwmzy72KxHsAxgOwwEgj6298IxMZ8CZ+mGCfjFq+KCjnQfPwcGVk3xRlJdhVzAg9U3nzyIAVWDxp4TPXPwYU1TOGSHE4gjyi4AuKxwse+SAgEE2eGXFdBt9uuFdZ9RZMpxjmMaEDOLxUH3EDI6BZEcFS8XiInkWBJEEoB79AsMTkHKMVtGYDdCMWKFG7p+OU5Ab+9uV0AX3AJuOmXTLmI8SpHHS6zHvr35eMGv7PqEbq3U3OuD93a2X0PRneqDMo8TNWBaizAFZFGhxhf7EB22KlUu+p70r26F5XgiOZmNGblL0BA9c/aNkOM30wvmfd4iMyzTlKiDZY/QmpP4RDcSI5ZywSabnazZP8kTtf0CO+Y6T/ iPrckWk/ eBd5IQ/aBxpSdlOmOfzzARWSPrKLFPKj3djxiXAwlogPEKT10jITBq/Eyc/b6z/Y8Z9do985+tQ4Y3RGFCA6FeiIGIffxjE1cT9KMAoa3sQBnZxSBxWIACE/2VoY1ll82SGF3+lRVLdPO0LlKdGJWHxAe/6npFsbbLTK0kqVS/dr/81eSuhvay6GL6yelGhMlh4cfkyLLU9Q77I46K3ow6g1f1/OTXCkwSpF4/fBPkbvG4Sa9DwspINUT3O9r6fjpMLL2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Qi Zheng Introduce some helpers for dynamically allocating shrinker instance, and their uses are as follows: 1. shrinker_alloc_and_init() Used to allocate and initialize a shrinker instance, the priv_data parameter is used to pass the pointer of the previously embedded structure of the shrinker instance. 2. shrinker_free() Used to free the shrinker instance when the registration of shrinker fails. 3. unregister_and_free_shrinker() Used to unregister and free the shrinker instance, and the kfree() will be changed to kfree_rcu() later. Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 12 ++++++++++++ mm/vmscan.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 43e6fcabbf51..8e9ba6fa3fcc 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -107,6 +107,18 @@ extern void unregister_shrinker(struct shrinker *shrinker); extern void free_prealloced_shrinker(struct shrinker *shrinker); extern void synchronize_shrinkers(void); +typedef unsigned long (*count_objects_cb)(struct shrinker *s, + struct shrink_control *sc); +typedef unsigned long (*scan_objects_cb)(struct shrinker *s, + struct shrink_control *sc); + +struct shrinker *shrinker_alloc_and_init(count_objects_cb count, + scan_objects_cb scan, long batch, + int seeks, unsigned flags, + void *priv_data); +void shrinker_free(struct shrinker *shrinker); +void unregister_and_free_shrinker(struct shrinker *shrinker); + #ifdef CONFIG_SHRINKER_DEBUG extern int shrinker_debugfs_add(struct shrinker *shrinker); extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, diff --git a/mm/vmscan.c b/mm/vmscan.c index 45d17c7cc555..64ff598fbad9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -809,6 +809,41 @@ void unregister_shrinker(struct shrinker *shrinker) } EXPORT_SYMBOL(unregister_shrinker); +struct shrinker *shrinker_alloc_and_init(count_objects_cb count, + scan_objects_cb scan, long batch, + int seeks, unsigned flags, + void *priv_data) +{ + struct shrinker *shrinker; + + shrinker = kzalloc(sizeof(struct shrinker), GFP_KERNEL); + if (!shrinker) + return NULL; + + shrinker->count_objects = count; + shrinker->scan_objects = scan; + shrinker->batch = batch; + shrinker->seeks = seeks; + shrinker->flags = flags; + shrinker->private_data = priv_data; + + return shrinker; +} +EXPORT_SYMBOL(shrinker_alloc_and_init); + +void shrinker_free(struct shrinker *shrinker) +{ + kfree(shrinker); +} +EXPORT_SYMBOL(shrinker_free); + +void unregister_and_free_shrinker(struct shrinker *shrinker) +{ + unregister_shrinker(shrinker); + kfree(shrinker); +} +EXPORT_SYMBOL(unregister_and_free_shrinker); + /** * synchronize_shrinkers - Wait for all running shrinkers to complete. *