From patchwork Fri Jun 23 17:12:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 13290835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDCAEB64D7 for ; Fri, 23 Jun 2023 17:12:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 050278D0002; Fri, 23 Jun 2023 13:12:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1C578D0001; Fri, 23 Jun 2023 13:12:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBCD38D0002; Fri, 23 Jun 2023 13:12:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C8FDF8D0001 for ; Fri, 23 Jun 2023 13:12:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 86C8C1402DF for ; Fri, 23 Jun 2023 17:12:45 +0000 (UTC) X-FDA: 80934657090.20.D833953 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 67A2B1C0018 for ; Fri, 23 Jun 2023 17:12:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=wUEukFRu; dkim=pass header.d=linutronix.de header.s=2020e header.b=crRCrHYh; spf=pass (imf21.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687540363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d174zlUL/lhF0vBTL/OICvsXlNACFuiYhQ7ttHm3uTo=; b=fT/ZUSDis5QC1rcb4YI5kyU8Jrb7ju+AiMDjWZ8Ty6ho4I26lgpLKaVQLtzKXEc4unqf4E zm+iovUNYMoc+JBsuBlwp33m3GgvU3xHBNFvVhFBqQ7uvObLQmkaicqbbDR2LybS5XWww+ NvUEyLC7zWvJQtR3kFYh22b1KX13jbY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687540363; a=rsa-sha256; cv=none; b=BcNwOxvax9I2Nwf0F6WCTzKtVVsqQfG3WQeAVHEvFTBC4k74T9p1Hw/Jum7EzPmkFzbX+l +gaByPdKqbrtJK9/n/Cr9MvQKDrYXGSYAXGsuwqPTeWCoAqbNCObKEwg0X2UVw97Ytl6tg Czd8dw+L7LoXib/D7JzFPtYp6XUycJ8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=wUEukFRu; dkim=pass header.d=linutronix.de header.s=2020e header.b=crRCrHYh; spf=pass (imf21.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687540361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d174zlUL/lhF0vBTL/OICvsXlNACFuiYhQ7ttHm3uTo=; b=wUEukFRuQtWtID4ZOeOhNXoXQ773U6bquwTxJC7s8rOqzIlrm+gZSF7ZYmg1UhYmzJz4qm oD5Ysr/0zLXb9jT8ovdKF0Bpnlu+ruuv5VQLGVR9IpQu1tCXNMfKYOdKKjWpQ6kyj38jjk A3H8UVBPOl/2QXtQf3GaYd928rVYkoeof+erMEKQc7QMrkdtrWBK1pJnKT5YTlzAhx4C64 eK4rIHSgqMfZyHITIAvcGigQjrydcs2bQNIuo3JhRnlq9qSlzz3y5lPmbLHw+cWmTyNiTQ YRAqhj5dYBPvaNyVjqV0onfE/WhUArwF1Be/lz2+WhLL5yHn/M6an9SWQOwFHQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687540361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d174zlUL/lhF0vBTL/OICvsXlNACFuiYhQ7ttHm3uTo=; b=crRCrHYhVULMoIjeuCQU0yIWeH3xxFHKwaD5PsqTuAc+qRz2en09xW9R2TKMpVhjpwL/DE JSx8UERIkzfTFABA== To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Luis Claudio R. Goncalves" , Andrew Morton , Boqun Feng , Ingo Molnar , John Ogness , Mel Gorman , Michal Hocko , Peter Zijlstra , Petr Mladek , Tetsuo Handa , Thomas Gleixner , Waiman Long , Will Deacon , Sebastian Andrzej Siewior , Tetsuo Handa Subject: [PATCH v2 1/2] seqlock: Do the lockdep annotation before locking in do_write_seqcount_begin_nested() Date: Fri, 23 Jun 2023 19:12:31 +0200 Message-Id: <20230623171232.892937-2-bigeasy@linutronix.de> In-Reply-To: <20230623171232.892937-1-bigeasy@linutronix.de> References: <20230623171232.892937-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-Rspamd-Queue-Id: 67A2B1C0018 X-Rspam-User: X-Stat-Signature: e8jd6ud1z7jipqxh7yn9pfdgzrcnaegn X-Rspamd-Server: rspam03 X-HE-Tag: 1687540363-404001 X-HE-Meta: U2FsdGVkX19bfs30Z/sfzrD8U0yT0Z3HGf+96oX6xVyo4N2HD2U84faJrr1uGmC1Yj5lboQCnnaX8054ewiU8u9VKvGbNtJjdLEejvZZvtgkxeUyszP4baGYSS1oeI1tJCMI5w2qHNPEvFts+5P/W4pYXGUzFz6Bo614jd+BcapRMa6Nv3ix8gY8cwPUhR+2gRoD3712d04hOYHalTz5cEo4ynBukOLGtb4ebHa4qWdqT/xZvkoSgo6LquWhfStCpjEWyHfTMluetpcn4SnqKGwMtsUpP3G9gQo8LgTLKAuAR53TVL9CvXbOacTxiVmyer1M/g+z3ucovGhNdvfgygjouSkGPAhKUcMrQAzVUK+maUH0s+9k9l5gPpAxgUcmXWomBckpvhITFvPQtR6phF0DdwFn4ZZkNxSRfukRJNHMvSn28f3WJuskYevuP0yQoIA9jdFOO3KFeV0NFJgHfuc+AOYkuqgVLTy0Du5RQ8bTiGqjoyHZOXvxmlc8oEYIuIByOiB47U16FFQA9LIYve86ZG85/n4K5afh0AVQYs95tiMNIefOzaiuo2e4iQbdSM1QsZYYa+95j6L/8RhG1K1hAX5tsdPN+zsl36zhds+6ZI/abCYCUaLesXfvK0Ce5L4GStYRjEV1oS1Q1mHrqDPM0FV3nMe5QgiHug1xXQ0/QExplieP0IXkGRu6Wzi1P++dlTzIT9r0SUWfQ4NytmbTur7ZJw4Y398NqSc1ZuPwR2M6kwpmpoqZbtvJ6jp1QD6E6isFEIWzEAt6n39nLJfD1fh6UNO4XnelaqYxKNfVsGqBJ1/V9sEs0E7ORu+IwHIWpoFGpcIuZNK5Aiep0GrU75wyodBJZodkN+pInKynbc/A1ZZ30VZHO9SHolc9sIsh0C8LVGRm0BmGbzg+3HAFNwDimJfaYCOSVZB+R2DxSnKtGL6w5zi+NCbILGkCZ5Z4iPRRoq0gpekhDiG tMnEjbLq 31E9/Ll2tMR8SNEDBmXEaXJqSOH00bu/7ktKW70wvVtECUgk+RLQVQxy9zbeVYVVumcgE44eGxd1F24Wp8K2GmUSPZEIZyGbdQCTAvu68da+a7ap10CAMxZGhl5VbJc1i+9V92uP8U3HWSxwu+CBaRVLyY+H1PuMTCGfBwRtC8q13+A/tM/f0/0nNFNiRfvWMzwGdHRy+Ss5qzq9JwLVG6+X5eBl1teTldCf8Usciq2nDfm4ASpm2r51lzaUh3i+92nvbpMP4oDfuCyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It was brought up by Tetsuo that the following sequence write_seqlock_irqsave() printk_deferred_enter() could lead to a deadlock if the lockdep annotation within write_seqlock_irqsave() triggers. The problem is that the sequence counter is incremented before the lockdep annotation is performed. The lockdep splat would then attempt to invoke printk() but the reader side, of the same seqcount, could have a tty_port::lock acquired waiting for the sequence number to become even again. The other lockdep annotations come before the actual locking because "we want to see the locking error before it happens". There is no reason why seqcount should be different here. Do the lockdep annotation first then perform the locking operation (the sequence increment). Fixes: 1ca7d67cf5d5a ("seqcount: Add lockdep functionality to seqcount/seqlock structures") Reported-by: Tetsuo Handa Link: https://lore.kernel.org/20230621130641.-5iueY1I@linutronix.de Signed-off-by: Sebastian Andrzej Siewior Acked-by: Mel Gorman --- include/linux/seqlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h index 3926e90279477..d778af83c8f36 100644 --- a/include/linux/seqlock.h +++ b/include/linux/seqlock.h @@ -512,8 +512,8 @@ do { \ static inline void do_write_seqcount_begin_nested(seqcount_t *s, int subclass) { - do_raw_write_seqcount_begin(s); seqcount_acquire(&s->dep_map, subclass, 0, _RET_IP_); + do_raw_write_seqcount_begin(s); } /**