From patchwork Wed Jul 5 18:12:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13302572 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFFCC0015E for ; Wed, 5 Jul 2023 18:16:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A2928E0001; Wed, 5 Jul 2023 14:16:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82BDB8D0001; Wed, 5 Jul 2023 14:16:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67F5E8E0001; Wed, 5 Jul 2023 14:16:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 559C98D0001 for ; Wed, 5 Jul 2023 14:16:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A5FF1C8ECB for ; Wed, 5 Jul 2023 18:16:47 +0000 (UTC) X-FDA: 80978364054.21.56AB8F5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 41DE6140019 for ; Wed, 5 Jul 2023 18:16:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Akn8jF+f; spf=pass (imf23.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688581005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=touy8a7//BeI9DXwQuTy3DIG1jDKoaRDRv3dbDYYd7A=; b=cwasePdes4SJFKF38sMJoUwhHtRWZ3dYuFtFixR/mYjA5BsScL7M3gm52cfNyP/b5cXLID qmzQk97eFzQHL1ZP6kszIEzipAxDv7LavyKLnogxhdbYIzflygqt9b3ssmiqFf9RQBLKd4 iS17+h/FRZa9G2bzqViI3hEmeCohZgI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688581005; a=rsa-sha256; cv=none; b=F8lECRgknfH1YecmsOn1GkCsrQP/urRzM8kFxb93mBKnzofMByAR9kcNeXAUA6b2qc/yTJ mSACVPOgdE/awBaMEpyO6sfMIajZKVCuhzo1Sleg42Wc9xBSb8eWYH04zNqMnagg9JJjbW yrQeXg+8w8LPbkGH4aroSqRsCxjtCYI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Akn8jF+f; spf=pass (imf23.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688581004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=touy8a7//BeI9DXwQuTy3DIG1jDKoaRDRv3dbDYYd7A=; b=Akn8jF+fPRfkNBx4skWRNhsTS1ClaljOqNUYLqsD3NMtzPT/KDXG1U5kikKm/KdiJm8S1u GHspUhVQeF2SIr1c7xAPZFxjGXpM6GvsGe6kZhVXYujNVGRfgptSDh7NBaWj6URvwW9bF3 P1v9XKx8KyDnVvylme7BtBDN6ozhAec= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-rTU3Fnz6O_mjXhT8Or3jrg-1; Wed, 05 Jul 2023 14:16:38 -0400 X-MC-Unique: rTU3Fnz6O_mjXhT8Or3jrg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6BA218037BA; Wed, 5 Jul 2023 18:16:36 +0000 (UTC) Received: from vschneid.remote.csb (unknown [10.42.28.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 508F218EB4; Wed, 5 Jul 2023 18:16:31 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org Cc: Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: [RFC PATCH 06/14] objtool: Flesh out warning related to pv_ops[] calls Date: Wed, 5 Jul 2023 19:12:48 +0100 Message-Id: <20230705181256.3539027-7-vschneid@redhat.com> In-Reply-To: <20230705181256.3539027-1-vschneid@redhat.com> References: <20230705181256.3539027-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Stat-Signature: qcjqa71wn1y169n7du199sdqr37pgms6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 41DE6140019 X-Rspam-User: X-HE-Tag: 1688581004-895933 X-HE-Meta: U2FsdGVkX1+aYLwEhQ1ZrD3K5BbtCIfwHtlTsz99eNY81WpQMdibbm2l1oz8jwi5+N3mQf4bTW335jA0lb42SirwHD2fIfWZloEwNtLjTYBqhUAEDtXm498RioWpMMQhZSjaGDpI3FhU6bl7vGUJImzFcRGyvnnEoWVRDf1+VuRGjglcVulS8rX4x7LtTX78yArjdKvmvjuFuaB0SL9BnBCx9jmDslpD97W8HZJF04JXdCZQtFRLfQMWS8QLqL21O0fofiaxpbWBtarROYgR0Kt4GHgKYraEfyk5YxH9UxlQdC/V0yP1+UP7OqH3fYFdf5OftvJLaoGLMe3zHQhW6EilIvrEFNLuPNQ3kNuLosvIk1pEDkFmK/JV0HLmqfYZSRPmzCI1hybO5K9vsCTSX9NtvpVcL1k+Q41cSLBu7L3KVBegIE6nIBuIE8wUolJlHjPN8iGxmCdyLDdgeYupJSGekqhHTW1dXCuz/qlpOVGtRprkm4RJHkpFAKUWAqudnMdKp+nI0cPKtOVR+GKbaYKGgFkuweNuG6RZszccEsiLYacjnBpegks5VWRkSOBhTfnfd3lzpdmREZ9TqXD1DbGBfwd4gdyUAZ+FVZ5j4uDjYgfXgZjOf6DJsxrR6hGzjfs4NRmbQFytGeuYkgT4c/x31n7/i4dhgV8rdD1Agus5pjevuolcBQvPBC5jZG6XPeaD9nXLG8sF+7PGY001uwmtH7MR39HWRKAXLxd+yw2NChddnpSBy4RTKTQIsxtR1rPav6ee47No5vntk2WyJ1as+LvJ1+B2Q9U/xvewbCJYqGUXPDBFsRsU+oJbMD3u5aPJkrru+3MBlI+TT9KhM4CfvZYfR+rcWeil0zmhXEXL0FqlQXVkIShJqPPAEnJxrFxxyVvzsqC69iQ2PWJwzaE/33rGJGXoW9EKUWCoMTtP2at+BG3UA5OpL0O/2ZdFq2yIaUarTJtb+dehs6c pQivTYN1 Fr8l2WOinSz62Gpii/gFK7+bKu+4p4KVEt7aye3JZZpbg9++nyvgeLpxoMbN2ZX34A/0quurZZEIosbvjwIAhmZ8/RtTSNgtteSDqfCf7S+ZNnMhTTd3hbgWD4CJEwqQxPv3Hmu8B+zeUB7KgXnsvexZZCQ7AO9NUpSxa6O5XdCQvsJON4hk3SXFjtojGQKpFG9U9RRBqVoOrwv5HzuRY845RERqEgkmx+rSI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I had to look into objtool itself to understand what this warning was about; make it more explicit. Signed-off-by: Valentin Schneider --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 0fcf99c914000..fe62232f218f9 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3404,7 +3404,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { if (!target->sec->noinstr) { - WARN("pv_ops[%d]: %s", idx, target->name); + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); file->pv_ops[idx].clean = false; } }